[PR PATCH] wine: add xshm build option

[PR PATCH] wine: add xshm build option

[amak79]

[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]

There is a new pull request by amak79 against master on the void-packages repository

https://github.com/amak79/void-packages wine
https://github.com/void-linux/void-packages/pull/35525

wine: add xshm build option
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

This PR adds the `xshm` build option to control support for the X Shared Memory Extension (Xshm).

The reason for this change is that I run Wine in an LXD container that doesn't have access to the hosts shared memory (`/dev/shm`). Wine will print the error message `Xlib:  extension "MIT-SHM" missing on display ":0".` and result in corrupted graphics, making Wine applications unusable.

To work around this issue I disabled the Xshm extension on the host, but this can result in performance issues. The `xshm` build option allows me to disable Xshm support in Wine, while having it enabled for all other applications.

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35525.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wine-35525.patch --]
[-- Type: text/x-diff, Size: 1402 bytes --]

From a96a11c1b2ff61152a5cd0db2123e7bc60169427 Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Thu, 10 Feb 2022 23:06:11 +1100
Subject: [PATCH] wine: add xshm build option

---
 srcpkgs/wine/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/wine/template b/srcpkgs/wine/template
index 6e620b56b073..272512112c2f 100644
--- a/srcpkgs/wine/template
+++ b/srcpkgs/wine/template
@@ -6,7 +6,7 @@ _pkgver=${version/r/-r}
 create_wrksrc=yes
 build_wrksrc=wine-${_pkgver}
 build_style=gnu-configure
-configure_args="--bindir=/usr/libexec/wine"
+configure_args="--bindir=/usr/libexec/wine $(vopt_with xshm)"
 short_desc="Run Microsoft Windows applications"
 maintainer="Helmut Pozimski <helmut@pozimski.eu>"
 license="LGPL-2.1-or-later"
@@ -16,10 +16,11 @@ distfiles="https://dl.winehq.org/wine/source/${version%.*}.x/wine-${_pkgver}.tar
 checksum="113c130eed2f3256c932ffbb7f482a0533ed3ac5c62c979622a2a6df7f9f636a
  7716daf2a24b61a37d356478639bc8e3a45833a9d9e4d8b7b506fa60f6ce76b2"
 
-build_options="mingw staging"
-build_options_default="mingw"
+build_options="mingw staging xshm"
+build_options_default="mingw xshm"
 desc_option_mingw="Use the MinGW cross compiler to build WinPE DLLs"
 desc_option_staging="Apply the wine-staging patchset"
+desc_option_xshm="Enable support for the X Shared Memory Extension"
 
 lib32mode=full
 archs="i686* x86_64*"

Re: [PR PATCH] [Merged]: wine: add xshm build option

[Hoshpak]

[-- Attachment #1: Type: text/plain, Size: 1961 bytes --]

There's a merged pull request on the void-packages repository

wine: add xshm build option
https://github.com/void-linux/void-packages/pull/35525

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

This PR adds the `xshm` build option to control support for the X Shared Memory Extension (Xshm).

The reason for this change is that I run Wine in an LXD container that doesn't have access to the hosts shared memory (`/dev/shm`). Wine will print the error message
```
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  130 (MIT-SHM)
  Minor opcode of failed request:  3 (X_ShmPutImage)
  Value in failed request:  0xb40
  Serial number of failed request:  535
  Current serial number in output stream:  539
```
which results in corrupted graphics, making Wine applications unusable.

To work around this issue I disabled the Xshm extension on the host, but this can result in performance issues. The `xshm` build option allows me to disable Xshm support in Wine, while having it enabled for all other applications.

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->