* Re: [PR PATCH] [Updated] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
@ 2022-04-29 20:25 ` Eloitor
2022-05-09 16:01 ` [PR REVIEW] " JamiKettunen
` (17 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Eloitor @ 2022-04-29 20:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages clickclack
https://github.com/void-linux/void-packages/pull/36915
New Package: clickclack-0.2.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/36915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-clickclack-36915.patch --]
[-- Type: text/x-diff, Size: 1022 bytes --]
From 7d998fafb2d1b9ad9483dbfed1d95bf36106472d Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloi.torrentsj@gmail.com>
Date: Sat, 30 Apr 2022 00:19:44 +0200
Subject: [PATCH] New Package: clickclack-0.2.2
---
srcpkgs/clickclack/template | 12 ++++++++++++
1 file changed, 12 insertions(+)
create mode 100644 srcpkgs/clickclack/template
diff --git a/srcpkgs/clickclack/template b/srcpkgs/clickclack/template
new file mode 100644
index 000000000000..bed0f77355d3
--- /dev/null
+++ b/srcpkgs/clickclack/template
@@ -0,0 +1,12 @@
+# Template file for 'clickclack'
+pkgname=clickclack
+version=0.2.2
+revision=1
+build_style=gnu-makefile
+hostmakedepends="SDL2-devel"
+short_desc="Simple haptic feedback and audio feedback tool"
+maintainer="Eloi Torrents <eloi.torrentsj@gmail.com>"
+license=MIT
+homepage=https://git.sr.ht/~proycon/clickclack
+distfiles="https://git.sr.ht/~proycon/clickclack/archive/${version}.tar.gz"
+checksum=0d2b1e55a59a0b7dc32dae60d7f2d420111b52d30fe2e0871a284436aa2ffcbd
\ No newline at end of file
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
2022-04-29 20:25 ` [PR PATCH] [Updated] " Eloitor
@ 2022-05-09 16:01 ` JamiKettunen
2022-05-09 16:02 ` JamiKettunen
` (16 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: JamiKettunen @ 2022-05-09 16:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/36915#discussion_r868158701
Comment:
I think you meant `makedepends`, this otherwise would have to be changed later anyway if you want to support cross-compilation.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
2022-04-29 20:25 ` [PR PATCH] [Updated] " Eloitor
2022-05-09 16:01 ` [PR REVIEW] " JamiKettunen
@ 2022-05-09 16:02 ` JamiKettunen
2022-05-09 16:34 ` [PR PATCH] [Updated] " Eloitor
` (15 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: JamiKettunen @ 2022-05-09 16:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 334 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/36915#issuecomment-1121288342
Comment:
For cross-compilation you can pick up the first patch I just sent as a part of my [Make vibrator event device node customizable](https://lists.sr.ht/~mil/sxmo-devel/patches/32123) series.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (2 preceding siblings ...)
2022-05-09 16:02 ` JamiKettunen
@ 2022-05-09 16:34 ` Eloitor
2022-05-09 16:48 ` Eloitor
` (14 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Eloitor @ 2022-05-09 16:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages clickclack
https://github.com/void-linux/void-packages/pull/36915
New Package: clickclack-0.2.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/36915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-clickclack-36915.patch --]
[-- Type: text/x-diff, Size: 1022 bytes --]
From 7d998fafb2d1b9ad9483dbfed1d95bf36106472d Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloi.torrentsj@gmail.com>
Date: Sat, 30 Apr 2022 00:19:44 +0200
Subject: [PATCH] New Package: clickclack-0.2.2
---
srcpkgs/clickclack/template | 12 ++++++++++++
1 file changed, 12 insertions(+)
create mode 100644 srcpkgs/clickclack/template
diff --git a/srcpkgs/clickclack/template b/srcpkgs/clickclack/template
new file mode 100644
index 000000000000..bed0f77355d3
--- /dev/null
+++ b/srcpkgs/clickclack/template
@@ -0,0 +1,12 @@
+# Template file for 'clickclack'
+pkgname=clickclack
+version=0.2.2
+revision=1
+build_style=gnu-makefile
+hostmakedepends="SDL2-devel"
+short_desc="Simple haptic feedback and audio feedback tool"
+maintainer="Eloi Torrents <eloi.torrentsj@gmail.com>"
+license=MIT
+homepage=https://git.sr.ht/~proycon/clickclack
+distfiles="https://git.sr.ht/~proycon/clickclack/archive/${version}.tar.gz"
+checksum=0d2b1e55a59a0b7dc32dae60d7f2d420111b52d30fe2e0871a284436aa2ffcbd
\ No newline at end of file
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (3 preceding siblings ...)
2022-05-09 16:34 ` [PR PATCH] [Updated] " Eloitor
@ 2022-05-09 16:48 ` Eloitor
2022-05-09 20:20 ` Eloitor
` (13 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Eloitor @ 2022-05-09 16:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages clickclack
https://github.com/void-linux/void-packages/pull/36915
New Package: clickclack-0.2.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/36915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-clickclack-36915.patch --]
[-- Type: text/x-diff, Size: 1904 bytes --]
From 1740ba4b88b7e32a9fe601793e4ea2a1a9d7e987 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloi.torrentsj@gmail.com>
Date: Sat, 30 Apr 2022 00:19:44 +0200
Subject: [PATCH] New Package: clickclack-0.2.2
---
.../patches/support-cross-compilation.patch | 22 +++++++++++++++++++
srcpkgs/clickclack/template | 12 ++++++++++
2 files changed, 34 insertions(+)
create mode 100644 srcpkgs/clickclack/patches/support-cross-compilation.patch
create mode 100644 srcpkgs/clickclack/template
diff --git a/srcpkgs/clickclack/patches/support-cross-compilation.patch b/srcpkgs/clickclack/patches/support-cross-compilation.patch
new file mode 100644
index 000000000000..ec0a57c38128
--- /dev/null
+++ b/srcpkgs/clickclack/patches/support-cross-compilation.patch
@@ -0,0 +1,22 @@
+ Makefile | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index b593b7f..1bf7a8e 100644
+--- a/Makefile
++++ b/Makefile
+@@ -2,12 +2,13 @@ PREFIX:=/usr
+
+ PROGRAMS = clickclack
+
++CC ?= $(CROSS_COMPILE)gcc
+ CFLAGS ?= -O2
+
+ all: $(PROGRAMS)
+
+ clickclack: clickclack.c
+- gcc $(CFLAGS) -o clickclack clickclack.c -l SDL2
++ $(CC) $(CFLAGS) -o clickclack clickclack.c -l SDL2
+
+ clean:
+ rm -f clickclack
diff --git a/srcpkgs/clickclack/template b/srcpkgs/clickclack/template
new file mode 100644
index 000000000000..a64ac6cd9f42
--- /dev/null
+++ b/srcpkgs/clickclack/template
@@ -0,0 +1,12 @@
+# Template file for 'clickclack'
+pkgname=clickclack
+version=0.2.2
+revision=1
+build_style=gnu-makefile
+makedepends="SDL2-devel"
+short_desc="Simple haptic feedback and audio feedback tool"
+maintainer="Eloi Torrents <eloi.torrentsj@gmail.com>"
+license=MIT
+homepage=https://git.sr.ht/~proycon/clickclack
+distfiles="https://git.sr.ht/~proycon/clickclack/archive/${version}.tar.gz"
+checksum=0d2b1e55a59a0b7dc32dae60d7f2d420111b52d30fe2e0871a284436aa2ffcbd
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (4 preceding siblings ...)
2022-05-09 16:48 ` Eloitor
@ 2022-05-09 20:20 ` Eloitor
2022-05-09 20:20 ` Eloitor
` (12 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Eloitor @ 2022-05-09 20:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages clickclack
https://github.com/void-linux/void-packages/pull/36915
New Package: clickclack-0.2.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/36915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-clickclack-36915.patch --]
[-- Type: text/x-diff, Size: 1950 bytes --]
From 227c46c133e52dce753ddf9d2da538420819c0da Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloi.torrentsj@gmail.com>
Date: Sat, 30 Apr 2022 00:19:44 +0200
Subject: [PATCH] New Package: clickclack-0.2.2
---
.../patches/support-cross-compilation.patch | 22 +++++++++++++++++++
srcpkgs/clickclack/template | 16 ++++++++++++++
2 files changed, 38 insertions(+)
create mode 100644 srcpkgs/clickclack/patches/support-cross-compilation.patch
create mode 100644 srcpkgs/clickclack/template
diff --git a/srcpkgs/clickclack/patches/support-cross-compilation.patch b/srcpkgs/clickclack/patches/support-cross-compilation.patch
new file mode 100644
index 000000000000..ec0a57c38128
--- /dev/null
+++ b/srcpkgs/clickclack/patches/support-cross-compilation.patch
@@ -0,0 +1,22 @@
+ Makefile | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index b593b7f..1bf7a8e 100644
+--- a/Makefile
++++ b/Makefile
+@@ -2,12 +2,13 @@ PREFIX:=/usr
+
+ PROGRAMS = clickclack
+
++CC ?= $(CROSS_COMPILE)gcc
+ CFLAGS ?= -O2
+
+ all: $(PROGRAMS)
+
+ clickclack: clickclack.c
+- gcc $(CFLAGS) -o clickclack clickclack.c -l SDL2
++ $(CC) $(CFLAGS) -o clickclack clickclack.c -l SDL2
+
+ clean:
+ rm -f clickclack
diff --git a/srcpkgs/clickclack/template b/srcpkgs/clickclack/template
new file mode 100644
index 000000000000..c7c883453319
--- /dev/null
+++ b/srcpkgs/clickclack/template
@@ -0,0 +1,16 @@
+# Template file for 'clickclack'
+pkgname=clickclack
+version=0.2.2
+revision=1
+build_style=gnu-makefile
+makedepends="SDL2-devel"
+short_desc="Simple haptic feedback and audio feedback tool"
+maintainer="Eloi Torrents <eloi.torrentsj@gmail.com>"
+license=MIT
+homepage=https://git.sr.ht/~proycon/clickclack
+distfiles="https://git.sr.ht/~proycon/clickclack/archive/${version}.tar.gz"
+checksum=0d2b1e55a59a0b7dc32dae60d7f2d420111b52d30fe2e0871a284436aa2ffcbd
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (5 preceding siblings ...)
2022-05-09 20:20 ` Eloitor
@ 2022-05-09 20:20 ` Eloitor
2022-05-09 21:52 ` [PR REVIEW] " paper42
` (11 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Eloitor @ 2022-05-09 20:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages clickclack
https://github.com/void-linux/void-packages/pull/36915
New Package: clickclack-0.2.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/36915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-clickclack-36915.patch --]
[-- Type: text/x-diff, Size: 1945 bytes --]
From b436233438a15bddfc687f849b65658d44909fbf Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloi.torrentsj@gmail.com>
Date: Sat, 30 Apr 2022 00:19:44 +0200
Subject: [PATCH] New Package: clickclack-0.2.2
---
.../patches/support-cross-compilation.patch | 22 +++++++++++++++++++
srcpkgs/clickclack/template | 16 ++++++++++++++
2 files changed, 38 insertions(+)
create mode 100644 srcpkgs/clickclack/patches/support-cross-compilation.patch
create mode 100644 srcpkgs/clickclack/template
diff --git a/srcpkgs/clickclack/patches/support-cross-compilation.patch b/srcpkgs/clickclack/patches/support-cross-compilation.patch
new file mode 100644
index 000000000000..ec0a57c38128
--- /dev/null
+++ b/srcpkgs/clickclack/patches/support-cross-compilation.patch
@@ -0,0 +1,22 @@
+ Makefile | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index b593b7f..1bf7a8e 100644
+--- a/Makefile
++++ b/Makefile
+@@ -2,12 +2,13 @@ PREFIX:=/usr
+
+ PROGRAMS = clickclack
+
++CC ?= $(CROSS_COMPILE)gcc
+ CFLAGS ?= -O2
+
+ all: $(PROGRAMS)
+
+ clickclack: clickclack.c
+- gcc $(CFLAGS) -o clickclack clickclack.c -l SDL2
++ $(CC) $(CFLAGS) -o clickclack clickclack.c -l SDL2
+
+ clean:
+ rm -f clickclack
diff --git a/srcpkgs/clickclack/template b/srcpkgs/clickclack/template
new file mode 100644
index 000000000000..bdf0a3b2c399
--- /dev/null
+++ b/srcpkgs/clickclack/template
@@ -0,0 +1,16 @@
+# Template file for 'clickclack'
+pkgname=clickclack
+version=0.2.2
+revision=1
+build_style=gnu-makefile
+makedepends="SDL2-devel"
+short_desc="Simple haptic feedback and audio feedback tool"
+maintainer="Eloi Torrents <eloitor@disroot.org>"
+license=MIT
+homepage=https://git.sr.ht/~proycon/clickclack
+distfiles="https://git.sr.ht/~proycon/clickclack/archive/${version}.tar.gz"
+checksum=0d2b1e55a59a0b7dc32dae60d7f2d420111b52d30fe2e0871a284436aa2ffcbd
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (6 preceding siblings ...)
2022-05-09 20:20 ` Eloitor
@ 2022-05-09 21:52 ` paper42
2022-05-09 21:52 ` paper42
` (10 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: paper42 @ 2022-05-09 21:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/36915#discussion_r868505141
Comment:
$CC is already set by make and we override it, so I don't think we have to patch this
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (7 preceding siblings ...)
2022-05-09 21:52 ` [PR REVIEW] " paper42
@ 2022-05-09 21:52 ` paper42
2022-05-09 21:52 ` paper42
` (9 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: paper42 @ 2022-05-09 21:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/36915#discussion_r868505140
Comment:
$CC is already set by make and we override it, so I don't think we have to patch this
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (8 preceding siblings ...)
2022-05-09 21:52 ` paper42
@ 2022-05-09 21:52 ` paper42
2022-05-10 11:10 ` JamiKettunen
` (8 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: paper42 @ 2022-05-09 21:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/36915#discussion_r868505141
Comment:
$CC is already set by make and we override it, so I don't think we have to patch this
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (9 preceding siblings ...)
2022-05-09 21:52 ` paper42
@ 2022-05-10 11:10 ` JamiKettunen
2022-05-10 11:11 ` JamiKettunen
` (7 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: JamiKettunen @ 2022-05-10 11:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 403 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/36915#discussion_r869110392
Comment:
Yeah technically this line addition isn't needed, I suppose I can drop it as it seems the `CROSS_COMPILE` part isn't useful anyway as `CC=cc` is set by default anyway and should be sufficient; I'll send a v2 and the new patch can be used here as well.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (10 preceding siblings ...)
2022-05-10 11:10 ` JamiKettunen
@ 2022-05-10 11:11 ` JamiKettunen
2022-05-10 12:27 ` JamiKettunen
` (6 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: JamiKettunen @ 2022-05-10 11:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/36915#discussion_r869110392
Comment:
Yeah technically this line addition isn't needed, I suppose I can drop it as it seems the `CROSS_COMPILE` part isn't useful anyway as `CC=cc` is set by default anyway (preventing `?=` from changing the already-set `CC` value) and should be sufficient; I'll send a v2 and the new patch can be used here as well.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (11 preceding siblings ...)
2022-05-10 11:11 ` JamiKettunen
@ 2022-05-10 12:27 ` JamiKettunen
2022-05-10 20:54 ` [PR PATCH] [Updated] " Eloitor
` (5 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: JamiKettunen @ 2022-05-10 12:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/36915#discussion_r869173555
Comment:
[v2 now submitted](https://lists.sr.ht/~mil/sxmo-devel/patches/32157), feel free to grab the simpler first patch from there now @Eloitor
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (12 preceding siblings ...)
2022-05-10 12:27 ` JamiKettunen
@ 2022-05-10 20:54 ` Eloitor
2022-05-10 20:54 ` [PR REVIEW] " Eloitor
` (4 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Eloitor @ 2022-05-10 20:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages clickclack
https://github.com/void-linux/void-packages/pull/36915
New Package: clickclack-0.2.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/36915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-clickclack-36915.patch --]
[-- Type: text/x-diff, Size: 1870 bytes --]
From bbb39eb552da911113347fe076ce3857605483b4 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloi.torrentsj@gmail.com>
Date: Sat, 30 Apr 2022 00:19:44 +0200
Subject: [PATCH] New Package: clickclack-0.2.2
---
.../patches/support-cross-compilation.patch | 16 ++++++++++++++++
srcpkgs/clickclack/template | 16 ++++++++++++++++
2 files changed, 32 insertions(+)
create mode 100644 srcpkgs/clickclack/patches/support-cross-compilation.patch
create mode 100644 srcpkgs/clickclack/template
diff --git a/srcpkgs/clickclack/patches/support-cross-compilation.patch b/srcpkgs/clickclack/patches/support-cross-compilation.patch
new file mode 100644
index 000000000000..cfc43805de34
--- /dev/null
+++ b/srcpkgs/clickclack/patches/support-cross-compilation.patch
@@ -0,0 +1,16 @@
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index b593b7f..ff07cbf 100644
+--- a/Makefile
++++ b/Makefile
+@@ -7,7 +7,7 @@ CFLAGS ?= -O2
+ all: $(PROGRAMS)
+
+ clickclack: clickclack.c
+- gcc $(CFLAGS) -o clickclack clickclack.c -l SDL2
++ $(CC) $(CFLAGS) -o clickclack clickclack.c -l SDL2
+
+ clean:
+ rm -f clickclack
diff --git a/srcpkgs/clickclack/template b/srcpkgs/clickclack/template
new file mode 100644
index 000000000000..bdf0a3b2c399
--- /dev/null
+++ b/srcpkgs/clickclack/template
@@ -0,0 +1,16 @@
+# Template file for 'clickclack'
+pkgname=clickclack
+version=0.2.2
+revision=1
+build_style=gnu-makefile
+makedepends="SDL2-devel"
+short_desc="Simple haptic feedback and audio feedback tool"
+maintainer="Eloi Torrents <eloitor@disroot.org>"
+license=MIT
+homepage=https://git.sr.ht/~proycon/clickclack
+distfiles="https://git.sr.ht/~proycon/clickclack/archive/${version}.tar.gz"
+checksum=0d2b1e55a59a0b7dc32dae60d7f2d420111b52d30fe2e0871a284436aa2ffcbd
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (13 preceding siblings ...)
2022-05-10 20:54 ` [PR PATCH] [Updated] " Eloitor
@ 2022-05-10 20:54 ` Eloitor
2022-05-10 22:30 ` JamiKettunen
` (3 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Eloitor @ 2022-05-10 20:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
New review comment by Eloitor on void-packages repository
https://github.com/void-linux/void-packages/pull/36915#discussion_r869671950
Comment:
Thank you
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (14 preceding siblings ...)
2022-05-10 20:54 ` [PR REVIEW] " Eloitor
@ 2022-05-10 22:30 ` JamiKettunen
2022-05-12 8:12 ` [PR PATCH] [Updated] " Eloitor
` (2 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: JamiKettunen @ 2022-05-10 22:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/36915#discussion_r869727196
Comment:
`0.2.3` has now been tagged and includes the fixes from my previously mentioned patch series including the cross-compile patch, so that can be dropped as well after updating :)
Btw it appears `./xbps-src update-check clickclack` fails to find an upstream version currently, so adding an `update` file [as per the XBPS source packages manual](https://github.com/void-linux/void-packages/blob/master/Manual.md#checking-for-new-upstream-releases) with `pattern='\s{12}\K[\d.]+'` in it should fix this (for now at least).
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (15 preceding siblings ...)
2022-05-10 22:30 ` JamiKettunen
@ 2022-05-12 8:12 ` Eloitor
2022-05-12 8:14 ` Eloitor
2022-05-13 19:18 ` [PR PATCH] [Merged]: New Package: clickclack-0.2.3 paper42
18 siblings, 0 replies; 20+ messages in thread
From: Eloitor @ 2022-05-12 8:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages clickclack
https://github.com/void-linux/void-packages/pull/36915
New Package: clickclack-0.2.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/36915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-clickclack-36915.patch --]
[-- Type: text/x-diff, Size: 1321 bytes --]
From 744b901e47dfacc9cea2fc1e3339c3a43679ed73 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloi.torrentsj@gmail.com>
Date: Sat, 30 Apr 2022 00:19:44 +0200
Subject: [PATCH] New Package: clickclack-0.2.2
---
srcpkgs/clickclack/template | 16 ++++++++++++++++
srcpkgs/clickclack/update | 1 +
2 files changed, 17 insertions(+)
create mode 100644 srcpkgs/clickclack/template
create mode 100644 srcpkgs/clickclack/update
diff --git a/srcpkgs/clickclack/template b/srcpkgs/clickclack/template
new file mode 100644
index 000000000000..bb137432cd35
--- /dev/null
+++ b/srcpkgs/clickclack/template
@@ -0,0 +1,16 @@
+# Template file for 'clickclack'
+pkgname=clickclack
+version=0.2.3
+revision=1
+build_style=gnu-makefile
+makedepends="SDL2-devel"
+short_desc="Simple haptic feedback and audio feedback tool"
+maintainer="Eloi Torrents <eloitor@disroot.org>"
+license=MIT
+homepage=https://git.sr.ht/~proycon/clickclack
+distfiles="https://git.sr.ht/~proycon/clickclack/archive/${version}.tar.gz"
+checksum=940f13ae1aa8b33677d8153db4af848233cb45dbb755320463dc3f980c73cced
+
+post_install() {
+ vlicense LICENSE
+}
diff --git a/srcpkgs/clickclack/update b/srcpkgs/clickclack/update
new file mode 100644
index 000000000000..963c41fa75bc
--- /dev/null
+++ b/srcpkgs/clickclack/update
@@ -0,0 +1 @@
+pattern='\s{12}\K[\d.]+'
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New Package: clickclack-0.2.2
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (16 preceding siblings ...)
2022-05-12 8:12 ` [PR PATCH] [Updated] " Eloitor
@ 2022-05-12 8:14 ` Eloitor
2022-05-13 19:18 ` [PR PATCH] [Merged]: New Package: clickclack-0.2.3 paper42
18 siblings, 0 replies; 20+ messages in thread
From: Eloitor @ 2022-05-12 8:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages clickclack
https://github.com/void-linux/void-packages/pull/36915
New Package: clickclack-0.2.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/36915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-clickclack-36915.patch --]
[-- Type: text/x-diff, Size: 1321 bytes --]
From 78ade6d0d5897b30b465f1d6e41d08256a80eb53 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloi.torrentsj@gmail.com>
Date: Sat, 30 Apr 2022 00:19:44 +0200
Subject: [PATCH] New Package: clickclack-0.2.3
---
srcpkgs/clickclack/template | 16 ++++++++++++++++
srcpkgs/clickclack/update | 1 +
2 files changed, 17 insertions(+)
create mode 100644 srcpkgs/clickclack/template
create mode 100644 srcpkgs/clickclack/update
diff --git a/srcpkgs/clickclack/template b/srcpkgs/clickclack/template
new file mode 100644
index 000000000000..bb137432cd35
--- /dev/null
+++ b/srcpkgs/clickclack/template
@@ -0,0 +1,16 @@
+# Template file for 'clickclack'
+pkgname=clickclack
+version=0.2.3
+revision=1
+build_style=gnu-makefile
+makedepends="SDL2-devel"
+short_desc="Simple haptic feedback and audio feedback tool"
+maintainer="Eloi Torrents <eloitor@disroot.org>"
+license=MIT
+homepage=https://git.sr.ht/~proycon/clickclack
+distfiles="https://git.sr.ht/~proycon/clickclack/archive/${version}.tar.gz"
+checksum=940f13ae1aa8b33677d8153db4af848233cb45dbb755320463dc3f980c73cced
+
+post_install() {
+ vlicense LICENSE
+}
diff --git a/srcpkgs/clickclack/update b/srcpkgs/clickclack/update
new file mode 100644
index 000000000000..963c41fa75bc
--- /dev/null
+++ b/srcpkgs/clickclack/update
@@ -0,0 +1 @@
+pattern='\s{12}\K[\d.]+'
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Merged]: New Package: clickclack-0.2.3
2022-04-29 20:22 [PR PATCH] New Package: clickclack-0.2.2 Eloitor
` (17 preceding siblings ...)
2022-05-12 8:14 ` Eloitor
@ 2022-05-13 19:18 ` paper42
18 siblings, 0 replies; 20+ messages in thread
From: paper42 @ 2022-05-13 19:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
There's a merged pull request on the void-packages repository
New Package: clickclack-0.2.3
https://github.com/void-linux/void-packages/pull/36915
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
^ permalink raw reply [flat|nested] 20+ messages in thread