* Re: [PR REVIEW] New package: espanso-2.1.6beta
2022-07-08 7:44 [PR PATCH] New package: espanso-2.1.6beta strec007
@ 2022-07-08 11:14 ` paper42
2022-07-08 11:14 ` paper42
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-07-08 11:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/37922#discussion_r916718954
Comment:
we should use a stable version
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] New package: espanso-2.1.6beta
2022-07-08 7:44 [PR PATCH] New package: espanso-2.1.6beta strec007
2022-07-08 11:14 ` [PR REVIEW] " paper42
@ 2022-07-08 11:14 ` paper42
2022-07-08 11:34 ` strec007
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-07-08 11:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/37922#discussion_r916719094
Comment:
remove this
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] New package: espanso-2.1.6beta
2022-07-08 7:44 [PR PATCH] New package: espanso-2.1.6beta strec007
2022-07-08 11:14 ` [PR REVIEW] " paper42
2022-07-08 11:14 ` paper42
@ 2022-07-08 11:34 ` strec007
2022-07-08 11:35 ` strec007
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: strec007 @ 2022-07-08 11:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
New review comment by strec007 on void-packages repository
https://github.com/void-linux/void-packages/pull/37922#discussion_r916732113
Comment:
Well, they have only released alpha or beta versions for years. See https://github.com/espanso/espanso/tags. The last one without the "beta" is probably obsolete. As a remark, Arch is also currently using the version 2.1.6. Without beta.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] New package: espanso-2.1.6beta
2022-07-08 7:44 [PR PATCH] New package: espanso-2.1.6beta strec007
` (2 preceding siblings ...)
2022-07-08 11:34 ` strec007
@ 2022-07-08 11:35 ` strec007
2022-07-08 14:05 ` paper42
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: strec007 @ 2022-07-08 11:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
New review comment by strec007 on void-packages repository
https://github.com/void-linux/void-packages/pull/37922#discussion_r916733004
Comment:
It seems that the authors only support 64-bit architectures. It won't compile for non-64-bit architectures.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] New package: espanso-2.1.6beta
2022-07-08 7:44 [PR PATCH] New package: espanso-2.1.6beta strec007
` (3 preceding siblings ...)
2022-07-08 11:35 ` strec007
@ 2022-07-08 14:05 ` paper42
2022-07-08 14:05 ` paper42
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-07-08 14:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/37922#discussion_r916844691
Comment:
Arch doesn't package this, it's only in AUR and no other main repositories. AUR calls the version 2.1.6, but it's actually beta. Do you know why they don't consider their software stable in recent versions?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] New package: espanso-2.1.6beta
2022-07-08 7:44 [PR PATCH] New package: espanso-2.1.6beta strec007
` (4 preceding siblings ...)
2022-07-08 14:05 ` paper42
@ 2022-07-08 14:05 ` paper42
2022-07-08 14:05 ` paper42
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-07-08 14:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/37922#discussion_r916847862
Comment:
can we also build it with wayland support?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] New package: espanso-2.1.6beta
2022-07-08 7:44 [PR PATCH] New package: espanso-2.1.6beta strec007
` (5 preceding siblings ...)
2022-07-08 14:05 ` paper42
@ 2022-07-08 14:05 ` paper42
2022-07-08 14:17 ` strec007
2022-07-12 8:36 ` [PR PATCH] [Closed]: " strec007
8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-07-08 14:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/37922#discussion_r916847196
Comment:
Do you have a link about that? It's a high level tool, so I don't really know why this would be necessary. Anyway, there are also other 64bit architectures, most notably -musl versions and ppc64le.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] New package: espanso-2.1.6beta
2022-07-08 7:44 [PR PATCH] New package: espanso-2.1.6beta strec007
` (6 preceding siblings ...)
2022-07-08 14:05 ` paper42
@ 2022-07-08 14:17 ` strec007
2022-07-12 8:36 ` [PR PATCH] [Closed]: " strec007
8 siblings, 0 replies; 10+ messages in thread
From: strec007 @ 2022-07-08 14:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 684 bytes --]
New review comment by strec007 on void-packages repository
https://github.com/void-linux/void-packages/pull/37922#discussion_r916863017
Comment:
I'm not familiar with their versioning conventions; I'm not in touch with them.
The support of only 64-bit architectures is my guess because with all others, the compilation fails stating that it's getting a u64 type instead of u32 which does not happen on the 64-bit architectures. I would expect that they don't care about non-64 bit and nobody tried. It might be in fact a trivial fix to make it run but I don't currently have the resources to dig into somebody else's project.
As for Wayland, I must take a look how to do it.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Closed]: New package: espanso-2.1.6beta
2022-07-08 7:44 [PR PATCH] New package: espanso-2.1.6beta strec007
` (7 preceding siblings ...)
2022-07-08 14:17 ` strec007
@ 2022-07-12 8:36 ` strec007
8 siblings, 0 replies; 10+ messages in thread
From: strec007 @ 2022-07-12 8:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
There's a closed pull request on the void-packages repository
New package: espanso-2.1.6beta
https://github.com/void-linux/void-packages/pull/37922
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
^ permalink raw reply [flat|nested] 10+ messages in thread