* [PR PATCH] New package: libopensmtpd-0.7
@ 2022-07-24 20:54 agausmann
2022-07-24 22:08 ` [PR PATCH] [Updated] " agausmann
` (34 more replies)
0 siblings, 35 replies; 36+ messages in thread
From: agausmann @ 2022-07-24 20:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]
There is a new pull request by agausmann against master on the void-packages repository
https://github.com/agausmann/void-packages libopensmtpd
https://github.com/void-linux/void-packages/pull/38253
New package: libopensmtpd-0.7
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Integration test with opensmtpd-filter-dkimsign (PR pending) and a fully configured OpenSMTPD server: Passed DKIM test provided by https://appmaildev.com/en/dkim
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
- It is a dependency of opensmtpd-filter-dkimsign (PR pending)
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures:
- x86_64-musl crossbuild
- i686 crossbuild
- aarch64 crossbuild
- aarch64-musl crossbuild
A patch file from https://github.com/void-linux/void-packages/pull/38253.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libopensmtpd-38253.patch --]
[-- Type: text/x-diff, Size: 2094 bytes --]
From e35b602d7ddcb4c1364a2ac8cec8608aa03bd8ff Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 14:45:34 -0500
Subject: [PATCH] New package: libopensmtpd-0.7
---
common/shlibs | 1 +
srcpkgs/libopensmtpd-devel | 1 +
srcpkgs/libopensmtpd/template | 31 +++++++++++++++++++++++++++++++
3 files changed, 33 insertions(+)
create mode 120000 srcpkgs/libopensmtpd-devel
create mode 100644 srcpkgs/libopensmtpd/template
diff --git a/common/shlibs b/common/shlibs
index c3dd63f542db..8df21eef97a3 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4175,3 +4175,4 @@ libjaylink.so.0 libjaylink-0.2.0_1
libnvidia-container.so.1 libnvidia-container-1.10.0_1
libnvidia-container-go.so.1 libnvidia-container-1.10.0_1
libqtspell-qt5.so.1 qtspell-1.0.1_1
+libopensmtpd.so.0 libopensmtpd-0.7_1
diff --git a/srcpkgs/libopensmtpd-devel b/srcpkgs/libopensmtpd-devel
new file mode 120000
index 000000000000..c2cb53a79f1b
--- /dev/null
+++ b/srcpkgs/libopensmtpd-devel
@@ -0,0 +1 @@
+libopensmtpd
\ No newline at end of file
diff --git a/srcpkgs/libopensmtpd/template b/srcpkgs/libopensmtpd/template
new file mode 100644
index 000000000000..0ad80471b65e
--- /dev/null
+++ b/srcpkgs/libopensmtpd/template
@@ -0,0 +1,31 @@
+# Template file for 'libopensmtpd'
+pkgname=libopensmtpd
+version=0.7
+revision=1
+hostmakedepends="mdocml"
+makedepends="libevent-devel"
+short_desc="Library for creating opensmtpd filters"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="custom:BSD-like"
+homepage="http://imperialat.at/dev/libopensmtpd/"
+distfiles="https://distfiles.sigtrap.nl/${pkgname}-${version}.tar.gz"
+checksum="cdd6d5e11a7063f9265da43a42309c646554b8b68b03982ca8472dbe2b08a613"
+
+libopensmtpd-devel_package() {
+ short_desc+=" - development files"
+ depends="${sourcepkg}>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/include
+ vmove "usr/lib/*.so"
+ vmove usr/share/man/man3
+ }
+}
+
+do_build() {
+ make -f Makefile.gnu
+}
+
+do_install() {
+ make -f Makefile.gnu DESTDIR="$DESTDIR" install
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR PATCH] [Updated] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
@ 2022-07-24 22:08 ` agausmann
2022-07-24 22:25 ` [PR REVIEW] " Duncaen
` (33 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-24 22:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]
There is an updated pull request by agausmann against master on the void-packages repository
https://github.com/agausmann/void-packages libopensmtpd
https://github.com/void-linux/void-packages/pull/38253
New package: libopensmtpd-0.7
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Integration test with opensmtpd-filter-dkimsign (#38254) and a fully configured OpenSMTPD server: Passed DKIM test provided by https://appmaildev.com/en/dkim
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
- It is a dependency of opensmtpd-filter-dkimsign (#38254)
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures:
- x86_64-musl crossbuild
- i686 crossbuild
- aarch64 crossbuild
- aarch64-musl crossbuild
A patch file from https://github.com/void-linux/void-packages/pull/38253.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libopensmtpd-38253.patch --]
[-- Type: text/x-diff, Size: 2092 bytes --]
From 37bebf6d196273cc552e9300f51be1694b04e08c Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 14:45:34 -0500
Subject: [PATCH] New package: libopensmtpd-0.7
---
common/shlibs | 1 +
srcpkgs/libopensmtpd-devel | 1 +
srcpkgs/libopensmtpd/template | 31 +++++++++++++++++++++++++++++++
3 files changed, 33 insertions(+)
create mode 120000 srcpkgs/libopensmtpd-devel
create mode 100644 srcpkgs/libopensmtpd/template
diff --git a/common/shlibs b/common/shlibs
index c3dd63f542db..8df21eef97a3 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4175,3 +4175,4 @@ libjaylink.so.0 libjaylink-0.2.0_1
libnvidia-container.so.1 libnvidia-container-1.10.0_1
libnvidia-container-go.so.1 libnvidia-container-1.10.0_1
libqtspell-qt5.so.1 qtspell-1.0.1_1
+libopensmtpd.so.0 libopensmtpd-0.7_1
diff --git a/srcpkgs/libopensmtpd-devel b/srcpkgs/libopensmtpd-devel
new file mode 120000
index 000000000000..c2cb53a79f1b
--- /dev/null
+++ b/srcpkgs/libopensmtpd-devel
@@ -0,0 +1 @@
+libopensmtpd
\ No newline at end of file
diff --git a/srcpkgs/libopensmtpd/template b/srcpkgs/libopensmtpd/template
new file mode 100644
index 000000000000..d67976bab4be
--- /dev/null
+++ b/srcpkgs/libopensmtpd/template
@@ -0,0 +1,31 @@
+# Template file for 'libopensmtpd'
+pkgname=libopensmtpd
+version=0.7
+revision=1
+hostmakedepends="mdocml"
+makedepends="libevent-devel"
+short_desc="Library for creating opensmtpd filters"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="custom:BSD-like"
+homepage="http://imperialat.at/dev/libopensmtpd/"
+distfiles="https://distfiles.sigtrap.nl/${pkgname}-${version}.tar.gz"
+checksum=cdd6d5e11a7063f9265da43a42309c646554b8b68b03982ca8472dbe2b08a613
+
+libopensmtpd-devel_package() {
+ short_desc+=" - development files"
+ depends="${sourcepkg}>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/include
+ vmove "usr/lib/*.so"
+ vmove usr/share/man/man3
+ }
+}
+
+do_build() {
+ make -f Makefile.gnu
+}
+
+do_install() {
+ make -f Makefile.gnu DESTDIR="$DESTDIR" install
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
2022-07-24 22:08 ` [PR PATCH] [Updated] " agausmann
@ 2022-07-24 22:25 ` Duncaen
2022-07-24 22:25 ` Duncaen
` (32 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: Duncaen @ 2022-07-24 22:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928319931
Comment:
Please move this function at the end after all the actual build functions.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
2022-07-24 22:08 ` [PR PATCH] [Updated] " agausmann
2022-07-24 22:25 ` [PR REVIEW] " Duncaen
@ 2022-07-24 22:25 ` Duncaen
2022-07-24 22:26 ` Duncaen
` (31 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: Duncaen @ 2022-07-24 22:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928319931
Comment:
Please move this function at the end after all the actual build/install functions.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (2 preceding siblings ...)
2022-07-24 22:25 ` Duncaen
@ 2022-07-24 22:26 ` Duncaen
2022-07-24 22:27 ` Duncaen
` (30 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: Duncaen @ 2022-07-24 22:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928320041
Comment:
`makecmd="make -f Makefile.gnu"` instead of the custom `do_build` and `do_install` functions should work.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (3 preceding siblings ...)
2022-07-24 22:26 ` Duncaen
@ 2022-07-24 22:27 ` Duncaen
2022-07-24 22:39 ` agausmann
` (29 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: Duncaen @ 2022-07-24 22:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 286 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928320041
Comment:
`makecmd="make -f Makefile.gnu"` instead of the custom `do_build` and `do_install` functions should work. (and `build_style=gnu-makefile`).
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (4 preceding siblings ...)
2022-07-24 22:27 ` Duncaen
@ 2022-07-24 22:39 ` agausmann
2022-07-24 22:40 ` agausmann
` (28 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-24 22:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
New review comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928321216
Comment:
I've tried a gnu-makefile build style just like you suggested (also making sure move the `vlicense LICENSE` to `post_install`), but I get this error:
```
opensmtpd.c:19:10: fatal error: sys/tree.h: No such file or directory
19 | #include <sys/tree.h>
| ^~~~~~~~~~~~
compilation terminated.
```
Adding `libbsd-devel` to makedepends doesn't seem to fix it either.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (5 preceding siblings ...)
2022-07-24 22:39 ` agausmann
@ 2022-07-24 22:40 ` agausmann
2022-07-24 22:42 ` agausmann
` (27 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-24 22:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
New review comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928321216
Comment:
I've tried a gnu-makefile build style just like you suggested (also making sure to move the `vlicense LICENSE` to `post_install`), but I get this error:
```
opensmtpd.c:19:10: fatal error: sys/tree.h: No such file or directory
19 | #include <sys/tree.h>
| ^~~~~~~~~~~~
compilation terminated.
```
Adding `libbsd-devel` to makedepends doesn't seem to fix it either.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (6 preceding siblings ...)
2022-07-24 22:40 ` agausmann
@ 2022-07-24 22:42 ` agausmann
2022-07-24 22:47 ` agausmann
` (26 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-24 22:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
New review comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928321216
Comment:
I've tried a gnu-makefile build style just like you suggested (also making sure to move the `vlicense LICENSE` to `post_install`), but I get this error:
```
opensmtpd.c:19:10: fatal error: sys/tree.h: No such file or directory
19 | #include <sys/tree.h>
| ^~~~~~~~~~~~
compilation terminated.
```
I've tried adding `libbsd-devel` to makedepends but that didn't work.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (7 preceding siblings ...)
2022-07-24 22:42 ` agausmann
@ 2022-07-24 22:47 ` agausmann
2022-07-24 22:48 ` agausmann
` (25 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-24 22:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
New review comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928321997
Comment:
It is missing some cflags by the look of it:
- with manual `do_build`:
```
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/libopensmtpd-0.7=. -I/builddir/libopensmtpd-0.7/ -I/builddir/libopensmtpd-0.7//openbsd-compat/ -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wsign-compare -fPIC -DNEED_RECALLOCARRAY=1 -DNEED_STRLCAT=1 -DNEED_STRLCPY=1 -DNEED_STRTONUM=1 -c -o opensmtpd.o opensmtpd.c
```
- with `build_style=gnu-makefile; make_cmd="make -f Makefile.gnu"`:
```
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/libopensmtpd-0.7=. -c -o opensmtpd.o opensmtpd.c
```
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (8 preceding siblings ...)
2022-07-24 22:47 ` agausmann
@ 2022-07-24 22:48 ` agausmann
2022-07-24 22:58 ` agausmann
` (24 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-24 22:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
New review comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928321997
Comment:
It is missing some cc flags by the look of it:
- with manual `do_build`:
```
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/libopensmtpd-0.7=. -I/builddir/libopensmtpd-0.7/ -I/builddir/libopensmtpd-0.7//openbsd-compat/ -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wsign-compare -fPIC -DNEED_RECALLOCARRAY=1 -DNEED_STRLCAT=1 -DNEED_STRLCPY=1 -DNEED_STRTONUM=1 -c -o opensmtpd.o opensmtpd.c
```
- with `build_style=gnu-makefile; make_cmd="make -f Makefile.gnu"`:
```
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/libopensmtpd-0.7=. -c -o opensmtpd.o opensmtpd.c
```
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (9 preceding siblings ...)
2022-07-24 22:48 ` agausmann
@ 2022-07-24 22:58 ` agausmann
2022-07-24 22:59 ` agausmann
` (23 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-24 22:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]
New review comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928321997
Comment:
It is missing some cc flags by the look of it:
- with manual `do_build`:
```
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/libopensmtpd-0.7=. -I/builddir/libopensmtpd-0.7/ -I/builddir/libopensmtpd-0.7//openbsd-compat/ -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wsign-compare -fPIC -DNEED_RECALLOCARRAY=1 -DNEED_STRLCAT=1 -DNEED_STRLCPY=1 -DNEED_STRTONUM=1 -c -o opensmtpd.o opensmtpd.c
```
- with `build_style=gnu-makefile; make_cmd="make -f Makefile.gnu"`:
```
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/libopensmtpd-0.7=. -c -o opensmtpd.o opensmtpd.c
```
<hr>
Edit - I remember this from another package I worked on - there are options added to CFLAGS in the makefile that get overwritten on the command line:
```make
CFLAGS+= -I${CURDIR} -I${CURDIR}/openbsd-compat/
CFLAGS+= -Wall
CFLAGS+= -Wstrict-prototypes -Wmissing-prototypes
CFLAGS+= -Wmissing-declarations
CFLAGS+= -Wshadow -Wpointer-arith -Wcast-qual
CFLAGS+= -Wsign-compare
```
Since they do not have the `override` directive, they don't affect the `CFLAGS` set on the command line by the gnu-makefile build style.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (10 preceding siblings ...)
2022-07-24 22:58 ` agausmann
@ 2022-07-24 22:59 ` agausmann
2022-07-24 23:05 ` Duncaen
` (22 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-24 22:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]
New review comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928321997
Comment:
It is missing some cc flags by the look of it:
- with manual `do_build`:
```
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/libopensmtpd-0.7=. -I/builddir/libopensmtpd-0.7/ -I/builddir/libopensmtpd-0.7//openbsd-compat/ -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wsign-compare -fPIC -DNEED_RECALLOCARRAY=1 -DNEED_STRLCAT=1 -DNEED_STRLCPY=1 -DNEED_STRTONUM=1 -c -o opensmtpd.o opensmtpd.c
```
- with `build_style=gnu-makefile; make_cmd="make -f Makefile.gnu"`:
```
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/libopensmtpd-0.7=. -c -o opensmtpd.o opensmtpd.c
```
<hr>
Edit - I remember this from another package I worked on - there are options added to CFLAGS in the makefile that get overwritten on the command line, since they don't use the `override` directive:
```make
CFLAGS+= -I${CURDIR} -I${CURDIR}/openbsd-compat/
CFLAGS+= -Wall
CFLAGS+= -Wstrict-prototypes -Wmissing-prototypes
CFLAGS+= -Wmissing-declarations
CFLAGS+= -Wshadow -Wpointer-arith -Wcast-qual
CFLAGS+= -Wsign-compare
```
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (11 preceding siblings ...)
2022-07-24 22:59 ` agausmann
@ 2022-07-24 23:05 ` Duncaen
2022-07-24 23:08 ` Duncaen
` (21 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: Duncaen @ 2022-07-24 23:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928323872
Comment:
Try `make_use_env=yes`.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (12 preceding siblings ...)
2022-07-24 23:05 ` Duncaen
@ 2022-07-24 23:08 ` Duncaen
2022-07-24 23:12 ` agausmann
` (20 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: Duncaen @ 2022-07-24 23:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928324158
Comment:
`ISC` is fine for this, http://imperialat.at/dev/libopensmtpd/LICENSE https://spdx.org/licenses/ISC.html
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (13 preceding siblings ...)
2022-07-24 23:08 ` Duncaen
@ 2022-07-24 23:12 ` agausmann
2022-07-24 23:13 ` Duncaen
` (19 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-24 23:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
New review comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928324733
Comment:
Much better than the patch file I was thinking of, thanks!
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (14 preceding siblings ...)
2022-07-24 23:12 ` agausmann
@ 2022-07-24 23:13 ` Duncaen
2022-07-24 23:13 ` Duncaen
` (18 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: Duncaen @ 2022-07-24 23:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 412 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928324791
Comment:
This is just used to format and then compress the man page, `xbps-src` uncompresses it again.
If you set `make_build_args="MANFORMAT="` and `make_install_args="MANFORMAT="` it should work without that extra dependency and just install the uncompressed mandoc file.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (15 preceding siblings ...)
2022-07-24 23:13 ` Duncaen
@ 2022-07-24 23:13 ` Duncaen
2022-07-24 23:38 ` [PR PATCH] [Updated] " agausmann
` (17 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: Duncaen @ 2022-07-24 23:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928324791
Comment:
This is just used to format and then compress the man page, `xbps-src` uncompresses it again.
If you set `make_build_args="MANFORMAT="` and `make_install_args="MANFORMAT="` it should work without that extra dependency and will just install the uncompressed mandoc file.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR PATCH] [Updated] New package: libopensmtpd-0.7
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (16 preceding siblings ...)
2022-07-24 23:13 ` Duncaen
@ 2022-07-24 23:38 ` agausmann
2022-07-24 23:57 ` [PR PATCH] [Updated] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5 agausmann
` (16 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-24 23:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]
There is an updated pull request by agausmann against master on the void-packages repository
https://github.com/agausmann/void-packages libopensmtpd
https://github.com/void-linux/void-packages/pull/38253
New package: libopensmtpd-0.7
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Integration test with opensmtpd-filter-dkimsign (#38254) and a fully configured OpenSMTPD server: Passed DKIM test provided by https://appmaildev.com/en/dkim
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
- It is a dependency of opensmtpd-filter-dkimsign (#38254)
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures:
- x86_64-musl crossbuild
- i686 crossbuild
- aarch64 crossbuild
- aarch64-musl crossbuild
A patch file from https://github.com/void-linux/void-packages/pull/38253.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libopensmtpd-38253.patch --]
[-- Type: text/x-diff, Size: 3450 bytes --]
From 45d23d13437e645eaf864ec0041435525d9d2abb Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 14:45:34 -0500
Subject: [PATCH 1/2] New package: libopensmtpd-0.7
---
common/shlibs | 1 +
srcpkgs/libopensmtpd-devel | 1 +
srcpkgs/libopensmtpd/template | 30 ++++++++++++++++++++++++++++++
3 files changed, 32 insertions(+)
create mode 120000 srcpkgs/libopensmtpd-devel
create mode 100644 srcpkgs/libopensmtpd/template
diff --git a/common/shlibs b/common/shlibs
index c3dd63f542db..8df21eef97a3 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4175,3 +4175,4 @@ libjaylink.so.0 libjaylink-0.2.0_1
libnvidia-container.so.1 libnvidia-container-1.10.0_1
libnvidia-container-go.so.1 libnvidia-container-1.10.0_1
libqtspell-qt5.so.1 qtspell-1.0.1_1
+libopensmtpd.so.0 libopensmtpd-0.7_1
diff --git a/srcpkgs/libopensmtpd-devel b/srcpkgs/libopensmtpd-devel
new file mode 120000
index 000000000000..c2cb53a79f1b
--- /dev/null
+++ b/srcpkgs/libopensmtpd-devel
@@ -0,0 +1 @@
+libopensmtpd
\ No newline at end of file
diff --git a/srcpkgs/libopensmtpd/template b/srcpkgs/libopensmtpd/template
new file mode 100644
index 000000000000..7000b5d74948
--- /dev/null
+++ b/srcpkgs/libopensmtpd/template
@@ -0,0 +1,30 @@
+# Template file for 'libopensmtpd'
+pkgname=libopensmtpd
+version=0.7
+revision=1
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libevent-devel"
+short_desc="Library for creating opensmtpd filters"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="http://imperialat.at/dev/libopensmtpd/"
+distfiles="https://distfiles.sigtrap.nl/${pkgname}-${version}.tar.gz"
+checksum=cdd6d5e11a7063f9265da43a42309c646554b8b68b03982ca8472dbe2b08a613
+
+post_install() {
+ vlicense LICENSE
+}
+
+libopensmtpd-devel_package() {
+ short_desc+=" - development files"
+ depends="${sourcepkg}>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/include
+ vmove "usr/lib/*.so"
+ vmove usr/share/man/man3
+ }
+}
From 3efbeb96077f578f8a257b9b4e3cd7f572d38029 Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 15:23:11 -0500
Subject: [PATCH 2/2] New package: opensmtpd-filter-dkimsign-0.5
---
srcpkgs/opensmtpd-filter-dkimsign/template | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 srcpkgs/opensmtpd-filter-dkimsign/template
diff --git a/srcpkgs/opensmtpd-filter-dkimsign/template b/srcpkgs/opensmtpd-filter-dkimsign/template
new file mode 100644
index 000000000000..b98decdf1941
--- /dev/null
+++ b/srcpkgs/opensmtpd-filter-dkimsign/template
@@ -0,0 +1,23 @@
+# Template file for 'opensmtpd-filter-dkimsign'
+pkgname=opensmtpd-filter-dkimsign
+version=0.5
+revision=1
+archs="x86_64 i686"
+_pkg="filter-dkimsign-${version}"
+wrksrc="${_pkg}"
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libopensmtpd-devel openssl-devel"
+short_desc="Filter for signing mail with DKIM"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="https://imperialat.at/dev/filter-dkimsign/"
+distfiles="https://distfiles.sigtrap.nl/${_pkg}.tar.gz"
+checksum=a5b4ec3af5ecb42351a0b5459bdd0f32c00ec55c23050b5f46dfaed8e321974b
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR PATCH] [Updated] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (17 preceding siblings ...)
2022-07-24 23:38 ` [PR PATCH] [Updated] " agausmann
@ 2022-07-24 23:57 ` agausmann
2022-07-25 9:47 ` [PR REVIEW] " Duncaen
` (15 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-24 23:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1511 bytes --]
There is an updated pull request by agausmann against master on the void-packages repository
https://github.com/agausmann/void-packages libopensmtpd
https://github.com/void-linux/void-packages/pull/38253
New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Integration test with and a fully configured OpenSMTPD server: Passed DKIM test provided by https://appmaildev.com/en/dkim
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
- The software needs to be compiled
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures:
- x86_64-musl _(crossbuild, libopensmtpd only)_
- i686 _(crossbuild)_
- aarch64 _(crossbuild, libopensmtpd only)_
- aarch64-musl _(crossbuild, libopensmtpd only)_
A patch file from https://github.com/void-linux/void-packages/pull/38253.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libopensmtpd-38253.patch --]
[-- Type: text/x-diff, Size: 3611 bytes --]
From def64255b9e93f2cf46268b98335e2da555f3b9d Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 14:45:34 -0500
Subject: [PATCH 1/2] New package: libopensmtpd-0.7
---
common/shlibs | 1 +
srcpkgs/libopensmtpd-devel | 1 +
srcpkgs/libopensmtpd/template | 34 ++++++++++++++++++++++++++++++++++
3 files changed, 36 insertions(+)
create mode 120000 srcpkgs/libopensmtpd-devel
create mode 100644 srcpkgs/libopensmtpd/template
diff --git a/common/shlibs b/common/shlibs
index c3dd63f542db..8df21eef97a3 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4175,3 +4175,4 @@ libjaylink.so.0 libjaylink-0.2.0_1
libnvidia-container.so.1 libnvidia-container-1.10.0_1
libnvidia-container-go.so.1 libnvidia-container-1.10.0_1
libqtspell-qt5.so.1 qtspell-1.0.1_1
+libopensmtpd.so.0 libopensmtpd-0.7_1
diff --git a/srcpkgs/libopensmtpd-devel b/srcpkgs/libopensmtpd-devel
new file mode 120000
index 000000000000..c2cb53a79f1b
--- /dev/null
+++ b/srcpkgs/libopensmtpd-devel
@@ -0,0 +1 @@
+libopensmtpd
\ No newline at end of file
diff --git a/srcpkgs/libopensmtpd/template b/srcpkgs/libopensmtpd/template
new file mode 100644
index 000000000000..a5d270be4e2d
--- /dev/null
+++ b/srcpkgs/libopensmtpd/template
@@ -0,0 +1,34 @@
+# Template file for 'libopensmtpd'
+pkgname=libopensmtpd
+version=0.7
+revision=1
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libevent-devel"
+short_desc="Library for creating opensmtpd filters"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="http://imperialat.at/dev/libopensmtpd/"
+distfiles="https://distfiles.sigtrap.nl/${pkgname}-${version}.tar.gz"
+checksum=cdd6d5e11a7063f9265da43a42309c646554b8b68b03982ca8472dbe2b08a613
+
+do_check() {
+ : # `make check` fails: there is no check/test target
+}
+
+post_install() {
+ vlicense LICENSE
+}
+
+libopensmtpd-devel_package() {
+ short_desc+=" - development files"
+ depends="${sourcepkg}>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/include
+ vmove "usr/lib/*.so"
+ vmove usr/share/man/man3
+ }
+}
From b59e4b380985bab4f0b33399bf7da12e11b4c78e Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 15:23:11 -0500
Subject: [PATCH 2/2] New package: opensmtpd-filter-dkimsign-0.5
---
srcpkgs/opensmtpd-filter-dkimsign/template | 27 ++++++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 srcpkgs/opensmtpd-filter-dkimsign/template
diff --git a/srcpkgs/opensmtpd-filter-dkimsign/template b/srcpkgs/opensmtpd-filter-dkimsign/template
new file mode 100644
index 000000000000..3d1182df39c8
--- /dev/null
+++ b/srcpkgs/opensmtpd-filter-dkimsign/template
@@ -0,0 +1,27 @@
+# Template file for 'opensmtpd-filter-dkimsign'
+pkgname=opensmtpd-filter-dkimsign
+version=0.5
+revision=1
+archs="x86_64 i686"
+_pkg="filter-dkimsign-${version}"
+wrksrc="${_pkg}"
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libopensmtpd-devel openssl-devel"
+short_desc="Filter for signing mail with DKIM"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="https://imperialat.at/dev/filter-dkimsign/"
+distfiles="https://distfiles.sigtrap.nl/${_pkg}.tar.gz"
+checksum=a5b4ec3af5ecb42351a0b5459bdd0f32c00ec55c23050b5f46dfaed8e321974b
+
+do_check() {
+ : # `make check` fails: there is no check/test target.
+}
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (19 preceding siblings ...)
2022-07-25 9:47 ` [PR REVIEW] " Duncaen
@ 2022-07-25 9:47 ` Duncaen
2022-07-25 10:01 ` paper42
` (13 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: Duncaen @ 2022-07-25 9:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928675422
Comment:
This shouldn't be limited to only those architectures.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (18 preceding siblings ...)
2022-07-24 23:57 ` [PR PATCH] [Updated] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5 agausmann
@ 2022-07-25 9:47 ` Duncaen
2022-07-25 9:47 ` Duncaen
` (14 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: Duncaen @ 2022-07-25 9:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928677177
Comment:
Just hardcode the name/version in wrksrc and distfiles.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (20 preceding siblings ...)
2022-07-25 9:47 ` Duncaen
@ 2022-07-25 10:01 ` paper42
2022-07-25 15:19 ` agausmann
` (12 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: paper42 @ 2022-07-25 10:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r928690016
Comment:
that's usually just a warning which doesn't mean we have to explicitly disable tests because do_check passes
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (21 preceding siblings ...)
2022-07-25 10:01 ` paper42
@ 2022-07-25 15:19 ` agausmann
2022-07-25 15:32 ` [PR PATCH] [Updated] " agausmann
` (11 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-25 15:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
New review comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r929008951
Comment:
It causes the CI to fail; adding this fixed it.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR PATCH] [Updated] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (22 preceding siblings ...)
2022-07-25 15:19 ` agausmann
@ 2022-07-25 15:32 ` agausmann
2022-07-25 15:41 ` [PR REVIEW] " agausmann
` (10 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-25 15:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]
There is an updated pull request by agausmann against master on the void-packages repository
https://github.com/agausmann/void-packages libopensmtpd
https://github.com/void-linux/void-packages/pull/38253
New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Integration test with and a fully configured OpenSMTPD server: Passed DKIM test provided by https://appmaildev.com/en/dkim
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
- The software needs to be compiled
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
A patch file from https://github.com/void-linux/void-packages/pull/38253.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libopensmtpd-38253.patch --]
[-- Type: text/x-diff, Size: 3593 bytes --]
From 6adc03ed08f7ed4bfa35b5665b3f0260cd49aaa4 Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 14:45:34 -0500
Subject: [PATCH 1/2] New package: libopensmtpd-0.7
---
common/shlibs | 1 +
srcpkgs/libopensmtpd-devel | 1 +
srcpkgs/libopensmtpd/template | 34 ++++++++++++++++++++++++++++++++++
3 files changed, 36 insertions(+)
create mode 120000 srcpkgs/libopensmtpd-devel
create mode 100644 srcpkgs/libopensmtpd/template
diff --git a/common/shlibs b/common/shlibs
index c3dd63f542db..8df21eef97a3 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4175,3 +4175,4 @@ libjaylink.so.0 libjaylink-0.2.0_1
libnvidia-container.so.1 libnvidia-container-1.10.0_1
libnvidia-container-go.so.1 libnvidia-container-1.10.0_1
libqtspell-qt5.so.1 qtspell-1.0.1_1
+libopensmtpd.so.0 libopensmtpd-0.7_1
diff --git a/srcpkgs/libopensmtpd-devel b/srcpkgs/libopensmtpd-devel
new file mode 120000
index 000000000000..c2cb53a79f1b
--- /dev/null
+++ b/srcpkgs/libopensmtpd-devel
@@ -0,0 +1 @@
+libopensmtpd
\ No newline at end of file
diff --git a/srcpkgs/libopensmtpd/template b/srcpkgs/libopensmtpd/template
new file mode 100644
index 000000000000..a5d270be4e2d
--- /dev/null
+++ b/srcpkgs/libopensmtpd/template
@@ -0,0 +1,34 @@
+# Template file for 'libopensmtpd'
+pkgname=libopensmtpd
+version=0.7
+revision=1
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libevent-devel"
+short_desc="Library for creating opensmtpd filters"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="http://imperialat.at/dev/libopensmtpd/"
+distfiles="https://distfiles.sigtrap.nl/${pkgname}-${version}.tar.gz"
+checksum=cdd6d5e11a7063f9265da43a42309c646554b8b68b03982ca8472dbe2b08a613
+
+do_check() {
+ : # `make check` fails: there is no check/test target
+}
+
+post_install() {
+ vlicense LICENSE
+}
+
+libopensmtpd-devel_package() {
+ short_desc+=" - development files"
+ depends="${sourcepkg}>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/include
+ vmove "usr/lib/*.so"
+ vmove usr/share/man/man3
+ }
+}
From 604e8134460060af52f6eb85f8b56f8b2cd89135 Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 15:23:11 -0500
Subject: [PATCH 2/2] New package: opensmtpd-filter-dkimsign-0.5
---
srcpkgs/opensmtpd-filter-dkimsign/template | 25 ++++++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 srcpkgs/opensmtpd-filter-dkimsign/template
diff --git a/srcpkgs/opensmtpd-filter-dkimsign/template b/srcpkgs/opensmtpd-filter-dkimsign/template
new file mode 100644
index 000000000000..84b09724ab90
--- /dev/null
+++ b/srcpkgs/opensmtpd-filter-dkimsign/template
@@ -0,0 +1,25 @@
+# Template file for 'opensmtpd-filter-dkimsign'
+pkgname=opensmtpd-filter-dkimsign
+version=0.5
+revision=1
+wrksrc="filter-dkimsign-${version}"
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libopensmtpd-devel openssl-devel"
+short_desc="Filter for signing mail with DKIM"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="https://imperialat.at/dev/filter-dkimsign/"
+distfiles="https://distfiles.sigtrap.nl/filter-dkimsign-${version}.tar.gz"
+checksum=a5b4ec3af5ecb42351a0b5459bdd0f32c00ec55c23050b5f46dfaed8e321974b
+
+do_check() {
+ : # `make check` fails: there is no check/test target.
+}
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (23 preceding siblings ...)
2022-07-25 15:32 ` [PR PATCH] [Updated] " agausmann
@ 2022-07-25 15:41 ` agausmann
2022-07-25 15:52 ` [PR PATCH] [Updated] " agausmann
` (9 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-25 15:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New review comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r929032271
Comment:
See previous rev 3efbeb96077f578f8a257b9b4e3cd7f572d38029
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR PATCH] [Updated] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (24 preceding siblings ...)
2022-07-25 15:41 ` [PR REVIEW] " agausmann
@ 2022-07-25 15:52 ` agausmann
2022-07-25 16:57 ` [PR REVIEW] " paper42
` (8 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-25 15:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]
There is an updated pull request by agausmann against master on the void-packages repository
https://github.com/agausmann/void-packages libopensmtpd
https://github.com/void-linux/void-packages/pull/38253
New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Integration test with and a fully configured OpenSMTPD server: Passed DKIM test provided by https://appmaildev.com/en/dkim
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
- The software needs to be compiled
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
A patch file from https://github.com/void-linux/void-packages/pull/38253.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libopensmtpd-38253.patch --]
[-- Type: text/x-diff, Size: 3593 bytes --]
From 18b75593f69689ed26eb78952bfbe1c5af366eb2 Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 14:45:34 -0500
Subject: [PATCH 1/2] New package: libopensmtpd-0.7
---
common/shlibs | 1 +
srcpkgs/libopensmtpd-devel | 1 +
srcpkgs/libopensmtpd/template | 34 ++++++++++++++++++++++++++++++++++
3 files changed, 36 insertions(+)
create mode 120000 srcpkgs/libopensmtpd-devel
create mode 100644 srcpkgs/libopensmtpd/template
diff --git a/common/shlibs b/common/shlibs
index c3dd63f542db..8df21eef97a3 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4175,3 +4175,4 @@ libjaylink.so.0 libjaylink-0.2.0_1
libnvidia-container.so.1 libnvidia-container-1.10.0_1
libnvidia-container-go.so.1 libnvidia-container-1.10.0_1
libqtspell-qt5.so.1 qtspell-1.0.1_1
+libopensmtpd.so.0 libopensmtpd-0.7_1
diff --git a/srcpkgs/libopensmtpd-devel b/srcpkgs/libopensmtpd-devel
new file mode 120000
index 000000000000..c2cb53a79f1b
--- /dev/null
+++ b/srcpkgs/libopensmtpd-devel
@@ -0,0 +1 @@
+libopensmtpd
\ No newline at end of file
diff --git a/srcpkgs/libopensmtpd/template b/srcpkgs/libopensmtpd/template
new file mode 100644
index 000000000000..a5d270be4e2d
--- /dev/null
+++ b/srcpkgs/libopensmtpd/template
@@ -0,0 +1,34 @@
+# Template file for 'libopensmtpd'
+pkgname=libopensmtpd
+version=0.7
+revision=1
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libevent-devel"
+short_desc="Library for creating opensmtpd filters"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="http://imperialat.at/dev/libopensmtpd/"
+distfiles="https://distfiles.sigtrap.nl/${pkgname}-${version}.tar.gz"
+checksum=cdd6d5e11a7063f9265da43a42309c646554b8b68b03982ca8472dbe2b08a613
+
+do_check() {
+ : # `make check` fails: there is no check/test target
+}
+
+post_install() {
+ vlicense LICENSE
+}
+
+libopensmtpd-devel_package() {
+ short_desc+=" - development files"
+ depends="${sourcepkg}>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/include
+ vmove "usr/lib/*.so"
+ vmove usr/share/man/man3
+ }
+}
From 6336596cdad204f9c0968082d498a2976227c759 Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 15:23:11 -0500
Subject: [PATCH 2/2] New package: opensmtpd-filter-dkimsign-0.5
---
srcpkgs/opensmtpd-filter-dkimsign/template | 25 ++++++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 srcpkgs/opensmtpd-filter-dkimsign/template
diff --git a/srcpkgs/opensmtpd-filter-dkimsign/template b/srcpkgs/opensmtpd-filter-dkimsign/template
new file mode 100644
index 000000000000..84b09724ab90
--- /dev/null
+++ b/srcpkgs/opensmtpd-filter-dkimsign/template
@@ -0,0 +1,25 @@
+# Template file for 'opensmtpd-filter-dkimsign'
+pkgname=opensmtpd-filter-dkimsign
+version=0.5
+revision=1
+wrksrc="filter-dkimsign-${version}"
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libopensmtpd-devel openssl-devel"
+short_desc="Filter for signing mail with DKIM"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="https://imperialat.at/dev/filter-dkimsign/"
+distfiles="https://distfiles.sigtrap.nl/filter-dkimsign-${version}.tar.gz"
+checksum=a5b4ec3af5ecb42351a0b5459bdd0f32c00ec55c23050b5f46dfaed8e321974b
+
+do_check() {
+ : # `make check` fails: there is no check/test target.
+}
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (25 preceding siblings ...)
2022-07-25 15:52 ` [PR PATCH] [Updated] " agausmann
@ 2022-07-25 16:57 ` paper42
2022-07-25 17:52 ` [PR PATCH] [Updated] " agausmann
` (7 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: paper42 @ 2022-07-25 16:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 248 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r929103711
Comment:
I see, it's not ignored when you set make_cmd. Could you use `make_check=no # <description>` instead?
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR PATCH] [Updated] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (26 preceding siblings ...)
2022-07-25 16:57 ` [PR REVIEW] " paper42
@ 2022-07-25 17:52 ` agausmann
2022-07-25 17:55 ` [PR REVIEW] " agausmann
` (6 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-25 17:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]
There is an updated pull request by agausmann against master on the void-packages repository
https://github.com/agausmann/void-packages libopensmtpd
https://github.com/void-linux/void-packages/pull/38253
New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Integration test with and a fully configured OpenSMTPD server: Passed DKIM test provided by https://appmaildev.com/en/dkim
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
- The software needs to be compiled
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
A patch file from https://github.com/void-linux/void-packages/pull/38253.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libopensmtpd-38253.patch --]
[-- Type: text/x-diff, Size: 3521 bytes --]
From 38c9acdba990d56606a24776074deb0ad1af5a05 Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 14:45:34 -0500
Subject: [PATCH 1/2] New package: libopensmtpd-0.7
---
common/shlibs | 1 +
srcpkgs/libopensmtpd-devel | 1 +
srcpkgs/libopensmtpd/template | 31 +++++++++++++++++++++++++++++++
3 files changed, 33 insertions(+)
create mode 120000 srcpkgs/libopensmtpd-devel
create mode 100644 srcpkgs/libopensmtpd/template
diff --git a/common/shlibs b/common/shlibs
index c3dd63f542db..8df21eef97a3 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4175,3 +4175,4 @@ libjaylink.so.0 libjaylink-0.2.0_1
libnvidia-container.so.1 libnvidia-container-1.10.0_1
libnvidia-container-go.so.1 libnvidia-container-1.10.0_1
libqtspell-qt5.so.1 qtspell-1.0.1_1
+libopensmtpd.so.0 libopensmtpd-0.7_1
diff --git a/srcpkgs/libopensmtpd-devel b/srcpkgs/libopensmtpd-devel
new file mode 120000
index 000000000000..c2cb53a79f1b
--- /dev/null
+++ b/srcpkgs/libopensmtpd-devel
@@ -0,0 +1 @@
+libopensmtpd
\ No newline at end of file
diff --git a/srcpkgs/libopensmtpd/template b/srcpkgs/libopensmtpd/template
new file mode 100644
index 000000000000..2ae8404c2654
--- /dev/null
+++ b/srcpkgs/libopensmtpd/template
@@ -0,0 +1,31 @@
+# Template file for 'libopensmtpd'
+pkgname=libopensmtpd
+version=0.7
+revision=1
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libevent-devel"
+short_desc="Library for creating opensmtpd filters"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="http://imperialat.at/dev/libopensmtpd/"
+distfiles="https://distfiles.sigtrap.nl/${pkgname}-${version}.tar.gz"
+checksum=cdd6d5e11a7063f9265da43a42309c646554b8b68b03982ca8472dbe2b08a613
+make_check=no # Does not have a test suite
+
+post_install() {
+ vlicense LICENSE
+}
+
+libopensmtpd-devel_package() {
+ short_desc+=" - development files"
+ depends="${sourcepkg}>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/include
+ vmove "usr/lib/*.so"
+ vmove usr/share/man/man3
+ }
+}
From 99e7bba0185eb5c88ee86f9cb620a8abf8904292 Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 15:23:11 -0500
Subject: [PATCH 2/2] New package: opensmtpd-filter-dkimsign-0.5
---
srcpkgs/opensmtpd-filter-dkimsign/template | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 srcpkgs/opensmtpd-filter-dkimsign/template
diff --git a/srcpkgs/opensmtpd-filter-dkimsign/template b/srcpkgs/opensmtpd-filter-dkimsign/template
new file mode 100644
index 000000000000..fc31d7d5466e
--- /dev/null
+++ b/srcpkgs/opensmtpd-filter-dkimsign/template
@@ -0,0 +1,22 @@
+# Template file for 'opensmtpd-filter-dkimsign'
+pkgname=opensmtpd-filter-dkimsign
+version=0.5
+revision=1
+wrksrc="filter-dkimsign-${version}"
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libopensmtpd-devel openssl-devel"
+short_desc="Filter for signing mail with DKIM"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="https://imperialat.at/dev/filter-dkimsign/"
+distfiles="https://distfiles.sigtrap.nl/filter-dkimsign-${version}.tar.gz"
+checksum=a5b4ec3af5ecb42351a0b5459bdd0f32c00ec55c23050b5f46dfaed8e321974b
+make_check=no # Does not have a test suite
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (27 preceding siblings ...)
2022-07-25 17:52 ` [PR PATCH] [Updated] " agausmann
@ 2022-07-25 17:55 ` agausmann
2022-07-25 17:55 ` agausmann
` (5 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-25 17:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 159 bytes --]
New review comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r929152021
Comment:
Thank you!
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR REVIEW] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (28 preceding siblings ...)
2022-07-25 17:55 ` [PR REVIEW] " agausmann
@ 2022-07-25 17:55 ` agausmann
2022-07-25 18:29 ` agausmann
` (4 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-25 17:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
New review comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#discussion_r929152021
Comment:
That works, thanks!
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (29 preceding siblings ...)
2022-07-25 17:55 ` agausmann
@ 2022-07-25 18:29 ` agausmann
2022-07-25 20:13 ` Duncaen
` (3 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-25 18:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
New comment by agausmann on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#issuecomment-1194454326
Comment:
Getting `#include` errors on cross-compiled targets, e.g.
```
In file included from /usr//include/features.h:489,
from /usr//include/inttypes.h:25,
from /usr/aarch64-linux-gnu/usr/include/openssl/e_os2.h:243,
from /usr/aarch64-linux-gnu/usr/include/openssl/err.h:13,
from main.c:16:
/usr//include/gnu/stubs.h:7:11: fatal error: gnu/stubs-32.h: No such file or directory
7 | # include <gnu/stubs-32.h>
| ^~~~~~~~~~~~~~~~
```
Shouldn't the `<inttypes.h>` be provided by the cross-libc?
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (30 preceding siblings ...)
2022-07-25 18:29 ` agausmann
@ 2022-07-25 20:13 ` Duncaen
2022-07-25 20:35 ` [PR PATCH] [Updated] " agausmann
` (2 subsequent siblings)
34 siblings, 0 replies; 36+ messages in thread
From: Duncaen @ 2022-07-25 20:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/38253#issuecomment-1194571684
Comment:
You probably need to patch out `CFLAGS+= -I${LOCALBASE}/include` from `Makefile.gnu`.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR PATCH] [Updated] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (31 preceding siblings ...)
2022-07-25 20:13 ` Duncaen
@ 2022-07-25 20:35 ` agausmann
2022-07-25 20:42 ` agausmann
2022-07-26 16:44 ` [PR PATCH] [Merged]: " Duncaen
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-25 20:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]
There is an updated pull request by agausmann against master on the void-packages repository
https://github.com/agausmann/void-packages libopensmtpd
https://github.com/void-linux/void-packages/pull/38253
New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Integration test with and a fully configured OpenSMTPD server: Passed DKIM test provided by https://appmaildev.com/en/dkim
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
- The software needs to be compiled
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
A patch file from https://github.com/void-linux/void-packages/pull/38253.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libopensmtpd-38253.patch --]
[-- Type: text/x-diff, Size: 4979 bytes --]
From 38c9acdba990d56606a24776074deb0ad1af5a05 Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 14:45:34 -0500
Subject: [PATCH 1/2] New package: libopensmtpd-0.7
---
common/shlibs | 1 +
srcpkgs/libopensmtpd-devel | 1 +
srcpkgs/libopensmtpd/template | 31 +++++++++++++++++++++++++++++++
3 files changed, 33 insertions(+)
create mode 120000 srcpkgs/libopensmtpd-devel
create mode 100644 srcpkgs/libopensmtpd/template
diff --git a/common/shlibs b/common/shlibs
index c3dd63f542db..8df21eef97a3 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4175,3 +4175,4 @@ libjaylink.so.0 libjaylink-0.2.0_1
libnvidia-container.so.1 libnvidia-container-1.10.0_1
libnvidia-container-go.so.1 libnvidia-container-1.10.0_1
libqtspell-qt5.so.1 qtspell-1.0.1_1
+libopensmtpd.so.0 libopensmtpd-0.7_1
diff --git a/srcpkgs/libopensmtpd-devel b/srcpkgs/libopensmtpd-devel
new file mode 120000
index 000000000000..c2cb53a79f1b
--- /dev/null
+++ b/srcpkgs/libopensmtpd-devel
@@ -0,0 +1 @@
+libopensmtpd
\ No newline at end of file
diff --git a/srcpkgs/libopensmtpd/template b/srcpkgs/libopensmtpd/template
new file mode 100644
index 000000000000..2ae8404c2654
--- /dev/null
+++ b/srcpkgs/libopensmtpd/template
@@ -0,0 +1,31 @@
+# Template file for 'libopensmtpd'
+pkgname=libopensmtpd
+version=0.7
+revision=1
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libevent-devel"
+short_desc="Library for creating opensmtpd filters"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="http://imperialat.at/dev/libopensmtpd/"
+distfiles="https://distfiles.sigtrap.nl/${pkgname}-${version}.tar.gz"
+checksum=cdd6d5e11a7063f9265da43a42309c646554b8b68b03982ca8472dbe2b08a613
+make_check=no # Does not have a test suite
+
+post_install() {
+ vlicense LICENSE
+}
+
+libopensmtpd-devel_package() {
+ short_desc+=" - development files"
+ depends="${sourcepkg}>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/include
+ vmove "usr/lib/*.so"
+ vmove usr/share/man/man3
+ }
+}
From 600822198eaeaac58d8d5aa3a6e8caca604d14b9 Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 15:23:11 -0500
Subject: [PATCH 2/2] New package: opensmtpd-filter-dkimsign-0.5
---
.../patches/cleanup-search-paths.patch | 27 +++++++++++++++++++
srcpkgs/opensmtpd-filter-dkimsign/template | 22 +++++++++++++++
2 files changed, 49 insertions(+)
create mode 100644 srcpkgs/opensmtpd-filter-dkimsign/patches/cleanup-search-paths.patch
create mode 100644 srcpkgs/opensmtpd-filter-dkimsign/template
diff --git a/srcpkgs/opensmtpd-filter-dkimsign/patches/cleanup-search-paths.patch b/srcpkgs/opensmtpd-filter-dkimsign/patches/cleanup-search-paths.patch
new file mode 100644
index 000000000000..05bcfe39ab69
--- /dev/null
+++ b/srcpkgs/opensmtpd-filter-dkimsign/patches/cleanup-search-paths.patch
@@ -0,0 +1,27 @@
+The LOCALBASE variable is used as a prefix for parts of both build and install.
+This causes issues with cross-compiling, where the prefix for development files
+and for installation are different (e.g. /usr/aarch64-linux-gnu versus /usr).
+
+This patch removes references to LOCALBASE in the include and link search paths
+to fix include errors caused by having `-I/usr/include` in a cross-compile.
+
+--- a/Makefile.gnu 2022-07-25 15:21:33.867612285 -0500
++++ b/Makefile.gnu 2022-07-25 15:22:53.977612960 -0500
+@@ -23,7 +23,7 @@
+ CRYPT_LDADD= -lcrypto
+ endif
+
+-CFLAGS+= -I${LOCALBASE}/include
++#CFLAGS+= -I${LOCALBASE}/include
+ CFLAGS+= -Wall -I${.CURDIR}
+ CFLAGS+= -Wstrict-prototypes -Wmissing-prototypes
+ CFLAGS+= -Wmissing-declarations
+@@ -32,7 +32,7 @@
+ CFLAGS+= ${CRYPT_CFLAGS}
+ CFLAGS+= -I${CURDIR} -I${CURDIR}/openbsd-compat/
+
+-LDFLAGS+= -L${LOCALBASE}/lib
++#LDFLAGS+= -L${LOCALBASE}/lib
+ LDFLAGS+= ${CRYPT_LDFLAGS}
+ LDADD+= ${CRYPT_LDADD} -lopensmtpd
+
diff --git a/srcpkgs/opensmtpd-filter-dkimsign/template b/srcpkgs/opensmtpd-filter-dkimsign/template
new file mode 100644
index 000000000000..fc31d7d5466e
--- /dev/null
+++ b/srcpkgs/opensmtpd-filter-dkimsign/template
@@ -0,0 +1,22 @@
+# Template file for 'opensmtpd-filter-dkimsign'
+pkgname=opensmtpd-filter-dkimsign
+version=0.5
+revision=1
+wrksrc="filter-dkimsign-${version}"
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libopensmtpd-devel openssl-devel"
+short_desc="Filter for signing mail with DKIM"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="https://imperialat.at/dev/filter-dkimsign/"
+distfiles="https://distfiles.sigtrap.nl/filter-dkimsign-${version}.tar.gz"
+checksum=a5b4ec3af5ecb42351a0b5459bdd0f32c00ec55c23050b5f46dfaed8e321974b
+make_check=no # Does not have a test suite
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR PATCH] [Updated] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (32 preceding siblings ...)
2022-07-25 20:35 ` [PR PATCH] [Updated] " agausmann
@ 2022-07-25 20:42 ` agausmann
2022-07-26 16:44 ` [PR PATCH] [Merged]: " Duncaen
34 siblings, 0 replies; 36+ messages in thread
From: agausmann @ 2022-07-25 20:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]
There is an updated pull request by agausmann against master on the void-packages repository
https://github.com/agausmann/void-packages libopensmtpd
https://github.com/void-linux/void-packages/pull/38253
New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Integration test with and a fully configured OpenSMTPD server: Passed DKIM test provided by https://appmaildev.com/en/dkim
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
- The software needs to be compiled
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
A patch file from https://github.com/void-linux/void-packages/pull/38253.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libopensmtpd-38253.patch --]
[-- Type: text/x-diff, Size: 4913 bytes --]
From 38c9acdba990d56606a24776074deb0ad1af5a05 Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 14:45:34 -0500
Subject: [PATCH 1/2] New package: libopensmtpd-0.7
---
common/shlibs | 1 +
srcpkgs/libopensmtpd-devel | 1 +
srcpkgs/libopensmtpd/template | 31 +++++++++++++++++++++++++++++++
3 files changed, 33 insertions(+)
create mode 120000 srcpkgs/libopensmtpd-devel
create mode 100644 srcpkgs/libopensmtpd/template
diff --git a/common/shlibs b/common/shlibs
index c3dd63f542db..8df21eef97a3 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4175,3 +4175,4 @@ libjaylink.so.0 libjaylink-0.2.0_1
libnvidia-container.so.1 libnvidia-container-1.10.0_1
libnvidia-container-go.so.1 libnvidia-container-1.10.0_1
libqtspell-qt5.so.1 qtspell-1.0.1_1
+libopensmtpd.so.0 libopensmtpd-0.7_1
diff --git a/srcpkgs/libopensmtpd-devel b/srcpkgs/libopensmtpd-devel
new file mode 120000
index 000000000000..c2cb53a79f1b
--- /dev/null
+++ b/srcpkgs/libopensmtpd-devel
@@ -0,0 +1 @@
+libopensmtpd
\ No newline at end of file
diff --git a/srcpkgs/libopensmtpd/template b/srcpkgs/libopensmtpd/template
new file mode 100644
index 000000000000..2ae8404c2654
--- /dev/null
+++ b/srcpkgs/libopensmtpd/template
@@ -0,0 +1,31 @@
+# Template file for 'libopensmtpd'
+pkgname=libopensmtpd
+version=0.7
+revision=1
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libevent-devel"
+short_desc="Library for creating opensmtpd filters"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="http://imperialat.at/dev/libopensmtpd/"
+distfiles="https://distfiles.sigtrap.nl/${pkgname}-${version}.tar.gz"
+checksum=cdd6d5e11a7063f9265da43a42309c646554b8b68b03982ca8472dbe2b08a613
+make_check=no # Does not have a test suite
+
+post_install() {
+ vlicense LICENSE
+}
+
+libopensmtpd-devel_package() {
+ short_desc+=" - development files"
+ depends="${sourcepkg}>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/include
+ vmove "usr/lib/*.so"
+ vmove usr/share/man/man3
+ }
+}
From cc771bd9ea333789720623ea135360600b1c70d1 Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Sun, 24 Jul 2022 15:23:11 -0500
Subject: [PATCH 2/2] New package: opensmtpd-filter-dkimsign-0.5
---
.../patches/cleanup-search-paths.patch | 25 +++++++++++++++++++
srcpkgs/opensmtpd-filter-dkimsign/template | 22 ++++++++++++++++
2 files changed, 47 insertions(+)
create mode 100644 srcpkgs/opensmtpd-filter-dkimsign/patches/cleanup-search-paths.patch
create mode 100644 srcpkgs/opensmtpd-filter-dkimsign/template
diff --git a/srcpkgs/opensmtpd-filter-dkimsign/patches/cleanup-search-paths.patch b/srcpkgs/opensmtpd-filter-dkimsign/patches/cleanup-search-paths.patch
new file mode 100644
index 000000000000..a2487293d488
--- /dev/null
+++ b/srcpkgs/opensmtpd-filter-dkimsign/patches/cleanup-search-paths.patch
@@ -0,0 +1,25 @@
+The LOCALBASE variable is used as a prefix for parts of both build and install.
+This causes issues with cross-compiling, where the prefix for development files
+and for installation are different (e.g. /usr/aarch64-linux-gnu versus /usr).
+
+This patch removes references to LOCALBASE in the include and link search paths
+to fix include errors caused by having `-I/usr/include` in a cross-compile.
+
+--- a/Makefile.gnu 2022-07-25 15:21:33.867612285 -0500
++++ b/Makefile.gnu 2022-07-25 15:41:18.197622258 -0500
+@@ -23,7 +23,6 @@
+ CRYPT_LDADD= -lcrypto
+ endif
+
+-CFLAGS+= -I${LOCALBASE}/include
+ CFLAGS+= -Wall -I${.CURDIR}
+ CFLAGS+= -Wstrict-prototypes -Wmissing-prototypes
+ CFLAGS+= -Wmissing-declarations
+@@ -32,7 +31,6 @@
+ CFLAGS+= ${CRYPT_CFLAGS}
+ CFLAGS+= -I${CURDIR} -I${CURDIR}/openbsd-compat/
+
+-LDFLAGS+= -L${LOCALBASE}/lib
+ LDFLAGS+= ${CRYPT_LDFLAGS}
+ LDADD+= ${CRYPT_LDADD} -lopensmtpd
+
diff --git a/srcpkgs/opensmtpd-filter-dkimsign/template b/srcpkgs/opensmtpd-filter-dkimsign/template
new file mode 100644
index 000000000000..fc31d7d5466e
--- /dev/null
+++ b/srcpkgs/opensmtpd-filter-dkimsign/template
@@ -0,0 +1,22 @@
+# Template file for 'opensmtpd-filter-dkimsign'
+pkgname=opensmtpd-filter-dkimsign
+version=0.5
+revision=1
+wrksrc="filter-dkimsign-${version}"
+build_style=gnu-makefile
+make_cmd="make -f Makefile.gnu"
+make_use_env=yes
+make_build_args="MANFORMAT="
+make_install_args="MANFORMAT="
+makedepends="libopensmtpd-devel openssl-devel"
+short_desc="Filter for signing mail with DKIM"
+maintainer="Adam Gausmann <agausmann@fastmail.com>"
+license="ISC"
+homepage="https://imperialat.at/dev/filter-dkimsign/"
+distfiles="https://distfiles.sigtrap.nl/filter-dkimsign-${version}.tar.gz"
+checksum=a5b4ec3af5ecb42351a0b5459bdd0f32c00ec55c23050b5f46dfaed8e321974b
+make_check=no # Does not have a test suite
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PR PATCH] [Merged]: New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
` (33 preceding siblings ...)
2022-07-25 20:42 ` agausmann
@ 2022-07-26 16:44 ` Duncaen
34 siblings, 0 replies; 36+ messages in thread
From: Duncaen @ 2022-07-26 16:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
There's a merged pull request on the void-packages repository
New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5
https://github.com/void-linux/void-packages/pull/38253
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Integration test with and a fully configured OpenSMTPD server: Passed DKIM test provided by https://appmaildev.com/en/dkim
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
- The software needs to be compiled
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
^ permalink raw reply [flat|nested] 36+ messages in thread
end of thread, other threads:[~2022-07-26 16:44 UTC | newest]
Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-24 20:54 [PR PATCH] New package: libopensmtpd-0.7 agausmann
2022-07-24 22:08 ` [PR PATCH] [Updated] " agausmann
2022-07-24 22:25 ` [PR REVIEW] " Duncaen
2022-07-24 22:25 ` Duncaen
2022-07-24 22:26 ` Duncaen
2022-07-24 22:27 ` Duncaen
2022-07-24 22:39 ` agausmann
2022-07-24 22:40 ` agausmann
2022-07-24 22:42 ` agausmann
2022-07-24 22:47 ` agausmann
2022-07-24 22:48 ` agausmann
2022-07-24 22:58 ` agausmann
2022-07-24 22:59 ` agausmann
2022-07-24 23:05 ` Duncaen
2022-07-24 23:08 ` Duncaen
2022-07-24 23:12 ` agausmann
2022-07-24 23:13 ` Duncaen
2022-07-24 23:13 ` Duncaen
2022-07-24 23:38 ` [PR PATCH] [Updated] " agausmann
2022-07-24 23:57 ` [PR PATCH] [Updated] New packages: libopensmtpd-0.7 opensmtpd-filter-dkimsign-0.5 agausmann
2022-07-25 9:47 ` [PR REVIEW] " Duncaen
2022-07-25 9:47 ` Duncaen
2022-07-25 10:01 ` paper42
2022-07-25 15:19 ` agausmann
2022-07-25 15:32 ` [PR PATCH] [Updated] " agausmann
2022-07-25 15:41 ` [PR REVIEW] " agausmann
2022-07-25 15:52 ` [PR PATCH] [Updated] " agausmann
2022-07-25 16:57 ` [PR REVIEW] " paper42
2022-07-25 17:52 ` [PR PATCH] [Updated] " agausmann
2022-07-25 17:55 ` [PR REVIEW] " agausmann
2022-07-25 17:55 ` agausmann
2022-07-25 18:29 ` agausmann
2022-07-25 20:13 ` Duncaen
2022-07-25 20:35 ` [PR PATCH] [Updated] " agausmann
2022-07-25 20:42 ` agausmann
2022-07-26 16:44 ` [PR PATCH] [Merged]: " Duncaen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).