[PR PATCH] Remove buildbot, buildbot-slave, and their orphaned dependencies

[PR PATCH] Remove buildbot, buildbot-slave, and their orphaned dependencies

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages py2purge
https://github.com/void-linux/void-packages/pull/38266

Remove buildbot, buildbot-slave, and their orphaned dependencies
The `buildbot` package hasn't been updated since almost six years. I don't think this is worth updating as it's safe to assume no one is actively using it from the void repo at `v0.8.14` while upstream is at `v3.5.0`.

In reference to https://github.com/void-linux/void-packages/issues/38229 this also removes three of the subsequently orphaned packages: `python-Jinja2`, `python-Twisted`, and `Twisted`. Ideally we would remove `python-dateutil` and `python-sqlalchemy-migrate` but those provides their python3 counterparts as subpackages.

A patch file from https://github.com/void-linux/void-packages/pull/38266.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-py2purge-38266.patch --]
[-- Type: text/x-diff, Size: 8832 bytes --]

From 572d74be0e735e2f90a81e4a08db4e23591a2da5 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Mon, 25 Jul 2022 14:09:53 +0530
Subject: [PATCH 1/5] buildbot-slave: remove package

---
 srcpkgs/buildbot-slave/template   | 13 -------------
 srcpkgs/removed-packages/template |  1 +
 2 files changed, 1 insertion(+), 13 deletions(-)
 delete mode 100644 srcpkgs/buildbot-slave/template

diff --git a/srcpkgs/buildbot-slave/template b/srcpkgs/buildbot-slave/template
deleted file mode 100644
index 8b6c19bd9e3b..000000000000
--- a/srcpkgs/buildbot-slave/template
+++ /dev/null
@@ -1,13 +0,0 @@
-# Template file for 'buildbot-slave'
-pkgname=buildbot-slave
-version=0.8.14
-revision=3
-build_style=python2-module
-hostmakedepends="python"
-depends="python-Twisted"
-short_desc="BuildBot Slave Daemon"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2.0-only"
-homepage="https://buildbot.net/"
-distfiles="${PYPI_SITE}/b/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=7db02738c02d34c4d32508ac200e5f089ba73549315b127a9d8c0808d1a6d7a9
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 8456cb959d35..b9143c107401 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -27,6 +27,7 @@ replaces="
  avogadro<=1.2.0_8
  bokken<=1.8_3
  bomi<=0.9.11_17
+ buildbot-slave<=0.8.14_3
  burp-client<=1.4.40_13
  burp-server<=1.4.40_13
  bzr<=2.7.0_1

From e68391199535ce0731226cfae4e08dfdd03104b0 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Mon, 25 Jul 2022 14:12:23 +0530
Subject: [PATCH 2/5] buildbot: remove package

---
 srcpkgs/buildbot/template         | 26 --------------------------
 srcpkgs/removed-packages/template |  1 +
 2 files changed, 1 insertion(+), 26 deletions(-)
 delete mode 100644 srcpkgs/buildbot/template

diff --git a/srcpkgs/buildbot/template b/srcpkgs/buildbot/template
deleted file mode 100644
index ae905fc67ab8..000000000000
--- a/srcpkgs/buildbot/template
+++ /dev/null
@@ -1,26 +0,0 @@
-# Template file for 'buildbot'
-pkgname=buildbot
-reverts="2.4.1_1"
-version=0.8.14
-revision=5
-build_style=python2-module
-pycompile_dirs="usr/share/buildbot/contrib"
-hostmakedepends="python"
-depends="python-setuptools python-dateutil python-Jinja2 python-sqlalchemy-migrate python-Twisted"
-short_desc="System to automate the compile/test cycle"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2.0-only"
-homepage="https://buildbot.net/"
-distfiles="${PYPI_SITE}/b/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=331efd07bd7522c222a8fb258801e8d78332c88d778ee76416b9e1028676e964
-
-pre_install() {
-	sed -i 's,#!/usr/bin/env jython,#!/usr/bin/python2,' contrib/run_maxq.py
-}
-post_install() {
-	# Install all contrib modules.
-	local contribdir=${DESTDIR}/usr/share/buildbot/contrib
-
-	vmkdir usr/share/buildbot/contrib
-	install -m755 ${wrksrc}/contrib/*.py ${contribdir}
-}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index b9143c107401..9c1f94a92108 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -28,6 +28,7 @@ replaces="
  bokken<=1.8_3
  bomi<=0.9.11_17
  buildbot-slave<=0.8.14_3
+ buildbot<=0.8.14_5
  burp-client<=1.4.40_13
  burp-server<=1.4.40_13
  bzr<=2.7.0_1

From d4ac452a947217feee0a66cc48f8cdd46f54e558 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Mon, 25 Jul 2022 14:14:29 +0530
Subject: [PATCH 3/5] python-Jinja2: remove package

---
 srcpkgs/python-Jinja2/template    | 27 ---------------------------
 srcpkgs/removed-packages/template |  1 +
 2 files changed, 1 insertion(+), 27 deletions(-)
 delete mode 100644 srcpkgs/python-Jinja2/template

diff --git a/srcpkgs/python-Jinja2/template b/srcpkgs/python-Jinja2/template
deleted file mode 100644
index 3e8ab4268b5d..000000000000
--- a/srcpkgs/python-Jinja2/template
+++ /dev/null
@@ -1,27 +0,0 @@
-# Template file for 'python-Jinja2'
-pkgname=python-Jinja2
-version=2.11.3
-revision=2
-wrksrc="Jinja2-${version}"
-build_style=python2-module
-hostmakedepends="python-setuptools"
-depends="python-MarkupSafe"
-checkdepends="python-pytest $depends"
-short_desc="Full featured template engine (Python2)"
-maintainer="Alessio Sergi <al3hex@gmail.com>"
-license="BSD-3-Clause"
-homepage="http://jinja.pocoo.org/"
-changelog="https://raw.githubusercontent.com/pallets/jinja/master/CHANGES.rst"
-distfiles="${PYPI_SITE}/J/Jinja2/Jinja2-${version}.tar.gz"
-checksum=a6d58433de0ae800347cab1fa3043cebbabe8baa9d29e668f1c768cb87a333c6
-
-do_check() {
-	PYTHONPATH=src python2 -m pytest
-}
-
-post_install() {
-	vlicense LICENSE.rst
-	# these files are valid only on Python 3.6+
-	rm -f ${DESTDIR}/${py2_sitelib}/jinja2/asyncsupport.py
-	rm -f ${DESTDIR}/${py2_sitelib}/jinja2/asyncfilters.py
-}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 9c1f94a92108..69d7df8d32b5 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -288,6 +288,7 @@ replaces="
  pyside-tools<=0.2.15_2
  pystopwatch<=2019_2
  python-Babel<=2.8.0_4
+ python-Jinja2<=2.11.3_2
  python-M2Crypto<=0.35.2_7
  python-Pillow<=6.2.2_3
  python-Pygments<=2.5.2_4

From e629d61ae8d3cf74e0b081532817a1a9c43be7e5 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Mon, 25 Jul 2022 14:15:59 +0530
Subject: [PATCH 4/5] Twisted: remove package

---
 srcpkgs/Twisted/template          | 10 ----------
 srcpkgs/removed-packages/template |  1 +
 2 files changed, 1 insertion(+), 10 deletions(-)
 delete mode 100644 srcpkgs/Twisted/template

diff --git a/srcpkgs/Twisted/template b/srcpkgs/Twisted/template
deleted file mode 100644
index c172f7c26be7..000000000000
--- a/srcpkgs/Twisted/template
+++ /dev/null
@@ -1,10 +0,0 @@
-# Template file for 'Twisted'
-pkgname=Twisted
-version=17.9.0
-revision=2
-build_style=meta
-depends="python-Twisted>=${version}_${revision}"
-short_desc="Event-driven networking engine written in Python (transitional dummy package)"
-maintainer="Orphaned <orphan@voidlinux.org>"
-homepage="https://twistedmatrix.com/"
-license="MIT"
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 69d7df8d32b5..bda52344fc97 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -13,6 +13,7 @@ replaces="
  MoinMoin<=1.9.11_1
  MultiMC<=0.6.13_1
  Platinum9-theme<=0.0.0.20170720_3
+ Twisted<=17.9.0_2
  Venom<=0.5.5_1
  XorCurses<=0.2.2_1
  acme-client<=0.1.16_5

From dd6b23e2daff0ea7c2e2864dccd77559636e0c80 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Mon, 25 Jul 2022 14:17:20 +0530
Subject: [PATCH 5/5] python-Twisted: remove package

---
 srcpkgs/python-Twisted/template   | 38 -------------------------------
 srcpkgs/removed-packages/template |  1 +
 2 files changed, 1 insertion(+), 38 deletions(-)
 delete mode 100644 srcpkgs/python-Twisted/template

diff --git a/srcpkgs/python-Twisted/template b/srcpkgs/python-Twisted/template
deleted file mode 100644
index 173600b79f34..000000000000
--- a/srcpkgs/python-Twisted/template
+++ /dev/null
@@ -1,38 +0,0 @@
-# Template file for 'python-Twisted'
-pkgname=python-Twisted
-version=20.3.0
-revision=4
-wrksrc="Twisted-${version}"
-build_style=python2-module
-hostmakedepends="python-setuptools python-incremental"
-makedepends="python-devel"
-depends="python-setuptools python-zope.interface python-openssl
- python-service_identity python-constantly python-incremental python-automat
- python-hyperlink python-PyHamcrest"
-short_desc="Asynchronous networking framework written in Python (Python2)"
-maintainer="Alessio Sergi <al3hex@gmail.com>"
-license="MIT"
-homepage="https://twistedmatrix.com/"
-changelog="https://raw.githubusercontent.com/twisted/twisted/trunk/NEWS.rst"
-distfiles="${PYPI_SITE}/T/Twisted/Twisted-${version}.tar.bz2"
-checksum=d72c55b5d56e176563b91d11952d13b01af8725c623e498db5507b6614fc1e10
-
-alternatives="
- twisted:cftp:/usr/bin/cftp2
- twisted:ckeygen:/usr/bin/ckeygen2
- twisted:conch:/usr/bin/conch2
- twisted:mailmail:/usr/bin/mailmail2
- twisted:pyhtmlizer:/usr/bin/pyhtmlizer2
- twisted:tkconch:/usr/bin/tkconch2
- twisted:trial:/usr/bin/trial2
- twisted:twist:/usr/bin/twist2
- twisted:twistd:/usr/bin/twistd2"
-
-post_install() {
-	# don't conflict with python3-Twisted
-	for f in "${DESTDIR}"/usr/bin/*; do
-		mv "${f}"{,2}
-	done
-
-	vlicense LICENSE
-}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index bda52344fc97..b179f61cae72 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -295,6 +295,7 @@ replaces="
  python-Pygments<=2.5.2_4
  python-PyQt4<=4.12.1_4
  python-SecretStorage<=2.3.1_4
+ python-Twisted<=20.3.0_4
  python-audit<=2.8.5_2
  python-chardet<=4.0.0_3
  python-configobj<=5.0.6_9

Re: Remove buildbot, buildbot-slave, and their orphaned dependencies

[paper42]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38266#issuecomment-1193780734

Comment:
this buildbot package is used on our builders, we can't remove it until we have a better solution

Re: [PR PATCH] [Closed]: Remove buildbot, buildbot-slave, and their orphaned dependencies

[paper42]

[-- Attachment #1: Type: text/plain, Size: 740 bytes --]

There's a closed pull request on the void-packages repository

Remove buildbot, buildbot-slave, and their orphaned dependencies
https://github.com/void-linux/void-packages/pull/38266

Description:
The `buildbot` package hasn't been updated since almost six years. I don't think this is worth updating as it's safe to assume no one is actively using it from the void repo at `v0.8.14` while upstream is at `v3.5.0`.

In reference to https://github.com/void-linux/void-packages/issues/38229 this also removes three of the subsequently orphaned packages: `python-Jinja2`, `python-Twisted`, and `Twisted`. Ideally we would remove `python-dateutil` and `python-sqlalchemy-migrate` but those provides their python3 counterparts as subpackages.

Re: Remove buildbot, buildbot-slave, and their orphaned dependencies

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38266#issuecomment-1194117495

Comment:
> Ideally we would remove python-dateutil and python-sqlalchemy-migrate but those provides their python3 counterparts as subpackages.

when it comes time to remove those, they can be converted to a purely-python3 template.

There's also more orphaned dependencies in that dependency tree, especially the twisted part.