[PR PATCH] efitools: Include manpages in the package

[PR PATCH] efitools: Include manpages in the package

[meator]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

There is a new pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages efitools
https://github.com/void-linux/void-packages/pull/38282

efitools: Include manpages in the package
Manpages are nice to have.

#### Testing the changes
- I tested the changes in this PR: **YES**

Ping @sgn (maintainer of the package)

A patch file from https://github.com/void-linux/void-packages/pull/38282.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-efitools-38282.patch --]
[-- Type: text/x-diff, Size: 2320 bytes --]

From 0ff68767d8257cded270cc0fa1f1dbd6898af66b Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Tue, 26 Jul 2022 14:32:16 +0200
Subject: [PATCH] efitools: Include manpages in the package

---
 ...05-makefile-remove-useless-problematic-target.patch | 10 ++++------
 srcpkgs/efitools/template                              |  4 ++--
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/efitools/patches/05-makefile-remove-useless-problematic-target.patch b/srcpkgs/efitools/patches/05-makefile-remove-useless-problematic-target.patch
index a960654dd9f2..4c473d539c0a 100644
--- a/srcpkgs/efitools/patches/05-makefile-remove-useless-problematic-target.patch
+++ b/srcpkgs/efitools/patches/05-makefile-remove-useless-problematic-target.patch
@@ -8,20 +8,18 @@ index 7d471da..30e236b 100644
  	KeyTool.efi HashTool.efi SetNull.efi ShimReplace.efi
  BINARIES = cert-to-efi-sig-list sig-list-to-certs sign-efi-sig-list \
  	hash-to-efi-sig-list efi-readvar efi-updatevar cert-to-efi-hash-list \
-@@ -27,20 +27,14 @@ include Make.rules
+@@ -27,9 +27,7 @@ include Make.rules
  
  EFISIGNED = $(patsubst %.efi,%-signed.efi,$(EFIFILES))
  
 -all: $(EFISIGNED) $(BINARIES) $(MANPAGES) noPK.auth $(KEYAUTH) \
 -	$(KEYUPDATEAUTH) $(KEYBLACKLISTAUTH) $(KEYHASHBLACKLISTAUTH)
 -
-+all: $(EFIFILES) $(BINARIES)
++all: $(EFIFILES) $(BINARIES) $(MANPAGES)
  
  install: all
--	$(INSTALL) -m 755 -d $(MANDIR)
--	$(INSTALL) -m 644 $(MANPAGES) $(MANDIR)
- 	$(INSTALL) -m 755 -d $(EFIDIR)
- 	$(INSTALL) -m 755 $(EFIFILES) $(EFIDIR)
+ 	$(INSTALL) -m 755 -d $(MANDIR)
+@@ -39,8 +37,6 @@ install: all
  	$(INSTALL) -m 755 -d $(BINDIR)
  	$(INSTALL) -m 755 $(BINARIES) $(BINDIR)
  	$(INSTALL) -m 755 mkusb.sh $(BINDIR)/efitool-mkusb
diff --git a/srcpkgs/efitools/template b/srcpkgs/efitools/template
index 5d26a4208de0..61069d7e095e 100644
--- a/srcpkgs/efitools/template
+++ b/srcpkgs/efitools/template
@@ -1,10 +1,10 @@
 # Template file for 'efitools'
 pkgname=efitools
 version=1.9.2
-revision=5
+revision=6
 archs="x86_64* i686* arm* aarch64*"
 build_style=gnu-makefile
-hostmakedepends="perl-File-Slurp"
+hostmakedepends="perl-File-Slurp help2man"
 makedepends="gnu-efi-libs openssl-devel"
 short_desc="Tools to manipulate EFI secure boot platforms"
 maintainer="Doan Tran Cong Danh <congdanhqx@gmail.com>"

Re: efitools: Include manpages in the package

[sgn]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38282#issuecomment-1195435265

Comment:
man-pages generated with `help2man` is useless, and can't be cross-generated..

Re: [PR PATCH] [Closed]: efitools: Include manpages in the package

[sgn]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

There's a closed pull request on the void-packages repository

efitools: Include manpages in the package
https://github.com/void-linux/void-packages/pull/38282

Description:
Manpages are nice to have.

#### Testing the changes
- I tested the changes in this PR: **YES**

Ping @sgn (maintainer of the package)

Re: efitools: Include manpages in the package

[sgn]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38282#issuecomment-1195435740

Comment:
Feel free to re-open if you can cross-compile.