Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] CONTRIBUTING.md: add instructions for testing PRs
@ 2022-08-03  4:10 classabbyamp
  2022-08-03  9:36 ` tranzystorek-io
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: classabbyamp @ 2022-08-03  4:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages contrib-testing
https://github.com/void-linux/void-packages/pull/38447

CONTRIBUTING.md: add instructions for testing PRs
I've had to find these instructions time and time again for requesting testing from people, so I figured why not make it part of our documentation. Maybe it will help get more users involved with testing.

Open to suggestions on wording, grammar, missing info, etc.


A patch file from https://github.com/void-linux/void-packages/pull/38447.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-contrib-testing-38447.patch --]
[-- Type: text/x-diff, Size: 1706 bytes --]

From 1222ddc6704bc7faeb809f24e87138c58c8d5151 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Wed, 3 Aug 2022 00:08:14 -0400
Subject: [PATCH] CONTRIBUTING.md: add instructions for testing PRs

---
 CONTRIBUTING.md | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index da3bef29c883..d74dd6203618 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -129,3 +129,24 @@ Please abstain from temporarily closing a pull request while revising the templa
 
 Once the reviewers have merged the pull request, our [build server](http://build.voidlinux.org) is automatically triggered and builds
 all packages in the pull request for all supported platforms. Upon completion, the packages are available to all Void Linux users.
+
+## Testing Pull Requests
+
+Testing new package submissions and updates is always helpful, and is a great way to get started with contributing.
+First, [clone the repository](https://github.com/void-linux/void-packages#quick-start) if you haven't done so already.
+Then check out the pull request, either with `github-cli`:
+
+    $ gh pr checkout <number>
+
+Or manually:
+
+    $ git fetch origin pull/<number>/head:<branch-name>
+    $ git checkout <branch-name>
+
+If your local void-packages repository is cloned from your fork, you may need to add the main repository as a remote first:
+
+    $ git remote add upstream https://github.com/void-linux/void-packages.git
+    $ git fetch upstream pull/<number>/head:<branch-name>
+    $ git checkout <branch-name>
+
+Then [build and install](https://github.com/void-linux/void-packages#building-packages) the package and test its functionality.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: CONTRIBUTING.md: add instructions for testing PRs
  2022-08-03  4:10 [PR PATCH] CONTRIBUTING.md: add instructions for testing PRs classabbyamp
@ 2022-08-03  9:36 ` tranzystorek-io
  2022-08-03  9:37 ` tranzystorek-io
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: tranzystorek-io @ 2022-08-03  9:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/38447#issuecomment-1203716530

Comment:
Do we want to suggest specific things to look at when testing? E.g., checking manpages, help prompts, runits?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: CONTRIBUTING.md: add instructions for testing PRs
  2022-08-03  4:10 [PR PATCH] CONTRIBUTING.md: add instructions for testing PRs classabbyamp
  2022-08-03  9:36 ` tranzystorek-io
@ 2022-08-03  9:37 ` tranzystorek-io
  2022-08-03 11:00 ` Duncaen
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: tranzystorek-io @ 2022-08-03  9:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/38447#issuecomment-1203716530

Comment:
Do we want to suggest specific things to look at when testing? E.g., checking manpages, help prompts, completion, runits?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: CONTRIBUTING.md: add instructions for testing PRs
  2022-08-03  4:10 [PR PATCH] CONTRIBUTING.md: add instructions for testing PRs classabbyamp
  2022-08-03  9:36 ` tranzystorek-io
  2022-08-03  9:37 ` tranzystorek-io
@ 2022-08-03 11:00 ` Duncaen
  2022-08-03 15:39 ` [PR REVIEW] " Chocimier
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2022-08-03 11:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/38447#issuecomment-1203797138

Comment:
> Do we want to suggest specific things to look at when testing? E.g., checking manpages, help prompts, completion, runits?

I don't think that would be necessary, we are more interested in users of the software actually testing if their setup works, not random people going trough a superficial checklist, which the contributor would probably already have done.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] CONTRIBUTING.md: add instructions for testing PRs
  2022-08-03  4:10 [PR PATCH] CONTRIBUTING.md: add instructions for testing PRs classabbyamp
                   ` (2 preceding siblings ...)
  2022-08-03 11:00 ` Duncaen
@ 2022-08-03 15:39 ` Chocimier
  2022-08-03 15:39 ` Chocimier
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Chocimier @ 2022-08-03 15:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/38447#discussion_r936815288

Comment:
I would introduce it with something like

> While it is PR creator responsibility to test changes before sending it, one person won't test all configuration options, usecases, hardware etc.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] CONTRIBUTING.md: add instructions for testing PRs
  2022-08-03  4:10 [PR PATCH] CONTRIBUTING.md: add instructions for testing PRs classabbyamp
                   ` (3 preceding siblings ...)
  2022-08-03 15:39 ` [PR REVIEW] " Chocimier
@ 2022-08-03 15:39 ` Chocimier
  2022-08-03 15:39 ` Chocimier
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Chocimier @ 2022-08-03 15:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/38447#discussion_r936816573

Comment:
This should go before fetching to preserve time order, and before `gh` if applies there.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] CONTRIBUTING.md: add instructions for testing PRs
  2022-08-03  4:10 [PR PATCH] CONTRIBUTING.md: add instructions for testing PRs classabbyamp
                   ` (4 preceding siblings ...)
  2022-08-03 15:39 ` Chocimier
@ 2022-08-03 15:39 ` Chocimier
  2022-08-03 16:01 ` [PR PATCH] [Updated] " classabbyamp
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Chocimier @ 2022-08-03 15:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/38447#discussion_r936815822

Comment:
Or with `git`.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] CONTRIBUTING.md: add instructions for testing PRs
  2022-08-03  4:10 [PR PATCH] CONTRIBUTING.md: add instructions for testing PRs classabbyamp
                   ` (5 preceding siblings ...)
  2022-08-03 15:39 ` Chocimier
@ 2022-08-03 16:01 ` classabbyamp
  2022-08-03 16:02 ` [PR REVIEW] " classabbyamp
  2022-08-05  0:34 ` [PR PATCH] [Merged]: " abenson
  8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-08-03 16:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages contrib-testing
https://github.com/void-linux/void-packages/pull/38447

CONTRIBUTING.md: add instructions for testing PRs
I've had to find these instructions time and time again for requesting testing from people, so I figured why not make it part of our documentation. Maybe it will help get more users involved with testing.

Open to suggestions on wording, grammar, missing info, etc.


A patch file from https://github.com/void-linux/void-packages/pull/38447.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-contrib-testing-38447.patch --]
[-- Type: text/x-diff, Size: 1871 bytes --]

From 149faa89debcb27228dec673162e97f2f1dec593 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Wed, 3 Aug 2022 00:08:14 -0400
Subject: [PATCH] CONTRIBUTING.md: add instructions for testing PRs

---
 CONTRIBUTING.md | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index da3bef29c883..3f33aeb1d974 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -129,3 +129,25 @@ Please abstain from temporarily closing a pull request while revising the templa
 
 Once the reviewers have merged the pull request, our [build server](http://build.voidlinux.org) is automatically triggered and builds
 all packages in the pull request for all supported platforms. Upon completion, the packages are available to all Void Linux users.
+
+## Testing Pull Requests
+
+While it is the responsibility of the PR creator to test changes before sending it, one person can't test all configuration options, usecases, hardware, etc.
+Testing new package submissions and updates is always helpful, and is a great way to get started with contributing.
+First, [clone the repository](https://github.com/void-linux/void-packages#quick-start) if you haven't done so already.
+Then check out the pull request, either with `github-cli`:
+
+    $ gh pr checkout <number>
+
+Or with `git`:
+
+If your local void-packages repository is cloned from your fork, you may need to add the main repository as a remote first:
+
+    $ git remote add upstream https://github.com/void-linux/void-packages.git
+
+Then fetch and check out the PR (replacing `<remote>` with either `origin` or `upstream`):
+
+    $ git fetch <remote> pull/<number>/head:<branch-name>
+    $ git checkout <branch-name>
+
+Then [build and install](https://github.com/void-linux/void-packages#building-packages) the package and test its functionality.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] CONTRIBUTING.md: add instructions for testing PRs
  2022-08-03  4:10 [PR PATCH] CONTRIBUTING.md: add instructions for testing PRs classabbyamp
                   ` (6 preceding siblings ...)
  2022-08-03 16:01 ` [PR PATCH] [Updated] " classabbyamp
@ 2022-08-03 16:02 ` classabbyamp
  2022-08-05  0:34 ` [PR PATCH] [Merged]: " abenson
  8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-08-03 16:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38447#discussion_r936846002

Comment:
tested and `gh` is able to do it without adding any remotes from either the fork clone or base repo clone

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Merged]: CONTRIBUTING.md: add instructions for testing PRs
  2022-08-03  4:10 [PR PATCH] CONTRIBUTING.md: add instructions for testing PRs classabbyamp
                   ` (7 preceding siblings ...)
  2022-08-03 16:02 ` [PR REVIEW] " classabbyamp
@ 2022-08-05  0:34 ` abenson
  8 siblings, 0 replies; 10+ messages in thread
From: abenson @ 2022-08-05  0:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

There's a merged pull request on the void-packages repository

CONTRIBUTING.md: add instructions for testing PRs
https://github.com/void-linux/void-packages/pull/38447

Description:
I've had to find these instructions time and time again for requesting testing from people, so I figured why not make it part of our documentation. Maybe it will help get more users involved with testing.

Open to suggestions on wording, grammar, missing info, etc.


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-08-05  0:34 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-03  4:10 [PR PATCH] CONTRIBUTING.md: add instructions for testing PRs classabbyamp
2022-08-03  9:36 ` tranzystorek-io
2022-08-03  9:37 ` tranzystorek-io
2022-08-03 11:00 ` Duncaen
2022-08-03 15:39 ` [PR REVIEW] " Chocimier
2022-08-03 15:39 ` Chocimier
2022-08-03 15:39 ` Chocimier
2022-08-03 16:01 ` [PR PATCH] [Updated] " classabbyamp
2022-08-03 16:02 ` [PR REVIEW] " classabbyamp
2022-08-05  0:34 ` [PR PATCH] [Merged]: " abenson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).