[ISSUE] [[:space:]] and [[:blank:] character classes not working as expected in nvi

[ISSUE] [[:space:]] and [[:blank:] character classes not working as expected in nvi

[chase-net]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

New issue by chase-net on void-packages repository

https://github.com/void-linux/void-packages/issues/38742

Description:
### Is this a new report?

Yes

### System Info

Void 5.18.17_1 x86_64-musl GenuineIntel notuptodate hold rFFF

### Package(s) Affected

nvi-1.81.6_17

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

_No response_

### Expected behaviour

Searching should match space and tab characters when using the POSIX character classes [:space:] and [:blank:].

### Actual behaviour

[:space:] and [:blank:] seem to match the [:alnum:] character class.

### Steps to reproduce

1. Start vi. `EXINIT= vi`
2. Insert some text including spaces and alphanumeric characters and return to normal mode. `ia b c d<esc>`
3. Search for the character classes [:space:] or [:blank:]. `/[[:space:]]`
4. Cycle through matches with `n`.

Re: [[:space:]] and [[:blank:] character classes not working as expected in nvi

[abenson]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/issues/38742#issuecomment-1220705491

Comment:
This isn't a Void issue, this should be brought up with [`nvi` upstream](https://repo.or.cz/nvi.git).  

FWIW the behavior on Void's `nvi` seems consistent with other distributions (tested on Debian).

Re: [ISSUE] [CLOSED] [[:space:]] and [[:blank:] character classes not working as expected in nvi

[abenson]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

Closed issue by chase-net on void-packages repository

https://github.com/void-linux/void-packages/issues/38742

Description:
### Is this a new report?

Yes

### System Info

Void 5.18.17_1 x86_64-musl GenuineIntel notuptodate hold rFFF

### Package(s) Affected

nvi-1.81.6_17

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

_No response_

### Expected behaviour

Searching should match space and tab characters when using the POSIX character classes [:space:] and [:blank:].

### Actual behaviour

[:space:] and [:blank:] seem to match the [:alnum:] character class.

### Steps to reproduce

1. Start vi. `EXINIT= vi`
2. Insert some text including spaces and alphanumeric characters and return to normal mode. `ia b c d<esc>`
3. Search for the character classes [:space:] or [:blank:]. `/[[:space:]]`
4. Cycle through matches with `n`.

Re: [[:space:]] and [[:blank:] character classes not working as expected in nvi

[sgn]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/38742#issuecomment-1220860177

Comment:
Yes, `nvi` uses nvi bundled `regexp(3)` not libc's one. It can't be compiled with libc's `regexp(3)` at least with musl, since it uses `REG_STARTEND` which is an BSD-extension.

Re: [[:space:]] and [[:blank:] character classes not working as expected in nvi

[sgn]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/38742#issuecomment-1220860177

Comment:
Yes, `nvi` uses nvi bundled `regexp(3)` not libc's one. It can't be compiled with libc's `regexp(3)` at least with musl, since it uses `REG_STARTEND` which is an BSD-extension. IOW, maybe upstream `regexp(3)` was buggy.

Re: [[:space:]] and [[:blank:] character classes not working as expected in nvi

[sgn]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/38742#issuecomment-1220921693

Comment:
Anyway, the character classes has been fix.

Re: [[:space:]] and [[:blank:] character classes not working as expected in nvi

[chase-net]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by chase-net on void-packages repository

https://github.com/void-linux/void-packages/issues/38742#issuecomment-1220939670

Comment:
It seems this was fixed in the upstream as well. The latest snapshot compiles without patches and has this and #38741 fixed.

Re: [[:space:]] and [[:blank:] character classes not working as expected in nvi

[sgn]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/38742#issuecomment-1220960653

Comment:
> It seems this was fixed in the upstream as well. The latest snapshot compiles without patches and has this and #38741 fixed.

Ask them for a release, then.
Quoting https://repo.or.cz/nvi.git/blob/HEAD:/README.1st#l1

> This is a development version of nvi.
> Use at your own risk.

For this bug, it can be traced easily, but #38741 is hard to trace.

Re: [[:space:]] and [[:blank:] character classes not working as expected in nvi

[chase-net]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by chase-net on void-packages repository

https://github.com/void-linux/void-packages/issues/38742#issuecomment-1220990521

Comment:
> Ask them for a release, then.

Will do. Thank you for the patches.