[PR PATCH] flatpak: add polkit build option

[PR PATCH] flatpak: add polkit build option

[bubba-champion]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

There is a new pull request by bubba-champion against master on the void-packages repository

https://github.com/bubba-champion/void-packages polkit-build-option
https://github.com/void-linux/void-packages/pull/39032

flatpak: add polkit build option
#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/39032.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-polkit-build-option-39032.patch --]
[-- Type: text/x-diff, Size: 2131 bytes --]

From 10a34e4af7c127d3fa675538d309830ccad4d8f9 Mon Sep 17 00:00:00 2001
From: bubba-champion <112645980+bubba-champion@users.noreply.github.com>
Date: Thu, 1 Sep 2022 15:55:47 +0000
Subject: [PATCH] flatpak: add polkit build option

---
 srcpkgs/flatpak/template | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/flatpak/template b/srcpkgs/flatpak/template
index 778ab0e681d8..cda84aaff2cb 100644
--- a/srcpkgs/flatpak/template
+++ b/srcpkgs/flatpak/template
@@ -7,14 +7,14 @@ build_helper="gir"
 configure_args="
  --with-system-bubblewrap
  --with-system-dbus-proxy
- --with-system-helper-user=_flatpak
  --enable-selinux-module=no
- $(vopt_enable gir introspection)"
+ $(vopt_enable gir introspection)
+ $(vopt_if polkit '--with-system-helper-user=_flatpak' '--disable-system-helper')"
 hostmakedepends="bubblewrap gettext glib-devel libxslt pkg-config bison
  python3-parsing xmlto docbook-xml docbook-xsl xdg-dbus-proxy"
 makedepends="AppStream-devel libarchive-devel gpgme-devel json-glib-devel
- libcap-devel libostree-devel libseccomp-devel polkit-devel dconf-devel
- fuse3-devel libsoup-devel libcurl-devel gdk-pixbuf-devel"
+ libcap-devel libostree-devel libseccomp-devel dconf-devel fuse3-devel
+ libsoup-devel libcurl-devel gdk-pixbuf-devel $(vopt_if polkit polkit-devel)"
 depends="bubblewrap gnupg2 xdg-dbus-proxy"
 checkdepends="attr-progs bubblewrap dbus gnupg2 socat which xdg-dbus-proxy"
 short_desc="Application sandboxing and distribution framework"
@@ -25,10 +25,13 @@ changelog="https://github.com/flatpak/flatpak/raw/main/NEWS"
 distfiles="https://github.com/flatpak/flatpak/releases/download/${version}/flatpak-${version}.tar.xz"
 checksum=8e276973770ea24ddf2597ad4aecd36b98393e6bde91e48e1743aaca67f27815
 
-build_options="gir"
-build_options_default="gir"
+build_options="gir polkit"
+build_options_default="gir polkit"
+desc_option_polkit="Helper for system-wide installation"
 
-system_accounts="_flatpak"
+if [ "$build_option_polkit" ]; then
+	system_accounts="_flatpak"
+fi
 
 post_patch() {
 	vsed -i -e '/cp.*usr.lib.locale.C/d' tests/make-test-runtime.sh

Re: flatpak: add polkit build option

[paper42]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/39032#issuecomment-1234594036

Comment:
Could you explain why you want this build option? How well does flatpak work without polkit?

cc @Duncaen

Re: flatpak: add polkit build option

[bubba-champion]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

New comment by bubba-champion on void-packages repository

https://github.com/void-linux/void-packages/pull/39032#issuecomment-1234637337

Comment:
This option can be useful for users who work with per-user flatpak installation instead of system-wide, and polkit in this case becomes unnecessary. As far as I can see, there are no problems when using the per-user flatpak installation without polkit.

Re: [PR PATCH] [Closed]: flatpak: add polkit build option

[bubba-champion]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

There's a closed pull request on the void-packages repository

flatpak: add polkit build option
https://github.com/void-linux/void-packages/pull/39032

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**