Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] polari: remove mozjs78 from depends
@ 2022-09-10 18:47 paper42
  2022-09-10 19:04 ` [PR PATCH] [Updated] " paper42
  2022-09-10 21:54 ` [PR PATCH] [Merged]: polari: fix dependencies paper42
  0 siblings, 2 replies; 3+ messages in thread
From: paper42 @ 2022-09-10 18:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages polari-no-mozjs78
https://github.com/void-linux/void-packages/pull/39217

polari: remove mozjs78 from depends
polari only needs mozjs because of gjs and gjs already depends on mozjs (currently v91)

* use the gir build helper

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39217.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-polari-no-mozjs78-39217.patch --]
[-- Type: text/x-diff, Size: 1664 bytes --]

From 2ed8e60736e5e5e863fb999864c772f9be3e9a22 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 10 Sep 2022 20:45:13 +0200
Subject: [PATCH] polari: remove mozjs78 from depends

polari only needs mozjs because of gjs and gjs already depends on mozjs
(currently v91)

* use the gir build helper
---
 srcpkgs/polari/template | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/polari/template b/srcpkgs/polari/template
index 53233e83acd3..d5c525f65628 100644
--- a/srcpkgs/polari/template
+++ b/srcpkgs/polari/template
@@ -1,13 +1,14 @@
 # Template file for 'polari'
 pkgname=polari
 version=41.0
-revision=1
+revision=2
 build_style=meson
-hostmakedepends="pkg-config itstool gobject-introspection gettext glib-devel"
+build_helper="gir"
+hostmakedepends="pkg-config itstool gettext glib-devel"
 makedepends="gjs-devel gspell-devel gtk+3-devel libsecret-devel
  libsoup-gnome-devel telepathy-glib-devel telepathy-logger-devel"
 depends="gspell telepathy-idle telepathy-logger telepathy-mission-control"
-checkdepends="appstream-glib desktop-file-utils mozjs78"
+checkdepends="appstream-glib desktop-file-utils"
 short_desc="GNOME IRC client"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
@@ -15,7 +16,3 @@ homepage="https://wiki.gnome.org/Apps/Polari"
 changelog="https://gitlab.gnome.org/GNOME/polari/-/raw/main/NEWS"
 distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
 checksum=a3b05f81660370c67c942b6f44b298c7b78816feb38c926ec2212bde22ea40eb
-
-if [ "$CROSS_BUILD" ] ; then
-	hostmakedepends+=" glib-devel prelink-cross qemu-user-static"
-fi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Updated] polari: remove mozjs78 from depends
  2022-09-10 18:47 [PR PATCH] polari: remove mozjs78 from depends paper42
@ 2022-09-10 19:04 ` paper42
  2022-09-10 21:54 ` [PR PATCH] [Merged]: polari: fix dependencies paper42
  1 sibling, 0 replies; 3+ messages in thread
From: paper42 @ 2022-09-10 19:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages polari-no-mozjs78
https://github.com/void-linux/void-packages/pull/39217

polari: remove mozjs78 from depends
polari only needs mozjs because of gjs and gjs already depends on mozjs (currently v91)

* use the gir build helper

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39217.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-polari-no-mozjs78-39217.patch --]
[-- Type: text/x-diff, Size: 1864 bytes --]

From ffa9874c62c8023512a717e7bbb9a4586f59a207 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 10 Sep 2022 20:45:13 +0200
Subject: [PATCH] polari: fix dependencies

* remove mozjs78 from checkdepends - polari only needs mozjs because of gjs
  and gjs already depends on mozjs (currently v91)
* add missing, drop unused dependencies
* use the gir build helper
---
 srcpkgs/polari/template | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/srcpkgs/polari/template b/srcpkgs/polari/template
index 53233e83acd3..8471ee141e0f 100644
--- a/srcpkgs/polari/template
+++ b/srcpkgs/polari/template
@@ -1,13 +1,13 @@
 # Template file for 'polari'
 pkgname=polari
 version=41.0
-revision=1
+revision=2
 build_style=meson
-hostmakedepends="pkg-config itstool gobject-introspection gettext glib-devel"
-makedepends="gjs-devel gspell-devel gtk+3-devel libsecret-devel
- libsoup-gnome-devel telepathy-glib-devel telepathy-logger-devel"
-depends="gspell telepathy-idle telepathy-logger telepathy-mission-control"
-checkdepends="appstream-glib desktop-file-utils mozjs78"
+build_helper="gir"
+hostmakedepends="pkg-config itstool gettext glib-devel"
+makedepends="gjs-devel telepathy-logger-devel telepathy-glib-devel"
+depends="telepathy-logger telepathy-glib libsecret gtk4"
+checkdepends="appstream-glib desktop-file-utils"
 short_desc="GNOME IRC client"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
@@ -15,7 +15,3 @@ homepage="https://wiki.gnome.org/Apps/Polari"
 changelog="https://gitlab.gnome.org/GNOME/polari/-/raw/main/NEWS"
 distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
 checksum=a3b05f81660370c67c942b6f44b298c7b78816feb38c926ec2212bde22ea40eb
-
-if [ "$CROSS_BUILD" ] ; then
-	hostmakedepends+=" glib-devel prelink-cross qemu-user-static"
-fi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: polari: fix dependencies
  2022-09-10 18:47 [PR PATCH] polari: remove mozjs78 from depends paper42
  2022-09-10 19:04 ` [PR PATCH] [Updated] " paper42
@ 2022-09-10 21:54 ` paper42
  1 sibling, 0 replies; 3+ messages in thread
From: paper42 @ 2022-09-10 21:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

There's a merged pull request on the void-packages repository

polari: fix dependencies
https://github.com/void-linux/void-packages/pull/39217

Description:
* remove mozjs78 from checkdepends - polari only needs mozjs because of gjs
  and gjs already depends on mozjs (currently v91)
* add missing, drop unused dependencies
* use the gir build helper

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-10 21:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-10 18:47 [PR PATCH] polari: remove mozjs78 from depends paper42
2022-09-10 19:04 ` [PR PATCH] [Updated] " paper42
2022-09-10 21:54 ` [PR PATCH] [Merged]: polari: fix dependencies paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).