* [PR PATCH] New package: bastet-0.43.2
@ 2022-10-01 0:36 awest03
2022-10-01 1:23 ` [PR PATCH] [Updated] " awest03
` (17 more replies)
0 siblings, 18 replies; 19+ messages in thread
From: awest03 @ 2022-10-01 0:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
There is a new pull request by awest03 against master on the void-packages repository
https://github.com/awest03/void-packages bastet
https://github.com/void-linux/void-packages/pull/39558
New package: bastet-0.43.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- i686
- armv6l
Fails to build on musl
A patch file from https://github.com/void-linux/void-packages/pull/39558.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bastet-39558.patch --]
[-- Type: text/x-diff, Size: 2593 bytes --]
From 4bcf75ef4e46858e56f6fa246183c0e8104335f1 Mon Sep 17 00:00:00 2001
From: Alaisdair West <alaisdair.west@outlook.com.au>
Date: Fri, 30 Sep 2022 17:33:37 +1000
Subject: [PATCH] New package: bastet-0.43.2
---
srcpkgs/bastet/patches/new-boost.patch | 22 +++++++++++++++++++
srcpkgs/bastet/template | 29 ++++++++++++++++++++++++++
2 files changed, 51 insertions(+)
create mode 100644 srcpkgs/bastet/patches/new-boost.patch
create mode 100644 srcpkgs/bastet/template
diff --git a/srcpkgs/bastet/patches/new-boost.patch b/srcpkgs/bastet/patches/new-boost.patch
new file mode 100644
index 000000000000..5ae11cb2f81d
--- /dev/null
+++ b/srcpkgs/bastet/patches/new-boost.patch
@@ -0,0 +1,22 @@
+diff -Np1 a/BastetBlockChooser.hpp b/BastetBlockChooser.hpp
+*** a/BastetBlockChooser.hpp 2015-08-30 17:04:24.000000000 +1000
+--- b/BastetBlockChooser.hpp 2022-09-30 12:18:43.100123811 +1000
+***************
+*** 25,28 ****
+
+! #include <boost/tr1/tr1/unordered_set>
+! #include <set>
+ #include <boost/functional/hash.hpp>
+--- 25,27 ----
+
+! #include <boost/unordered_set.hpp>
+ #include <boost/functional/hash.hpp>
+*************** namespace Bastet{
+*** 77,79 ****
+ private:
+! std::tr1::unordered_set<Vertex> _visited;
+ //std::set<Vertex> _visited; ^^ the above is more efficient, we need to do many inserts
+--- 76,78 ----
+ private:
+! boost::unordered_set<Vertex> _visited;
+ //std::set<Vertex> _visited; ^^ the above is more efficient, we need to do many inserts
diff --git a/srcpkgs/bastet/template b/srcpkgs/bastet/template
new file mode 100644
index 000000000000..bf051e2e93c9
--- /dev/null
+++ b/srcpkgs/bastet/template
@@ -0,0 +1,29 @@
+# Template file for 'bastet'
+pkgname=bastet
+version=0.43.2
+revision=1
+archs="~*-musl"
+hostmakedepends="gcc"
+makedepends="boost-devel ncurses-devel"
+depends="boost ncurses"
+short_desc="Evil falling block game"
+maintainer="Alaisdair West <alaisdair.west2@outlook.com>"
+license="GPL-3.0-only"
+homepage="http://fph.altervista.org/prog/bastet.html"
+changelog="https://raw.githubusercontent.com/fph/bastet/master/NEWS"
+distfiles="https://github.com/fph/${pkgname}/archive/refs/tags/${version}.tar.gz"
+checksum=f219510afc1d83e4651fbffd5921b1e0b926d5311da4f8fa7df103dc7f2c403f
+nocheckperms=yes # For High Score file
+
+do_build() {
+ make
+ touch ${pkgname}.scores2
+}
+
+do_install() {
+ vbin ./${pkgname}
+ vinstall ${pkgname}.desktop 0644 usr/share/applications
+ vinstall ${pkgname}.png 0644 usr/share/pixmaps
+ vmkdir -m 0666 var/games
+ vinstall ${pkgname}.scores2 0666 var/games
+}
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR PATCH] [Updated] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
@ 2022-10-01 1:23 ` awest03
2022-10-02 19:54 ` [PR REVIEW] " Johnnynator
` (16 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: awest03 @ 2022-10-01 1:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]
There is an updated pull request by awest03 against master on the void-packages repository
https://github.com/awest03/void-packages bastet
https://github.com/void-linux/void-packages/pull/39558
New package: bastet-0.43.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- i686
- armv6l
Fails to build on musl
A patch file from https://github.com/void-linux/void-packages/pull/39558.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bastet-39558.patch --]
[-- Type: text/x-diff, Size: 2593 bytes --]
From 8f9c214011979e7e55b140cd2eac22dea4b746f1 Mon Sep 17 00:00:00 2001
From: Alaisdair West <alaisdair.west@outlook.com.au>
Date: Fri, 30 Sep 2022 17:33:37 +1000
Subject: [PATCH] New package: bastet-0.43.2
---
srcpkgs/bastet/patches/new-boost.patch | 22 +++++++++++++++++++
srcpkgs/bastet/template | 29 ++++++++++++++++++++++++++
2 files changed, 51 insertions(+)
create mode 100644 srcpkgs/bastet/patches/new-boost.patch
create mode 100644 srcpkgs/bastet/template
diff --git a/srcpkgs/bastet/patches/new-boost.patch b/srcpkgs/bastet/patches/new-boost.patch
new file mode 100644
index 000000000000..5ae11cb2f81d
--- /dev/null
+++ b/srcpkgs/bastet/patches/new-boost.patch
@@ -0,0 +1,22 @@
+diff -Np1 a/BastetBlockChooser.hpp b/BastetBlockChooser.hpp
+*** a/BastetBlockChooser.hpp 2015-08-30 17:04:24.000000000 +1000
+--- b/BastetBlockChooser.hpp 2022-09-30 12:18:43.100123811 +1000
+***************
+*** 25,28 ****
+
+! #include <boost/tr1/tr1/unordered_set>
+! #include <set>
+ #include <boost/functional/hash.hpp>
+--- 25,27 ----
+
+! #include <boost/unordered_set.hpp>
+ #include <boost/functional/hash.hpp>
+*************** namespace Bastet{
+*** 77,79 ****
+ private:
+! std::tr1::unordered_set<Vertex> _visited;
+ //std::set<Vertex> _visited; ^^ the above is more efficient, we need to do many inserts
+--- 76,78 ----
+ private:
+! boost::unordered_set<Vertex> _visited;
+ //std::set<Vertex> _visited; ^^ the above is more efficient, we need to do many inserts
diff --git a/srcpkgs/bastet/template b/srcpkgs/bastet/template
new file mode 100644
index 000000000000..bf051e2e93c9
--- /dev/null
+++ b/srcpkgs/bastet/template
@@ -0,0 +1,29 @@
+# Template file for 'bastet'
+pkgname=bastet
+version=0.43.2
+revision=1
+archs="~*-musl"
+hostmakedepends="gcc"
+makedepends="boost-devel ncurses-devel"
+depends="boost ncurses"
+short_desc="Evil falling block game"
+maintainer="Alaisdair West <alaisdair.west2@outlook.com>"
+license="GPL-3.0-only"
+homepage="http://fph.altervista.org/prog/bastet.html"
+changelog="https://raw.githubusercontent.com/fph/bastet/master/NEWS"
+distfiles="https://github.com/fph/${pkgname}/archive/refs/tags/${version}.tar.gz"
+checksum=f219510afc1d83e4651fbffd5921b1e0b926d5311da4f8fa7df103dc7f2c403f
+nocheckperms=yes # For High Score file
+
+do_build() {
+ make
+ touch ${pkgname}.scores2
+}
+
+do_install() {
+ vbin ./${pkgname}
+ vinstall ${pkgname}.desktop 0644 usr/share/applications
+ vinstall ${pkgname}.png 0644 usr/share/pixmaps
+ vmkdir -m 0666 var/games
+ vinstall ${pkgname}.scores2 0666 var/games
+}
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
2022-10-01 1:23 ` [PR PATCH] [Updated] " awest03
@ 2022-10-02 19:54 ` Johnnynator
2022-10-02 19:54 ` Johnnynator
` (15 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Johnnynator @ 2022-10-02 19:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
New review comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#discussion_r985288007
Comment:
gcc is never needed in `hostmakedepend`
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
2022-10-01 1:23 ` [PR PATCH] [Updated] " awest03
2022-10-02 19:54 ` [PR REVIEW] " Johnnynator
@ 2022-10-02 19:54 ` Johnnynator
2022-10-02 19:55 ` Johnnynator
` (14 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Johnnynator @ 2022-10-02 19:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
New review comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#discussion_r985288041
Comment:
You probably want to use `build_style=gnu-makefile`
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (2 preceding siblings ...)
2022-10-02 19:54 ` Johnnynator
@ 2022-10-02 19:55 ` Johnnynator
2022-10-03 8:42 ` [PR PATCH] [Updated] " awest03
` (13 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Johnnynator @ 2022-10-02 19:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 195 bytes --]
New review comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#discussion_r985288157
Comment:
Can you privide the reason musl is disabled?
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR PATCH] [Updated] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (3 preceding siblings ...)
2022-10-02 19:55 ` Johnnynator
@ 2022-10-03 8:42 ` awest03
2022-10-03 9:15 ` [WIP] " awest03
` (12 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: awest03 @ 2022-10-03 8:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]
There is an updated pull request by awest03 against master on the void-packages repository
https://github.com/awest03/void-packages bastet
https://github.com/void-linux/void-packages/pull/39558
New package: bastet-0.43.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- i686
- armv6l
Fails to build on musl
A patch file from https://github.com/void-linux/void-packages/pull/39558.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bastet-39558.patch --]
[-- Type: text/x-diff, Size: 2593 bytes --]
From 8f9c214011979e7e55b140cd2eac22dea4b746f1 Mon Sep 17 00:00:00 2001
From: Alaisdair West <alaisdair.west@outlook.com.au>
Date: Fri, 30 Sep 2022 17:33:37 +1000
Subject: [PATCH] New package: bastet-0.43.2
---
srcpkgs/bastet/patches/new-boost.patch | 22 +++++++++++++++++++
srcpkgs/bastet/template | 29 ++++++++++++++++++++++++++
2 files changed, 51 insertions(+)
create mode 100644 srcpkgs/bastet/patches/new-boost.patch
create mode 100644 srcpkgs/bastet/template
diff --git a/srcpkgs/bastet/patches/new-boost.patch b/srcpkgs/bastet/patches/new-boost.patch
new file mode 100644
index 000000000000..5ae11cb2f81d
--- /dev/null
+++ b/srcpkgs/bastet/patches/new-boost.patch
@@ -0,0 +1,22 @@
+diff -Np1 a/BastetBlockChooser.hpp b/BastetBlockChooser.hpp
+*** a/BastetBlockChooser.hpp 2015-08-30 17:04:24.000000000 +1000
+--- b/BastetBlockChooser.hpp 2022-09-30 12:18:43.100123811 +1000
+***************
+*** 25,28 ****
+
+! #include <boost/tr1/tr1/unordered_set>
+! #include <set>
+ #include <boost/functional/hash.hpp>
+--- 25,27 ----
+
+! #include <boost/unordered_set.hpp>
+ #include <boost/functional/hash.hpp>
+*************** namespace Bastet{
+*** 77,79 ****
+ private:
+! std::tr1::unordered_set<Vertex> _visited;
+ //std::set<Vertex> _visited; ^^ the above is more efficient, we need to do many inserts
+--- 76,78 ----
+ private:
+! boost::unordered_set<Vertex> _visited;
+ //std::set<Vertex> _visited; ^^ the above is more efficient, we need to do many inserts
diff --git a/srcpkgs/bastet/template b/srcpkgs/bastet/template
new file mode 100644
index 000000000000..bf051e2e93c9
--- /dev/null
+++ b/srcpkgs/bastet/template
@@ -0,0 +1,29 @@
+# Template file for 'bastet'
+pkgname=bastet
+version=0.43.2
+revision=1
+archs="~*-musl"
+hostmakedepends="gcc"
+makedepends="boost-devel ncurses-devel"
+depends="boost ncurses"
+short_desc="Evil falling block game"
+maintainer="Alaisdair West <alaisdair.west2@outlook.com>"
+license="GPL-3.0-only"
+homepage="http://fph.altervista.org/prog/bastet.html"
+changelog="https://raw.githubusercontent.com/fph/bastet/master/NEWS"
+distfiles="https://github.com/fph/${pkgname}/archive/refs/tags/${version}.tar.gz"
+checksum=f219510afc1d83e4651fbffd5921b1e0b926d5311da4f8fa7df103dc7f2c403f
+nocheckperms=yes # For High Score file
+
+do_build() {
+ make
+ touch ${pkgname}.scores2
+}
+
+do_install() {
+ vbin ./${pkgname}
+ vinstall ${pkgname}.desktop 0644 usr/share/applications
+ vinstall ${pkgname}.png 0644 usr/share/pixmaps
+ vmkdir -m 0666 var/games
+ vinstall ${pkgname}.scores2 0666 var/games
+}
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [WIP] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (4 preceding siblings ...)
2022-10-03 8:42 ` [PR PATCH] [Updated] " awest03
@ 2022-10-03 9:15 ` awest03
2022-10-03 9:16 ` [PR REVIEW] " awest03
` (11 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: awest03 @ 2022-10-03 9:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New comment by awest03 on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#issuecomment-1265158128
Comment:
Sorry I've messed up the commit history so I have marked it was WIP while I fix it.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] [WIP] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (5 preceding siblings ...)
2022-10-03 9:15 ` [WIP] " awest03
@ 2022-10-03 9:16 ` awest03
2022-10-03 10:40 ` [PR PATCH] [Updated] " awest03
` (10 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: awest03 @ 2022-10-03 9:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New review comment by awest03 on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#discussion_r985553349
Comment:
Building with musl encountered some errors, I'll try again and see if I can work out a patch for it
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR PATCH] [Updated] [WIP] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (6 preceding siblings ...)
2022-10-03 9:16 ` [PR REVIEW] " awest03
@ 2022-10-03 10:40 ` awest03
2022-10-03 10:42 ` [PR REVIEW] " awest03
` (9 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: awest03 @ 2022-10-03 10:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
There is an updated pull request by awest03 against master on the void-packages repository
https://github.com/awest03/void-packages bastet
https://github.com/void-linux/void-packages/pull/39558
[WIP] New package: bastet-0.43.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- i686
- armv6l
Fails to build on musl
A patch file from https://github.com/void-linux/void-packages/pull/39558.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bastet-39558.patch --]
[-- Type: text/x-diff, Size: 2640 bytes --]
From 0ef901c3b49a17750a91c946ec7aba4c7a405a0f Mon Sep 17 00:00:00 2001
From: Alaisdair West <alaisdair.west@outlook.com.au>
Date: Mon, 3 Oct 2022 20:37:25 +1000
Subject: [PATCH] New package: bastet-0.43.2
---
srcpkgs/bastet/patches/new-boost.patch | 22 +++++++++++++++++++
srcpkgs/bastet/template | 29 ++++++++++++++++++++++++++
2 files changed, 51 insertions(+)
create mode 100644 srcpkgs/bastet/patches/new-boost.patch
create mode 100644 srcpkgs/bastet/template
diff --git a/srcpkgs/bastet/patches/new-boost.patch b/srcpkgs/bastet/patches/new-boost.patch
new file mode 100644
index 000000000000..5ae11cb2f81d
--- /dev/null
+++ b/srcpkgs/bastet/patches/new-boost.patch
@@ -0,0 +1,22 @@
+diff -Np1 a/BastetBlockChooser.hpp b/BastetBlockChooser.hpp
+*** a/BastetBlockChooser.hpp 2015-08-30 17:04:24.000000000 +1000
+--- b/BastetBlockChooser.hpp 2022-09-30 12:18:43.100123811 +1000
+***************
+*** 25,28 ****
+
+! #include <boost/tr1/tr1/unordered_set>
+! #include <set>
+ #include <boost/functional/hash.hpp>
+--- 25,27 ----
+
+! #include <boost/unordered_set.hpp>
+ #include <boost/functional/hash.hpp>
+*************** namespace Bastet{
+*** 77,79 ****
+ private:
+! std::tr1::unordered_set<Vertex> _visited;
+ //std::set<Vertex> _visited; ^^ the above is more efficient, we need to do many inserts
+--- 76,78 ----
+ private:
+! boost::unordered_set<Vertex> _visited;
+ //std::set<Vertex> _visited; ^^ the above is more efficient, we need to do many inserts
diff --git a/srcpkgs/bastet/template b/srcpkgs/bastet/template
new file mode 100644
index 000000000000..86cff35a136b
--- /dev/null
+++ b/srcpkgs/bastet/template
@@ -0,0 +1,29 @@
+# Template file for 'bastet'
+pkgname=bastet
+version=0.43.2
+revision=1
+hostmakedepends=""
+makedepends="boost-devel ncurses-devel"
+depends="boost ncurses"
+short_desc="Evil falling block game"
+maintainer="Alaisdair West <alaisdair.west2@outlook.com>"
+license="GPL-3.0-only"
+homepage="http://fph.altervista.org/prog/bastet.html"
+changelog="https://raw.githubusercontent.com/fph/bastet/master/NEWS"
+distfiles="https://github.com/fph/${pkgname}/archive/refs/tags/${version}.tar.gz"
+checksum=f219510afc1d83e4651fbffd5921b1e0b926d5311da4f8fa7df103dc7f2c403f
+nocheckperms=yes # For High Score file
+
+do_build() {
+ # Bastet's makefile does not work with build_style="gnu-makefile"
+ make
+ touch ${pkgname}.scores2
+}
+
+do_install() {
+ vbin ./${pkgname}
+ vinstall ${pkgname}.desktop 0644 usr/share/applications
+ vinstall ${pkgname}.png 0644 usr/share/pixmaps
+ vmkdir -m 0666 var/games
+ vinstall ${pkgname}.scores2 0666 var/games
+}
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (7 preceding siblings ...)
2022-10-03 10:40 ` [PR PATCH] [Updated] " awest03
@ 2022-10-03 10:42 ` awest03
2022-10-03 10:43 ` awest03
` (8 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: awest03 @ 2022-10-03 10:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New review comment by awest03 on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#discussion_r985639996
Comment:
I have re-enabled it now, turns out I had something set up wrong and it builds with musl now, sorry
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (8 preceding siblings ...)
2022-10-03 10:42 ` [PR REVIEW] " awest03
@ 2022-10-03 10:43 ` awest03
2022-10-03 10:49 ` sgn
` (7 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: awest03 @ 2022-10-03 10:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
New review comment by awest03 on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#discussion_r985640458
Comment:
Unfortunately the makefile provided by bastet does not seem to work with that
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (9 preceding siblings ...)
2022-10-03 10:43 ` awest03
@ 2022-10-03 10:49 ` sgn
2022-10-03 10:54 ` awest03
` (6 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: sgn @ 2022-10-03 10:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#discussion_r985645583
Comment:
Why not `std::unordered_set`?
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (10 preceding siblings ...)
2022-10-03 10:49 ` sgn
@ 2022-10-03 10:54 ` awest03
2022-10-03 11:11 ` awest03
` (5 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: awest03 @ 2022-10-03 10:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
New review comment by awest03 on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#discussion_r985649705
Comment:
`boost::unordered_set` is used in the repository (however unreleased) and was used to patch for FreeBSD, so I assumed that this was the appropriate solution.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (11 preceding siblings ...)
2022-10-03 10:54 ` awest03
@ 2022-10-03 11:11 ` awest03
2022-10-03 12:24 ` [PR PATCH] [Updated] [WIP] " awest03
` (4 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: awest03 @ 2022-10-03 11:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New review comment by awest03 on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#discussion_r985639996
Comment:
I have re-enabled it now, turns out I had something set up wrong and it builds with musl now, sorry
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR PATCH] [Updated] [WIP] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (12 preceding siblings ...)
2022-10-03 11:11 ` awest03
@ 2022-10-03 12:24 ` awest03
2022-10-03 13:14 ` [PR REVIEW] " awest03
` (3 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: awest03 @ 2022-10-03 12:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
There is an updated pull request by awest03 against master on the void-packages repository
https://github.com/awest03/void-packages bastet
https://github.com/void-linux/void-packages/pull/39558
[WIP] New package: bastet-0.43.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- i686
- armv6l
Fails to build on musl
A patch file from https://github.com/void-linux/void-packages/pull/39558.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bastet-39558.patch --]
[-- Type: text/x-diff, Size: 4291 bytes --]
From 5497cf6b16f44801dde9412ce290ddb4b33cade1 Mon Sep 17 00:00:00 2001
From: Alaisdair West <alaisdair.west@outlook.com.au>
Date: Mon, 3 Oct 2022 20:37:25 +1000
Subject: [PATCH] New package: bastet-0.43.2
---
srcpkgs/bastet/patches/musl.patch | 9 ++++++
srcpkgs/bastet/patches/new-boost.patch | 22 +++++++++++++
.../bastet/patches/scorer-names-bugfix.patch | 12 +++++++
srcpkgs/bastet/template | 31 +++++++++++++++++++
4 files changed, 74 insertions(+)
create mode 100644 srcpkgs/bastet/patches/musl.patch
create mode 100644 srcpkgs/bastet/patches/new-boost.patch
create mode 100644 srcpkgs/bastet/patches/scorer-names-bugfix.patch
create mode 100644 srcpkgs/bastet/template
diff --git a/srcpkgs/bastet/patches/musl.patch b/srcpkgs/bastet/patches/musl.patch
new file mode 100644
index 000000000000..e5cfd52d1317
--- /dev/null
+++ b/srcpkgs/bastet/patches/musl.patch
@@ -0,0 +1,9 @@
+diff -Np1 a/Ui.cpp b/Ui.cpp
+*** a/Ui.cpp 2015-08-30 17:04:24.000000000 +1000
+--- b/Ui.cpp 2022-10-03 21:07:31.638179807 +1000
+***************
+*** 29,30 ****
+--- 29,31 ----
+ #include <boost/algorithm/string.hpp>
++ #include <sys/select.h>
+
diff --git a/srcpkgs/bastet/patches/new-boost.patch b/srcpkgs/bastet/patches/new-boost.patch
new file mode 100644
index 000000000000..5ae11cb2f81d
--- /dev/null
+++ b/srcpkgs/bastet/patches/new-boost.patch
@@ -0,0 +1,22 @@
+diff -Np1 a/BastetBlockChooser.hpp b/BastetBlockChooser.hpp
+*** a/BastetBlockChooser.hpp 2015-08-30 17:04:24.000000000 +1000
+--- b/BastetBlockChooser.hpp 2022-09-30 12:18:43.100123811 +1000
+***************
+*** 25,28 ****
+
+! #include <boost/tr1/tr1/unordered_set>
+! #include <set>
+ #include <boost/functional/hash.hpp>
+--- 25,27 ----
+
+! #include <boost/unordered_set.hpp>
+ #include <boost/functional/hash.hpp>
+*************** namespace Bastet{
+*** 77,79 ****
+ private:
+! std::tr1::unordered_set<Vertex> _visited;
+ //std::set<Vertex> _visited; ^^ the above is more efficient, we need to do many inserts
+--- 76,78 ----
+ private:
+! boost::unordered_set<Vertex> _visited;
+ //std::set<Vertex> _visited; ^^ the above is more efficient, we need to do many inserts
diff --git a/srcpkgs/bastet/patches/scorer-names-bugfix.patch b/srcpkgs/bastet/patches/scorer-names-bugfix.patch
new file mode 100644
index 000000000000..ffff7fb65889
--- /dev/null
+++ b/srcpkgs/bastet/patches/scorer-names-bugfix.patch
@@ -0,0 +1,12 @@
+diff -Np1 a/Config.cpp b/Config.cpp
+*** a/Config.cpp 2015-08-30 17:04:24.000000000 +1000
+--- b/Config.cpp 2022-10-03 21:45:30.198811697 +1000
+*************** namespace Bastet{
+*** 189,191 ****
+ BOOST_FOREACH(const HighScore &hs, _hs[difficulty]){
+! ofs2<<str(scorer % difficulty % i) << " = \"" << hs.Scorer << "\"\n";
+ ofs2<<str(score % difficulty % i) << " = " << hs.Score <<"\n";
+--- 189,191 ----
+ BOOST_FOREACH(const HighScore &hs, _hs[difficulty]){
+! ofs2<<str(scorer % difficulty % i) << " = " << hs.Scorer << "\n";
+ ofs2<<str(score % difficulty % i) << " = " << hs.Score <<"\n";
diff --git a/srcpkgs/bastet/template b/srcpkgs/bastet/template
new file mode 100644
index 000000000000..a0051d691d20
--- /dev/null
+++ b/srcpkgs/bastet/template
@@ -0,0 +1,31 @@
+# Template file for 'bastet'
+pkgname=bastet
+version=0.43.2
+revision=1
+makedepends="boost-devel ncurses-devel"
+depends="boost ncurses"
+short_desc="Evil falling block game"
+maintainer="Alaisdair West <alaisdair.west2@outlook.com>"
+license="GPL-3.0-or-later"
+homepage="http://fph.altervista.org/prog/bastet.html"
+changelog="https://raw.githubusercontent.com/fph/bastet/master/NEWS"
+distfiles="https://github.com/fph/${pkgname}/archive/refs/tags/${version}.tar.gz"
+checksum=f219510afc1d83e4651fbffd5921b1e0b926d5311da4f8fa7df103dc7f2c403f
+nocheckperms=yes # For High Score file
+
+do_build() {
+ # Bastet's makefile does not work with build_style="gnu-makefile"
+ make
+}
+
+do_install() {
+ vbin ./${pkgname}
+ vinstall ${pkgname}.desktop 0644 usr/share/applications
+ vinstall ${pkgname}.png 0644 usr/share/pixmaps
+ # Don't overwrite the high scores file on update
+ if [! -f ${pkgname}.scores2]; then
+ vmkdir -m 0666 var/games
+ touch ${pkgname}.scores2
+ vinstall ${pkgname}.scores2 0666 var/games
+ fi
+}
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (13 preceding siblings ...)
2022-10-03 12:24 ` [PR PATCH] [Updated] [WIP] " awest03
@ 2022-10-03 13:14 ` awest03
2022-10-03 13:15 ` awest03
` (2 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: awest03 @ 2022-10-03 13:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 215 bytes --]
New review comment by awest03 on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#discussion_r985768334
Comment:
I've managed to patch it to work with musl and built for x86_64-musl
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (14 preceding siblings ...)
2022-10-03 13:14 ` [PR REVIEW] " awest03
@ 2022-10-03 13:15 ` awest03
2023-01-03 12:06 ` sgn
2023-01-04 15:38 ` [PR PATCH] [Closed]: " sgn
17 siblings, 0 replies; 19+ messages in thread
From: awest03 @ 2022-10-03 13:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 219 bytes --]
New review comment by awest03 on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#discussion_r985768334
Comment:
I've managed to patch it to work with musl and built for x86_64-musl now
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (15 preceding siblings ...)
2022-10-03 13:15 ` awest03
@ 2023-01-03 12:06 ` sgn
2023-01-04 15:38 ` [PR PATCH] [Closed]: " sgn
17 siblings, 0 replies; 19+ messages in thread
From: sgn @ 2023-01-03 12:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/39558#discussion_r1060523686
Comment:
`boost::unorder_set` needs to be linked with libboost_container, I think
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR PATCH] [Closed]: New package: bastet-0.43.2
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
` (16 preceding siblings ...)
2023-01-03 12:06 ` sgn
@ 2023-01-04 15:38 ` sgn
17 siblings, 0 replies; 19+ messages in thread
From: sgn @ 2023-01-04 15:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
There's a closed pull request on the void-packages repository
New package: bastet-0.43.2
https://github.com/void-linux/void-packages/pull/39558
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- i686
- armv6l
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2023-01-04 15:38 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-01 0:36 [PR PATCH] New package: bastet-0.43.2 awest03
2022-10-01 1:23 ` [PR PATCH] [Updated] " awest03
2022-10-02 19:54 ` [PR REVIEW] " Johnnynator
2022-10-02 19:54 ` Johnnynator
2022-10-02 19:55 ` Johnnynator
2022-10-03 8:42 ` [PR PATCH] [Updated] " awest03
2022-10-03 9:15 ` [WIP] " awest03
2022-10-03 9:16 ` [PR REVIEW] " awest03
2022-10-03 10:40 ` [PR PATCH] [Updated] " awest03
2022-10-03 10:42 ` [PR REVIEW] " awest03
2022-10-03 10:43 ` awest03
2022-10-03 10:49 ` sgn
2022-10-03 10:54 ` awest03
2022-10-03 11:11 ` awest03
2022-10-03 12:24 ` [PR PATCH] [Updated] [WIP] " awest03
2022-10-03 13:14 ` [PR REVIEW] " awest03
2022-10-03 13:15 ` awest03
2023-01-03 12:06 ` sgn
2023-01-04 15:38 ` [PR PATCH] [Closed]: " sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).