[PR PATCH] github-cli: update to 2.19.0

[PR PATCH] github-cli: update to 2.19.0

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

There is a new pull request by tranzystorek-io against master on the void-packages repository

https://github.com/tranzystorek-io/void-packages gh
https://github.com/void-linux/void-packages/pull/40320

github-cli: update to 2.19.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40320.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gh-40320.patch --]
[-- Type: text/x-diff, Size: 1458 bytes --]

From 3b2271b6b35545959dae2413e9ad19184350743c Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Thu, 3 Nov 2022 22:21:31 +0100
Subject: [PATCH] github-cli: update to 2.19.0

---
 srcpkgs/github-cli/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/github-cli/template b/srcpkgs/github-cli/template
index 973cd64ec8c2..a1de81fe0bae 100644
--- a/srcpkgs/github-cli/template
+++ b/srcpkgs/github-cli/template
@@ -1,6 +1,6 @@
 # Template file for 'github-cli'
 pkgname=github-cli
-version=2.18.1
+version=2.19.0
 revision=1
 wrksrc="cli-${version}"
 build_style=go
@@ -13,7 +13,7 @@ license="MIT"
 homepage="https://cli.github.com"
 changelog="https://github.com/cli/cli/releases"
 distfiles="https://github.com/cli/cli/archive/refs/tags/v${version}.tar.gz"
-checksum=b66c15f03de1fa964fdd60641aec7f1d5c09b338ee10e9475c645bb0d8fa1e98
+checksum=522aeaa5e1ed885d89cf44fe8e1c84da6a372046d4e173a5cd290821ac5afdc8
 
 pre_build() {
 	local _date
@@ -29,9 +29,9 @@ post_install() {
 	CGO_ENABLED=0 GOARCH="" go run script/build.go manpages
 	vcopy share/man usr/share
 
-	GH="${DESTDIR}/usr/bin/gh"
+	local gh="${DESTDIR}/usr/bin/gh"
 	for shell in bash fish zsh; do
-		vtargetrun ${GH} completion -s $shell > github-cli.$shell
-		vcompletion github-cli.$shell $shell gh
+		vtargetrun ${gh} completion -s ${shell} > github-cli.${shell}
+		vcompletion github-cli.${shell} ${shell} gh
 	done
 }

Re: [PR REVIEW] github-cli: update to 2.19.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40320#discussion_r1014055621

Comment:
from what I can see, this variable is only used once, so I don't think it makes much sense

Re: [PR REVIEW] github-cli: update to 2.19.0

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/40320#discussion_r1014060994

Comment:
But it doesn't hurt to wrap this variable into local, even just to show that it's a one-off

Re: [PR REVIEW] github-cli: update to 2.19.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40320#discussion_r1014077525

Comment:
It doesn't hurt, but since we are already improving it, we can get rid of it.

Re: [PR PATCH] [Updated] github-cli: update to 2.19.0

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

There is an updated pull request by tranzystorek-io against master on the void-packages repository

https://github.com/tranzystorek-io/void-packages gh
https://github.com/void-linux/void-packages/pull/40320

github-cli: update to 2.19.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40320.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gh-40320.patch --]
[-- Type: text/x-diff, Size: 1439 bytes --]

From f72b4f9c7a7f616c46787db167c2098167abd0dd Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Thu, 3 Nov 2022 22:21:31 +0100
Subject: [PATCH] github-cli: update to 2.19.0

---
 srcpkgs/github-cli/template | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/github-cli/template b/srcpkgs/github-cli/template
index 973cd64ec8c2..458fbe94ad0e 100644
--- a/srcpkgs/github-cli/template
+++ b/srcpkgs/github-cli/template
@@ -1,6 +1,6 @@
 # Template file for 'github-cli'
 pkgname=github-cli
-version=2.18.1
+version=2.19.0
 revision=1
 wrksrc="cli-${version}"
 build_style=go
@@ -13,7 +13,7 @@ license="MIT"
 homepage="https://cli.github.com"
 changelog="https://github.com/cli/cli/releases"
 distfiles="https://github.com/cli/cli/archive/refs/tags/v${version}.tar.gz"
-checksum=b66c15f03de1fa964fdd60641aec7f1d5c09b338ee10e9475c645bb0d8fa1e98
+checksum=522aeaa5e1ed885d89cf44fe8e1c84da6a372046d4e173a5cd290821ac5afdc8
 
 pre_build() {
 	local _date
@@ -29,9 +29,8 @@ post_install() {
 	CGO_ENABLED=0 GOARCH="" go run script/build.go manpages
 	vcopy share/man usr/share
 
-	GH="${DESTDIR}/usr/bin/gh"
 	for shell in bash fish zsh; do
-		vtargetrun ${GH} completion -s $shell > github-cli.$shell
-		vcompletion github-cli.$shell $shell gh
+		vtargetrun "${DESTDIR}/usr/bin/gh" completion -s ${shell} > github-cli.${shell}
+		vcompletion github-cli.${shell} ${shell} gh
 	done
 }

Re: [PR REVIEW] github-cli: update to 2.19.0

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/40320#discussion_r1014117083

Comment:
Ah, I misunderstood what you requested.

Re: [PR PATCH] [Merged]: github-cli: update to 2.19.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

There's a merged pull request on the void-packages repository

github-cli: update to 2.19.0
https://github.com/void-linux/void-packages/pull/40320

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->