* [PR PATCH] common/build-style/python3-pep517: add missing \n for msg_warn
@ 2022-11-10 0:31 JamiKettunen
2022-11-10 1:42 ` [PR PATCH] [Merged]: " sgn
0 siblings, 1 reply; 2+ messages in thread
From: JamiKettunen @ 2022-11-10 0:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
There is a new pull request by JamiKettunen against master on the void-packages repository
https://github.com/JamiKettunen/void-packages pep517-newline
https://github.com/void-linux/void-packages/pull/40426
common/build-style/python3-pep517: add missing \n for msg_warn
<!-- Uncomment relevant sections and delete options which are not applicable -->
Fixes the following (missing newline) for this warning:
![image](https://user-images.githubusercontent.com/47358222/200971182-8f275696-2d34-424b-af51-de9d0a88262e.png)
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/40426.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pep517-newline-40426.patch --]
[-- Type: text/x-diff, Size: 847 bytes --]
From e17bb5614399ba3f089c737a91d464b59249ca48 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 10 Nov 2022 02:27:52 +0200
Subject: [PATCH] common/build-style/python3-pep517: add missing \n for
msg_warn
---
common/build-style/python3-pep517.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/build-style/python3-pep517.sh b/common/build-style/python3-pep517.sh
index da1e238e1192..0994384aacfa 100644
--- a/common/build-style/python3-pep517.sh
+++ b/common/build-style/python3-pep517.sh
@@ -20,7 +20,7 @@ do_check() {
fi
${make_check_pre} python3 -m pytest ${testjobs} ${make_check_args} ${make_check_target}
else
- msg_warn "Unable to determine tests for PEP517 Python templates"
+ msg_warn "Unable to determine tests for PEP517 Python templates\n"
return 0
fi
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PR PATCH] [Merged]: common/build-style/python3-pep517: add missing \n for msg_warn
2022-11-10 0:31 [PR PATCH] common/build-style/python3-pep517: add missing \n for msg_warn JamiKettunen
@ 2022-11-10 1:42 ` sgn
0 siblings, 0 replies; 2+ messages in thread
From: sgn @ 2022-11-10 1:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]
There's a merged pull request on the void-packages repository
common/build-style/python3-pep517: add missing \n for msg_warn
https://github.com/void-linux/void-packages/pull/40426
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
Fixes the following (missing newline) for this warning:
![image](https://user-images.githubusercontent.com/47358222/200971182-8f275696-2d34-424b-af51-de9d0a88262e.png)
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-10 1:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 0:31 [PR PATCH] common/build-style/python3-pep517: add missing \n for msg_warn JamiKettunen
2022-11-10 1:42 ` [PR PATCH] [Merged]: " sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).