[PR PATCH] cherrytree: update to 0.99.51

[PR PATCH] cherrytree: update to 0.99.51

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

There is a new pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages cherry
https://github.com/void-linux/void-packages/pull/40444

cherrytree: update to 0.99.51
#### Testing the changes
- I tested the changes in this PR: **YES**

---

To explain the changes, cherrytree now has tests that run as part of the build process right after building the program. These tests require access to an X server, and I don't think it would be good to run the entire build under `xvfb-run` or something like that. Cherrytree also uses a bundled version of gtest and will attempt to build it regardless of whether tests are enabled unless a configure arg is set and gtest is available in the environment.

A patch file from https://github.com/void-linux/void-packages/pull/40444.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cherry-40444.patch --]
[-- Type: text/x-diff, Size: 2095 bytes --]

From 255617a6d7c636097e34d13e13fbcdc54b28dd8c Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Thu, 10 Nov 2022 11:22:52 -0500
Subject: [PATCH] cherrytree: update to 0.99.51

---
 srcpkgs/cherrytree/template | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/cherrytree/template b/srcpkgs/cherrytree/template
index da04195b9b95..ee6649318f82 100644
--- a/srcpkgs/cherrytree/template
+++ b/srcpkgs/cherrytree/template
@@ -1,19 +1,21 @@
 # Template file for 'cherrytree'
 pkgname=cherrytree
-version=0.99.39
-revision=3
+version=0.99.51
+revision=1
 build_style=cmake
-hostmakedepends="gettext pkg-config desktop-file-utils python3 glib-devel"
-makedepends="cpputest uchardet-devel libcurl-devel sqlite-devel
- libxml++-devel gtksourceviewmm-devel gspell-devel gtkmm-devel
- fmt-devel spdlog"
+# Tests are built during the normal build process and require access to X server
+# Needs gtest even if tests are disabled
+configure_args="-DUSE_SHARED_GTEST_GMOCK=ON -DBUILD_TESTING=OFF"
+hostmakedepends="gettext glib-devel pkg-config python3"
+makedepends="fmt-devel fribidi-devel gtkmm-devel gtksourceviewmm-devel
+ gspell-devel gtest-devel libcurl-devel libxml++-devel spdlog sqlite-devel
+ uchardet-devel vte3-devel"
 depends="desktop-file-utils"
 short_desc="Hierarchial note taking application with syntax highlighting"
 maintainer="Logen K <logen@sudotask.com>"
 license="GPL-3.0-or-later"
 homepage="https://www.giuspen.com/cherrytree/"
-distfiles="https://github.com/giuspen/cherrytree/releases/download/${version}/cherrytree_${version}.tar.xz"
-checksum=7af0adc2e2edf3f8797ba6b1bcb534f2309ba8297c4b235835ea969bae457d62
-configure_args+=" -DBUILD_GMOCK:BOOL='OFF'
- -DBUILD_GTEST:BOOL='OFF'
- -DBUILD_TESTING:BOOL='OFF'"
+changelog="https://raw.githubusercontent.com/giuspen/cherrytree/master/changelog.txt"
+distfiles="https://github.com/giuspen/cherrytree/archive/refs/tags/${version}.tar.gz"
+checksum=5c88bd8d709226006819cc7bba8445bab7bc5d2795364110d9ce59ecb69c7bcb
+make_check=no  # Tests are run during build step

Re: cherrytree: update to 0.99.51

[paper42]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40444#issuecomment-1318615823

Comment:
> Cherrytree also uses a bundled version of gtest and will attempt to build it regardless of whether tests are enabled unless a configure arg is set and gtest is available in the environment.

Could you report that upstream, that sounds like a bug.

Re: [PR PATCH] [Updated] cherrytree: update to 0.99.51

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]

There is an updated pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages cherry
https://github.com/void-linux/void-packages/pull/40444

cherrytree: update to 0.99.51
#### Testing the changes
- I tested the changes in this PR: **YES**

---

To explain the changes, cherrytree now has tests that run as part of the build process right after building the program. These tests require access to an X server, and I don't think it would be good to run the entire build under `xvfb-run` or something like that. Cherrytree also uses a bundled version of gtest and will attempt to build it regardless of whether tests are enabled unless a configure arg is set and gtest is available in the environment.

A patch file from https://github.com/void-linux/void-packages/pull/40444.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cherry-40444.patch --]
[-- Type: text/x-diff, Size: 2012 bytes --]

From a2fc943171d70c343dafce384643ebd00094cfae Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Fri, 18 Nov 2022 22:35:57 -0500
Subject: [PATCH] cherrytree: update to 0.99.51

---
 srcpkgs/cherrytree/template | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/cherrytree/template b/srcpkgs/cherrytree/template
index da04195b9b95..ef8bdd30ce22 100644
--- a/srcpkgs/cherrytree/template
+++ b/srcpkgs/cherrytree/template
@@ -1,19 +1,20 @@
 # Template file for 'cherrytree'
 pkgname=cherrytree
-version=0.99.39
-revision=3
+version=0.99.51
+revision=1
 build_style=cmake
-hostmakedepends="gettext pkg-config desktop-file-utils python3 glib-devel"
-makedepends="cpputest uchardet-devel libcurl-devel sqlite-devel
- libxml++-devel gtksourceviewmm-devel gspell-devel gtkmm-devel
- fmt-devel spdlog"
+# Tests are built during the normal build process and require access to X server
+configure_args="-DBUILD_TESTING=OFF"
+hostmakedepends="gettext glib-devel pkg-config python3"
+makedepends="fmt-devel fribidi-devel gtkmm-devel gtksourceviewmm-devel
+ gspell-devel libcurl-devel libxml++-devel spdlog sqlite-devel uchardet-devel
+ vte3-devel"
 depends="desktop-file-utils"
 short_desc="Hierarchial note taking application with syntax highlighting"
 maintainer="Logen K <logen@sudotask.com>"
 license="GPL-3.0-or-later"
 homepage="https://www.giuspen.com/cherrytree/"
-distfiles="https://github.com/giuspen/cherrytree/releases/download/${version}/cherrytree_${version}.tar.xz"
-checksum=7af0adc2e2edf3f8797ba6b1bcb534f2309ba8297c4b235835ea969bae457d62
-configure_args+=" -DBUILD_GMOCK:BOOL='OFF'
- -DBUILD_GTEST:BOOL='OFF'
- -DBUILD_TESTING:BOOL='OFF'"
+changelog="https://raw.githubusercontent.com/giuspen/cherrytree/master/changelog.txt"
+distfiles="https://github.com/giuspen/cherrytree/archive/refs/tags/${version}.tar.gz"
+checksum=5c88bd8d709226006819cc7bba8445bab7bc5d2795364110d9ce59ecb69c7bcb
+make_check=no  # Tests are run during build step

Re: cherrytree: update to 0.99.51

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/40444#issuecomment-1320780376

Comment:
> Could you report that upstream, that sounds like a bug.

Actually that was me misreading `cmakelists.txt`. The part about tests running during the build process is still true.

Re: [PR PATCH] [Merged]: cherrytree: update to 0.99.51

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]

There's a merged pull request on the void-packages repository

cherrytree: update to 0.99.51
https://github.com/void-linux/void-packages/pull/40444

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

---

To explain the changes, cherrytree now has tests that run as part of the build process right after building the program. These tests require access to an X server, and I don't think it would be good to run the entire build under `xvfb-run` or something like that. Cherrytree also uses a bundled version of gtest and will attempt to build it regardless of whether tests are enabled unless a configure arg is set and gtest is available in the environment.