From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] fcitx5-qt: remove unused conditional block
Date: Sat, 19 Nov 2022 01:41:13 +0100 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40601@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
There is a new pull request by classabbyamp against master on the void-packages repository
https://github.com/classabbyamp/void-packages fix/fcitx5-qt-atomic
https://github.com/void-linux/void-packages/pull/40601
fcitx5-qt: remove unused conditional block
the test on this block always evaluates false because `XBPS_TARGET_NOATOMIC8` is never set, so it is never run (the variable is actually `XBPS_TARGET_NO_ATOMIC8`).
Because it was never active it should not change the resultant package on armv6 or other no atomic8 platforms.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
A patch file from https://github.com/void-linux/void-packages/pull/40601.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/fcitx5-qt-atomic-40601.patch --]
[-- Type: text/x-diff, Size: 1071 bytes --]
From 62f4f89f53dca7f4b41673029c88e4a136c259ba Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Fri, 18 Nov 2022 19:35:22 -0500
Subject: [PATCH] fcitx5-qt: remove unused conditional block
the test on this block always evaluates false because
`XBPS_TARGET_NOATOMIC8` is never set, so it is never run
(the variable is actually `XBPS_TARGET_NO_ATOMIC8`).
---
srcpkgs/fcitx5-qt/template | 5 -----
1 file changed, 5 deletions(-)
diff --git a/srcpkgs/fcitx5-qt/template b/srcpkgs/fcitx5-qt/template
index 3c88aa0bf50c..dbae8b99a5ca 100644
--- a/srcpkgs/fcitx5-qt/template
+++ b/srcpkgs/fcitx5-qt/template
@@ -17,11 +17,6 @@ distfiles="https://download.fcitx-im.org/fcitx5/fcitx5-qt/fcitx5-qt-${version}.t
checksum=21743c4353c793934222fa7115493cd30da9843b4baed22e64bddfa6dd7341a8
lib32disabled=yes
-if [ "$XBPS_TARGET_NOATOMIC8" ]; then
- configure_args+=" -DCMAKE_CXX_STANDARD_LIBRARIES=-latomic"
- makedepends+=" libatomic-devel"
-fi
-
post_install() {
local _file
for _file in $(grep -rl 'SPDX-License-Identifier: BSD-3-Clause' qt5 qt6)
next reply other threads:[~2022-11-19 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 0:41 classabbyamp [this message]
2022-11-19 0:46 ` [PR PATCH] [Updated] " classabbyamp
2022-11-24 4:16 ` [PR PATCH] [Merged]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40601@inbox.vuxu.org \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).