From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: fcitx5-qt: remove unused conditional block
Date: Thu, 24 Nov 2022 05:16:07 +0100 [thread overview]
Message-ID: <20221124041607.nsBNRBoWTpVo1tclaedRdTHxs8_e3HF39i9-jN5iM6k@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40601@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
There's a merged pull request on the void-packages repository
fcitx5-qt: remove unused conditional block
https://github.com/void-linux/void-packages/pull/40601
Description:
added in #30714, but it seems to have never been necessary.
the test on this block always evaluates false because `XBPS_TARGET_NOATOMIC8` is never set, so it is never run (the variable is actually `XBPS_TARGET_NO_ATOMIC8`).
Because it was never active it should not change the resultant package on armv6 or other no atomic8 platforms.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
prev parent reply other threads:[~2022-11-24 4:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 0:41 [PR PATCH] " classabbyamp
2022-11-19 0:46 ` [PR PATCH] [Updated] " classabbyamp
2022-11-24 4:16 ` sgn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221124041607.nsBNRBoWTpVo1tclaedRdTHxs8_e3HF39i9-jN5iM6k@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).