[PR PATCH] fcitx5-qt: remove unused conditional block

[PR PATCH] fcitx5-qt: remove unused conditional block

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages fix/fcitx5-qt-atomic
https://github.com/void-linux/void-packages/pull/40601

fcitx5-qt: remove unused conditional block
the test on this block always evaluates false because `XBPS_TARGET_NOATOMIC8` is never set, so it is never run (the variable is actually `XBPS_TARGET_NO_ATOMIC8`).

Because it was never active it should not change the resultant package on armv6 or other no atomic8 platforms.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**



A patch file from https://github.com/void-linux/void-packages/pull/40601.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/fcitx5-qt-atomic-40601.patch --]
[-- Type: text/x-diff, Size: 1071 bytes --]

From 62f4f89f53dca7f4b41673029c88e4a136c259ba Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Fri, 18 Nov 2022 19:35:22 -0500
Subject: [PATCH] fcitx5-qt: remove unused conditional block

the test on this block always evaluates false because
`XBPS_TARGET_NOATOMIC8` is never set, so it is never run
(the variable is actually `XBPS_TARGET_NO_ATOMIC8`).
---
 srcpkgs/fcitx5-qt/template | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/srcpkgs/fcitx5-qt/template b/srcpkgs/fcitx5-qt/template
index 3c88aa0bf50c..dbae8b99a5ca 100644
--- a/srcpkgs/fcitx5-qt/template
+++ b/srcpkgs/fcitx5-qt/template
@@ -17,11 +17,6 @@ distfiles="https://download.fcitx-im.org/fcitx5/fcitx5-qt/fcitx5-qt-${version}.t
 checksum=21743c4353c793934222fa7115493cd30da9843b4baed22e64bddfa6dd7341a8
 lib32disabled=yes
 
-if [ "$XBPS_TARGET_NOATOMIC8" ]; then
-	configure_args+=" -DCMAKE_CXX_STANDARD_LIBRARIES=-latomic"
-	makedepends+=" libatomic-devel"
-fi
-
 post_install() {
 	local _file
 	for _file in $(grep -rl 'SPDX-License-Identifier: BSD-3-Clause' qt5 qt6)

Re: [PR PATCH] [Updated] fcitx5-qt: remove unused conditional block

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages fix/fcitx5-qt-atomic
https://github.com/void-linux/void-packages/pull/40601

fcitx5-qt: remove unused conditional block
the test on this block always evaluates false because `XBPS_TARGET_NOATOMIC8` is never set, so it is never run (the variable is actually `XBPS_TARGET_NO_ATOMIC8`).

Because it was never active it should not change the resultant package on armv6 or other no atomic8 platforms.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**



A patch file from https://github.com/void-linux/void-packages/pull/40601.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/fcitx5-qt-atomic-40601.patch --]
[-- Type: text/x-diff, Size: 1132 bytes --]

From 5b8369ec90b85ab1acc94c34d6a444ad0cee87af Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Fri, 18 Nov 2022 19:35:22 -0500
Subject: [PATCH] fcitx5-qt: remove unused conditional block

added in #30714, but it seems to have never been necessary.

the test on this block always evaluates false because
`XBPS_TARGET_NOATOMIC8` is never set, so it is never run
(the variable is actually `XBPS_TARGET_NO_ATOMIC8`).
---
 srcpkgs/fcitx5-qt/template | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/srcpkgs/fcitx5-qt/template b/srcpkgs/fcitx5-qt/template
index 3c88aa0bf50c..dbae8b99a5ca 100644
--- a/srcpkgs/fcitx5-qt/template
+++ b/srcpkgs/fcitx5-qt/template
@@ -17,11 +17,6 @@ distfiles="https://download.fcitx-im.org/fcitx5/fcitx5-qt/fcitx5-qt-${version}.t
 checksum=21743c4353c793934222fa7115493cd30da9843b4baed22e64bddfa6dd7341a8
 lib32disabled=yes
 
-if [ "$XBPS_TARGET_NOATOMIC8" ]; then
-	configure_args+=" -DCMAKE_CXX_STANDARD_LIBRARIES=-latomic"
-	makedepends+=" libatomic-devel"
-fi
-
 post_install() {
 	local _file
 	for _file in $(grep -rl 'SPDX-License-Identifier: BSD-3-Clause' qt5 qt6)

Re: [PR PATCH] [Merged]: fcitx5-qt: remove unused conditional block

[sgn]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

There's a merged pull request on the void-packages repository

fcitx5-qt: remove unused conditional block
https://github.com/void-linux/void-packages/pull/40601

Description:
added in #30714, but it seems to have never been necessary.

the test on this block always evaluates false because `XBPS_TARGET_NOATOMIC8` is never set, so it is never run (the variable is actually `XBPS_TARGET_NO_ATOMIC8`).

Because it was never active it should not change the resultant package on armv6 or other no atomic8 platforms.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**