[PR PATCH] libblockdev: update to 2.28.

[PR PATCH] libblockdev: update to 2.28.

[skmpz]

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

There is a new pull request by skmpz against master on the void-packages repository

https://github.com/skmpz/void-packages libblockdev-2.28
https://github.com/void-linux/void-packages/pull/40642

libblockdev: update to 2.28.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40642.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libblockdev-2.28-40642.patch --]
[-- Type: text/x-diff, Size: 1310 bytes --]

From 181b99c1214a1671442795e48c4dda924eaa8ae0 Mon Sep 17 00:00:00 2001
From: skmpz <dem.procopiou@gmail.com>
Date: Sun, 20 Nov 2022 15:50:03 +0400
Subject: [PATCH] libblockdev: update to 2.28.

---
 srcpkgs/libblockdev/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/libblockdev/template b/srcpkgs/libblockdev/template
index b857dd3b4678..157332c30daf 100644
--- a/srcpkgs/libblockdev/template
+++ b/srcpkgs/libblockdev/template
@@ -1,7 +1,7 @@
 # Template file for 'libblockdev'
 pkgname=libblockdev
-version=2.26
-revision=2
+version=2.28
+revision=1
 build_style=gnu-configure
 hostmakedepends="pkg-config python3"
 makedepends="cryptsetup-devel device-mapper-devel dmraid-devel libbytesize-devel
@@ -13,7 +13,7 @@ license="LGPL-2.1-or-later"
 homepage="https://github.com/storaged-project/libblockdev"
 changelog="https://raw.githubusercontent.com/storaged-project/libblockdev/master/NEWS.rst"
 distfiles="https://github.com/storaged-project/libblockdev/releases/download/${version}-1/libblockdev-${version}.tar.gz"
-checksum=c4c0e10b35ac632bda8ce6d200b5601184984dec387fe59185921eb42432e069
+checksum=82c9c841e28a74fecadedebfae6a772df623cecdf652e5376650fa26da5b7df4
 conf_files="/etc/libblockdev/conf.d/10-lvm-dbus.cfg
  /etc/libblockdev/conf.d/00-default.cfg"
 

Re: [PR REVIEW] libblockdev: update to 2.28.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40642#discussion_r1031000811

Comment:
```suggestion
changelog="https://raw.githubusercontent.com/storaged-project/libblockdev/${version%%.*}.x-branch/NEWS.rst"
```

Re: [PR PATCH] [Updated] libblockdev: update to 2.28.

[skmpz]

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

There is an updated pull request by skmpz against master on the void-packages repository

https://github.com/skmpz/void-packages libblockdev-2.28
https://github.com/void-linux/void-packages/pull/40642

libblockdev: update to 2.28.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40642.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libblockdev-2.28-40642.patch --]
[-- Type: text/x-diff, Size: 1520 bytes --]

From fcd3acd3bdfdabd52ad28f288d93b2f017cd6847 Mon Sep 17 00:00:00 2001
From: skmpz <dem.procopiou@gmail.com>
Date: Sun, 20 Nov 2022 15:50:03 +0400
Subject: [PATCH] libblockdev: update to 2.28.

---
 srcpkgs/libblockdev/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/libblockdev/template b/srcpkgs/libblockdev/template
index b857dd3b4678..309c98f417ee 100644
--- a/srcpkgs/libblockdev/template
+++ b/srcpkgs/libblockdev/template
@@ -1,7 +1,7 @@
 # Template file for 'libblockdev'
 pkgname=libblockdev
-version=2.26
-revision=2
+version=2.28
+revision=1
 build_style=gnu-configure
 hostmakedepends="pkg-config python3"
 makedepends="cryptsetup-devel device-mapper-devel dmraid-devel libbytesize-devel
@@ -11,9 +11,9 @@ short_desc="Library for manipulating block devices"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://github.com/storaged-project/libblockdev"
-changelog="https://raw.githubusercontent.com/storaged-project/libblockdev/master/NEWS.rst"
+changelog="https://raw.githubusercontent.com/storaged-project/libblockdev/${version%%.*}.x-branch/NEWS.rst"
 distfiles="https://github.com/storaged-project/libblockdev/releases/download/${version}-1/libblockdev-${version}.tar.gz"
-checksum=c4c0e10b35ac632bda8ce6d200b5601184984dec387fe59185921eb42432e069
+checksum=82c9c841e28a74fecadedebfae6a772df623cecdf652e5376650fa26da5b7df4
 conf_files="/etc/libblockdev/conf.d/10-lvm-dbus.cfg
  /etc/libblockdev/conf.d/00-default.cfg"
 

Re: [PR PATCH] [Updated] libblockdev: update to 2.28.

[skmpz]

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

There is an updated pull request by skmpz against master on the void-packages repository

https://github.com/skmpz/void-packages libblockdev-2.28
https://github.com/void-linux/void-packages/pull/40642

libblockdev: update to 2.28.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40642.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libblockdev-2.28-40642.patch --]
[-- Type: text/x-diff, Size: 1520 bytes --]

From 2de03ea02623833079eb8744395d17e33cc3a0a3 Mon Sep 17 00:00:00 2001
From: skmpz <dem.procopiou@gmail.com>
Date: Sun, 20 Nov 2022 15:50:03 +0400
Subject: [PATCH] libblockdev: update to 2.28.

---
 srcpkgs/libblockdev/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/libblockdev/template b/srcpkgs/libblockdev/template
index b857dd3b4678..309c98f417ee 100644
--- a/srcpkgs/libblockdev/template
+++ b/srcpkgs/libblockdev/template
@@ -1,7 +1,7 @@
 # Template file for 'libblockdev'
 pkgname=libblockdev
-version=2.26
-revision=2
+version=2.28
+revision=1
 build_style=gnu-configure
 hostmakedepends="pkg-config python3"
 makedepends="cryptsetup-devel device-mapper-devel dmraid-devel libbytesize-devel
@@ -11,9 +11,9 @@ short_desc="Library for manipulating block devices"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://github.com/storaged-project/libblockdev"
-changelog="https://raw.githubusercontent.com/storaged-project/libblockdev/master/NEWS.rst"
+changelog="https://raw.githubusercontent.com/storaged-project/libblockdev/${version%%.*}.x-branch/NEWS.rst"
 distfiles="https://github.com/storaged-project/libblockdev/releases/download/${version}-1/libblockdev-${version}.tar.gz"
-checksum=c4c0e10b35ac632bda8ce6d200b5601184984dec387fe59185921eb42432e069
+checksum=82c9c841e28a74fecadedebfae6a772df623cecdf652e5376650fa26da5b7df4
 conf_files="/etc/libblockdev/conf.d/10-lvm-dbus.cfg
  /etc/libblockdev/conf.d/00-default.cfg"
 

Re: [PR REVIEW] libblockdev: update to 2.28.

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

New review comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/40642#discussion_r1088168181

Comment:
This breaks copy and pasting the changelog url to the browser so as to help review the changes. Please make this just `2.x-branch` and comment above it "This needs to be adjusted as the major version changes."

I'm hesitant to want 2 versions of changelog=, one commented and one not, since the field was introduced primarily so reviewers could quickly reference a list of changes.

Re: [PR PATCH] [Updated] libblockdev: update to 2.28.

[skmpz]

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

There is an updated pull request by skmpz against master on the void-packages repository

https://github.com/skmpz/void-packages libblockdev-2.28
https://github.com/void-linux/void-packages/pull/40642

libblockdev: update to 2.28.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40642.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libblockdev-2.28-40642.patch --]
[-- Type: text/x-diff, Size: 1568 bytes --]

From d85c7a9902a578c8392c20f21bdb6514e33ba3e0 Mon Sep 17 00:00:00 2001
From: skmpz <dem.procopiou@gmail.com>
Date: Sun, 20 Nov 2022 15:50:03 +0400
Subject: [PATCH] libblockdev: update to 2.28.

---
 srcpkgs/libblockdev/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/libblockdev/template b/srcpkgs/libblockdev/template
index b857dd3b4678..c3287673749e 100644
--- a/srcpkgs/libblockdev/template
+++ b/srcpkgs/libblockdev/template
@@ -1,7 +1,7 @@
 # Template file for 'libblockdev'
 pkgname=libblockdev
-version=2.26
-revision=2
+version=2.28
+revision=1
 build_style=gnu-configure
 hostmakedepends="pkg-config python3"
 makedepends="cryptsetup-devel device-mapper-devel dmraid-devel libbytesize-devel
@@ -11,9 +11,10 @@ short_desc="Library for manipulating block devices"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://github.com/storaged-project/libblockdev"
-changelog="https://raw.githubusercontent.com/storaged-project/libblockdev/master/NEWS.rst"
+# changelog needs to be adjusted on major version changes
+changelog="https://raw.githubusercontent.com/storaged-project/libblockdev/2.x-branch/NEWS.rst"
 distfiles="https://github.com/storaged-project/libblockdev/releases/download/${version}-1/libblockdev-${version}.tar.gz"
-checksum=c4c0e10b35ac632bda8ce6d200b5601184984dec387fe59185921eb42432e069
+checksum=82c9c841e28a74fecadedebfae6a772df623cecdf652e5376650fa26da5b7df4
 conf_files="/etc/libblockdev/conf.d/10-lvm-dbus.cfg
  /etc/libblockdev/conf.d/00-default.cfg"
 

Re: [PR PATCH] [Merged]: libblockdev: update to 2.28.

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

There's a merged pull request on the void-packages repository

libblockdev: update to 2.28.
https://github.com/void-linux/void-packages/pull/40642

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Re: libblockdev: update to 2.28.

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/40642#issuecomment-1405454921

Comment:
Thank you!