[PR PATCH] python3-cypari2: reenable full testsuite

[PR PATCH] python3-cypari2: reenable full testsuite

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages python3-cypari2
https://github.com/void-linux/void-packages/pull/40667

python3-cypari2: reenable full testsuite
Note that running pytest will run a few tests, but running `make check` will run many more tests (including all the pytest tests).

No need to revbump as there are no changes to package itself.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40667.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-cypari2-40667.patch --]
[-- Type: text/x-diff, Size: 1111 bytes --]

From 5d1c023441067147080e259e53457f6237b7d586 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 21 Nov 2022 12:55:27 -0300
Subject: [PATCH] python3-cypari2: reenable full testsuite

Note that running pytest will run a few tests, but running `make check`
will run many more tests (including all the pytest tests).

No need to revbump as there are no changes to package itself.
---
 srcpkgs/python3-cypari2/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/python3-cypari2/template b/srcpkgs/python3-cypari2/template
index a8ef86740ec4..8ac4dd3a5624 100644
--- a/srcpkgs/python3-cypari2/template
+++ b/srcpkgs/python3-cypari2/template
@@ -15,5 +15,7 @@ distfiles="https://github.com/sagemath/cypari2/archive/refs/tags/${version}.tar.
 checksum=6f6f6ca2b2c2dbef4444727e8fb8652b090cfac4297ba959e94b3a91bbd86548
 
 do_check() {
-	PYTHONPATH=$(cd build/lib* && pwd) pytest
+	# Please do not disable this custom check;
+	# This will run many more tests than just running pytest
+	PYTHONPATH=$(cd build/lib* && pwd) make check
 }

Re: python3-cypari2: reenable full testsuite

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/40667#issuecomment-1322587162

Comment:
Some related reasoning for the change is in [this thread](https://github.com/void-linux/void-packages/pull/40569#discussion_r1025051561)

Re: python3-cypari2: reenable full testsuite

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/40667#issuecomment-1322666358

Comment:
> Some related reasoning for the change is in [this thread](https://github.com/void-linux/void-packages/pull/40569#discussion_r1025051561)

That is just as mistaken as it is here. I agree with "prefer using pytest" if upstream supports that. But both python3-cypari2 and python3-pplpy do not support running tests using pytest. Both are misleading in the sense that pytest will seemingly succeed while not running the real testsuite.

Re: [PR PATCH] [Merged]: python3-cypari2: reenable full testsuite

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

There's a merged pull request on the void-packages repository

python3-cypari2: reenable full testsuite
https://github.com/void-linux/void-packages/pull/40667

Description:
Note that running pytest will run a few tests, but running `make check` will run many more tests (including all the pytest tests).

No need to revbump as there are no changes to package itself.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->