[PR PATCH] New package: ibus-chewing, ibus-array: add runtime dep.

[PR PATCH] New package: ibus-chewing, ibus-array: add runtime dep.

[funk443]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

There is a new pull request by funk443 against master on the void-packages repository

https://github.com/funk443/void-packages master
https://github.com/void-linux/void-packages/pull/40710

New package: ibus-chewing, ibus-array: add runtime dep.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/40710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-40710.patch --]
[-- Type: text/x-diff, Size: 4417 bytes --]

From f5a648ad2c3e53a0df0cc29376987d3d4e22616b Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Wed, 23 Nov 2022 23:23:43 +0800
Subject: [PATCH 1/4] New package: ibus-chewing-1.5.1

---
 srcpkgs/ibus-chewing/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/ibus-chewing/template

diff --git a/srcpkgs/ibus-chewing/template b/srcpkgs/ibus-chewing/template
new file mode 100644
index 000000000000..ee8f5d6717de
--- /dev/null
+++ b/srcpkgs/ibus-chewing/template
@@ -0,0 +1,30 @@
+# Template file for 'ibus-chewing'
+pkgname=ibus-chewing
+version=1.5.1
+revision=1
+archs="x86_64"
+build_style=gnu-makefile
+hostmakedepends="git cmake pkg-config"
+makedepends="gettext-devel libchewing-devel ibus-devel gob2 libX11-devel gtk+3-devel glib-devel findutils"
+depends="ibus libchewing"
+short_desc="Chewing input method for ibus"
+maintainer="ctoid <funk443@yandex.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/definite/ibus-chewing"
+
+do_fetch() {
+	git clone https://github.com/definite/ibus-chewing.git $wrksrc
+}
+
+pre_configure() {
+	rm -rf cmake-fedora
+	git clone https://pagure.io/cmake-fedora.git
+}
+
+do_configure() {
+	cmake . -DCMAKE_INSTALL_PREFIX='/usr' -DLIBEXEC_DIR='/usr/libexec'
+}
+
+post_install() {
+	glib-compile-schemas /usr/share/glib-2.0/schemas
+}

From c3b3d25a8e0f681f2aff8c2bfbdf1ef6a6918699 Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Wed, 23 Nov 2022 23:25:46 +0800
Subject: [PATCH 2/4] ibus-array: Add a runtime dep.

---
 srcpkgs/ibus-array/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/ibus-array/template b/srcpkgs/ibus-array/template
index 14462250e789..f5392e3bd92c 100644
--- a/srcpkgs/ibus-array/template
+++ b/srcpkgs/ibus-array/template
@@ -1,10 +1,11 @@
 # Template file for 'ibus-array'
 pkgname=ibus-array
 version=0.2.2
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="automake pkg-config python3 gettext-devel libtool"
 makedepends="ibus-devel gettext-devel sqlite-devel"
+depends="ibus"
 short_desc="Array 30 engine for iBus"
 maintainer="CToID <funk443@yandex.com>"
 license="GPL-2.0-or-later"

From a39a93103ae28c1d6460554e62742118d924ec20 Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Wed, 23 Nov 2022 23:23:43 +0800
Subject: [PATCH 3/4] New package: ibus-chewing-1.5.1

---
 srcpkgs/ibus-chewing/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/ibus-chewing/template

diff --git a/srcpkgs/ibus-chewing/template b/srcpkgs/ibus-chewing/template
new file mode 100644
index 000000000000..ee8f5d6717de
--- /dev/null
+++ b/srcpkgs/ibus-chewing/template
@@ -0,0 +1,30 @@
+# Template file for 'ibus-chewing'
+pkgname=ibus-chewing
+version=1.5.1
+revision=1
+archs="x86_64"
+build_style=gnu-makefile
+hostmakedepends="git cmake pkg-config"
+makedepends="gettext-devel libchewing-devel ibus-devel gob2 libX11-devel gtk+3-devel glib-devel findutils"
+depends="ibus libchewing"
+short_desc="Chewing input method for ibus"
+maintainer="ctoid <funk443@yandex.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/definite/ibus-chewing"
+
+do_fetch() {
+	git clone https://github.com/definite/ibus-chewing.git $wrksrc
+}
+
+pre_configure() {
+	rm -rf cmake-fedora
+	git clone https://pagure.io/cmake-fedora.git
+}
+
+do_configure() {
+	cmake . -DCMAKE_INSTALL_PREFIX='/usr' -DLIBEXEC_DIR='/usr/libexec'
+}
+
+post_install() {
+	glib-compile-schemas /usr/share/glib-2.0/schemas
+}

From aee3fae4b43d1a35a02ef107851422347274c865 Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Wed, 23 Nov 2022 23:25:46 +0800
Subject: [PATCH 4/4] ibus-array: Add a runtime dep.

---
 srcpkgs/ibus-array/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/ibus-array/template b/srcpkgs/ibus-array/template
index 14462250e789..f5392e3bd92c 100644
--- a/srcpkgs/ibus-array/template
+++ b/srcpkgs/ibus-array/template
@@ -1,10 +1,11 @@
 # Template file for 'ibus-array'
 pkgname=ibus-array
 version=0.2.2
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="automake pkg-config python3 gettext-devel libtool"
 makedepends="ibus-devel gettext-devel sqlite-devel"
+depends="ibus"
 short_desc="Array 30 engine for iBus"
 maintainer="CToID <funk443@yandex.com>"
 license="GPL-2.0-or-later"

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1030709380

Comment:
ibus-array already depends on ibus, you can confirm using `xbps-query -Rx ibus-array`.
(it should be added in the "collect rundeps" step)

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1030710776

Comment:
We don't generally accept packages using git clone. We definitely will not accept a package using git and cloning straight to the master branch.

Please use tagged releases whenever possible, and use proper distfiles whenever possible.

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1030712271

Comment:
For this, you shouldn't need to add a custom do_configure, you should be able to just do `configure_args`.

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1030713606

Comment:
Why is this restricted to x86_64? (if, for example, it doesn't cross compile, it should instead be marked as nocross)

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1030714445

Comment:
`makedepends` is for library dependencies, `hostmakedepends` is for application dependencies, `gettext-devel` should be in `hostmakedepends`, I imagine `findutils` should be as well.

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1030709380

Comment:
ibus-array already depends on ibus, you can confirm using `xbps-query -Rx ibus-array`.
(it should already be added in the "collect rundeps" step)

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1030712271

Comment:
For this, you shouldn't need to add a custom do_configure, you should be able to just use `configure_args`.

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1030713606

Comment:
Why is this restricted to x86_64? (if, for example, it simply cannot be cross compiled, it should instead be marked as nocross)

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1030714445

Comment:
`makedepends` is for library dependencies, `hostmakedepends` is for applications that need to run during the build, `gettext-devel` should be in `hostmakedepends`, I imagine `findutils` should be as well.

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1030712271

Comment:
For this, you shouldn't need to add a custom do_configure, you should be able to just use `configure_args`.
https://github.com/void-linux/void-packages/blob/master/Manual.md

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1030954461

Comment:
and `-DCMAKE_INSTALL_PREFIX='/usr'` is already defined in the build-style so it doesn't need to specified.

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1031023413

Comment:
Please don't do this.

Re: [PR PATCH] [Updated] New package: ibus-chewing, ibus-array: add runtime dep.

[funk443]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

There is an updated pull request by funk443 against master on the void-packages repository

https://github.com/funk443/void-packages master
https://github.com/void-linux/void-packages/pull/40710

New package: ibus-chewing, ibus-array: add runtime dep.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/40710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-40710.patch --]
[-- Type: text/x-diff, Size: 2208 bytes --]

From a39a93103ae28c1d6460554e62742118d924ec20 Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Wed, 23 Nov 2022 23:23:43 +0800
Subject: [PATCH 1/2] New package: ibus-chewing-1.5.1

---
 srcpkgs/ibus-chewing/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/ibus-chewing/template

diff --git a/srcpkgs/ibus-chewing/template b/srcpkgs/ibus-chewing/template
new file mode 100644
index 000000000000..ee8f5d6717de
--- /dev/null
+++ b/srcpkgs/ibus-chewing/template
@@ -0,0 +1,30 @@
+# Template file for 'ibus-chewing'
+pkgname=ibus-chewing
+version=1.5.1
+revision=1
+archs="x86_64"
+build_style=gnu-makefile
+hostmakedepends="git cmake pkg-config"
+makedepends="gettext-devel libchewing-devel ibus-devel gob2 libX11-devel gtk+3-devel glib-devel findutils"
+depends="ibus libchewing"
+short_desc="Chewing input method for ibus"
+maintainer="ctoid <funk443@yandex.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/definite/ibus-chewing"
+
+do_fetch() {
+	git clone https://github.com/definite/ibus-chewing.git $wrksrc
+}
+
+pre_configure() {
+	rm -rf cmake-fedora
+	git clone https://pagure.io/cmake-fedora.git
+}
+
+do_configure() {
+	cmake . -DCMAKE_INSTALL_PREFIX='/usr' -DLIBEXEC_DIR='/usr/libexec'
+}
+
+post_install() {
+	glib-compile-schemas /usr/share/glib-2.0/schemas
+}

From aee3fae4b43d1a35a02ef107851422347274c865 Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Wed, 23 Nov 2022 23:25:46 +0800
Subject: [PATCH 2/2] ibus-array: Add a runtime dep.

---
 srcpkgs/ibus-array/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/ibus-array/template b/srcpkgs/ibus-array/template
index 14462250e789..f5392e3bd92c 100644
--- a/srcpkgs/ibus-array/template
+++ b/srcpkgs/ibus-array/template
@@ -1,10 +1,11 @@
 # Template file for 'ibus-array'
 pkgname=ibus-array
 version=0.2.2
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="automake pkg-config python3 gettext-devel libtool"
 makedepends="ibus-devel gettext-devel sqlite-devel"
+depends="ibus"
 short_desc="Array 30 engine for iBus"
 maintainer="CToID <funk443@yandex.com>"
 license="GPL-2.0-or-later"

Re: [PR PATCH] [Updated] New package: ibus-chewing, ibus-array: add runtime dep.

[funk443]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

There is an updated pull request by funk443 against master on the void-packages repository

https://github.com/funk443/void-packages master
https://github.com/void-linux/void-packages/pull/40710

New package: ibus-chewing, ibus-array: add runtime dep.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/40710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-40710.patch --]
[-- Type: text/x-diff, Size: 1355 bytes --]

From a39a93103ae28c1d6460554e62742118d924ec20 Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Wed, 23 Nov 2022 23:23:43 +0800
Subject: [PATCH] New package: ibus-chewing-1.5.1

---
 srcpkgs/ibus-chewing/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/ibus-chewing/template

diff --git a/srcpkgs/ibus-chewing/template b/srcpkgs/ibus-chewing/template
new file mode 100644
index 000000000000..ee8f5d6717de
--- /dev/null
+++ b/srcpkgs/ibus-chewing/template
@@ -0,0 +1,30 @@
+# Template file for 'ibus-chewing'
+pkgname=ibus-chewing
+version=1.5.1
+revision=1
+archs="x86_64"
+build_style=gnu-makefile
+hostmakedepends="git cmake pkg-config"
+makedepends="gettext-devel libchewing-devel ibus-devel gob2 libX11-devel gtk+3-devel glib-devel findutils"
+depends="ibus libchewing"
+short_desc="Chewing input method for ibus"
+maintainer="ctoid <funk443@yandex.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/definite/ibus-chewing"
+
+do_fetch() {
+	git clone https://github.com/definite/ibus-chewing.git $wrksrc
+}
+
+pre_configure() {
+	rm -rf cmake-fedora
+	git clone https://pagure.io/cmake-fedora.git
+}
+
+do_configure() {
+	cmake . -DCMAKE_INSTALL_PREFIX='/usr' -DLIBEXEC_DIR='/usr/libexec'
+}
+
+post_install() {
+	glib-compile-schemas /usr/share/glib-2.0/schemas
+}

Re: [PR PATCH] [Updated] New package: ibus-chewing, ibus-array: add runtime dep.

[funk443]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

There is an updated pull request by funk443 against master on the void-packages repository

https://github.com/funk443/void-packages master
https://github.com/void-linux/void-packages/pull/40710

New package: ibus-chewing, ibus-array: add runtime dep.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/40710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-40710.patch --]
[-- Type: text/x-diff, Size: 3098 bytes --]

From a39a93103ae28c1d6460554e62742118d924ec20 Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Wed, 23 Nov 2022 23:23:43 +0800
Subject: [PATCH 1/2] New package: ibus-chewing-1.5.1

---
 srcpkgs/ibus-chewing/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/ibus-chewing/template

diff --git a/srcpkgs/ibus-chewing/template b/srcpkgs/ibus-chewing/template
new file mode 100644
index 000000000000..ee8f5d6717de
--- /dev/null
+++ b/srcpkgs/ibus-chewing/template
@@ -0,0 +1,30 @@
+# Template file for 'ibus-chewing'
+pkgname=ibus-chewing
+version=1.5.1
+revision=1
+archs="x86_64"
+build_style=gnu-makefile
+hostmakedepends="git cmake pkg-config"
+makedepends="gettext-devel libchewing-devel ibus-devel gob2 libX11-devel gtk+3-devel glib-devel findutils"
+depends="ibus libchewing"
+short_desc="Chewing input method for ibus"
+maintainer="ctoid <funk443@yandex.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/definite/ibus-chewing"
+
+do_fetch() {
+	git clone https://github.com/definite/ibus-chewing.git $wrksrc
+}
+
+pre_configure() {
+	rm -rf cmake-fedora
+	git clone https://pagure.io/cmake-fedora.git
+}
+
+do_configure() {
+	cmake . -DCMAKE_INSTALL_PREFIX='/usr' -DLIBEXEC_DIR='/usr/libexec'
+}
+
+post_install() {
+	glib-compile-schemas /usr/share/glib-2.0/schemas
+}

From 631e913de961b58e8074dd33ad5c6b78b4d73f4a Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Thu, 24 Nov 2022 19:13:09 +0800
Subject: [PATCH 2/2] ibus-chewing: update to 1.5.1.

---
 srcpkgs/ibus-chewing/template | 24 +++++++++---------------
 1 file changed, 9 insertions(+), 15 deletions(-)

diff --git a/srcpkgs/ibus-chewing/template b/srcpkgs/ibus-chewing/template
index ee8f5d6717de..361a71647a2a 100644
--- a/srcpkgs/ibus-chewing/template
+++ b/srcpkgs/ibus-chewing/template
@@ -3,28 +3,22 @@ pkgname=ibus-chewing
 version=1.5.1
 revision=1
 archs="x86_64"
-build_style=gnu-makefile
-hostmakedepends="git cmake pkg-config"
-makedepends="gettext-devel libchewing-devel ibus-devel gob2 libX11-devel gtk+3-devel glib-devel findutils"
+build_style=cmake
+configure_args="-DLIBEXEC_DIR=/usr/libexec"
+make_cmd=make
+hostmakedepends="git cmake pkg-config findutils gettext-devel"
+makedepends="libchewing-devel ibus-devel gob2 libX11-devel gtk+-devel glib-devel"
 depends="ibus libchewing"
 short_desc="Chewing input method for ibus"
 maintainer="ctoid <funk443@yandex.com>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/definite/ibus-chewing"
-
-do_fetch() {
-	git clone https://github.com/definite/ibus-chewing.git $wrksrc
-}
+distfiles="https://github.com/definite/ibus-chewing/archive/refs/tags/${version}.tar.gz"
+checksum="4c0b58e9b13b826969d8df6276275bbd893a4a6d665cc218a65aa3eecde00d53"
+nocross=yes
 
 pre_configure() {
 	rm -rf cmake-fedora
 	git clone https://pagure.io/cmake-fedora.git
-}
-
-do_configure() {
-	cmake . -DCMAKE_INSTALL_PREFIX='/usr' -DLIBEXEC_DIR='/usr/libexec'
-}
-
-post_install() {
-	glib-compile-schemas /usr/share/glib-2.0/schemas
+	export CMAKE_GENERATOR="Unix Makefiles"
 }

Re: [PR REVIEW] New package: ibus-chewing, ibus-array: add runtime dep.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1031390979

Comment:
why is this needed?

Re: [PR PATCH] [Updated] New package: ibus-chewing, ibus-array: add runtime dep.

[funk443]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

There is an updated pull request by funk443 against master on the void-packages repository

https://github.com/funk443/void-packages master
https://github.com/void-linux/void-packages/pull/40710

New package: ibus-chewing, ibus-array: add runtime dep.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/40710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-40710.patch --]
[-- Type: text/x-diff, Size: 1373 bytes --]

From 54833756b9444892b39cf4fe7d91eec34943683f Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Thu, 24 Nov 2022 19:18:39 +0800
Subject: [PATCH] New package: ibus-chewing-1.5.1

---
 srcpkgs/ibus-chewing/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/ibus-chewing/template

diff --git a/srcpkgs/ibus-chewing/template b/srcpkgs/ibus-chewing/template
new file mode 100644
index 000000000000..361a71647a2a
--- /dev/null
+++ b/srcpkgs/ibus-chewing/template
@@ -0,0 +1,24 @@
+# Template file for 'ibus-chewing'
+pkgname=ibus-chewing
+version=1.5.1
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DLIBEXEC_DIR=/usr/libexec"
+make_cmd=make
+hostmakedepends="git cmake pkg-config findutils gettext-devel"
+makedepends="libchewing-devel ibus-devel gob2 libX11-devel gtk+-devel glib-devel"
+depends="ibus libchewing"
+short_desc="Chewing input method for ibus"
+maintainer="ctoid <funk443@yandex.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/definite/ibus-chewing"
+distfiles="https://github.com/definite/ibus-chewing/archive/refs/tags/${version}.tar.gz"
+checksum="4c0b58e9b13b826969d8df6276275bbd893a4a6d665cc218a65aa3eecde00d53"
+nocross=yes
+
+pre_configure() {
+	rm -rf cmake-fedora
+	git clone https://pagure.io/cmake-fedora.git
+	export CMAKE_GENERATOR="Unix Makefiles"
+}

Re: [PR PATCH] [Updated] New package: ibus-chewing, ibus-array: add runtime dep.

[funk443]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

There is an updated pull request by funk443 against master on the void-packages repository

https://github.com/funk443/void-packages master
https://github.com/void-linux/void-packages/pull/40710

New package: ibus-chewing, ibus-array: add runtime dep.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/40710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-40710.patch --]
[-- Type: text/x-diff, Size: 1373 bytes --]

From 54833756b9444892b39cf4fe7d91eec34943683f Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Thu, 24 Nov 2022 19:18:39 +0800
Subject: [PATCH] New package: ibus-chewing-1.5.1

---
 srcpkgs/ibus-chewing/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/ibus-chewing/template

diff --git a/srcpkgs/ibus-chewing/template b/srcpkgs/ibus-chewing/template
new file mode 100644
index 000000000000..361a71647a2a
--- /dev/null
+++ b/srcpkgs/ibus-chewing/template
@@ -0,0 +1,24 @@
+# Template file for 'ibus-chewing'
+pkgname=ibus-chewing
+version=1.5.1
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DLIBEXEC_DIR=/usr/libexec"
+make_cmd=make
+hostmakedepends="git cmake pkg-config findutils gettext-devel"
+makedepends="libchewing-devel ibus-devel gob2 libX11-devel gtk+-devel glib-devel"
+depends="ibus libchewing"
+short_desc="Chewing input method for ibus"
+maintainer="ctoid <funk443@yandex.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/definite/ibus-chewing"
+distfiles="https://github.com/definite/ibus-chewing/archive/refs/tags/${version}.tar.gz"
+checksum="4c0b58e9b13b826969d8df6276275bbd893a4a6d665cc218a65aa3eecde00d53"
+nocross=yes
+
+pre_configure() {
+	rm -rf cmake-fedora
+	git clone https://pagure.io/cmake-fedora.git
+	export CMAKE_GENERATOR="Unix Makefiles"
+}

Re: [PR PATCH] [Updated] New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

There is an updated pull request by funk443 against master on the void-packages repository

https://github.com/funk443/void-packages master
https://github.com/void-linux/void-packages/pull/40710

New package: ibus-chewing
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/40710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-40710.patch --]
[-- Type: text/x-diff, Size: 1373 bytes --]

From 54833756b9444892b39cf4fe7d91eec34943683f Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Thu, 24 Nov 2022 19:18:39 +0800
Subject: [PATCH] New package: ibus-chewing-1.5.1

---
 srcpkgs/ibus-chewing/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/ibus-chewing/template

diff --git a/srcpkgs/ibus-chewing/template b/srcpkgs/ibus-chewing/template
new file mode 100644
index 000000000000..361a71647a2a
--- /dev/null
+++ b/srcpkgs/ibus-chewing/template
@@ -0,0 +1,24 @@
+# Template file for 'ibus-chewing'
+pkgname=ibus-chewing
+version=1.5.1
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DLIBEXEC_DIR=/usr/libexec"
+make_cmd=make
+hostmakedepends="git cmake pkg-config findutils gettext-devel"
+makedepends="libchewing-devel ibus-devel gob2 libX11-devel gtk+-devel glib-devel"
+depends="ibus libchewing"
+short_desc="Chewing input method for ibus"
+maintainer="ctoid <funk443@yandex.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/definite/ibus-chewing"
+distfiles="https://github.com/definite/ibus-chewing/archive/refs/tags/${version}.tar.gz"
+checksum="4c0b58e9b13b826969d8df6276275bbd893a4a6d665cc218a65aa3eecde00d53"
+nocross=yes
+
+pre_configure() {
+	rm -rf cmake-fedora
+	git clone https://pagure.io/cmake-fedora.git
+	export CMAKE_GENERATOR="Unix Makefiles"
+}

Re: [PR REVIEW] New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by funk443 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1031397460

Comment:
You mean the cmake-fedora part?

Re: [PR PATCH] [Updated] New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

There is an updated pull request by funk443 against master on the void-packages repository

https://github.com/funk443/void-packages master
https://github.com/void-linux/void-packages/pull/40710

New package: ibus-chewing
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/40710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-40710.patch --]
[-- Type: text/x-diff, Size: 1411 bytes --]

From 5cc2d806611cef44647dbad924243841995687a9 Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Thu, 24 Nov 2022 19:18:39 +0800
Subject: [PATCH] New package: ibus-chewing-1.5.1

---
 srcpkgs/ibus-chewing/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/ibus-chewing/template

diff --git a/srcpkgs/ibus-chewing/template b/srcpkgs/ibus-chewing/template
new file mode 100644
index 000000000000..e71babd65d92
--- /dev/null
+++ b/srcpkgs/ibus-chewing/template
@@ -0,0 +1,25 @@
+# Template file for 'ibus-chewing'
+pkgname=ibus-chewing
+version=1.5.1
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DLIBEXEC_DIR=/usr/libexec"
+make_cmd=make
+hostmakedepends="git cmake pkg-config findutils gettext-devel"
+makedepends="libchewing-devel ibus-devel gob2 libX11-devel gtk+-devel glib-devel"
+depends="ibus libchewing"
+short_desc="Chewing input method for ibus"
+maintainer="ctoid <funk443@yandex.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/definite/ibus-chewing"
+distfiles="https://github.com/definite/ibus-chewing/archive/refs/tags/${version}.tar.gz"
+checksum="4c0b58e9b13b826969d8df6276275bbd893a4a6d665cc218a65aa3eecde00d53"
+nocross=yes
+make_check=no  # No idea how to fix
+
+pre_configure() {
+	rm -rf cmake-fedora
+	git clone https://pagure.io/cmake-fedora.git
+	export CMAKE_GENERATOR="Unix Makefiles"
+}

Re: [PR REVIEW] New package: ibus-chewing

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1031440470

Comment:
Yes, if the project actually depends on a specific git submodule, we generally add new distfile (tar.gz for a specific commit) to it and move it into the right place.

Re: [PR REVIEW] New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by funk443 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1031461854

Comment:
I added this part because the original cmake-fedora host is no longer available.

Re: [PR PATCH] [Updated] New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

There is an updated pull request by funk443 against master on the void-packages repository

https://github.com/funk443/void-packages master
https://github.com/void-linux/void-packages/pull/40710

New package: ibus-chewing
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/40710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-40710.patch --]
[-- Type: text/x-diff, Size: 1558 bytes --]

From 96c5a57abe752200fe128d8a4b6e0cce0c959715 Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Thu, 24 Nov 2022 19:18:39 +0800
Subject: [PATCH] New package: ibus-chewing-1.5.1

---
 srcpkgs/ibus-chewing/template | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 srcpkgs/ibus-chewing/template

diff --git a/srcpkgs/ibus-chewing/template b/srcpkgs/ibus-chewing/template
new file mode 100644
index 000000000000..e027957cbd2d
--- /dev/null
+++ b/srcpkgs/ibus-chewing/template
@@ -0,0 +1,26 @@
+# Template file for 'ibus-chewing'
+pkgname=ibus-chewing
+version=1.5.1
+revision=1
+archs="x86_64"
+build_wrksrc=ibus-chewing-1.5.1
+build_style=cmake
+configure_args="-DLIBEXEC_DIR=/usr/libexec"
+make_cmd=make
+hostmakedepends="git cmake pkg-config findutils gettext-devel"
+makedepends="libchewing-devel ibus-devel gob2 libX11-devel gtk+-devel glib-devel"
+depends="ibus libchewing"
+short_desc="Chewing input method for ibus"
+maintainer="ctoid <funk443@yandex.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/definite/ibus-chewing"
+distfiles="https://github.com/definite/ibus-chewing/archive/refs/tags/${version}.tar.gz https://pagure.io/cmake-fedora/archive/2.9.3/cmake-fedora-2.9.3.tar.gz"
+checksum="4c0b58e9b13b826969d8df6276275bbd893a4a6d665cc218a65aa3eecde00d53
+ 291b6d6ea1381d6d7f7d49e9b9a6f5ca5cbfeaed81b58f591dfcd0781e5de68c"
+nocross=yes
+make_check=no  # No idea how to fix
+
+pre_configure() {
+	mv ../cmake-fedora-2.9.3/* ./cmake-fedora
+	export CMAKE_GENERATOR="Unix Makefiles"
+}

Re: [PR REVIEW] New package: ibus-chewing

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1031799352

Comment:
I didn't notice this earlier, sorry, but I don't believe new gtk2 packages will be accepted.

Re: [PR REVIEW] New package: ibus-chewing

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1031799352

Comment:
New gtk2 packages aren't going to be accepted.
And the gtk3 version doesn't have a tagged release.

https://github.com/definite/ibus-chewing/issues/162
There is an open issue to create a new release, but it has received no response.

Re: [PR REVIEW] New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by funk443 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1032008770

Comment:
Ya, that's why I directly cloned the repo before, instead of downloading the realeases.  

Re: [PR REVIEW] New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New review comment by funk443 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1032008770

Comment:
Ya, that's why I directly cloned the repo before, instead of downloading the realeases.  The git version of the package has been ported to gtk3, but not released.  

Re: [PR REVIEW] New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

New review comment by funk443 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1032008770

Comment:
Ya, that's why I directly cloned the repo before, instead of downloading the realeases.  The git version of the package has been ported to gtk3, but it is not released.  

Re: [PR PATCH] [Updated] New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

There is an updated pull request by funk443 against master on the void-packages repository

https://github.com/funk443/void-packages master
https://github.com/void-linux/void-packages/pull/40710

New package: ibus-chewing
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/40710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-40710.patch --]
[-- Type: text/x-diff, Size: 1567 bytes --]

From e52dfd278a9320a2e04ef359cc2f02f93c8491e5 Mon Sep 17 00:00:00 2001
From: ctoid <funk443@yandex.com>
Date: Thu, 24 Nov 2022 19:18:39 +0800
Subject: [PATCH] New package: ibus-chewing-1.5.1

---
 srcpkgs/ibus-chewing/template | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 srcpkgs/ibus-chewing/template

diff --git a/srcpkgs/ibus-chewing/template b/srcpkgs/ibus-chewing/template
new file mode 100644
index 000000000000..74aa0b5167e5
--- /dev/null
+++ b/srcpkgs/ibus-chewing/template
@@ -0,0 +1,26 @@
+# Template file for 'ibus-chewing'
+pkgname=ibus-chewing
+version=1.5.2
+revision=1
+archs="x86_64"
+build_wrksrc=ibus-chewing-1-${version}
+build_style=cmake
+configure_args="-DLIBEXEC_DIR=/usr/libexec"
+make_cmd=make
+hostmakedepends="git cmake pkg-config findutils gettext-devel"
+makedepends="libchewing-devel ibus-devel gob2 libX11-devel gtk+3-devel glib-devel"
+depends="ibus libchewing"
+short_desc="Chewing input method for ibus"
+maintainer="ctoid <funk443@yandex.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/definite/ibus-chewing"
+distfiles="https://github.com/funk443/ibus-chewing-1/archive/refs/tags/${version}.tar.gz https://pagure.io/cmake-fedora/archive/2.9.3/cmake-fedora-2.9.3.tar.gz"
+checksum="ea1c750dd1bda11f67870cf102d176a34d0759f27121985f12c86593c09c465b
+ 291b6d6ea1381d6d7f7d49e9b9a6f5ca5cbfeaed81b58f591dfcd0781e5de68c"
+nocross=yes
+make_check=no  # No idea how to fix
+
+pre_configure() {
+	mv ../cmake-fedora-2.9.3/* ./cmake-fedora
+	export CMAKE_GENERATOR="Unix Makefiles"
+}

Re: [PR REVIEW] New package: ibus-chewing

[paper42]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1032955420

Comment:
You can get a tarball at a specific commit from GitHub. I don't think this meets quality requirements, it either uses GTK2 or it doesn't have a release.

Re: [PR REVIEW] New package: ibus-chewing

[paper42]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1032955610

Comment:
This was not resolved, please don't mark it resolved 

Re: [PR REVIEW] New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by funk443 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1032959902

Comment:
I just simply fork it, and release the latest commit by myself.  

Re: [PR REVIEW] New package: ibus-chewing

[paper42]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1032966211

Comment:
No, that's equivalent to just not using a release. A release is required because the developers know the best when the code is stable and usable. If we packaged the latest commit, we would have to figure out issues on our own and the maintenance burden would be much higher.

Re: [PR REVIEW] New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New review comment by funk443 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1032977384

Comment:
Oh, ok then...  What should I do?

Re: [PR REVIEW] New package: ibus-chewing

[paper42]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1032978043

Comment:
It's not acceptable right now.

Re: [PR REVIEW] New package: ibus-chewing

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1032978203

Comment:
you could ask upstream to make a release

Re: [PR REVIEW] New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by funk443 on void-packages repository

https://github.com/void-linux/void-packages/pull/40710#discussion_r1032978446

Comment:
All right then, sorry for wasting you guys so much time.  

Re: [PR PATCH] [Closed]: New package: ibus-chewing

[funk443]

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

There's a closed pull request on the void-packages repository

New package: ibus-chewing
https://github.com/void-linux/void-packages/pull/40710

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc