Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] river: add missing libevdev-devel, remove git from hostmakedepends
@ 2022-11-24 18:25 kruceter
  2022-11-26 15:14 ` paper42
  2022-11-26 17:58 ` [PR PATCH] [Merged]: " paper42
  0 siblings, 2 replies; 3+ messages in thread
From: kruceter @ 2022-11-24 18:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

There is a new pull request by kruceter against master on the void-packages repository

https://github.com/kruceter/void-packages river
https://github.com/void-linux/void-packages/pull/40738

river: add missing libevdev-devel, remove git from hostmakedepends
I do not use wayland, but maybe someone else around does. 

Incrementing revision is not needed; the current revision already depends on libevdev.

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l-musl (cross)


A patch file from https://github.com/void-linux/void-packages/pull/40738.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-river-40738.patch --]
[-- Type: text/x-diff, Size: 1012 bytes --]

From a9af6c53cb6720f71c0070cf2a1d239463b35f93 Mon Sep 17 00:00:00 2001
From: Krul Ceter <kruceter@proton.me>
Date: Thu, 24 Nov 2022 21:09:52 +0300
Subject: [PATCH] river: add missing libevdev-devel, remove git from
 hostmakedepends

* libevdev-devel is required to build the package.

* git is not used for tarball releases.
---
 srcpkgs/river/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/river/template b/srcpkgs/river/template
index 9cf3abe4b85b..5c34a94799c9 100644
--- a/srcpkgs/river/template
+++ b/srcpkgs/river/template
@@ -4,8 +4,8 @@ version=0.1.1
 revision=1
 build_style=zig-build
 configure_args="$(vopt_if xwayland -Dxwayland)"
-hostmakedepends="pkg-config wayland-devel scdoc git"
-makedepends="wlroots-devel"
+hostmakedepends="pkg-config wayland-devel scdoc"
+makedepends="wlroots-devel libevdev-devel"
 depends="$(vopt_if xwayland xorg-server-xwayland)"
 short_desc="Dynamic tiling Wayland compositor"
 maintainer="Isaac Freund <mail@isaacfreund.com>"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: river: add missing libevdev-devel, remove git from hostmakedepends
  2022-11-24 18:25 [PR PATCH] river: add missing libevdev-devel, remove git from hostmakedepends kruceter
@ 2022-11-26 15:14 ` paper42
  2022-11-26 17:58 ` [PR PATCH] [Merged]: " paper42
  1 sibling, 0 replies; 3+ messages in thread
From: paper42 @ 2022-11-26 15:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40738#issuecomment-1328063919

Comment:
libevdev-devel used to be a dependency of one of the other build dependencies, but was removed and had to be added to many other compositor templates, so this is expected. Removing git sounds reasonable, but I don't know why it was in the template

cc @ifreund 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: river: add missing libevdev-devel, remove git from hostmakedepends
  2022-11-24 18:25 [PR PATCH] river: add missing libevdev-devel, remove git from hostmakedepends kruceter
  2022-11-26 15:14 ` paper42
@ 2022-11-26 17:58 ` paper42
  1 sibling, 0 replies; 3+ messages in thread
From: paper42 @ 2022-11-26 17:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

There's a merged pull request on the void-packages repository

river: add missing libevdev-devel, remove git from hostmakedepends
https://github.com/void-linux/void-packages/pull/40738

Description:
I do not use wayland, but maybe someone else around does. 

Incrementing revision is not needed; the current revision already depends on libevdev.

Refer to #39083.

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l-musl (cross)


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-26 17:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-24 18:25 [PR PATCH] river: add missing libevdev-devel, remove git from hostmakedepends kruceter
2022-11-26 15:14 ` paper42
2022-11-26 17:58 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).