Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] coturn: allow to bind to ports below 1024
@ 2022-11-29 18:09 steinex
  2022-11-30  0:07 ` [PR PATCH] [Merged]: " Vaelatern
  0 siblings, 1 reply; 2+ messages in thread
From: steinex @ 2022-11-29 18:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

There is a new pull request by steinex against master on the void-packages repository

https://github.com/steinex/void-packages coturn
https://github.com/void-linux/void-packages/pull/40838

coturn: allow to bind to ports below 1024
In some cases (corporate firewalls, hospitals) it may be desirable to have a TURN service on 443 because this is open in every case.

To allow that, allow the turnserver to bind to ports below 1024.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

cc @Vaelatern  

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40838.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-coturn-40838.patch --]
[-- Type: text/x-diff, Size: 1160 bytes --]

From 407c8a259647f703d5a97479af2382c136907f59 Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Tue, 29 Nov 2022 16:26:51 +0100
Subject: [PATCH] coturn: allow to bind to ports below 1024

In some cases (corporate firewalls, hospitals) it may be desirable to
have a TURN service on 443 because this is open in every case.

To allow that, allow the turnserver to bind to ports below 1024.
---
 srcpkgs/coturn/INSTALL  | 5 +++++
 srcpkgs/coturn/template | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/coturn/INSTALL

diff --git a/srcpkgs/coturn/INSTALL b/srcpkgs/coturn/INSTALL
new file mode 100644
index 000000000000..3ee6f34d2ae3
--- /dev/null
+++ b/srcpkgs/coturn/INSTALL
@@ -0,0 +1,5 @@
+case "${ACTION}" in
+post)
+	setcap CAP_NET_BIND_SERVICE=+ep usr/bin/turnserver
+	;;
+esac
diff --git a/srcpkgs/coturn/template b/srcpkgs/coturn/template
index 613195194083..7ab9f7296df7 100644
--- a/srcpkgs/coturn/template
+++ b/srcpkgs/coturn/template
@@ -1,7 +1,7 @@
 # Template file for 'coturn'
 pkgname=coturn
 version=4.6.0
-revision=1
+revision=2
 build_style=configure
 configure_args="
  --prefix=/usr

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: coturn: allow to bind to ports below 1024
  2022-11-29 18:09 [PR PATCH] coturn: allow to bind to ports below 1024 steinex
@ 2022-11-30  0:07 ` Vaelatern
  0 siblings, 0 replies; 2+ messages in thread
From: Vaelatern @ 2022-11-30  0:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

There's a merged pull request on the void-packages repository

coturn: allow to bind to ports below 1024
https://github.com/void-linux/void-packages/pull/40838

Description:
In some cases (corporate firewalls, hospitals) it may be desirable to have a TURN service on 443 because this is open in every case.

To allow that, allow the turnserver to bind to ports below 1024.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

cc @Vaelatern  

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-30  0:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-29 18:09 [PR PATCH] coturn: allow to bind to ports below 1024 steinex
2022-11-30  0:07 ` [PR PATCH] [Merged]: " Vaelatern

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).