* [PR PATCH] glab: update to 1.24.1.
@ 2022-12-14 19:55 icp1994
2022-12-16 18:41 ` [PR REVIEW] " paper42
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: icp1994 @ 2022-12-14 19:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
There is a new pull request by icp1994 against master on the void-packages repository
https://github.com/icp1994/void-packages glab
https://github.com/void-linux/void-packages/pull/41089
glab: update to 1.24.1.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/41089.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-glab-41089.patch --]
[-- Type: text/x-diff, Size: 1383 bytes --]
From 375b8972b87a80df9abfd28b176738bda140c68d Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 14 Dec 2022 22:43:32 +0530
Subject: [PATCH] glab: update to 1.24.1.
---
srcpkgs/glab/template | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/glab/template b/srcpkgs/glab/template
index dd9350b8e41b..1cb62c5f1030 100644
--- a/srcpkgs/glab/template
+++ b/srcpkgs/glab/template
@@ -1,18 +1,24 @@
# Template file for 'glab'
pkgname=glab
-version=1.22.0
+version=1.24.1
revision=1
build_style=go
+build_helper=qemu
go_ldflags="-X main.version=$version"
-go_import_path=github.com/profclems/glab
+go_import_path=gitlab.com/gitlab-org/cli
go_package="${go_import_path}/cmd/glab"
short_desc="Command line tool bringing GitLab's features to your command line"
maintainer="Enno Boland <gottox@voidlinux.org>"
license="MIT"
homepage="https://gitlab.com/gitlab-org/cli"
distfiles="https://gitlab.com/gitlab-org/cli/-/archive/v$version/cli-v$version.tar.gz"
-checksum=4d9bceb6818c8bf9f681119dae3a65f1c895fa21e9da6b38e8f88d245f524e10
+checksum=dc942f7806aa417714483bd5323bfcde9eceadd7ed33154f7a77038b416bdd95
post_install() {
+ local glab=${DESTDIR}/usr/bin/glab
+ for shell in bash fish zsh; do
+ vtargetrun ${glab} completion -s ${shell} > glab.${shell}
+ vcompletion glab.${shell} ${shell}
+ done
vlicense LICENSE
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR REVIEW] glab: update to 1.24.1.
2022-12-14 19:55 [PR PATCH] glab: update to 1.24.1 icp1994
@ 2022-12-16 18:41 ` paper42
2022-12-17 13:32 ` [PR PATCH] [Updated] " icp1994
2022-12-17 13:37 ` [PR PATCH] [Merged]: " paper42
2 siblings, 0 replies; 4+ messages in thread
From: paper42 @ 2022-12-16 18:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/41089#discussion_r1051047851
Comment:
there is no point in setting a variable when it's only going to be used once in the code
```suggestion
for shell in bash fish zsh; do
vtargetrun ${DESTDIR}/usr/bin/glab completion -s ${shell} > glab.${shell}
vcompletion glab.${shell} ${shell}
done
```
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR PATCH] [Updated] glab: update to 1.24.1.
2022-12-14 19:55 [PR PATCH] glab: update to 1.24.1 icp1994
2022-12-16 18:41 ` [PR REVIEW] " paper42
@ 2022-12-17 13:32 ` icp1994
2022-12-17 13:37 ` [PR PATCH] [Merged]: " paper42
2 siblings, 0 replies; 4+ messages in thread
From: icp1994 @ 2022-12-17 13:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
There is an updated pull request by icp1994 against master on the void-packages repository
https://github.com/icp1994/void-packages glab
https://github.com/void-linux/void-packages/pull/41089
glab: update to 1.24.1.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/41089.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-glab-41089.patch --]
[-- Type: text/x-diff, Size: 1361 bytes --]
From d359eae513c64ad0450600809637b55d0b9797d6 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Wed, 14 Dec 2022 22:43:32 +0530
Subject: [PATCH] glab: update to 1.24.1.
---
srcpkgs/glab/template | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/glab/template b/srcpkgs/glab/template
index dd9350b8e41b..840e13d8f160 100644
--- a/srcpkgs/glab/template
+++ b/srcpkgs/glab/template
@@ -1,18 +1,23 @@
# Template file for 'glab'
pkgname=glab
-version=1.22.0
+version=1.24.1
revision=1
build_style=go
+build_helper=qemu
go_ldflags="-X main.version=$version"
-go_import_path=github.com/profclems/glab
+go_import_path=gitlab.com/gitlab-org/cli
go_package="${go_import_path}/cmd/glab"
short_desc="Command line tool bringing GitLab's features to your command line"
maintainer="Enno Boland <gottox@voidlinux.org>"
license="MIT"
homepage="https://gitlab.com/gitlab-org/cli"
distfiles="https://gitlab.com/gitlab-org/cli/-/archive/v$version/cli-v$version.tar.gz"
-checksum=4d9bceb6818c8bf9f681119dae3a65f1c895fa21e9da6b38e8f88d245f524e10
+checksum=dc942f7806aa417714483bd5323bfcde9eceadd7ed33154f7a77038b416bdd95
post_install() {
+ for shell in bash fish zsh; do
+ vtargetrun ${DESTDIR}/usr/bin/glab completion -s ${shell} > glab.${shell}
+ vcompletion glab.${shell} ${shell}
+ done
vlicense LICENSE
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR PATCH] [Merged]: glab: update to 1.24.1.
2022-12-14 19:55 [PR PATCH] glab: update to 1.24.1 icp1994
2022-12-16 18:41 ` [PR REVIEW] " paper42
2022-12-17 13:32 ` [PR PATCH] [Updated] " icp1994
@ 2022-12-17 13:37 ` paper42
2 siblings, 0 replies; 4+ messages in thread
From: paper42 @ 2022-12-17 13:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
There's a merged pull request on the void-packages repository
glab: update to 1.24.1.
https://github.com/void-linux/void-packages/pull/41089
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-17 13:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-14 19:55 [PR PATCH] glab: update to 1.24.1 icp1994
2022-12-16 18:41 ` [PR REVIEW] " paper42
2022-12-17 13:32 ` [PR PATCH] [Updated] " icp1994
2022-12-17 13:37 ` [PR PATCH] [Merged]: " paper42
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).