Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] common/environment/build-style/go.sh: allow setting CGO_ENABLED
@ 2022-12-18 16:31 sug0
  2023-01-13 17:24 ` Vaelatern
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: sug0 @ 2022-12-18 16:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]

There is a new pull request by sug0 against master on the void-packages repository

https://github.com/sug0/void-packages set-cgo-enabled
https://github.com/void-linux/void-packages/pull/41167

common/environment/build-style/go.sh: allow setting CGO_ENABLED
Change hard-coded value of `CGO_ENABLED` to allow reading a user configured value from a template file. This is required to fix a segmentation fault in #40919, derived some kind of linking error. The default behavior is kept, i.e. cgo is still enabled by default, which shouldn't break any packages.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41167.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-set-cgo-enabled-41167.patch --]
[-- Type: text/x-diff, Size: 883 bytes --]

From e12fdc40e8600d41298fb2b5fe604f68af47e551 Mon Sep 17 00:00:00 2001
From: Tiago Carvalho <sugoiuguu@tfwno.gf>
Date: Sun, 18 Dec 2022 16:25:05 +0000
Subject: [PATCH] common/environment/build-style/go.sh: allow setting
 CGO_ENABLED from templates

---
 common/environment/build-style/go.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/environment/build-style/go.sh b/common/environment/build-style/go.sh
index a7b7dd81918a..68f88c6dbee8 100644
--- a/common/environment/build-style/go.sh
+++ b/common/environment/build-style/go.sh
@@ -37,7 +37,7 @@ export CGO_CFLAGS="$CFLAGS"
 export CGO_CPPFLAGS="$CPPFLAGS"
 export CGO_CXXFLAGS="$CXXFLAGS"
 export CGO_LDFLAGS="$LDFLAGS"
-export CGO_ENABLED=1
+export CGO_ENABLED="${CGO_ENABLED:-1}"
 export GO111MODULE=auto
 case "$XBPS_TARGET_MACHINE" in
 	*-musl) export GOCACHE="${XBPS_HOSTDIR}/gocache-muslc" ;;

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-01-14 13:07 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-18 16:31 [PR PATCH] common/environment/build-style/go.sh: allow setting CGO_ENABLED sug0
2023-01-13 17:24 ` Vaelatern
2023-01-13 18:32 ` sug0
2023-01-13 18:34 ` sug0
2023-01-13 18:49 ` Vaelatern
2023-01-13 19:24 ` classabbyamp
2023-01-13 19:24 ` classabbyamp
2023-01-13 22:35 ` sug0
2023-01-13 23:16 ` Vaelatern
2023-01-13 23:57 ` [PR PATCH] [Merged]: " classabbyamp
2023-01-14 13:07 ` sug0

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).