[PR PATCH] New package: newm-0.3alpha

[PR PATCH] New package: newm-0.3alpha

[Zoh-j02r]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

There is a new pull request by Zoh-j02r against master on the void-packages repository

https://github.com/Zoh-j02r/void-packages newm-testing
https://github.com/void-linux/void-packages/pull/41185

New package: newm-0.3alpha
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


A patch file from https://github.com/void-linux/void-packages/pull/41185.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newm-testing-41185.patch --]
[-- Type: text/x-diff, Size: 2239 bytes --]

From 5905a7e3f53070380afd05275910de90a4dcfdba Mon Sep 17 00:00:00 2001
From: Zoh-j02r <saulobruno@usp.br>
Date: Mon, 19 Dec 2022 13:32:02 -0300
Subject: [PATCH] New package: newm-0.3alpha

---
 srcpkgs/newm/template | 46 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 srcpkgs/newm/template

diff --git a/srcpkgs/newm/template b/srcpkgs/newm/template
new file mode 100644
index 000000000000..cd8f5f3c0e47
--- /dev/null
+++ b/srcpkgs/newm/template
@@ -0,0 +1,46 @@
+# Template file for 'newm'
+pkgname=newm
+version=0.3alpha
+revision=1
+create_wrksrc=yes
+hostmakedepends="python3-devel wayland-protocols  pkg-config meson ninja git"
+makedepends="pango-devel cairo-devel pixman-devel wayland-devel libevdev-devel libinput-devel glslang-devel wlroots-devel Vulkan-Headers vulkan-loader libseat-devel libxkbcommon-devel libxcb-devel xorg-server-xwayland"
+depends="xorg-server-xwayland python3-evdev  python3-imageio python3-cairo python3-psutil python3-pam python3-pyfiglet python3-thefuzz python3-cairo"
+short_desc="Wayland compositor written with laptops and touchpads in mind"
+maintainer=" Zoh-j02r <saulobruno@usp.br>"
+license="MIT"
+homepage="https://github.com/jbuchermn/newm"
+
+_wlroots_commit=e279266f714c7122e9ad97d56d047313f78cfdbe
+
+distfiles=" ${homepage}/archive/refs/tags/v${version}.tar.gz
+ https://github.com/jbuchermn/pywm/archive/refs/tags/v${version}.zip
+ https://gitlab.freedesktop.org/wlroots/wlroots/-/archive/${_wlroots_commit}.tar.gz"
+
+checksum=" 989f7c02cc4ecc3f9f390caef97a2d2713af3b6a391a895ca7e1253076102645
+ 2297c3bb32f716a95f0846d0fd351a3e39a00a0fa0f078d48427605a484e28e1
+ e09dd1bcd08bed22b1bc61b6992511be0dc1d31f019b93e118a97882c30d65cd"
+
+post_extract() {
+	cd $wrksrc/pywm-${version}
+	rmdir subprojects/wlroots
+	mv -v $wrksrc/wlroots-${_wlroots_commit} subprojects/wlroots
+}
+
+do_build() {
+	cd $wrksrc/pywm-${version}
+	python3 setup.py build
+	cd $wrksrc/newm-${version}
+	python3 setup.py build
+}
+
+do_install() {
+	cd $wrksrc/pywm-${version}
+	python3 setup.py install --root="${DESTDIR}"
+	cd $wrksrc/newm-${version}
+	python3 setup.py install --root="${DESTDIR}"
+}
+
+post_install() {
+	vlicense $wrksrc/newm-${version}/LICENSE
+}

Re: New package: newm-0.3alpha

[paper42]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#issuecomment-1357933910

Comment:
alpha software using unstable wlroots will not be accepted

Re: New package: newm-0.3alpha

[Zoh-j02r]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by Zoh-j02r on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#issuecomment-1357969544

Comment:
pushing back newm to version 0.2 and using wlroots 0.15.1 will solve the issue?

Re: New package: newm-0.3alpha

[paper42]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#issuecomment-1357986151

Comment:
yes

Re: [PR PATCH] [Updated] New package: newm-0.3alpha

[Zoh-j02r]

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

There is an updated pull request by Zoh-j02r against master on the void-packages repository

https://github.com/Zoh-j02r/void-packages newm-testing
https://github.com/void-linux/void-packages/pull/41185

New package: newm-0.3alpha
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


A patch file from https://github.com/void-linux/void-packages/pull/41185.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newm-testing-41185.patch --]
[-- Type: text/x-diff, Size: 3889 bytes --]

From 19d6d65daa80e483796649a0704f83689238e86f Mon Sep 17 00:00:00 2001
From: Zoh-j02r <saulobruno@usp.br>
Date: Mon, 19 Dec 2022 13:32:02 -0300
Subject: [PATCH 1/2] New package: newm-0.3alpha

---
 srcpkgs/newm/template | 46 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 srcpkgs/newm/template

diff --git a/srcpkgs/newm/template b/srcpkgs/newm/template
new file mode 100644
index 000000000000..cd8f5f3c0e47
--- /dev/null
+++ b/srcpkgs/newm/template
@@ -0,0 +1,46 @@
+# Template file for 'newm'
+pkgname=newm
+version=0.3alpha
+revision=1
+create_wrksrc=yes
+hostmakedepends="python3-devel wayland-protocols  pkg-config meson ninja git"
+makedepends="pango-devel cairo-devel pixman-devel wayland-devel libevdev-devel libinput-devel glslang-devel wlroots-devel Vulkan-Headers vulkan-loader libseat-devel libxkbcommon-devel libxcb-devel xorg-server-xwayland"
+depends="xorg-server-xwayland python3-evdev  python3-imageio python3-cairo python3-psutil python3-pam python3-pyfiglet python3-thefuzz python3-cairo"
+short_desc="Wayland compositor written with laptops and touchpads in mind"
+maintainer=" Zoh-j02r <saulobruno@usp.br>"
+license="MIT"
+homepage="https://github.com/jbuchermn/newm"
+
+_wlroots_commit=e279266f714c7122e9ad97d56d047313f78cfdbe
+
+distfiles=" ${homepage}/archive/refs/tags/v${version}.tar.gz
+ https://github.com/jbuchermn/pywm/archive/refs/tags/v${version}.zip
+ https://gitlab.freedesktop.org/wlroots/wlroots/-/archive/${_wlroots_commit}.tar.gz"
+
+checksum=" 989f7c02cc4ecc3f9f390caef97a2d2713af3b6a391a895ca7e1253076102645
+ 2297c3bb32f716a95f0846d0fd351a3e39a00a0fa0f078d48427605a484e28e1
+ e09dd1bcd08bed22b1bc61b6992511be0dc1d31f019b93e118a97882c30d65cd"
+
+post_extract() {
+	cd $wrksrc/pywm-${version}
+	rmdir subprojects/wlroots
+	mv -v $wrksrc/wlroots-${_wlroots_commit} subprojects/wlroots
+}
+
+do_build() {
+	cd $wrksrc/pywm-${version}
+	python3 setup.py build
+	cd $wrksrc/newm-${version}
+	python3 setup.py build
+}
+
+do_install() {
+	cd $wrksrc/pywm-${version}
+	python3 setup.py install --root="${DESTDIR}"
+	cd $wrksrc/newm-${version}
+	python3 setup.py install --root="${DESTDIR}"
+}
+
+post_install() {
+	vlicense $wrksrc/newm-${version}/LICENSE
+}

From 9ae8878aa43c76339579d0b4b44c60ec45b5d6bd Mon Sep 17 00:00:00 2001
From: Zoh-j02r <saulobruno@usp.br>
Date: Tue, 20 Dec 2022 08:59:28 -0300
Subject: [PATCH 2/2] New Package: newm-0.2

---
 srcpkgs/newm/template | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/newm/template b/srcpkgs/newm/template
index cd8f5f3c0e47..ae3ebba72ecf 100644
--- a/srcpkgs/newm/template
+++ b/srcpkgs/newm/template
@@ -1,6 +1,6 @@
 # Template file for 'newm'
 pkgname=newm
-version=0.3alpha
+version=0.2
 revision=1
 create_wrksrc=yes
 hostmakedepends="python3-devel wayland-protocols  pkg-config meson ninja git"
@@ -11,15 +11,15 @@ maintainer=" Zoh-j02r <saulobruno@usp.br>"
 license="MIT"
 homepage="https://github.com/jbuchermn/newm"
 
-_wlroots_commit=e279266f714c7122e9ad97d56d047313f78cfdbe
+_wlroots_commit=0855cdacb2eeeff35849e2e9c4db0aa996d78d10
 
 distfiles=" ${homepage}/archive/refs/tags/v${version}.tar.gz
  https://github.com/jbuchermn/pywm/archive/refs/tags/v${version}.zip
- https://gitlab.freedesktop.org/wlroots/wlroots/-/archive/${_wlroots_commit}.tar.gz"
+ https://github.com/swaywm/wlroots/archive/${_wlroots_commit}.tar.gz"
+checksum=" a03e9a4dd51b767059f9c53049597ac6e754cee11029f66b00d32031128310b4
+ 4df9bcb4c98aea1f4c452a29805d96a3066109a1424612298cc7e83f4d0ae771
+ c012482fafdad9bd4d9d75dcb5b61e28e5d60eb9f77ba0bec7c15ac2870fb70a"
 
-checksum=" 989f7c02cc4ecc3f9f390caef97a2d2713af3b6a391a895ca7e1253076102645
- 2297c3bb32f716a95f0846d0fd351a3e39a00a0fa0f078d48427605a484e28e1
- e09dd1bcd08bed22b1bc61b6992511be0dc1d31f019b93e118a97882c30d65cd"
 
 post_extract() {
 	cd $wrksrc/pywm-${version}

Re: New package: newm-0.3alpha

[Zoh-j02r]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by Zoh-j02r on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#issuecomment-1359283628

Comment:
With this change I believe the package can be successfully merged

Re: [PR REVIEW] New package: newm-0.3alpha

[paper42]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#discussion_r1053402449

Comment:
use system wlroots
```suggestion
distfiles=" ${homepage}/archive/refs/tags/v${version}.tar.gz
 https://github.com/jbuchermn/pywm/archive/refs/tags/v${version}.zip"
checksum=" a03e9a4dd51b767059f9c53049597ac6e754cee11029f66b00d32031128310b4
 4df9bcb4c98aea1f4c452a29805d96a3066109a1424612298cc7e83f4d0ae771"
```

Re: [PR REVIEW] New package: newm-0.3alpha

[paper42]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#discussion_r1053402755

Comment:
can we just use two packages?

Re: [PR REVIEW] New package: newm-0.3alpha

[paper42]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#discussion_r1053403965

Comment:
```suggestion
maintainer="Zoh-j02r <saulobruno@usp.br>"
```

Re: [PR REVIEW] New package: newm-0.3alpha

[paper42]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#discussion_r1053403428

Comment:
wrap at 80 columns

Re: [PR REVIEW] New package: newm-0.3alpha

[paper42]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#discussion_r1053403789

Comment:
remove double spaces all over the template
```suggestion
hostmakedepends="python3-devel wayland-protocols pkg-config meson ninja git"
```

Re: [PR REVIEW] New package: newm-0.3alpha

[Zoh-j02r]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New review comment by Zoh-j02r on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#discussion_r1053532190

Comment:
if not initializing the submodule newm refuses to compile, I dont know it there a better solution for the submodule init problem

Re: [PR REVIEW] New package: newm-0.3alpha

[Zoh-j02r]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New review comment by Zoh-j02r on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#discussion_r1053535154

Comment:
I was kinda of following the template made for Arch Linux by the creator [here](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=newm-git).

Re: [PR REVIEW] New package: newm-0.3alpha

[paper42]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#discussion_r1055638769

Comment:
We are not AUR, can we just use two packages?

Re: [PR REVIEW] New package: newm-0.3alpha

[paper42]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#discussion_r1055639149

Comment:
Using system wlroots is a requirement for this to even be mergeable.

Re: New package: newm-0.3alpha

[Zoh-j02r]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

New comment by Zoh-j02r on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#issuecomment-1370086123

Comment:
I made this [issue](https://github.com/jbuchermn/pywm/issues/21) suggestion the addition for an option to use the system wlroots, if for some technical reason or disinterest for the developer in using a stable wlroots release, then it is unlikely the port of newm to Void, since there is low activity in the newm project for a while it might take some time. I may close this issue and reopen it if there is some progress.

Re: [PR PATCH] [Closed]: New package: newm-0.3alpha

[Zoh-j02r]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

There's a closed pull request on the void-packages repository

New package: newm-0.3alpha
https://github.com/void-linux/void-packages/pull/41185

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

Re: [PR REVIEW] New package: newm-0.3alpha

[eli-schwartz]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by eli-schwartz on void-packages repository

https://github.com/void-linux/void-packages/pull/41185#discussion_r1061090312

Comment:
"What the upstream developer does in a custom recipe that has no QA or review process" is not relevant to *any* distro.