[PR PATCH] libsigc++: update to 2.10.8.

[PR PATCH] libsigc++: update to 2.10.8.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages libsigc++-2.10.8
https://github.com/void-linux/void-packages/pull/41241

libsigc++: update to 2.10.8.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly** (compiled and ran Waybar, which depends on libsigc++, but I couldn't for the life of me compile a simple example program to test libsigc++ directly)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41241.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libsigc++-2.10.8-41241.patch --]
[-- Type: text/x-diff, Size: 1899 bytes --]

From 985fa5521b2cd390f557ff244e647c3baada27fe Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 22 Dec 2022 01:07:01 +0000
Subject: [PATCH] libsigc++: update to 2.10.8.

---
 srcpkgs/libsigc++/template | 17 +++++++++++------
 srcpkgs/libsigc++/update   |  2 +-
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/libsigc++/template b/srcpkgs/libsigc++/template
index 8f8733b55f2a..5d428af0f7f2 100644
--- a/srcpkgs/libsigc++/template
+++ b/srcpkgs/libsigc++/template
@@ -1,16 +1,21 @@
 # Template file for 'libsigc++'
 pkgname=libsigc++
-version=2.10.3
+version=2.10.8
 revision=1
-build_style=gnu-configure
-configure_args="--enable-static --disable-documentation --disable-benchmark"
-hostmakedepends="m4"
+build_style=meson
+configure_args="-Dbuild-documentation=false -Dbenchmark=false -Dwarnings=max"
+meson_builddir="meson_build"
 short_desc="Type-safe callback system for C++ programs"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://libsigcplusplus.github.io/libsigcplusplus/"
-distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=0b68dfc6313c6cc90ac989c6d722a1bf0585ad13846e79746aa87cb265904786
+distfiles="${GNOME_SITE}/libsigc++/${version%.*}/libsigc++-${version}.tar.xz"
+checksum=235a40bec7346c7b82b6a8caae0456353dc06e71f14bc414bcc858af1838719a
+
+pre_configure() {
+	# build static library as well as shared
+	vsed -i 's,library(,both_libraries(,' sigc++/meson.build
+}
 
 libsigc++-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
diff --git a/srcpkgs/libsigc++/update b/srcpkgs/libsigc++/update
index 0d3fa3bab911..9aa2cd0feba8 100644
--- a/srcpkgs/libsigc++/update
+++ b/srcpkgs/libsigc++/update
@@ -1 +1 @@
-pattern="libsigc\+\+-\K[0-9]\.[0-9]*[02468]\.[0-9.]*[0-9](?=)"
+pattern="libsigc\+\+-\K2\.[0-9]*[02468]\.[0-9.]*[0-9](?=)"

Re: [PR REVIEW] libsigc++: update to 2.10.8.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/41241#discussion_r1055782306

Comment:
There was no `configure` script in the 2.10.8 tarball, so I thought I might as well change the template to use Meson instead. (I could also switch it to Autotools, if you want).

Re: [PR REVIEW] libsigc++: update to 2.10.8.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/41241#discussion_r1055782691

Comment:
See https://github.com/libsigcplusplus/libsigcplusplus/blob/cd68de2df3b9e80b5b25a087fbf94b432b9ef84b/README#L57-L58.

Re: [PR REVIEW] libsigc++: update to 2.10.8.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/41241#discussion_r1055782971

Comment:
The build seems to be the exact same whether or not m4 is present.

Re: [PR REVIEW] libsigc++: update to 2.10.8.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/41241#discussion_r1055782306

Comment:
There was no `configure` script in the 2.10.8 tarball, so I thought I might as well change the template to use Meson instead (I could also switch it to Autotools, if you want).

Re: [PR PATCH] [Updated] libsigc++: update to 2.10.8.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages libsigc++-2.10.8
https://github.com/void-linux/void-packages/pull/41241

libsigc++: update to 2.10.8.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly** (compiled and ran Waybar, which depends on libsigc++, but I couldn't for the life of me compile a simple example program to test libsigc++ directly)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41241.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libsigc++-2.10.8-41241.patch --]
[-- Type: text/x-diff, Size: 1963 bytes --]

From c91bce2baf48c34f1831e6aaf095bdc37e88cb82 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 22 Dec 2022 01:07:01 +0000
Subject: [PATCH] libsigc++: update to 2.12.0.

---
 srcpkgs/libsigc++/template | 21 +++++++++++++++------
 srcpkgs/libsigc++/update   |  2 +-
 2 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/libsigc++/template b/srcpkgs/libsigc++/template
index 8f8733b55f2a..af89ef2db31c 100644
--- a/srcpkgs/libsigc++/template
+++ b/srcpkgs/libsigc++/template
@@ -1,16 +1,25 @@
 # Template file for 'libsigc++'
 pkgname=libsigc++
-version=2.10.3
+version=2.12.0
 revision=1
-build_style=gnu-configure
-configure_args="--enable-static --disable-documentation --disable-benchmark"
-hostmakedepends="m4"
+build_style=meson
+configure_args="-Dbuild-examples=false -Dwarnings=max"
+meson_builddir="meson_build"
 short_desc="Type-safe callback system for C++ programs"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://libsigcplusplus.github.io/libsigcplusplus/"
-distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=0b68dfc6313c6cc90ac989c6d722a1bf0585ad13846e79746aa87cb265904786
+distfiles="${GNOME_SITE}/libsigc++/${version%.*}/libsigc++-${version}.tar.xz"
+checksum=1c466d2e64b34f9b118976eb21b138c37ed124d0f61497df2a90ce6c3d9fa3b5
+
+if [ -z "$XBPS_CHECK_PKGS" ]; then
+	configure_args+=" -Dbuild-tests=false"
+fi
+
+pre_configure() {
+	# build static library as well as shared
+	vsed -i 's,library(,both_libraries(,' sigc++/meson.build
+}
 
 libsigc++-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
diff --git a/srcpkgs/libsigc++/update b/srcpkgs/libsigc++/update
index 0d3fa3bab911..9aa2cd0feba8 100644
--- a/srcpkgs/libsigc++/update
+++ b/srcpkgs/libsigc++/update
@@ -1 +1 @@
-pattern="libsigc\+\+-\K[0-9]\.[0-9]*[02468]\.[0-9.]*[0-9](?=)"
+pattern="libsigc\+\+-\K2\.[0-9]*[02468]\.[0-9.]*[0-9](?=)"

Re: [PR PATCH] [Closed]: libsigc++: update to 2.12.0.

[abenson]

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

There's a closed pull request on the void-packages repository

libsigc++: update to 2.12.0.
https://github.com/void-linux/void-packages/pull/41241

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly** (compiled and ran Waybar, which depends on libsigc++, but I couldn't for the life of me compile a simple example program to test libsigc++ directly)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->