Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gallery-dl: update to 1.24.2.
@ 2022-12-23 18:54 icp1994
  2022-12-25 10:25 ` [PR REVIEW] " paper42
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: icp1994 @ 2022-12-23 18:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages gallery-dl
https://github.com/void-linux/void-packages/pull/41255

gallery-dl: update to 1.24.2.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

A patch file from https://github.com/void-linux/void-packages/pull/41255.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gallery-dl-41255.patch --]
[-- Type: text/x-diff, Size: 1511 bytes --]

From d1ce9f930ddd91c1cf5cea38d1b23ecaaf70d0ad Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 22 Dec 2022 20:52:30 +0530
Subject: [PATCH] gallery-dl: update to 1.24.2.

---
 srcpkgs/gallery-dl/template | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/srcpkgs/gallery-dl/template b/srcpkgs/gallery-dl/template
index f3d0836d3b32..809f957415be 100644
--- a/srcpkgs/gallery-dl/template
+++ b/srcpkgs/gallery-dl/template
@@ -1,22 +1,19 @@
 # Template file for 'gallery-dl'
 pkgname=gallery-dl
-version=1.23.2
-revision=2
+version=1.24.2
+revision=1
 build_style=python3-module
+make_check_args="--ignore test/test_results.py"
 hostmakedepends="python3-setuptools"
 depends="python3-requests"
-checkdepends="python3-requests"
+checkdepends="${depends} youtube-dl python3-pytest"
 short_desc="Command-line program to download image galleries"
 maintainer="SolitudeSF <solitudesf@protonmail.com>"
-license="GPL-2.0-or-later"
+license="GPL-2.0-only"
 homepage="https://github.com/mikf/gallery-dl"
 changelog="https://raw.githubusercontent.com/mikf/gallery-dl/master/CHANGELOG.md"
-distfiles="https://github.com/mikf/gallery-dl/archive/v${version}.tar.gz"
-checksum=94ea35f4a10800fcd4bf97c6316e41636164a98f1ef7849981de69979d5a3ea1
-
-do_check() {
-	make test
-}
+distfiles="https://github.com/mikf/gallery-dl/archive/refs/tags/v${version}.tar.gz"
+checksum=e0d760359393c0750bd0b918db73dea3edbb99f3021e116f547a76018af8e946
 
 pre_build() {
 	make man completion

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] gallery-dl: update to 1.24.2.
  2022-12-23 18:54 [PR PATCH] gallery-dl: update to 1.24.2 icp1994
@ 2022-12-25 10:25 ` paper42
  2022-12-25 19:34 ` icp1994
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-12-25 10:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41255#discussion_r1056931512

Comment:
Is it possible to use yt-dlp instead?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] gallery-dl: update to 1.24.2.
  2022-12-23 18:54 [PR PATCH] gallery-dl: update to 1.24.2 icp1994
  2022-12-25 10:25 ` [PR REVIEW] " paper42
@ 2022-12-25 19:34 ` icp1994
  2022-12-25 21:42 ` paper42
  2022-12-25 21:42 ` [PR PATCH] [Merged]: " paper42
  3 siblings, 0 replies; 5+ messages in thread
From: icp1994 @ 2022-12-25 19:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/41255#discussion_r1056990778

Comment:
Looking at the tests, they have separate tests for both `youtube-dl` and `yt-dlp`. But running `yt-dlp` tests fail with pytest and need to use `make test` as the template has currently.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] gallery-dl: update to 1.24.2.
  2022-12-23 18:54 [PR PATCH] gallery-dl: update to 1.24.2 icp1994
  2022-12-25 10:25 ` [PR REVIEW] " paper42
  2022-12-25 19:34 ` icp1994
@ 2022-12-25 21:42 ` paper42
  2022-12-25 21:42 ` [PR PATCH] [Merged]: " paper42
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-12-25 21:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41255#discussion_r1057000850

Comment:
That's unfortunate, thank you for looking into this

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: gallery-dl: update to 1.24.2.
  2022-12-23 18:54 [PR PATCH] gallery-dl: update to 1.24.2 icp1994
                   ` (2 preceding siblings ...)
  2022-12-25 21:42 ` paper42
@ 2022-12-25 21:42 ` paper42
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-12-25 21:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

There's a merged pull request on the void-packages repository

gallery-dl: update to 1.24.2.
https://github.com/void-linux/void-packages/pull/41255

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-12-25 21:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-23 18:54 [PR PATCH] gallery-dl: update to 1.24.2 icp1994
2022-12-25 10:25 ` [PR REVIEW] " paper42
2022-12-25 19:34 ` icp1994
2022-12-25 21:42 ` paper42
2022-12-25 21:42 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).