* [PR PATCH] openrgb: update to 0.8
@ 2022-12-26 20:14 sirn
2022-12-26 20:35 ` sirn
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: sirn @ 2022-12-26 20:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
There is a new pull request by sirn against master on the void-packages repository
https://github.com/sirn/void-packages openrgb-0.8
https://github.com/void-linux/void-packages/pull/41305
openrgb: update to 0.8
#### Testing the changes
- I tested the changes in this PR: **YES** (but only on glibc)
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
#### Notes
- `musl.patch` removed as the relevant change is now incorporated in the release ([openrgb@48d1a4f7](https://gitlab.com/CalcProgrammer1/OpenRGB/-/commit/48d1a4f7b60198e13009ff32879d07986ca6a9ec))
A patch file from https://github.com/void-linux/void-packages/pull/41305.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-openrgb-0.8-41305.patch --]
[-- Type: text/x-diff, Size: 2008 bytes --]
From 6d6d2be5c1b50c06427889c06468ee60791e42d7 Mon Sep 17 00:00:00 2001
From: Sirn Thanabulpong <sirn@ogsite.net>
Date: Tue, 27 Dec 2022 05:06:44 +0900
Subject: [PATCH] openrgb: update to 0.8
---
srcpkgs/openrgb/patches/musl.patch | 13 -------------
srcpkgs/openrgb/template | 4 ++--
2 files changed, 2 insertions(+), 15 deletions(-)
delete mode 100644 srcpkgs/openrgb/patches/musl.patch
diff --git a/srcpkgs/openrgb/patches/musl.patch b/srcpkgs/openrgb/patches/musl.patch
deleted file mode 100644
index 05fe5df2597e..000000000000
--- a/srcpkgs/openrgb/patches/musl.patch
+++ /dev/null
@@ -1,13 +0,0 @@
-diff --git a/i2c_smbus/i2c_smbus_linux.cpp b/i2c_smbus/i2c_smbus_linux.cpp
-index 33d1494b..f8a2c503 100644
---- a/i2c_smbus/i2c_smbus_linux.cpp
-+++ b/i2c_smbus/i2c_smbus_linux.cpp
-@@ -133,7 +133,7 @@ bool i2c_smbus_linux_detect()
- strcat(path, ent->d_name);
- if(ent->d_type == DT_LNK)
- {
-- ptr = canonicalize_file_name(path);
-+ ptr = realpath(path, NULL);
- if(ptr == NULL)
- continue;
-
diff --git a/srcpkgs/openrgb/template b/srcpkgs/openrgb/template
index 5b1d8c43eeeb..273dd7356ef2 100644
--- a/srcpkgs/openrgb/template
+++ b/srcpkgs/openrgb/template
@@ -1,6 +1,6 @@
# Template file for 'openrgb'
pkgname=openrgb
-version=0.7
+version=0.8
revision=1
build_style=qmake
hostmakedepends="qt5-qmake qt5-host-tools git pkg-config"
@@ -10,7 +10,7 @@ maintainer="Neel Chotai <neel@chot.ai>"
license="GPL-2.0-only"
homepage="https://gitlab.com/CalcProgrammer1/OpenRGB"
distfiles="https://gitlab.com/CalcProgrammer1/OpenRGB/-/archive/release_${version}/OpenRGB-release_${version}.tar.gz"
-checksum=6052e04ad736f94a91a386f6cfc0aaff9554fafdabe99cdd46a296fd49132569
+checksum=0d803753873ca1ec2bd78632b4ac605669394e7eeba2d2efe305c7f9c9d7df0c
pre_build() {
sed -i 's|rules.path=/lib|rules.path=/usr/lib|g' OpenRGB.pro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: openrgb: update to 0.8
2022-12-26 20:14 [PR PATCH] openrgb: update to 0.8 sirn
@ 2022-12-26 20:35 ` sirn
2022-12-26 20:35 ` sirn
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: sirn @ 2022-12-26 20:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
New comment by sirn on void-packages repository
https://github.com/void-linux/void-packages/pull/41305#issuecomment-1365450066
Comment:
Looks like it's failing on musl due to different reason than the removed patch (missing `#include <sys/select.h>`)? Will try to fix with upstream.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: openrgb: update to 0.8
2022-12-26 20:14 [PR PATCH] openrgb: update to 0.8 sirn
2022-12-26 20:35 ` sirn
@ 2022-12-26 20:35 ` sirn
2022-12-28 20:42 ` [PR PATCH] [Updated] WIP: " sirn
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: sirn @ 2022-12-26 20:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
New comment by sirn on void-packages repository
https://github.com/void-linux/void-packages/pull/41305#issuecomment-1365450066
Comment:
Looks like it's failing on musl due missing `#include <sys/select.h>`. Will try to fix with upstream.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] WIP: openrgb: update to 0.8
2022-12-26 20:14 [PR PATCH] openrgb: update to 0.8 sirn
2022-12-26 20:35 ` sirn
2022-12-26 20:35 ` sirn
@ 2022-12-28 20:42 ` sirn
2022-12-28 20:59 ` sirn
2023-01-14 0:58 ` [PR PATCH] [Merged]: " classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: sirn @ 2022-12-28 20:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
There is an updated pull request by sirn against master on the void-packages repository
https://github.com/sirn/void-packages openrgb-0.8
https://github.com/void-linux/void-packages/pull/41305
WIP: openrgb: update to 0.8
#### Testing the changes
- I tested the changes in this PR: **YES** (but only on glibc)
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
#### Notes
- `musl.patch` removed as the relevant change is now incorporated in the release ([openrgb@48d1a4f7](https://gitlab.com/CalcProgrammer1/OpenRGB/-/commit/48d1a4f7b60198e13009ff32879d07986ca6a9ec))
A patch file from https://github.com/void-linux/void-packages/pull/41305.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-openrgb-0.8-41305.patch --]
[-- Type: text/x-diff, Size: 2867 bytes --]
From a3ba8d480b398d9d914808a72a9c9ace7e505ab9 Mon Sep 17 00:00:00 2001
From: Sirn Thanabulpong <sirn@ogsite.net>
Date: Thu, 29 Dec 2022 05:41:35 +0900
Subject: [PATCH] openrgb: update to 0.8
---
srcpkgs/openrgb/patches/musl.patch | 37 ++++++++++++++++++++----------
srcpkgs/openrgb/template | 4 ++--
2 files changed, 27 insertions(+), 14 deletions(-)
diff --git a/srcpkgs/openrgb/patches/musl.patch b/srcpkgs/openrgb/patches/musl.patch
index 05fe5df2597e..a57d93ecfd17 100644
--- a/srcpkgs/openrgb/patches/musl.patch
+++ b/srcpkgs/openrgb/patches/musl.patch
@@ -1,13 +1,26 @@
-diff --git a/i2c_smbus/i2c_smbus_linux.cpp b/i2c_smbus/i2c_smbus_linux.cpp
-index 33d1494b..f8a2c503 100644
---- a/i2c_smbus/i2c_smbus_linux.cpp
-+++ b/i2c_smbus/i2c_smbus_linux.cpp
-@@ -133,7 +133,7 @@ bool i2c_smbus_linux_detect()
- strcat(path, ent->d_name);
- if(ent->d_type == DT_LNK)
- {
-- ptr = canonicalize_file_name(path);
-+ ptr = realpath(path, NULL);
- if(ptr == NULL)
- continue;
+https://gitlab.com/CalcProgrammer1/OpenRGB/-/commit/8c893fba4fcec17e6221f2d754def4aa71b020b8
+
+From 8c893fba4fcec17e6221f2d754def4aa71b020b8 Mon Sep 17 00:00:00 2001
+From: Sirn Thanabulpong <sirn@ogsite.net>
+Date: Wed, 28 Dec 2022 00:49:47 +0900
+Subject: [PATCH] Fix build on musl in Nanoleaf settings
+
+---
+ qt/OpenRGBNanoleafSettingsPage/OpenRGBNanoleafScanningThread.cpp | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/qt/OpenRGBNanoleafSettingsPage/OpenRGBNanoleafScanningThread.cpp b/qt/OpenRGBNanoleafSettingsPage/OpenRGBNanoleafScanningThread.cpp
+index 1e3c926b3..55ed5fcaa 100644
+--- a/qt/OpenRGBNanoleafSettingsPage/OpenRGBNanoleafScanningThread.cpp
++++ b/qt/OpenRGBNanoleafSettingsPage/OpenRGBNanoleafScanningThread.cpp
+@@ -8,6 +8,7 @@
+ #else
+ #include <netdb.h>
+ #include <ifaddrs.h>
++#include <sys/select.h>
+ #endif
+ #include "mdns.h"
+--
+GitLab
+
diff --git a/srcpkgs/openrgb/template b/srcpkgs/openrgb/template
index 5b1d8c43eeeb..273dd7356ef2 100644
--- a/srcpkgs/openrgb/template
+++ b/srcpkgs/openrgb/template
@@ -1,6 +1,6 @@
# Template file for 'openrgb'
pkgname=openrgb
-version=0.7
+version=0.8
revision=1
build_style=qmake
hostmakedepends="qt5-qmake qt5-host-tools git pkg-config"
@@ -10,7 +10,7 @@ maintainer="Neel Chotai <neel@chot.ai>"
license="GPL-2.0-only"
homepage="https://gitlab.com/CalcProgrammer1/OpenRGB"
distfiles="https://gitlab.com/CalcProgrammer1/OpenRGB/-/archive/release_${version}/OpenRGB-release_${version}.tar.gz"
-checksum=6052e04ad736f94a91a386f6cfc0aaff9554fafdabe99cdd46a296fd49132569
+checksum=0d803753873ca1ec2bd78632b4ac605669394e7eeba2d2efe305c7f9c9d7df0c
pre_build() {
sed -i 's|rules.path=/lib|rules.path=/usr/lib|g' OpenRGB.pro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: openrgb: update to 0.8
2022-12-26 20:14 [PR PATCH] openrgb: update to 0.8 sirn
` (2 preceding siblings ...)
2022-12-28 20:42 ` [PR PATCH] [Updated] WIP: " sirn
@ 2022-12-28 20:59 ` sirn
2023-01-14 0:58 ` [PR PATCH] [Merged]: " classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: sirn @ 2022-12-28 20:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
New comment by sirn on void-packages repository
https://github.com/void-linux/void-packages/pull/41305#issuecomment-1366912500
Comment:
Patch [merged upstream](https://gitlab.com/CalcProgrammer1/OpenRGB/-/merge_requests/1597), and PR updated with the patch backported.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: openrgb: update to 0.8
2022-12-26 20:14 [PR PATCH] openrgb: update to 0.8 sirn
` (3 preceding siblings ...)
2022-12-28 20:59 ` sirn
@ 2023-01-14 0:58 ` classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2023-01-14 0:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
There's a merged pull request on the void-packages repository
openrgb: update to 0.8
https://github.com/void-linux/void-packages/pull/41305
Description:
#### Testing the changes
- I tested the changes in this PR: **YES** (but only on glibc)
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
#### Notes
- `musl.patch` removed as the relevant change is now incorporated in the release ([openrgb@48d1a4f7](https://gitlab.com/CalcProgrammer1/OpenRGB/-/commit/48d1a4f7b60198e13009ff32879d07986ca6a9ec))
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-14 0:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-26 20:14 [PR PATCH] openrgb: update to 0.8 sirn
2022-12-26 20:35 ` sirn
2022-12-26 20:35 ` sirn
2022-12-28 20:42 ` [PR PATCH] [Updated] WIP: " sirn
2022-12-28 20:59 ` sirn
2023-01-14 0:58 ` [PR PATCH] [Merged]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).