[PR PATCH] New Package: ncspot-0.11.2

[PR PATCH] New Package: ncspot-0.11.2

[d33vliter]

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

There is a new pull request by d33vliter against master on the void-packages repository

https://github.com/d33vliter/void-packages patch-2
https://github.com/void-linux/void-packages/pull/41327

New Package: ncspot-0.11.2
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41327.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-2-41327.patch --]
[-- Type: text/x-diff, Size: 1158 bytes --]

From b65589eb451dcf5fa5438d41d4ba938e0a14d16f Mon Sep 17 00:00:00 2001
From: d33vliter <iandupuy1998@gmail.com>
Date: Wed, 28 Dec 2022 00:18:20 -0500
Subject: [PATCH] New Package: ncspot0.11.2

---
 srcpkgs/ncspot/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 000000000000..b90f65e6d598
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,22 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.11.2
+revision=1
+archs="x86_64"
+wrksrc=${pkgname}-${version}
+create_wrksrc=yes
+#hostmakedepends=""
+#makedepends=""
+depends="libpulseaudio openssl libxcb dbus"
+short_desc="Is a ncurses Spotify client written in Rust using librespot"
+maintainer="d33vliter <d33vliter@protonmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/hrkfdn/ncspot"
+distfiles="https://github.com/hrkfdn/ncspot/releases/download/v${version}/ncspot-v${version}-linux-x86_64.tar.gz"
+checksum=a97b62a0bb19383b34fe2a0c7128bb8940e1e78dd1fa3be98cdb53b008ed6050
+
+
+ do_install(){
+	vbin ncspot
+
+ }

Re: [PR REVIEW] New Package: ncspot-0.11.2

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41327#discussion_r1058066908

Comment:
why only x86_64?

Re: [PR REVIEW] New Package: ncspot-0.11.2

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41327#discussion_r1058066841

Comment:
```suggestion
```
wrksrc shouldn't be used anymore, and you probably don't need create_wrksrc

Re: [PR REVIEW] New Package: ncspot-0.11.2

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41327#discussion_r1058067204

Comment:
this should probably be auto-detected if you set makedepends with the proper devel packages

Re: [PR REVIEW] New Package: ncspot-0.11.2

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41327#discussion_r1058067012

Comment:
```suggestion
short_desc="ncurses Spotify client"
```

Re: [PR PATCH] [Updated] New Package: ncspot-0.11.2

[d33vliter]

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

There is an updated pull request by d33vliter against master on the void-packages repository

https://github.com/d33vliter/void-packages patch-2
https://github.com/void-linux/void-packages/pull/41327

New Package: ncspot-0.11.2
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41327.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-2-41327.patch --]
[-- Type: text/x-diff, Size: 1882 bytes --]

From b65589eb451dcf5fa5438d41d4ba938e0a14d16f Mon Sep 17 00:00:00 2001
From: d33vliter <iandupuy1998@gmail.com>
Date: Wed, 28 Dec 2022 00:18:20 -0500
Subject: [PATCH 1/2] New Package: ncspot0.11.2

---
 srcpkgs/ncspot/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 000000000000..b90f65e6d598
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,22 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.11.2
+revision=1
+archs="x86_64"
+wrksrc=${pkgname}-${version}
+create_wrksrc=yes
+#hostmakedepends=""
+#makedepends=""
+depends="libpulseaudio openssl libxcb dbus"
+short_desc="Is a ncurses Spotify client written in Rust using librespot"
+maintainer="d33vliter <d33vliter@protonmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/hrkfdn/ncspot"
+distfiles="https://github.com/hrkfdn/ncspot/releases/download/v${version}/ncspot-v${version}-linux-x86_64.tar.gz"
+checksum=a97b62a0bb19383b34fe2a0c7128bb8940e1e78dd1fa3be98cdb53b008ed6050
+
+
+ do_install(){
+	vbin ncspot
+
+ }

From 1ae41a5b88c3d493932e8b80a7f3e97e71ca32ca Mon Sep 17 00:00:00 2001
From: d33vliter <iandupuy1998@gmail.com>
Date: Wed, 28 Dec 2022 00:41:42 -0500
Subject: [PATCH 2/2] Update srcpkgs/ncspot/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/ncspot/template | 2 --
 1 file changed, 2 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index b90f65e6d598..1cd2164fee8e 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -3,8 +3,6 @@ pkgname=ncspot
 version=0.11.2
 revision=1
 archs="x86_64"
-wrksrc=${pkgname}-${version}
-create_wrksrc=yes
 #hostmakedepends=""
 #makedepends=""
 depends="libpulseaudio openssl libxcb dbus"

Re: [PR PATCH] [Updated] New Package: ncspot-0.11.2

[d33vliter]

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

There is an updated pull request by d33vliter against master on the void-packages repository

https://github.com/d33vliter/void-packages patch-2
https://github.com/void-linux/void-packages/pull/41327

New Package: ncspot-0.11.2
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41327.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-2-41327.patch --]
[-- Type: text/x-diff, Size: 2759 bytes --]

From b65589eb451dcf5fa5438d41d4ba938e0a14d16f Mon Sep 17 00:00:00 2001
From: d33vliter <iandupuy1998@gmail.com>
Date: Wed, 28 Dec 2022 00:18:20 -0500
Subject: [PATCH 1/3] New Package: ncspot0.11.2

---
 srcpkgs/ncspot/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 000000000000..b90f65e6d598
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,22 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.11.2
+revision=1
+archs="x86_64"
+wrksrc=${pkgname}-${version}
+create_wrksrc=yes
+#hostmakedepends=""
+#makedepends=""
+depends="libpulseaudio openssl libxcb dbus"
+short_desc="Is a ncurses Spotify client written in Rust using librespot"
+maintainer="d33vliter <d33vliter@protonmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/hrkfdn/ncspot"
+distfiles="https://github.com/hrkfdn/ncspot/releases/download/v${version}/ncspot-v${version}-linux-x86_64.tar.gz"
+checksum=a97b62a0bb19383b34fe2a0c7128bb8940e1e78dd1fa3be98cdb53b008ed6050
+
+
+ do_install(){
+	vbin ncspot
+
+ }

From 1ae41a5b88c3d493932e8b80a7f3e97e71ca32ca Mon Sep 17 00:00:00 2001
From: d33vliter <iandupuy1998@gmail.com>
Date: Wed, 28 Dec 2022 00:41:42 -0500
Subject: [PATCH 2/3] Update srcpkgs/ncspot/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/ncspot/template | 2 --
 1 file changed, 2 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index b90f65e6d598..1cd2164fee8e 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -3,8 +3,6 @@ pkgname=ncspot
 version=0.11.2
 revision=1
 archs="x86_64"
-wrksrc=${pkgname}-${version}
-create_wrksrc=yes
 #hostmakedepends=""
 #makedepends=""
 depends="libpulseaudio openssl libxcb dbus"

From 5ba9c841d35cf156e1484e964573ec05dc36955f Mon Sep 17 00:00:00 2001
From: d33vliter <iandupuy1998@gmail.com>
Date: Wed, 28 Dec 2022 00:41:54 -0500
Subject: [PATCH 3/3] Update srcpkgs/ncspot/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/ncspot/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 1cd2164fee8e..869976d1d1aa 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -6,7 +6,7 @@ archs="x86_64"
 #hostmakedepends=""
 #makedepends=""
 depends="libpulseaudio openssl libxcb dbus"
-short_desc="Is a ncurses Spotify client written in Rust using librespot"
+short_desc="ncurses Spotify client"
 maintainer="d33vliter <d33vliter@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/hrkfdn/ncspot"

Re: [PR PATCH] [Updated] New Package: ncspot-0.11.2

[d33vliter]

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

There is an updated pull request by d33vliter against master on the void-packages repository

https://github.com/d33vliter/void-packages patch-2
https://github.com/void-linux/void-packages/pull/41327

New Package: ncspot-0.11.2
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41327.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-2-41327.patch --]
[-- Type: text/x-diff, Size: 4242 bytes --]

From b65589eb451dcf5fa5438d41d4ba938e0a14d16f Mon Sep 17 00:00:00 2001
From: d33vliter <iandupuy1998@gmail.com>
Date: Wed, 28 Dec 2022 00:18:20 -0500
Subject: [PATCH 1/4] New Package: ncspot0.11.2

---
 srcpkgs/ncspot/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 000000000000..b90f65e6d598
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,22 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.11.2
+revision=1
+archs="x86_64"
+wrksrc=${pkgname}-${version}
+create_wrksrc=yes
+#hostmakedepends=""
+#makedepends=""
+depends="libpulseaudio openssl libxcb dbus"
+short_desc="Is a ncurses Spotify client written in Rust using librespot"
+maintainer="d33vliter <d33vliter@protonmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/hrkfdn/ncspot"
+distfiles="https://github.com/hrkfdn/ncspot/releases/download/v${version}/ncspot-v${version}-linux-x86_64.tar.gz"
+checksum=a97b62a0bb19383b34fe2a0c7128bb8940e1e78dd1fa3be98cdb53b008ed6050
+
+
+ do_install(){
+	vbin ncspot
+
+ }

From 1ae41a5b88c3d493932e8b80a7f3e97e71ca32ca Mon Sep 17 00:00:00 2001
From: d33vliter <iandupuy1998@gmail.com>
Date: Wed, 28 Dec 2022 00:41:42 -0500
Subject: [PATCH 2/4] Update srcpkgs/ncspot/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/ncspot/template | 2 --
 1 file changed, 2 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index b90f65e6d598..1cd2164fee8e 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -3,8 +3,6 @@ pkgname=ncspot
 version=0.11.2
 revision=1
 archs="x86_64"
-wrksrc=${pkgname}-${version}
-create_wrksrc=yes
 #hostmakedepends=""
 #makedepends=""
 depends="libpulseaudio openssl libxcb dbus"

From 5ba9c841d35cf156e1484e964573ec05dc36955f Mon Sep 17 00:00:00 2001
From: d33vliter <iandupuy1998@gmail.com>
Date: Wed, 28 Dec 2022 00:41:54 -0500
Subject: [PATCH 3/4] Update srcpkgs/ncspot/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/ncspot/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 1cd2164fee8e..869976d1d1aa 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -6,7 +6,7 @@ archs="x86_64"
 #hostmakedepends=""
 #makedepends=""
 depends="libpulseaudio openssl libxcb dbus"
-short_desc="Is a ncurses Spotify client written in Rust using librespot"
+short_desc="ncurses Spotify client"
 maintainer="d33vliter <d33vliter@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/hrkfdn/ncspot"

From 2e9ef7c76655c8345497401e2250c23aef7d12dd Mon Sep 17 00:00:00 2001
From: d33vliter <iandupuy1998@gmail.com>
Date: Wed, 28 Dec 2022 01:35:12 -0500
Subject: [PATCH 4/4] Update template

---
 srcpkgs/ncspot/template | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 869976d1d1aa..cf6c7a1320f4 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,20 +1,21 @@
 # Template file for 'ncspot'
 pkgname=ncspot
 version=0.11.2
-revision=1
-archs="x86_64"
-#hostmakedepends=""
-#makedepends=""
-depends="libpulseaudio openssl libxcb dbus"
+revision=2
+build_style=cargo
+hostmakedepends="pkg-config python3 libpulseaudio"
+makedepends="openssl-devel python3-devel libxcb-devel ncurses-devel dbus-devel"
 short_desc="ncurses Spotify client"
 maintainer="d33vliter <d33vliter@protonmail.com>"
-license="GPL-3.0-or-later"
+license="BSD 2-Clause License"
 homepage="https://github.com/hrkfdn/ncspot"
-distfiles="https://github.com/hrkfdn/ncspot/releases/download/v${version}/ncspot-v${version}-linux-x86_64.tar.gz"
-checksum=a97b62a0bb19383b34fe2a0c7128bb8940e1e78dd1fa3be98cdb53b008ed6050
+distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
+checksum=0fd9696e13912b906605e9972bf3b2a8a68688cce17478353713550801c94fab
 
+do_install() {
+	cargo build --release
+}
 
- do_install(){
-	vbin ncspot
-
- }
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New Package: ncspot-0.11.2

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41327#discussion_r1058110401

Comment:
```suggestion
```
the default do_install from the cargo build_style should work fine here. does it not?

Re: [PR REVIEW] New Package: ncspot-0.11.2

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41327#discussion_r1058123529

Comment:
libpulseaudio should be libpulseaudio-devel and in makedepends

Re: [PR REVIEW] New Package: ncspot-0.11.2

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41327#discussion_r1058124208

Comment:
https://github.com/void-linux/void-packages/actions/runs/3792212763/jobs/6448498462#step:8:9

do_build is already building the binaries, and do_install is when those files are moved to the package destination directory. with do_install overridden, it creates an empty package

Re: New Package: ncspot-0.11.2

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/41327#issuecomment-1366498701

Comment:
There is also this one: https://github.com/void-linux/void-packages/pull/33600

Re: [PR PATCH] [Closed]: New Package: ncspot-0.11.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

There's a closed pull request on the void-packages repository

New Package: ncspot-0.11.2
https://github.com/void-linux/void-packages/pull/41327

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->