Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] cpuburn: build statically
@ 2022-12-28 14:20 sgn
  2022-12-28 19:51 ` [PR PATCH] [Merged]: " leahneukirchen
  2022-12-28 20:51 ` sbromberger
  0 siblings, 2 replies; 3+ messages in thread
From: sgn @ 2022-12-28 14:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages cpuburn-static
https://github.com/void-linux/void-packages/pull/41329

cpuburn: build statically
The status quote of cpuburn is always built for 32bits on x86_64, which requires dynamic linker for 32 bit system.

On x86-64 system, we can workaround by depends on glibc-32bit. However, we don't have that luxury on x86_64-musl system.

Since `cpuburn` doesn't use any features from libc and/or dynamic linker, we can simply build static instead.

Fix #41307

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41329.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cpuburn-static-41329.patch --]
[-- Type: text/x-diff, Size: 1558 bytes --]

From 5cfea8e7b3281e89b90099cf5fbe33594c037983 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Wed, 28 Dec 2022 21:19:34 +0700
Subject: [PATCH] cpuburn: build statically

The status quote of cpuburn is always built for 32bits on x86_64,
which requires dynamic linker for 32 bit system.

On x86-64 system, we can workaround by depends on glibc-32bit.
However, we don't have that luxury on x86_64-musl system.

Since `cpuburn` doesn't use any features from libc and/or
dynamic linker, we can simply build static instead.

Fix #41307
---
 srcpkgs/cpuburn/patches/02-m32.patch | 2 +-
 srcpkgs/cpuburn/template             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/cpuburn/patches/02-m32.patch b/srcpkgs/cpuburn/patches/02-m32.patch
index 6da74c20b0fd..d7a1cdf3945e 100644
--- a/srcpkgs/cpuburn/patches/02-m32.patch
+++ b/srcpkgs/cpuburn/patches/02-m32.patch
@@ -4,4 +4,4 @@
  all : burnP5 burnP6 burnK6 burnK7 burnBX burnMMX
  .S:
 -	gcc -s -nostdlib -o $@ $<
-+	gcc -m32 -s -nostdlib -o $@ $<
++	gcc -static -m32 -s -nostdlib -o $@ $<
diff --git a/srcpkgs/cpuburn/template b/srcpkgs/cpuburn/template
index a215520fb764..27ac24c39e42 100644
--- a/srcpkgs/cpuburn/template
+++ b/srcpkgs/cpuburn/template
@@ -1,7 +1,7 @@
 # Template file for 'cpuburn'
 pkgname=cpuburn
 version=1.4a
-revision=4
+revision=5
 archs="armv6l* armv7l* i686* x86_64*"
 short_desc="Collection of programs to put heavy load on CPU"
 maintainer="Leah Neukirchen <leah@vuxu.org>"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: cpuburn: build statically
  2022-12-28 14:20 [PR PATCH] cpuburn: build statically sgn
@ 2022-12-28 19:51 ` leahneukirchen
  2022-12-28 20:51 ` sbromberger
  1 sibling, 0 replies; 3+ messages in thread
From: leahneukirchen @ 2022-12-28 19:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

There's a merged pull request on the void-packages repository

cpuburn: build statically
https://github.com/void-linux/void-packages/pull/41329

Description:
The status quote of cpuburn is always built for 32bits on x86_64, which requires dynamic linker for 32 bit system.

On x86-64 system, we can workaround by depends on glibc-32bit. However, we don't have that luxury on x86_64-musl system.

Since `cpuburn` doesn't use any features from libc and/or dynamic linker, we can simply build static instead.

Fix #41307

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: cpuburn: build statically
  2022-12-28 14:20 [PR PATCH] cpuburn: build statically sgn
  2022-12-28 19:51 ` [PR PATCH] [Merged]: " leahneukirchen
@ 2022-12-28 20:51 ` sbromberger
  1 sibling, 0 replies; 3+ messages in thread
From: sbromberger @ 2022-12-28 20:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by sbromberger on void-packages repository

https://github.com/void-linux/void-packages/pull/41329#issuecomment-1366909368

Comment:
Thank you both for the really quick turnaround!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-12-28 20:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-28 14:20 [PR PATCH] cpuburn: build statically sgn
2022-12-28 19:51 ` [PR PATCH] [Merged]: " leahneukirchen
2022-12-28 20:51 ` sbromberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).