[PR PATCH] neovim: switch to custom build type

[PR PATCH] neovim: switch to custom build type

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

There is a new pull request by tranzystorek-io against master on the void-packages repository

https://github.com/tranzystorek-io/void-packages nvim-build-type
https://github.com/void-linux/void-packages/pull/41384

neovim: switch to custom build type
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41384.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nvim-build-type-41384.patch --]
[-- Type: text/x-diff, Size: 2637 bytes --]

From 1bfa2fb9eb6f6028fc1d0aaadf659dfe092b2e2a Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Sat, 31 Dec 2022 18:05:47 +0100
Subject: [PATCH] neovim: switch to custom build type

---
 .../patches/cmake-allow-build-type-none.patch | 26 +++++++++++++++++++
 srcpkgs/neovim/template                       |  4 +--
 2 files changed, 28 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/neovim/patches/cmake-allow-build-type-none.patch

diff --git a/srcpkgs/neovim/patches/cmake-allow-build-type-none.patch b/srcpkgs/neovim/patches/cmake-allow-build-type-none.patch
new file mode 100644
index 000000000000..d6d8c8f1b15f
--- /dev/null
+++ b/srcpkgs/neovim/patches/cmake-allow-build-type-none.patch
@@ -0,0 +1,26 @@
+diff --git a/cmake/Util.cmake b/cmake/Util.cmake
+index 343a729..d7d15e1 100644
+--- a/cmake/Util.cmake
++++ b/cmake/Util.cmake
+@@ -177,7 +177,7 @@ function(set_default_buildtype)
+       message(STATUS "CMAKE_BUILD_TYPE not specified, default is 'Debug'")
+       set(CMAKE_BUILD_TYPE Debug CACHE STRING "Choose the type of build" FORCE)
+     elseif(NOT CMAKE_BUILD_TYPE IN_LIST allowableBuildTypes)
+-      message(FATAL_ERROR "Invalid build type: ${CMAKE_BUILD_TYPE}")
++      message(WARNING "Invalid build type: ${CMAKE_BUILD_TYPE}")
+     else()
+       message(STATUS "CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}")
+     endif()
+diff --git a/runtime/autoload/health/nvim.vim b/runtime/autoload/health/nvim.vim
+index be56658..46fdd0f 100644
+--- a/runtime/autoload/health/nvim.vim
++++ b/runtime/autoload/health/nvim.vim
+@@ -135,7 +135,7 @@ function! s:check_performance() abort
+   let buildtype = matchstr(execute('version'), '\v\cbuild type:?\s*[^\n\r\t ]+')
+   if empty(buildtype)
+     call health#report_error('failed to get build type from :version')
+-  elseif buildtype =~# '\v(MinSizeRel|Release|RelWithDebInfo)'
++  elseif buildtype =~# '\v(MinSizeRel|Release|RelWithDebInfo|None)'
+     call health#report_ok(buildtype)
+   else
+     call health#report_info(buildtype)
diff --git a/srcpkgs/neovim/template b/srcpkgs/neovim/template
index 8ee497a2fc18..da9efa2a4098 100644
--- a/srcpkgs/neovim/template
+++ b/srcpkgs/neovim/template
@@ -1,10 +1,10 @@
 # Template file for 'neovim'
 pkgname=neovim
 version=0.8.2
-revision=1
+revision=2
 build_style=cmake
 build_helper="qemu"
-configure_args="-DCMAKE_BUILD_TYPE=Release -DCOMPILE_LUA=OFF"
+configure_args="-DCOMPILE_LUA=OFF"
 hostmakedepends="pkg-config gettext gperf LuaJIT lua51-lpeg lua51-mpack"
 makedepends="libtermkey-devel libuv-devel libvterm-devel msgpack-devel
  LuaJIT-devel libluv-devel tree-sitter-devel"

Re: neovim: switch to custom build type

[kruceter]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/pull/41384#issuecomment-1368735351

Comment:
How about adding `None` to `allowableBuildTypes` instead? ([0001-fixup-neovim-switch-to-custom-build-type.txt](https://github.com/void-linux/void-packages/files/10330567/0001-fixup-neovim-switch-to-custom-build-type.txt))

Re: neovim: switch to custom build type

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

New comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/41384#issuecomment-1368745115

Comment:
> How about adding `None` to `allowableBuildTypes` instead? ([0001-fixup-neovim-switch-to-custom-build-type.txt](https://github.com/void-linux/void-packages/files/10330567/0001-fixup-neovim-switch-to-custom-build-type.txt))

We could, but the `fatal -> warning` seems more straightforward to me

Re: [PR PATCH] [Merged]: neovim: switch to custom build type

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

There's a merged pull request on the void-packages repository

neovim: switch to custom build type
https://github.com/void-linux/void-packages/pull/41384

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->