[PR PATCH] black: ignore alpha releases.

[PR PATCH] black: ignore alpha releases.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages black-fix-update
https://github.com/void-linux/void-packages/pull/41481

black: ignore alpha releases.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41481.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-black-fix-update-41481.patch --]
[-- Type: text/x-diff, Size: 481 bytes --]

From 91a4792585ccfc2f4dfed5dd245d74728fe50a0a Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 5 Jan 2023 23:59:17 +0000
Subject: [PATCH] black: ignore alpha releases.

---
 srcpkgs/black/update | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 srcpkgs/black/update

diff --git a/srcpkgs/black/update b/srcpkgs/black/update
new file mode 100644
index 000000000000..2c857beffb29
--- /dev/null
+++ b/srcpkgs/black/update
@@ -0,0 +1 @@
+ignore="*a*"

Re: black: ignore alpha releases.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#issuecomment-1373205771

Comment:
Maybe it will be better to ignore non-numeric chars all together since there are beta releases too: https://github.com/psf/black/releases

Re: black: ignore alpha releases.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#issuecomment-1373753132

Comment:
Maybe, but back when beta releases for black were used, they were meant to convey the stability of black as a whole, not the stability of that specific release. However, after black was declared stable, beta releases were never used, so we don't know what they'll convey in the future in terms of stability of the release. As a result, I think it's better to be conservative and ignore only alpha releases until a sufficient reason to ignore beta releases too arises.

Re: black: ignore alpha releases.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#issuecomment-1373753132

Comment:
Maybe, but back when beta releases for black were used, they were meant to convey the stability of black as a whole, not the stability of that specific release. However, after black was declared stable, beta releases were never used, so we don't know what they'll convey in the future in terms of stability of the release. As a result, I think it's better to be conservative and ignore only alpha releases until a sufficient reason to ignore beta releases too arises (better than missing a "beta" release that's actually considered stable).

Re: [PR REVIEW] black: ignore alpha releases.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#discussion_r1063937602

Comment:
this will ignore `1.33.7-all-bugs-squashed`

Re: [PR REVIEW] black: ignore alpha releases.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#discussion_r1063937602

Comment:
this will ignore `1.33.7-all-bugs-squashed` or `black-1.33.7`

Re: [PR REVIEW] black: ignore alpha releases.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#discussion_r1065803810

Comment:
Good point, I'll push a fix for it.

Re: [PR REVIEW] black: ignore alpha releases.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#discussion_r1161122139

Comment:
Actually, according to the manual, `ignore` is matched against version numbers, so I think this shouldn't be an issue? Many other packages also do something similar, so if it is an issue, those packages have to be updated too.

Re: [PR REVIEW] black: ignore alpha releases.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#discussion_r1241361264

Comment:
it won't actually ignore those, as it only captures the version part of the regex it uses

Re: [PR REVIEW] black: ignore alpha releases.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#discussion_r1241361264

Comment:
it won't actually ignore those, as it only captures the version part of the regex it uses. that said, it should also ignore beta releases (`*b*`)

Re: [PR REVIEW] black: ignore alpha releases.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#discussion_r1241900797

Comment:
@classabbyamp see my [comment above](https://github.com/void-linux/void-packages/pull/41481#issuecomment-1373753132).

Re: [PR REVIEW] black: ignore alpha releases.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#discussion_r1241906706

Comment:
it's pretty clear what beta would mean in the future, if used again.

Re: [PR REVIEW] black: ignore alpha releases.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#discussion_r1242330037

Comment:
Okay then.

Re: [PR REVIEW] black: ignore alpha releases.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/41481#discussion_r1242330037

Comment:
Okay then, I'll update this.

Re: [PR PATCH] [Updated] black: ignore alpha releases.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages black-fix-update
https://github.com/void-linux/void-packages/pull/41481

black: ignore alpha releases.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41481.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-black-fix-update-41481.patch --]
[-- Type: text/x-diff, Size: 494 bytes --]

From 9061ab6e87a214dd09192f68926cba70213cd93d Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 5 Jan 2023 23:59:17 +0000
Subject: [PATCH] black: ignore alpha and beta releases.

---
 srcpkgs/black/update | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 srcpkgs/black/update

diff --git a/srcpkgs/black/update b/srcpkgs/black/update
new file mode 100644
index 000000000000..e957dc43055f
--- /dev/null
+++ b/srcpkgs/black/update
@@ -0,0 +1 @@
+ignore="*a* *b*"

Re: [PR PATCH] [Updated] black: ignore alpha and beta releases.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages black-fix-update
https://github.com/void-linux/void-packages/pull/41481

black: ignore alpha and beta releases.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**
[ci skip]
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41481.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-black-fix-update-41481.patch --]
[-- Type: text/x-diff, Size: 494 bytes --]

From 17b626627effb40b56b6f955654bd6ccfa36d596 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 5 Jan 2023 23:59:17 +0000
Subject: [PATCH] black: ignore alpha and beta releases.

---
 srcpkgs/black/update | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 srcpkgs/black/update

diff --git a/srcpkgs/black/update b/srcpkgs/black/update
new file mode 100644
index 000000000000..e957dc43055f
--- /dev/null
+++ b/srcpkgs/black/update
@@ -0,0 +1 @@
+ignore="*a* *b*"

Re: [PR PATCH] [Merged]: black: ignore alpha and beta releases.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

There's a merged pull request on the void-packages repository

black: ignore alpha and beta releases.
https://github.com/void-linux/void-packages/pull/41481

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

[ci skip]
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->