[PR PATCH] chroot-grep: patch out problematic warnings in egrep and fgrep.

[PR PATCH] chroot-grep: patch out problematic warnings in egrep and fgrep.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages egrep
https://github.com/void-linux/void-packages/pull/41593

chroot-grep: patch out problematic warnings in egrep and fgrep.
This mirrors the changes from grep in https://github.com/void-linux/void-packages/commit/ef5ffe4d696b31041c272be92e912fb454c075ac into chroot-grep.

A patch file from https://github.com/void-linux/void-packages/pull/41593.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-egrep-41593.patch --]
[-- Type: text/x-diff, Size: 1476 bytes --]

From 6aab3a8f07f8dcc4a12bcacc07ec49720e01d961 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 12 Jan 2023 01:37:31 +0530
Subject: [PATCH] chroot-grep: patch out problematic warnings in egrep and
 fgrep.

---
 .../chroot-grep/patches/efgrep-remove-warning.patch    | 10 ++++++++++
 srcpkgs/chroot-grep/template                           |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/chroot-grep/patches/efgrep-remove-warning.patch

diff --git a/srcpkgs/chroot-grep/patches/efgrep-remove-warning.patch b/srcpkgs/chroot-grep/patches/efgrep-remove-warning.patch
new file mode 100644
index 000000000000..6371301688f0
--- /dev/null
+++ b/srcpkgs/chroot-grep/patches/efgrep-remove-warning.patch
@@ -0,0 +1,10 @@
+since 3.8, egrep and fgrep print a warning which can cause many issues with
+programs not expecting this behaviour
+
+--- a/src/egrep.sh
++++ b/src/egrep.sh
+@@ -1,4 +1,3 @@
+ #!@SHELL@
+ cmd=${0##*/}
+-echo "$cmd: warning: $cmd is obsolescent; using @grep@ @option@" >&2
+ exec @grep@ @option@ "$@"
diff --git a/srcpkgs/chroot-grep/template b/srcpkgs/chroot-grep/template
index 6a99116d4b5d..7b68ca9348b8 100644
--- a/srcpkgs/chroot-grep/template
+++ b/srcpkgs/chroot-grep/template
@@ -1,7 +1,7 @@
 # Template file for 'chroot-grep'
 pkgname=chroot-grep
 version=3.8
-revision=1
+revision=2
 bootstrap=yes
 build_style=gnu-configure
 configure_args="--disable-perl-regexp --disable-nls ac_cv_path_GREP=grep"

Re: chroot-grep: patch out problematic warnings in egrep and fgrep.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41593#issuecomment-1379914901

Comment:
Before updating chroot-grep, I rebuilt the whole repository and nothing failed to build without this patch. Is there a reason for this?

Re: chroot-grep: patch out problematic warnings in egrep and fgrep.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/41593#issuecomment-1379918145

Comment:
discussions in the linked pr ^

Re: [PR PATCH] [Merged]: chroot-grep: patch out problematic warnings in egrep and fgrep.

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

There's a merged pull request on the void-packages repository

chroot-grep: patch out problematic warnings in egrep and fgrep.
https://github.com/void-linux/void-packages/pull/41593

Description:
This mirrors the changes from grep in https://github.com/void-linux/void-packages/commit/ef5ffe4d696b31041c272be92e912fb454c075ac into chroot-grep.

Re: chroot-grep: patch out problematic warnings in egrep and fgrep.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41593#issuecomment-1380834924

Comment:
I am still against this even though this was merged, the grep package regular users get has this patched out and we are able to fix this in packaging and send PRs upstream. This is an upstream decision and packages that use e/fgrep and this causes an issue should be fixed instead.