[PR PATCH] NoiseTorch: remove package

[PR PATCH] NoiseTorch: remove package

[lz-coder]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

There is a new pull request by lz-coder against master on the void-packages repository

https://github.com/lz-coder/void-packages NoiseTorch
https://github.com/void-linux/void-packages/pull/41656

NoiseTorch: remove package
This version of NoiseTorch is dead because of secutity breach, see: https://github.com/lawl/NoiseTorch.

A patch file from https://github.com/void-linux/void-packages/pull/41656.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NoiseTorch-41656.patch --]
[-- Type: text/x-diff, Size: 2211 bytes --]

From 3231dd99283bf4424978b83dffaf78e337a5a8d3 Mon Sep 17 00:00:00 2001
From: lz-coder <lzcoder@proton.me>
Date: Sat, 14 Jan 2023 20:10:58 -0300
Subject: [PATCH] NoiseTorch: remove package

---
 srcpkgs/NoiseTorch/INSTALL        |  5 -----
 srcpkgs/NoiseTorch/template       | 25 -------------------------
 srcpkgs/removed-packages/template |  1 +
 3 files changed, 1 insertion(+), 30 deletions(-)
 delete mode 100644 srcpkgs/NoiseTorch/INSTALL
 delete mode 100644 srcpkgs/NoiseTorch/template

diff --git a/srcpkgs/NoiseTorch/INSTALL b/srcpkgs/NoiseTorch/INSTALL
deleted file mode 100644
index 63f13c0c59ea..000000000000
--- a/srcpkgs/NoiseTorch/INSTALL
+++ /dev/null
@@ -1,5 +0,0 @@
-case "${ACTION}" in
-post)
-	setcap 'CAP_SYS_RESOURCE=+ep' usr/bin/noisetorch
-	;;
-esac
diff --git a/srcpkgs/NoiseTorch/template b/srcpkgs/NoiseTorch/template
deleted file mode 100644
index a9e9fb2c92d4..000000000000
--- a/srcpkgs/NoiseTorch/template
+++ /dev/null
@@ -1,25 +0,0 @@
-# Template file for 'NoiseTorch'
-pkgname=NoiseTorch
-version=0.11.4
-revision=1
-build_style=go
-go_ldflags="-X main.version=${version} -X main.distribution=VoidLinux"
-go_import_path="noisetorch"
-depends="libcap-progs"
-short_desc="Real-time microphone noise suppression on Linux"
-maintainer="Soc Virnyl S. Estela <renegan.ronin@gmail.com>"
-license="GPL-3.0-or-later"
-homepage="https://github.com/lawl/NoiseTorch"
-distfiles="https://github.com/lawl/NoiseTorch/archive/${version}.tar.gz"
-checksum=3da6cad119ecca6f4e131c8bca86eb122d2363d5d30dcd1da41974af5887a3c1
-
-pre_build() {
-	make rnnoise
-	GOARCH= go build scripts/embedlicenses.go
-	./embedlicenses
-}
-
-post_install() {
-	vinstall assets/noisetorch.desktop 644 usr/share/applications
-	vinstall assets/icon/noisetorch.png 644 usr/share/icons/hicolor/256x256/apps
-}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 8febb5f0c1f4..749531505134 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -323,6 +323,7 @@ replaces="
  ncdns<=0.0.2_12
  newt-python<=0.52.21_5
  nodejs-lts-10<=10.24.0_2
+ NoiseTorch<=0.11.4
  nvidia340-dkms<=340.108_4
  nvidia340-libs<=340.108_4
  nvidia340-opencl<=340.108_4

Re: NoiseTorch: remove package

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41656#issuecomment-1382959899

Comment:
is there another upstream we can switch to?

Re: NoiseTorch: remove package

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

New comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/41656#issuecomment-1382960042

Comment:
Fwiw there's this community continued fork of the original project: https://github.com/noisetorch/NoiseTorch

I don't use the program personally (anymore) so I don't care what happens with it, just pointing out what I know.

Re: NoiseTorch: remove package

[lz-coder]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

New comment by lz-coder on void-packages repository

https://github.com/void-linux/void-packages/pull/41656#issuecomment-1382963880

Comment:
Yes, the community continued the project, and audits were carried out, because of this security issue. I tried to update the template and build a package for this new version of the community but with no success.

Re: NoiseTorch: remove package

[paper42]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41656#issuecomment-1382964184

Comment:
What was the issue?

Re: NoiseTorch: remove package

[lz-coder]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by lz-coder on void-packages repository

https://github.com/void-linux/void-packages/pull/41656#issuecomment-1382964867

Comment:
This new version relies on two git submodules to build.

Re: NoiseTorch: remove package

[paper42]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41656#issuecomment-1382968337

Comment:
That is not an issue

Re: NoiseTorch: remove package

[paper42]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41656#issuecomment-1382968337

Comment:
That is not an issue, we can easily have the submodules in distfiles just like many other packages, see chatty for an example.

Re: NoiseTorch: remove package

[paper42]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41656#issuecomment-1382968337

Comment:
That is not an issue, we can easily have the submodules in distfiles just like many other packages, see chatterino2 for an example.

Re: NoiseTorch: remove package

[lz-coder]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

New comment by lz-coder on void-packages repository

https://github.com/void-linux/void-packages/pull/41656#issuecomment-1382975123

Comment:
These two submodules don't have releases published, just git repos.
"Software need to be used in version announced by authors as ready to use by the general public - usually called releases. Betas, arbitrary VCS revisions, templates using tip of development branch taken at build time and releases created by the package maintainer won't be accepted."

Re: NoiseTorch: remove package

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

New comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/41656#issuecomment-1383006995

Comment:
Unfortunately for some programs not much can be done about that, if it's just submodules that don't have tags (but main repo does) it's generally fine to package it, it's just more maintenance burden. https://github.com/void-linux/void-packages/blob/master/srcpkgs/babashka/template is an example of a really unfortunate amount of vendored submodules.

We already have [`rnnoise`](https://github.com/void-linux/void-packages/blob/master/srcpkgs/rnnoise/template) packaged as well so maybe you could make use of `rnnoise-devel` to build against the distro packaging (which is up-to-date) and avoid the submodule for that at least; there is an upstream issue about creating a tag since late 2020: https://github.com/xiph/rnnoise/issues/137

Re: NoiseTorch: remove package

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/41656#issuecomment-1509458721

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: NoiseTorch: remove package

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

There's a closed pull request on the void-packages repository

NoiseTorch: remove package
https://github.com/void-linux/void-packages/pull/41656

Description:
This version of NoiseTorch is dead because of secutity breach, see: https://github.com/lawl/NoiseTorch.