[PR PATCH] New package: radio-sh-2.0

[PR PATCH] New package: radio-sh-2.0

[Singustromo]

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

There is a new pull request by Singustromo against master on the void-packages repository

https://github.com/Singustromo/void-packages new-pkg_radio-sh
https://github.com/void-linux/void-packages/pull/41737

New package: radio-sh-2.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)


A patch file from https://github.com/void-linux/void-packages/pull/41737.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-pkg_radio-sh-41737.patch --]
[-- Type: text/x-diff, Size: 1454 bytes --]

From 2e53610e90cf4c3084ad4a1dae5f3ee3279f65b5 Mon Sep 17 00:00:00 2001
From: Singustromo <singustromo@disroot.org>
Date: Thu, 19 Jan 2023 05:09:44 +0100
Subject: [PATCH] New package: radio-sh-2.0

---
 srcpkgs/radio-sh/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/radio-sh/template

diff --git a/srcpkgs/radio-sh/template b/srcpkgs/radio-sh/template
new file mode 100644
index 000000000000..09fa6efa907e
--- /dev/null
+++ b/srcpkgs/radio-sh/template
@@ -0,0 +1,25 @@
+# Template file for 'radio-sh'
+pkgname=radio-sh
+version=2.0
+revision=9
+build_style=fetch
+hostmakedepends="tar gzip"
+depends="bash>=5.1.016_2 procps-ng>=3.3.17_2 mpv>=0.35.0_2 socat>=1.7.4.4_1 jq>=1.6_2"
+short_desc="Conveniently play internet radio streams, with simplicity in mind"
+maintainer="Singustromo <singustromo@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://git.nevrlands.de/radio-sh/about/"
+distfiles="https://git.nevrlands.de/$pkgname/snapshot/${pkgname}-${version}.${revision}.tar.gz"
+checksum=b2bf165fbe23e86144a2565fe77ba04706d539c74e294f0fa333261bf6a235cf
+tags="bash script radio stream radiostream"
+mutable_files="/etc/xdg/radio-sh/radio_config.json"
+
+do_extract() {
+	tar --strip-components 1 --no-same-owner --extract --file \
+		${XBPS_SRCDISTDIR}/${pkgname}-${version}/${pkgname}-${version}.${revision}.tar.gz \
+		--directory ${wrksrc}
+}
+
+do_install() {
+	vbin $wrksrc/radio
+}

Re: New package: radio-sh-2.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41737#issuecomment-1396422141

Comment:
> 1. System: The software should be installed system-wide, not per-user.
> 2. Compiled: The software needs to be compiled before being used, even if it is software that is not needed by the whole system.
> 3. Required: Another package either within the repository or pending inclusion requires the package.
>
> [...] Simple shell scripts are unlikely to be accepted unless they provide considerable value to a broad user base. [...]

from [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements)

how does this meet those requirements?

Re: New package: radio-sh-2.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/41737#issuecomment-1396440930

Comment:
This belongs in `~/bin`, not a distribution package.

Re: [PR PATCH] [Closed]: New package: radio-sh-2.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

There's a closed pull request on the void-packages repository

New package: radio-sh-2.0
https://github.com/void-linux/void-packages/pull/41737

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)

Re: New package: radio-sh-2.0

[Singustromo]

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

New comment by Singustromo on void-packages repository

https://github.com/void-linux/void-packages/pull/41737#issuecomment-1396940319

Comment:
> > 1. System: The software should be installed system-wide, not per-user.
> > 2. Compiled: The software needs to be compiled before being used, even if it is software that is not needed by the whole system.
> > 3. Required: Another package either within the repository or pending inclusion requires the package.
> > 
> > [...] Simple shell scripts are unlikely to be accepted unless they provide considerable value to a broad user base. [...]
> 
> from [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements)
> 
> how does this meet those requirements?

All right, I thought it might be something worth adding since there are also packages like #14199 with a similar functionality but also with more dependencies. I don't really think this is a **small** unneeded script.

Re: New package: radio-sh-2.0

[Singustromo]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

New comment by Singustromo on void-packages repository

https://github.com/void-linux/void-packages/pull/41737#issuecomment-1396940319

Comment:
> > 1. System: The software should be installed system-wide, not per-user.
> > 2. Compiled: The software needs to be compiled before being used, even if it is software that is not needed by the whole system.
> > 3. Required: Another package either within the repository or pending inclusion requires the package.
> > 
> > [...] Simple shell scripts are unlikely to be accepted unless they provide considerable value to a broad user base. [...]
> 
> from [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements)
> 
> how does this meet those requirements?

All right, I thought it might be something worth adding since there are also packages like #14199 with a similar functionality but also with more dependencies. PyRadio - in the end of the day - is also a wrapper for mpv.

Re: New package: radio-sh-2.0

[Singustromo]

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

New comment by Singustromo on void-packages repository

https://github.com/void-linux/void-packages/pull/41737#issuecomment-1396940319

Comment:
> > 1. System: The software should be installed system-wide, not per-user.
> > 2. Compiled: The software needs to be compiled before being used, even if it is software that is not needed by the whole system.
> > 3. Required: Another package either within the repository or pending inclusion requires the package.
> > 
> > [...] Simple shell scripts are unlikely to be accepted unless they provide considerable value to a broad user base. [...]
> 
> from [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements)
> 
> how does this meet those requirements?

All right, I thought it might be something worth adding since there are also packages like #14199 with similar functionality but also with more dependencies. PyRadio - in the end of the day - is also a wrapper for mpv.

Re: New package: radio-sh-2.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/41737#issuecomment-1396966788

Comment:
It's not about the length of the shell script, but whether

    curl -L -O ~/bin/output.sh https://some-url-for-download

is equivalent to

    xbps-install some-package

and, for a single shell script that is intended for individual use on a personal computer, is generally true. It is certainly true here. The PyRadio package requires a proper installation and integration into the system's python ecosystem (or else venv management) and is therefore a candidate for packaging.

Re: New package: radio-sh-2.0

[Singustromo]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by Singustromo on void-packages repository

https://github.com/void-linux/void-packages/pull/41737#issuecomment-1397161993

Comment:
Thank you for the explanation. I did not think of it this way.

Is there another way to share such things in an unobtrusive manner?

Re: New package: radio-sh-2.0

[Singustromo]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New comment by Singustromo on void-packages repository

https://github.com/void-linux/void-packages/pull/41737#issuecomment-1397161993

Comment:
Thank you for the explanation. I did not think of it this way.

Is there another way - in general - to share such things in an unobtrusive manner?