Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] libechonest-qt5: remove package
@ 2023-01-29 12:59 Johnnynator
  2023-01-29 14:43 ` [PR PATCH] [Merged]: " Johnnynator
  0 siblings, 1 reply; 2+ messages in thread
From: Johnnynator @ 2023-01-29 12:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

There is a new pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages remove-libechonest-qt5
https://github.com/void-linux/void-packages/pull/41937

libechonest-qt5: remove package
libechonest is unmaintained close to a decade and doesn't compile ootb with gcc12
Neither of the 2 packages that had libechonest in their template did actually use it.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41937.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-remove-libechonest-qt5-41937.patch --]
[-- Type: text/x-diff, Size: 4622 bytes --]

From 47f248675881510e3cda37bd9914080d4534b47f Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Sun, 29 Jan 2023 13:56:07 +0100
Subject: [PATCH] libechonest-qt5: remove package

libechonest is unmaintained close to a decade and doesn't compile ootb with gcc12
Neither of the 2 packages that had libechonest in their template did actually use it.
---
 srcpkgs/clementine/template       |  2 +-
 srcpkgs/libechonest-qt5-devel     |  1 -
 srcpkgs/libechonest-qt5/template  | 30 ------------------------------
 srcpkgs/libechonest-qt5/update    |  1 -
 srcpkgs/removed-packages/template |  4 +++-
 srcpkgs/tomahawk/template         |  2 +-
 6 files changed, 5 insertions(+), 35 deletions(-)
 delete mode 120000 srcpkgs/libechonest-qt5-devel
 delete mode 100644 srcpkgs/libechonest-qt5/template
 delete mode 100644 srcpkgs/libechonest-qt5/update

diff --git a/srcpkgs/clementine/template b/srcpkgs/clementine/template
index b9b554cd7778..d8492fc1eed4 100644
--- a/srcpkgs/clementine/template
+++ b/srcpkgs/clementine/template
@@ -12,7 +12,7 @@ makedepends="chromaprint-devel boost-devel gst-plugins-base1-devel
  taglib-devel crypto++-devel $(vopt_if spotify libspotify-devel)
  libgpod-devel libmygpo-qt-devel qt5-x11extras-devel qt5-plugin-mysql
  qt5-plugin-pgsql qt5-plugin-sqlite qt5-plugin-tds qt5-plugin-odbc
- qt5-tools-devel liblastfm-qt5-devel libechonest-qt5-devel projectM-devel"
+ qt5-tools-devel liblastfm-qt5-devel projectM-devel"
 depends="desktop-file-utils"
 short_desc="Modern music player and library organizer"
 maintainer="Andrea Brancaleoni <abc@pompel.me>"
diff --git a/srcpkgs/libechonest-qt5-devel b/srcpkgs/libechonest-qt5-devel
deleted file mode 120000
index bf36a5da4be3..000000000000
--- a/srcpkgs/libechonest-qt5-devel
+++ /dev/null
@@ -1 +0,0 @@
-libechonest-qt5
\ No newline at end of file
diff --git a/srcpkgs/libechonest-qt5/template b/srcpkgs/libechonest-qt5/template
deleted file mode 100644
index b2f341535b0d..000000000000
--- a/srcpkgs/libechonest-qt5/template
+++ /dev/null
@@ -1,30 +0,0 @@
-# Template file for 'libechonest-qt5'
-pkgname=libechonest-qt5
-version=2.3.1
-revision=2
-build_style=cmake
-configure_args="-DBUILD_WITH_QT4=OFF"
-hostmakedepends="qt5-qmake"
-makedepends="boost-devel qt5-xmlpatterns-devel"
-short_desc="A C++/Qt wrapper around the wonderful echo nest api"
-maintainer="Duncaen <duncaen@voidlinux.org>"
-license="GPL-2.0-or-later"
-homepage="https://projects.kde.org/projects/playground/libs/libechonest"
-distfiles="http://files.lfranchi.com/${pkgname%-*}-${version}.tar.bz2"
-checksum=56756545fd1cb3d9067479f52215b6157c1ced2bc82b895e72fdcd9bebb47889
-
-if [ -n "$CROSS_BUILD" ]; then
-	hostmakedepends+=" qt5-host-tools qt5-xmlpatterns-devel"
-fi
-
-libechonest-qt5-devel_package() {
-	depends="${sourcepkg}-${version}_${revision}"
-	short_desc+=" - development files"
-	provides="libechonest-devel-${version}_${revision}"
-	replaces="libechonest-devel>=0"
-	pkg_install() {
-		vmove usr/include
-		vmove usr/lib/*.so
-		vmove usr/lib/pkgconfig
-	}
-}
diff --git a/srcpkgs/libechonest-qt5/update b/srcpkgs/libechonest-qt5/update
deleted file mode 100644
index 45bccdf8f388..000000000000
--- a/srcpkgs/libechonest-qt5/update
+++ /dev/null
@@ -1 +0,0 @@
-pkgname=${pkgname%-*}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 0429a5fb4796..8528ac460a0b 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -1,6 +1,6 @@
 # Template file for 'removed-packages'
 pkgname=removed-packages
-version=0.1.20230120
+version=0.1.20230129
 revision=1
 build_style=meta
 short_desc="Uninstalls packages removed from repository"
@@ -266,6 +266,8 @@ replaces="
  libapp<=20140527_2
  libco-devel<=20_1
  libco<=20_1
+ libechonest-qt5<=2.3.1_2
+ libechonest-qt5-devel<=2.3.1_2
  libdbusmenu-qt<=0.9.2_4
  libfcitx-qt-devel<=4.2.9.8_1
  libfcitx-qt<=4.2.9.8_1
diff --git a/srcpkgs/tomahawk/template b/srcpkgs/tomahawk/template
index c01d8eb0dc93..5b251d6a464f 100644
--- a/srcpkgs/tomahawk/template
+++ b/srcpkgs/tomahawk/template
@@ -13,7 +13,7 @@ configure_args="-Wno-dev -DBUILD_RELEASE=ON \
  $(vopt_if upower '-DWITH_UPOWER=ON' '-DWITH_UPOWER=OFF')"
 hostmakedepends="pkg-config extra-cmake-modules"
 makedepends="Lucene++-devel attica-qt5-devel boost-devel gnutls-devel
- libechonest-qt5-devel liblastfm-qt5-devel phonon-qt5-devel qca-qt5-devel
+ liblastfm-qt5-devel phonon-qt5-devel qca-qt5-devel
  qt5-svg-devel qt5-tools-devel qt5-webkit-devel qtkeychain-qt5-devel
  quazip-devel sparsehash taglib-devel vlc-devel
  $(vopt_if hatchet websocketpp) $(vopt_if xmpp jreen-devel)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: libechonest-qt5: remove package
  2023-01-29 12:59 [PR PATCH] libechonest-qt5: remove package Johnnynator
@ 2023-01-29 14:43 ` Johnnynator
  0 siblings, 0 replies; 2+ messages in thread
From: Johnnynator @ 2023-01-29 14:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

There's a merged pull request on the void-packages repository

libechonest-qt5: remove package
https://github.com/void-linux/void-packages/pull/41937

Description:
libechonest is unmaintained close to a decade and doesn't compile ootb with gcc12
Neither of the 2 packages that had libechonest in their template did actually use it.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-29 14:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-29 12:59 [PR PATCH] libechonest-qt5: remove package Johnnynator
2023-01-29 14:43 ` [PR PATCH] [Merged]: " Johnnynator

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).