[PR PATCH] rankwidth: remove dependency on igraph

[PR PATCH] rankwidth: remove dependency on igraph

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages rankwidth
https://github.com/void-linux/void-packages/pull/41973

rankwidth: remove dependency on igraph
It turns out that rankwidth only depends on igraph for the binary, but we don't ship the binary anyway (for sagemath we only need the library).

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41973.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rankwidth-41973.patch --]
[-- Type: text/x-diff, Size: 1336 bytes --]

From 7549ee302c6d3e0c745f43a8484de9b8aba4e8dc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 30 Jan 2023 13:31:28 -0300
Subject: [PATCH] rankwidth: remove dependency on igraph

It turns out that rankwidth only depends on igraph for the binary, but
we don't ship the binary anyway (for sagemath we only need the library).
---
 srcpkgs/rankwidth/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/rankwidth/template b/srcpkgs/rankwidth/template
index 873e93e1bd15..a28ca16a44b8 100644
--- a/srcpkgs/rankwidth/template
+++ b/srcpkgs/rankwidth/template
@@ -1,10 +1,10 @@
 # Template file for 'rankwidth'
 pkgname=rankwidth
 version=0.9
-revision=2
+revision=3
 build_style=gnu-configure
-hostmakedepends="pkg-config"
-makedepends="igraph-devel"
+# don't depend on igraph, we don't ship the binary anyway
+configure_args="--disable-executable"
 short_desc="Calculates rank-width and rank-decompositions"
 maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
 license="GPL-2.0-or-later"
@@ -21,7 +21,7 @@ post_install() {
 }
 
 rankwidth-devel_package() {
-	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
+	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include

Re: rankwidth: remove dependency on igraph

[szhorvat]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New comment by szhorvat on void-packages repository

https://github.com/void-linux/void-packages/pull/41973#issuecomment-1409159478

Comment:
Sounds reasonable, but just to confirm: This was not triggered by any issues with igraph 0.10.4, right?

Re: rankwidth: remove dependency on igraph

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/41973#issuecomment-1409246237

Comment:
> Sounds reasonable, but just to confirm: This was not triggered by any issues with igraph 0.10.4, right?

Nope. In fact, we don't ship the binary for `rankwidth` from the beginning because it conflicts with package `rw` and it's not needed for sage. Now, after updating `igraph` I looked into `rw` to see if it needed recompiling and I realized the library never needed `igraph` to begin with.

So this change is really a noop, except for removing `igraph-devel` from dependencies of `rankwidth-devel`.

Re: [PR PATCH] [Merged]: rankwidth: remove dependency on igraph

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

There's a merged pull request on the void-packages repository

rankwidth: remove dependency on igraph
https://github.com/void-linux/void-packages/pull/41973

Description:
It turns out that rankwidth only depends on igraph for the binary, but we don't ship the binary anyway (for sagemath we only need the library).

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->