[ISSUE] XBPS doesn't fail kernel installation if post-install kernel hook failed

[ISSUE] XBPS doesn't fail kernel installation if post-install kernel hook failed

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 2470 bytes --]

New issue by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/issues/42047

Description:
The problem: I updated kernel version, it successfully generated initramfs using drakut and copied kernel vmlinuz file to boot partition but failed to copy initramfs due to "No space left on device" error. Then xbps continued to execute configuration hooks and generated new grub config. Grub has found vmlinux file for new kernel, so it generated new entry for this version. But during boot initramfs was not found, so boot failed with kernel panic.

I'm suggesting to stop configuration execution if any hook fails and skip other hooks to avoid it.

xbps log:
```
[*] Configuring unpacked packages
linux6.1-6.1.7_1: configuring ...
Executing post-install kernel hook: 10-dkms ...
Available DKMS module: wireguard-1.0.20220627.
Building DKMS module: wireguard-1.0.20220627... skipped!
Generating kernel module dependency lists... done.
Executing post-install kernel hook: 10-mount ...
INFO: boot already mounted
Executing post-install kernel hook: 20-dracut ...
cp: error writing '/boot/initramfs-6.1.7_1.img': No space left on device
dracut: Creation of /boot/initramfs-6.1.7_1.img failed
Executing post-install kernel hook: 50-efibootmgr ...
Executing post-install kernel hook: 50-grub ...
Generating grub configuration file ...
Found linux image: /boot/vmlinuz-6.1.7_1
Found initrd image: /boot/early_ucode.cpio
Found linux image: /boot/vmlinuz-6.1.3_1
Found initrd image: /boot/early_ucode.cpio /boot/initramfs-6.1.3_1.img
Found linux image: /boot/vmlinuz-5.16.20_1
Found initrd image: /boot/early_ucode.cpio
Found linux image: /boot/vmlinuz-5.16.16_1
Found initrd image: /boot/early_ucode.cpio /boot/initramfs-5.16.16_1.img
Found linux image: /boot/vmlinuz-5.16.7_1
Found initrd image: /boot/early_ucode.cpio
Found linux image: /boot/vmlinuz-5.15.82_1
Found initrd image: /boot/early_ucode.cpio
Found linux image: /boot/vmlinuz-5.4.66-gentoo-x86_64
Found initrd image: /boot/early_ucode.cpio /boot/initramfs-5.4.66-gentoo-x86_64.img
Warning: os-prober will not be executed to detect other bootable partitions.
Systems on them will not be added to the GRUB boot configuration.
Check GRUB_DISABLE_OS_PROBER documentation entry.
Adding boot menu entry for UEFI Firmware Settings ...
done
Executing post-install kernel hook: 99-umount ...
INFO: skip boot umount
linux6.1-6.1.7_1: installed successfully.
```

Re: XBPS doesn't fail kernel installation if post-install kernel hook failed

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/42047#issuecomment-1414451060

Comment:
Moved to https://github.com/void-linux/void-packages since this is not really an xbps issue, but something that may be improved in https://github.com/void-linux/void-packages/blob/7e0dde51308b921d7eb143ca3f84828f6d2ac82a/srcpkgs/xbps-triggers/files/kernel-hooks.

Re: XBPS doesn't fail kernel installation if post-install kernel hook failed

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/42047#issuecomment-1533974309

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

Re: XBPS doesn't fail kernel installation if post-install kernel hook failed

[g4s8]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

New comment by g4s8 on void-packages repository

https://github.com/void-linux/void-packages/issues/42047#issuecomment-1545479958

Comment:
@classabbyamp @Duncaen I added `exit 1` to kernel-hook in #43852 and tested any hook fails parent hook script (with debug logs), but the problem is still here - the hook script fails but xbps successfully install or reconfigure the package:
```
Executing post-install kernel hook: 20-initramfs ...
dracut-install: ERROR: installing '/boot/volume1.key'
dracut: FAILED: /usr/lib/dracut/dracut-install -D /var/tmp/dracut.da3HNp/initramfs -a /boot/volume1.key /etc/crypttab
cp: cannot create regular file 'boot/initramfs-6.2.13_1.img': No such file or directory
dracut: Creation of boot/initramfs-6.2.13_1.img failed
DEBUG: !!! hook etc/kernel.d/post-install/20-initramfs failed
linux6.2-6.2.13_1: configured successfully.
```

Re: XBPS doesn't fail kernel installation if post-install kernel hook failed

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/issues/42047#issuecomment-1563345919

Comment:
I think a better fix for your specific problem is checking in the `grub` hook that both the kernel and initramfs for the specified `$VERSION` exist and, if not, don't run `grub-mkconfig`.