[PR PATCH] libreadline8: update to 8.2.001.

[PR PATCH] libreadline8: update to 8.2.001.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages libreadline8-8.2.001
https://github.com/void-linux/void-packages/pull/42170

libreadline8: update to 8.2.001.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/42170.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libreadline8-8.2.001-42170.patch --]
[-- Type: text/x-diff, Size: 4054 bytes --]

From 87b22802c14099ae7f473eb644dc85bff5d63952 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 9 Feb 2023 20:56:25 +0000
Subject: [PATCH] libreadline8: update to 8.2.001.

---
 .../patches/no-rpath-and-link.patch           | 40 -------------------
 srcpkgs/libreadline8/template                 | 15 ++++---
 2 files changed, 10 insertions(+), 45 deletions(-)

diff --git a/srcpkgs/libreadline8/patches/no-rpath-and-link.patch b/srcpkgs/libreadline8/patches/no-rpath-and-link.patch
index 45548e5fb9b4..202dd22ba73f 100644
--- a/srcpkgs/libreadline8/patches/no-rpath-and-link.patch
+++ b/srcpkgs/libreadline8/patches/no-rpath-and-link.patch
@@ -4,49 +4,9 @@ Date: Thu, 5 Nov 2020 02:49:21 +0100
 Subject: [PATCH] drop rpath and link against the termcap library
 
 ---
- configure          | 8 ++++----
- configure.ac       | 8 ++++----
  support/shobj-conf | 2 +-
  3 files changed, 9 insertions(+), 9 deletions(-)
 
-diff --git configure configure
-index 7d7bce0..eff4e76 100755
---- a/configure
-+++ b/configure
-@@ -6823,10 +6823,10 @@ if test -f ${srcdir}/support/shobj-conf; then
- $as_echo_n "checking configuration for building shared libraries... " >&6; }
-         eval `TERMCAP_LIB=$TERMCAP_LIB ${CONFIG_SHELL-/bin/sh} ${srcdir}/support/shobj-conf -C "${CC}" -c ${host_cpu} -o ${host_os} -v ${host_vendor}`
- 
--#	case "$SHLIB_LIBS" in
--#	*curses*|*termcap*|*termlib*)	;;
--#	*)			SHLIB_LIBS="$SHLIB_LIBS $TERMCAP_LIB" ;;
--#	esac
-+	case "$SHLIB_LIBS" in
-+	*curses*|*termcap*|*termlib*)	;;
-+	*)			SHLIB_LIBS="$SHLIB_LIBS $TERMCAP_LIB" ;;
-+	esac
- 
- 
- 
-diff --git configure.ac configure.ac
-index db788a6..9ac3eef 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -227,10 +227,10 @@ if test -f ${srcdir}/support/shobj-conf; then
-         AC_MSG_CHECKING(configuration for building shared libraries)
-         eval `TERMCAP_LIB=$TERMCAP_LIB ${CONFIG_SHELL-/bin/sh} ${srcdir}/support/shobj-conf -C "${CC}" -c ${host_cpu} -o ${host_os} -v ${host_vendor}`
- 
--#	case "$SHLIB_LIBS" in
--#	*curses*|*termcap*|*termlib*)	;;
--#	*)			SHLIB_LIBS="$SHLIB_LIBS $TERMCAP_LIB" ;;
--#	esac
-+	case "$SHLIB_LIBS" in
-+	*curses*|*termcap*|*termlib*)	;;
-+	*)			SHLIB_LIBS="$SHLIB_LIBS $TERMCAP_LIB" ;;
-+	esac
- 	
-         AC_SUBST(SHOBJ_CC)
-         AC_SUBST(SHOBJ_CFLAGS)
 diff --git support/shobj-conf support/shobj-conf
 index 7920f1b..7ac9c9f 100644
 --- a/support/shobj-conf
diff --git a/srcpkgs/libreadline8/template b/srcpkgs/libreadline8/template
index e0bca94a7a7e..8517bf9854b2 100644
--- a/srcpkgs/libreadline8/template
+++ b/srcpkgs/libreadline8/template
@@ -1,25 +1,30 @@
 # Template file for 'libreadline8'
 pkgname=libreadline8
-version=8.1.000
+version=8.2.001
 revision=1
 _dist_ver="${version%.*}"
 _patch_ver="${version##*.}"
 bootstrap=yes
 build_style=gnu-configure
-configure_args="--with-curses --enable-multibyte bash_cv_termcap_lib=libncursesw"
+configure_args="--with-curses --with-shared-termcap-library --enable-multibyte
+ bash_cv_termcap_lib=libncursesw"
 makedepends="ncurses-devel"
 short_desc="GNU Readline Library"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://tiswww.cwru.edu/php/chet/readline/rltop.html"
-distfiles="${GNU_SITE}/readline/readline-${_dist_ver}.tar.gz"
-checksum=f8ceb4ee131e3232226a17f51b164afc46cd0b9e6cef344be87c65962cb82b02
+changelog="https://tiswww.cwru.edu/php/chet/readline/NEWS"
+distfiles="${GNU_SITE}/readline/readline-${_dist_ver}.tar.gz
+ ${GNU_SITE}/readline/readline-${_dist_ver}-patches/readline${_dist_ver/./}-001"
+checksum="3feb7171f16a84ee82ca18a36d7b9be109a52c04f492a053331d7d1095007c35
+ bbf97f1ec40a929edab5aa81998c1e2ef435436c597754916e6a5868f273aff7"
+skip_extraction="readline${_dist_ver/./}-001"
 
 post_patch() {
 	cd ${wrksrc}
 	for p in $(seq -w 001 ${_patch_ver}); do
 		patch -s -Np0 -i ${XBPS_SRCDISTDIR}/${pkgname}-${version}/readline${_dist_ver/./}-${p}
-		msg_normal " Applying patch readline${_dist_ver/./}-$p.\n"
+		msg_normal "Applying patch readline${_dist_ver/./}-$p.\n"
 	done
 }
 

Re: [PR PATCH] [Updated] libreadline8: update to 8.2.001.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages libreadline8-8.2.001
https://github.com/void-linux/void-packages/pull/42170

libreadline8: update to 8.2.001.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/42170.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libreadline8-8.2.001-42170.patch --]
[-- Type: text/x-diff, Size: 4104 bytes --]

From 434b07e23a8b1a759e177c219b9a4fb03bad25c3 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 9 Feb 2023 20:56:25 +0000
Subject: [PATCH] libreadline8: update to 8.2.001.

---
 .../patches/no-rpath-and-link.patch           | 42 +------------------
 srcpkgs/libreadline8/template                 | 15 ++++---
 2 files changed, 11 insertions(+), 46 deletions(-)

diff --git a/srcpkgs/libreadline8/patches/no-rpath-and-link.patch b/srcpkgs/libreadline8/patches/no-rpath-and-link.patch
index 45548e5fb9b4..bec079ef31ae 100644
--- a/srcpkgs/libreadline8/patches/no-rpath-and-link.patch
+++ b/srcpkgs/libreadline8/patches/no-rpath-and-link.patch
@@ -4,49 +4,9 @@ Date: Thu, 5 Nov 2020 02:49:21 +0100
 Subject: [PATCH] drop rpath and link against the termcap library
 
 ---
- configure          | 8 ++++----
- configure.ac       | 8 ++++----
  support/shobj-conf | 2 +-
- 3 files changed, 9 insertions(+), 9 deletions(-)
+ 1 file changed, 1 insertions(+), 1 deletions(-)
 
-diff --git configure configure
-index 7d7bce0..eff4e76 100755
---- a/configure
-+++ b/configure
-@@ -6823,10 +6823,10 @@ if test -f ${srcdir}/support/shobj-conf; then
- $as_echo_n "checking configuration for building shared libraries... " >&6; }
-         eval `TERMCAP_LIB=$TERMCAP_LIB ${CONFIG_SHELL-/bin/sh} ${srcdir}/support/shobj-conf -C "${CC}" -c ${host_cpu} -o ${host_os} -v ${host_vendor}`
- 
--#	case "$SHLIB_LIBS" in
--#	*curses*|*termcap*|*termlib*)	;;
--#	*)			SHLIB_LIBS="$SHLIB_LIBS $TERMCAP_LIB" ;;
--#	esac
-+	case "$SHLIB_LIBS" in
-+	*curses*|*termcap*|*termlib*)	;;
-+	*)			SHLIB_LIBS="$SHLIB_LIBS $TERMCAP_LIB" ;;
-+	esac
- 
- 
- 
-diff --git configure.ac configure.ac
-index db788a6..9ac3eef 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -227,10 +227,10 @@ if test -f ${srcdir}/support/shobj-conf; then
-         AC_MSG_CHECKING(configuration for building shared libraries)
-         eval `TERMCAP_LIB=$TERMCAP_LIB ${CONFIG_SHELL-/bin/sh} ${srcdir}/support/shobj-conf -C "${CC}" -c ${host_cpu} -o ${host_os} -v ${host_vendor}`
- 
--#	case "$SHLIB_LIBS" in
--#	*curses*|*termcap*|*termlib*)	;;
--#	*)			SHLIB_LIBS="$SHLIB_LIBS $TERMCAP_LIB" ;;
--#	esac
-+	case "$SHLIB_LIBS" in
-+	*curses*|*termcap*|*termlib*)	;;
-+	*)			SHLIB_LIBS="$SHLIB_LIBS $TERMCAP_LIB" ;;
-+	esac
- 	
-         AC_SUBST(SHOBJ_CC)
-         AC_SUBST(SHOBJ_CFLAGS)
 diff --git support/shobj-conf support/shobj-conf
 index 7920f1b..7ac9c9f 100644
 --- a/support/shobj-conf
diff --git a/srcpkgs/libreadline8/template b/srcpkgs/libreadline8/template
index e0bca94a7a7e..8517bf9854b2 100644
--- a/srcpkgs/libreadline8/template
+++ b/srcpkgs/libreadline8/template
@@ -1,25 +1,30 @@
 # Template file for 'libreadline8'
 pkgname=libreadline8
-version=8.1.000
+version=8.2.001
 revision=1
 _dist_ver="${version%.*}"
 _patch_ver="${version##*.}"
 bootstrap=yes
 build_style=gnu-configure
-configure_args="--with-curses --enable-multibyte bash_cv_termcap_lib=libncursesw"
+configure_args="--with-curses --with-shared-termcap-library --enable-multibyte
+ bash_cv_termcap_lib=libncursesw"
 makedepends="ncurses-devel"
 short_desc="GNU Readline Library"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://tiswww.cwru.edu/php/chet/readline/rltop.html"
-distfiles="${GNU_SITE}/readline/readline-${_dist_ver}.tar.gz"
-checksum=f8ceb4ee131e3232226a17f51b164afc46cd0b9e6cef344be87c65962cb82b02
+changelog="https://tiswww.cwru.edu/php/chet/readline/NEWS"
+distfiles="${GNU_SITE}/readline/readline-${_dist_ver}.tar.gz
+ ${GNU_SITE}/readline/readline-${_dist_ver}-patches/readline${_dist_ver/./}-001"
+checksum="3feb7171f16a84ee82ca18a36d7b9be109a52c04f492a053331d7d1095007c35
+ bbf97f1ec40a929edab5aa81998c1e2ef435436c597754916e6a5868f273aff7"
+skip_extraction="readline${_dist_ver/./}-001"
 
 post_patch() {
 	cd ${wrksrc}
 	for p in $(seq -w 001 ${_patch_ver}); do
 		patch -s -Np0 -i ${XBPS_SRCDISTDIR}/${pkgname}-${version}/readline${_dist_ver/./}-${p}
-		msg_normal " Applying patch readline${_dist_ver/./}-$p.\n"
+		msg_normal "Applying patch readline${_dist_ver/./}-$p.\n"
 	done
 }
 

Re: [PR REVIEW] libreadline8: update to 8.2.001.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/42170#discussion_r1102018836

Comment:
Is it alright to change the patch like this?

Re: [PR REVIEW] libreadline8: update to 8.2.001.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/42170#discussion_r1102019172

Comment:
Is https://tiswww.cwru.edu/php/chet/readline/CHANGES better to put here maybe?

Re: libreadline8: update to 8.2.001.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42170#issuecomment-1544989610

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: libreadline8: update to 8.2.001.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/42170#issuecomment-1546700667

Comment:
Bump for review.

Re: [PR PATCH] [Closed]: libreadline8: update to 8.2.001.

[abenson]

[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]

There's a closed pull request on the void-packages repository

libreadline8: update to 8.2.001.
https://github.com/void-linux/void-packages/pull/42170

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->