[PR PATCH] etckeeper: update to 1.18.20, support xbps, run tests

[PR PATCH] etckeeper: update to 1.18.20, support xbps, run tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

There is a new pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages etck
https://github.com/void-linux/void-packages/pull/42192

etckeeper: update to 1.18.20, support xbps, run tests
- I tested the changes in this PR: **YES**|**briefly**|**NO**
- I built this PR locally for my native architecture, (x86_64-musl)

If I include `fakeroot` in `checkdepends`, then a couple of tests fail.

A patch file from https://github.com/void-linux/void-packages/pull/42192.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-etck-42192.patch --]
[-- Type: text/x-diff, Size: 1649 bytes --]

From 9c5b0a98815e910701c9c92b5fd54af7cc435991 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 10 Feb 2023 11:52:09 -0500
Subject: [PATCH] etckeeper: update to 1.18.20, support xbps, run tests

---
 srcpkgs/etckeeper/template | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/etckeeper/template b/srcpkgs/etckeeper/template
index 54dea0890c2b..777b61755363 100644
--- a/srcpkgs/etckeeper/template
+++ b/srcpkgs/etckeeper/template
@@ -1,23 +1,32 @@
 # Template file for 'etckeeper'
 pkgname=etckeeper
-version=1.18.14
-revision=2
+version=1.18.20
+revision=1
 build_style=gnu-makefile
 conf_files="/etc/etckeeper/etckeeper.conf"
 hostmakedepends="perl"
 depends="git perl"
+checkdepends="bats git"
 short_desc="Tools to store /etc in a git, mercurial, or darcs repository"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://etckeeper.branchable.com"
 distfiles="https://git.joeyh.name/index.cgi/etckeeper.git/snapshot/${pkgname}-${version}.tar.gz"
-checksum=15924673fa3f15e4b172f9f0111a442ed3f0ee99dcf9ad3c5107736ffb8c1089
+checksum=0bb856e96f59cf582a92361294f0fc32e0a8bbc02fac3aacae0a735d11b3addd
+make_check_target=test
 
 pre_install() {
 	sed -ni '/systemddir/!p' Makefile
 	sed -ni '/apt.conf/!p' Makefile
+	sed -i 's|^PYTHON=python$|PYTHON=/bin/false|' Makefile
+
+	sed -i -e "/^LOWLEVEL_PACKAGE_MANAGER/c LOWLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
+	sed -i -e "/^HIGHLEVEL_PACKAGE_MANAGER/c HIGHLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
 }
 
 post_install() {
 	vdoc doc/README.mdwn
+
+	rm -rf lib/systemd
+	rm -rf etc/apt
 }

Re: [PR PATCH] [Updated] etckeeper: update to 1.18.20, support xbps, run tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages etck
https://github.com/void-linux/void-packages/pull/42192

etckeeper: update to 1.18.20, support xbps, run tests
- I tested the changes in this PR: **YES**|**briefly**|**NO**
- I built this PR locally for my native architecture, (x86_64-musl)

If I include `fakeroot` in `checkdepends`, then a couple of tests fail.

A patch file from https://github.com/void-linux/void-packages/pull/42192.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-etck-42192.patch --]
[-- Type: text/x-diff, Size: 1658 bytes --]

From cbb7df737cc1d1f0d8d7d5a67eb9c12a7ac236bd Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 10 Feb 2023 11:52:09 -0500
Subject: [PATCH] etckeeper: update to 1.18.20, support xbps, run tests

---
 srcpkgs/etckeeper/template | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/etckeeper/template b/srcpkgs/etckeeper/template
index 54dea0890c2b..f2fdc9791a86 100644
--- a/srcpkgs/etckeeper/template
+++ b/srcpkgs/etckeeper/template
@@ -1,23 +1,32 @@
 # Template file for 'etckeeper'
 pkgname=etckeeper
-version=1.18.14
-revision=2
+version=1.18.20
+revision=1
 build_style=gnu-makefile
 conf_files="/etc/etckeeper/etckeeper.conf"
+make_check_target=test
 hostmakedepends="perl"
 depends="git perl"
+checkdepends="bats git fakeroot"
 short_desc="Tools to store /etc in a git, mercurial, or darcs repository"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://etckeeper.branchable.com"
 distfiles="https://git.joeyh.name/index.cgi/etckeeper.git/snapshot/${pkgname}-${version}.tar.gz"
-checksum=15924673fa3f15e4b172f9f0111a442ed3f0ee99dcf9ad3c5107736ffb8c1089
+checksum=0bb856e96f59cf582a92361294f0fc32e0a8bbc02fac3aacae0a735d11b3addd
 
 pre_install() {
 	sed -ni '/systemddir/!p' Makefile
 	sed -ni '/apt.conf/!p' Makefile
+	sed -i 's|^PYTHON=python$|PYTHON=/bin/false|' Makefile
+
+	sed -i -e "/^LOWLEVEL_PACKAGE_MANAGER/c LOWLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
+	sed -i -e "/^HIGHLEVEL_PACKAGE_MANAGER/c HIGHLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
 }
 
 post_install() {
 	vdoc doc/README.mdwn
+
+	rm -rf lib/systemd
+	rm -rf etc/apt
 }

Re: etckeeper: update to 1.18.20, support xbps, run tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/42192#issuecomment-1426090080

Comment:
```
not ok 8 root_test: create file owned by bin:daemon
# (in test file test-etckeeper, line 88)
#   `install -o $owner -g $group -m $mode /dev/null $testdir/$testfile' failed
# install: invalid user ‘bin’
```

Re: etckeeper: update to 1.18.20, support xbps, run tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/42192#issuecomment-1426093830

Comment:
locally:
```
not ok 7 root_test: create file owned by root:root
# (in test file test-etckeeper, line 75)
#   `install -o $owner -g $group -m $mode /dev/null $testdir/$testfile' failed
# install: cannot change ownership of '/tmp/tmp.XUHYBeCFoX/file5': Invalid argument
not ok 8 root_test: create file owned by bin:daemon
# (in test file test-etckeeper, line 88)
#   `install -o $owner -g $group -m $mode /dev/null $testdir/$testfile' failed
# install: invalid user ‘bin’
```

Re: etckeeper: update to 1.18.20, support xbps, run tests

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42192#issuecomment-1548852359

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Updated] etckeeper: update to 1.18.20, support xbps, run tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages etck
https://github.com/void-linux/void-packages/pull/42192

etckeeper: update to 1.18.20, support xbps, run tests
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (`x86_64-musl`)

A couple of tests fail, likely due to `fakeroot` or similar.

A patch file from https://github.com/void-linux/void-packages/pull/42192.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-etck-42192.patch --]
[-- Type: text/x-diff, Size: 1658 bytes --]

From 3d33c04df0b997eb4262292a526d6798e577d5a4 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 10 Feb 2023 11:52:09 -0500
Subject: [PATCH] etckeeper: update to 1.18.20, support xbps, run tests

---
 srcpkgs/etckeeper/template | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/etckeeper/template b/srcpkgs/etckeeper/template
index 54dea0890c2b..f2fdc9791a86 100644
--- a/srcpkgs/etckeeper/template
+++ b/srcpkgs/etckeeper/template
@@ -1,23 +1,32 @@
 # Template file for 'etckeeper'
 pkgname=etckeeper
-version=1.18.14
-revision=2
+version=1.18.20
+revision=1
 build_style=gnu-makefile
 conf_files="/etc/etckeeper/etckeeper.conf"
+make_check_target=test
 hostmakedepends="perl"
 depends="git perl"
+checkdepends="bats git fakeroot"
 short_desc="Tools to store /etc in a git, mercurial, or darcs repository"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://etckeeper.branchable.com"
 distfiles="https://git.joeyh.name/index.cgi/etckeeper.git/snapshot/${pkgname}-${version}.tar.gz"
-checksum=15924673fa3f15e4b172f9f0111a442ed3f0ee99dcf9ad3c5107736ffb8c1089
+checksum=0bb856e96f59cf582a92361294f0fc32e0a8bbc02fac3aacae0a735d11b3addd
 
 pre_install() {
 	sed -ni '/systemddir/!p' Makefile
 	sed -ni '/apt.conf/!p' Makefile
+	sed -i 's|^PYTHON=python$|PYTHON=/bin/false|' Makefile
+
+	sed -i -e "/^LOWLEVEL_PACKAGE_MANAGER/c LOWLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
+	sed -i -e "/^HIGHLEVEL_PACKAGE_MANAGER/c HIGHLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
 }
 
 post_install() {
 	vdoc doc/README.mdwn
+
+	rm -rf lib/systemd
+	rm -rf etc/apt
 }

Re: [PR PATCH] [Updated] etckeeper: update to 1.18.20, support xbps, run tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages etck
https://github.com/void-linux/void-packages/pull/42192

etckeeper: update to 1.18.20, support xbps, run tests
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (`x86_64-musl`)

A couple of tests fail, likely due to `fakeroot` or similar.

A patch file from https://github.com/void-linux/void-packages/pull/42192.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-etck-42192.patch --]
[-- Type: text/x-diff, Size: 1688 bytes --]

From e5cbddc9e7e0582b0c5a7671411a67bc74d1b0a0 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 10 Feb 2023 11:52:09 -0500
Subject: [PATCH] etckeeper: update to 1.18.20, support xbps, run tests

only tests that don't require fakeroot
---
 srcpkgs/etckeeper/template | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/etckeeper/template b/srcpkgs/etckeeper/template
index 54dea0890c2b..5dfbe88b3bda 100644
--- a/srcpkgs/etckeeper/template
+++ b/srcpkgs/etckeeper/template
@@ -1,23 +1,32 @@
 # Template file for 'etckeeper'
 pkgname=etckeeper
-version=1.18.14
-revision=2
+version=1.18.20
+revision=1
 build_style=gnu-makefile
 conf_files="/etc/etckeeper/etckeeper.conf"
+make_check_target=test
 hostmakedepends="perl"
 depends="git perl"
+checkdepends="bats git"
 short_desc="Tools to store /etc in a git, mercurial, or darcs repository"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://etckeeper.branchable.com"
 distfiles="https://git.joeyh.name/index.cgi/etckeeper.git/snapshot/${pkgname}-${version}.tar.gz"
-checksum=15924673fa3f15e4b172f9f0111a442ed3f0ee99dcf9ad3c5107736ffb8c1089
+checksum=0bb856e96f59cf582a92361294f0fc32e0a8bbc02fac3aacae0a735d11b3addd
 
 pre_install() {
 	sed -ni '/systemddir/!p' Makefile
 	sed -ni '/apt.conf/!p' Makefile
+	sed -i 's|^PYTHON=python$|PYTHON=/bin/false|' Makefile
+
+	sed -i -e "/^LOWLEVEL_PACKAGE_MANAGER/c LOWLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
+	sed -i -e "/^HIGHLEVEL_PACKAGE_MANAGER/c HIGHLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
 }
 
 post_install() {
 	vdoc doc/README.mdwn
+
+	rm -rf lib/systemd
+	rm -rf etc/apt
 }

Re: etckeeper: update to 1.18.20, support xbps, run tests

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42192#issuecomment-1679845363

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: etckeeper: update to 1.18.20, support xbps, run tests

[zevweiss]

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

New comment by zevweiss on void-packages repository

https://github.com/void-linux/void-packages/pull/42192#issuecomment-1679878735

Comment:
Bump?

Re: [PR PATCH] [Updated] etckeeper: update to 1.18.20, support xbps, run tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages etck
https://github.com/void-linux/void-packages/pull/42192

etckeeper: update to 1.18.20, support xbps, run tests
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (`x86_64-musl`)

A couple of tests fail, likely due to `fakeroot` or similar.

A patch file from https://github.com/void-linux/void-packages/pull/42192.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-etck-42192.patch --]
[-- Type: text/x-diff, Size: 1651 bytes --]

From 50b217927331aedded718afc273442cf8428f243 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 10 Feb 2023 11:52:09 -0500
Subject: [PATCH] etckeeper: update to 1.18.20, support xbps, run tests

---
 srcpkgs/etckeeper/template | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/etckeeper/template b/srcpkgs/etckeeper/template
index 54dea0890c2b1..5dfbe88b3bda0 100644
--- a/srcpkgs/etckeeper/template
+++ b/srcpkgs/etckeeper/template
@@ -1,23 +1,32 @@
 # Template file for 'etckeeper'
 pkgname=etckeeper
-version=1.18.14
-revision=2
+version=1.18.20
+revision=1
 build_style=gnu-makefile
 conf_files="/etc/etckeeper/etckeeper.conf"
+make_check_target=test
 hostmakedepends="perl"
 depends="git perl"
+checkdepends="bats git"
 short_desc="Tools to store /etc in a git, mercurial, or darcs repository"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://etckeeper.branchable.com"
 distfiles="https://git.joeyh.name/index.cgi/etckeeper.git/snapshot/${pkgname}-${version}.tar.gz"
-checksum=15924673fa3f15e4b172f9f0111a442ed3f0ee99dcf9ad3c5107736ffb8c1089
+checksum=0bb856e96f59cf582a92361294f0fc32e0a8bbc02fac3aacae0a735d11b3addd
 
 pre_install() {
 	sed -ni '/systemddir/!p' Makefile
 	sed -ni '/apt.conf/!p' Makefile
+	sed -i 's|^PYTHON=python$|PYTHON=/bin/false|' Makefile
+
+	sed -i -e "/^LOWLEVEL_PACKAGE_MANAGER/c LOWLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
+	sed -i -e "/^HIGHLEVEL_PACKAGE_MANAGER/c HIGHLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
 }
 
 post_install() {
 	vdoc doc/README.mdwn
+
+	rm -rf lib/systemd
+	rm -rf etc/apt
 }

Re: [PR PATCH] [Updated] etckeeper: update to 1.18.20, support xbps, run tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages etck
https://github.com/void-linux/void-packages/pull/42192

etckeeper: update to 1.18.20, support xbps, run tests
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (`x86_64-musl`)

A couple of tests fail, likely due to `fakeroot` or similar.

A patch file from https://github.com/void-linux/void-packages/pull/42192.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-etck-42192.patch --]
[-- Type: text/x-diff, Size: 1651 bytes --]

From 91809841f928837f7bcdc300e443521d1d258e39 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 10 Feb 2023 11:52:09 -0500
Subject: [PATCH] etckeeper: update to 1.18.20, support xbps, run tests

---
 srcpkgs/etckeeper/template | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/etckeeper/template b/srcpkgs/etckeeper/template
index 54dea0890c2b1..5dfbe88b3bda0 100644
--- a/srcpkgs/etckeeper/template
+++ b/srcpkgs/etckeeper/template
@@ -1,23 +1,32 @@
 # Template file for 'etckeeper'
 pkgname=etckeeper
-version=1.18.14
-revision=2
+version=1.18.20
+revision=1
 build_style=gnu-makefile
 conf_files="/etc/etckeeper/etckeeper.conf"
+make_check_target=test
 hostmakedepends="perl"
 depends="git perl"
+checkdepends="bats git"
 short_desc="Tools to store /etc in a git, mercurial, or darcs repository"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://etckeeper.branchable.com"
 distfiles="https://git.joeyh.name/index.cgi/etckeeper.git/snapshot/${pkgname}-${version}.tar.gz"
-checksum=15924673fa3f15e4b172f9f0111a442ed3f0ee99dcf9ad3c5107736ffb8c1089
+checksum=0bb856e96f59cf582a92361294f0fc32e0a8bbc02fac3aacae0a735d11b3addd
 
 pre_install() {
 	sed -ni '/systemddir/!p' Makefile
 	sed -ni '/apt.conf/!p' Makefile
+	sed -i 's|^PYTHON=python$|PYTHON=/bin/false|' Makefile
+
+	sed -i -e "/^LOWLEVEL_PACKAGE_MANAGER/c LOWLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
+	sed -i -e "/^HIGHLEVEL_PACKAGE_MANAGER/c HIGHLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
 }
 
 post_install() {
 	vdoc doc/README.mdwn
+
+	rm -rf lib/systemd
+	rm -rf etc/apt
 }

Re: [PR PATCH] [Updated] etckeeper: update to 1.18.20, support xbps, run tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages etck
https://github.com/void-linux/void-packages/pull/42192

etckeeper: update to 1.18.20, support xbps, run tests
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (`x86_64-musl`)

A couple of tests fail, likely due to `fakeroot` or similar.

A patch file from https://github.com/void-linux/void-packages/pull/42192.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-etck-42192.patch --]
[-- Type: text/x-diff, Size: 1702 bytes --]

From c10b1ac257ec6da4aa6bbd0dd194e40b9d8ea453 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 10 Feb 2023 11:52:09 -0500
Subject: [PATCH] etckeeper: update to 1.18.20, support xbps, run tests

---
 srcpkgs/etckeeper/template | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/etckeeper/template b/srcpkgs/etckeeper/template
index 54dea0890c2b1..2f68081d700d3 100644
--- a/srcpkgs/etckeeper/template
+++ b/srcpkgs/etckeeper/template
@@ -1,23 +1,33 @@
 # Template file for 'etckeeper'
 pkgname=etckeeper
-version=1.18.14
-revision=2
+version=1.18.20
+revision=1
 build_style=gnu-makefile
 conf_files="/etc/etckeeper/etckeeper.conf"
+make_check_target=test
 hostmakedepends="perl"
 depends="git perl"
+checkdepends="bats git"
 short_desc="Tools to store /etc in a git, mercurial, or darcs repository"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://etckeeper.branchable.com"
 distfiles="https://git.joeyh.name/index.cgi/etckeeper.git/snapshot/${pkgname}-${version}.tar.gz"
-checksum=15924673fa3f15e4b172f9f0111a442ed3f0ee99dcf9ad3c5107736ffb8c1089
+checksum=0bb856e96f59cf582a92361294f0fc32e0a8bbc02fac3aacae0a735d11b3addd
+make_check=ci-skip # due to not detecting chroot
 
 pre_install() {
 	sed -ni '/systemddir/!p' Makefile
 	sed -ni '/apt.conf/!p' Makefile
+	sed -i 's|^PYTHON=python$|PYTHON=/bin/false|' Makefile
+
+	sed -i -e "/^LOWLEVEL_PACKAGE_MANAGER/c LOWLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
+	sed -i -e "/^HIGHLEVEL_PACKAGE_MANAGER/c HIGHLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
 }
 
 post_install() {
 	vdoc doc/README.mdwn
+
+	rm -rf lib/systemd
+	rm -rf etc/apt
 }

Re: etckeeper: update to 1.18.20, support xbps, run tests

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42192#issuecomment-1911277237

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: etckeeper: update to 1.18.20, support xbps, run tests

[zevweiss]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by zevweiss on void-packages repository

https://github.com/void-linux/void-packages/pull/42192#issuecomment-1912427744

Comment:
Bump...though current upstream is now at 1.18.21, FWIW.

Re: [PR PATCH] [Updated] etckeeper: update to 1.18.20, support xbps, run tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages etck
https://github.com/void-linux/void-packages/pull/42192

etckeeper: update to 1.18.20, support xbps, run tests
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (`x86_64-musl`)

A couple of tests fail, likely due to `fakeroot` or similar.

A patch file from https://github.com/void-linux/void-packages/pull/42192.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-etck-42192.patch --]
[-- Type: text/x-diff, Size: 1696 bytes --]

From 3df48abdf54d8d859fb4b70606cce403dcaebb9d Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 10 Feb 2023 11:52:09 -0500
Subject: [PATCH] etckeeper: update to 1.18.21, support xbps, run tests

---
 srcpkgs/etckeeper/template | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/etckeeper/template b/srcpkgs/etckeeper/template
index 54dea0890c2b1..563d59f1863e7 100644
--- a/srcpkgs/etckeeper/template
+++ b/srcpkgs/etckeeper/template
@@ -1,23 +1,31 @@
 # Template file for 'etckeeper'
 pkgname=etckeeper
-version=1.18.14
-revision=2
+version=1.18.21
+revision=1
 build_style=gnu-makefile
 conf_files="/etc/etckeeper/etckeeper.conf"
+make_check_target=test
 hostmakedepends="perl"
 depends="git perl"
+checkdepends="bats git"
 short_desc="Tools to store /etc in a git, mercurial, or darcs repository"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://etckeeper.branchable.com"
 distfiles="https://git.joeyh.name/index.cgi/etckeeper.git/snapshot/${pkgname}-${version}.tar.gz"
-checksum=15924673fa3f15e4b172f9f0111a442ed3f0ee99dcf9ad3c5107736ffb8c1089
+checksum=a87c5e9c847c29f761da933c1cd907779545c7ddf92fb75de8ef692b90fc9e5d
+make_check=ci-skip # due to not detecting chroot
 
 pre_install() {
 	sed -ni '/systemddir/!p' Makefile
 	sed -ni '/apt.conf/!p' Makefile
+	sed -i 's|^PYTHON=python$|PYTHON=/bin/false|' Makefile
+	sed -i -e "/^LOWLEVEL_PACKAGE_MANAGER/c LOWLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
+	sed -i -e "/^HIGHLEVEL_PACKAGE_MANAGER/c HIGHLEVEL_PACKAGE_MANAGER=xbps" etckeeper.conf
 }
 
 post_install() {
 	vdoc doc/README.mdwn
+	rm -rf lib/systemd
+	rm -rf etc/apt
 }

Re: etckeeper: update to 1.18.21, support xbps, run tests

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/42192#issuecomment-1919987429

Comment:
@leahneukirchen Can you take a look?

Re: [PR PATCH] [Merged]: etckeeper: update to 1.18.21, support xbps, run tests

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

There's a merged pull request on the void-packages repository

etckeeper: update to 1.18.21, support xbps, run tests
https://github.com/void-linux/void-packages/pull/42192

Description:
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (`x86_64-musl`)

A couple of tests fail, likely due to `fakeroot` or similar.

Re: etckeeper: update to 1.18.21, support xbps, run tests

[zevweiss]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by zevweiss on void-packages repository

https://github.com/void-linux/void-packages/pull/42192#issuecomment-1922296571

Comment:
Thanks!