* Re: [PR REVIEW] added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
@ 2023-02-10 17:28 ` paper42
2023-02-10 17:41 ` [PR PATCH] [Updated] " terminaldweller
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2023-02-10 17:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/42193#discussion_r1103034937
Comment:
```suggestion
if [ "$build_option_mixmaster" ]; then
configure_args+=" --mixmaster"
fi
```
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
2023-02-10 17:28 ` [PR REVIEW] " paper42
@ 2023-02-10 17:41 ` terminaldweller
2023-02-10 18:04 ` terminaldweller
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: terminaldweller @ 2023-02-10 17:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]
There is an updated pull request by terminaldweller against master on the void-packages repository
https://github.com/terminaldweller/void-packages master
https://github.com/void-linux/void-packages/pull/42193
added mixmaster as a build option to the neomutt template
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/42193.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-42193.patch --]
[-- Type: text/x-diff, Size: 2063 bytes --]
From b44ba3462d677d31075155920f79007a42bb0c13 Mon Sep 17 00:00:00 2001
From: terminaldweller <thabogre@gmail.com>
Date: Fri, 10 Feb 2023 20:49:44 +0330
Subject: [PATCH 1/2] added mixmaster as a build option to the neomutt template
---
srcpkgs/neomutt/template | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/srcpkgs/neomutt/template b/srcpkgs/neomutt/template
index 39927bb48fbb..a09301f29d7e 100644
--- a/srcpkgs/neomutt/template
+++ b/srcpkgs/neomutt/template
@@ -26,6 +26,9 @@ checksum="45496542897ba8de6bc7cce3f5951d9033ed1c49e5d6f1353adaeefe795d9043
bda7c7f9f7bac528398040a46da505f906913a86f5db65cdbab743d595ee2947"
python_version=3
+build_options="mixmaster"
+desc_option_mixmaster="Enable mixmaster remailer support"
+
# fix:
if [ "${XBPS_CROSS_BASE}" ]; then
configure_args="${configure_args} --host=$XBPS_CROSS_TRIPLET"
@@ -38,6 +41,13 @@ case "${XBPS_TARGET_MACHINE}" in
# Inquiry: Do we have largefile support on everywhere?
esac
+do_configure() {
+ if [ "$build_option_mixmaster" ]; then
+ configure_args+=" --mixmaster"
+ fi
+ ./configure ${configure_args}
+}
+
post_install() {
# move dist to examples dir
vsconf contrib/samples/gpg.rc Muttrc.gpg.dist
From 7c6cd3d7c38b3e2cfed61b35ad2d909c6ea131cb Mon Sep 17 00:00:00 2001
From: terminaldweller <thabogre@gmail.com>
Date: Fri, 10 Feb 2023 21:11:01 +0330
Subject: [PATCH 2/2] neomutt: added "--mixmaster" as a buld option
---
srcpkgs/neomutt/template | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/neomutt/template b/srcpkgs/neomutt/template
index a09301f29d7e..d0c8e6c548f7 100644
--- a/srcpkgs/neomutt/template
+++ b/srcpkgs/neomutt/template
@@ -41,12 +41,9 @@ case "${XBPS_TARGET_MACHINE}" in
# Inquiry: Do we have largefile support on everywhere?
esac
-do_configure() {
- if [ "$build_option_mixmaster" ]; then
- configure_args+=" --mixmaster"
- fi
- ./configure ${configure_args}
-}
+if [ "$build_option_mixmaster" ]; then
+ configure_args+=" --mixmaster"
+fi
post_install() {
# move dist to examples dir
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
2023-02-10 17:28 ` [PR REVIEW] " paper42
2023-02-10 17:41 ` [PR PATCH] [Updated] " terminaldweller
@ 2023-02-10 18:04 ` terminaldweller
2023-02-10 18:05 ` terminaldweller
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: terminaldweller @ 2023-02-10 18:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]
There is an updated pull request by terminaldweller against master on the void-packages repository
https://github.com/terminaldweller/void-packages master
https://github.com/void-linux/void-packages/pull/42193
added mixmaster as a build option to the neomutt template
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/42193.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-42193.patch --]
[-- Type: text/x-diff, Size: 1128 bytes --]
From 7c6bfbf4828104cd7a2b2167c81d6de7d097e52c Mon Sep 17 00:00:00 2001
From: terminaldweller <thabogre@gmail.com>
Date: Fri, 10 Feb 2023 21:33:47 +0330
Subject: [PATCH] neomutt: added "--mixmaster" as a buld option
---
srcpkgs/neomutt/template | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/srcpkgs/neomutt/template b/srcpkgs/neomutt/template
index 39927bb48fbb..d0c8e6c548f7 100644
--- a/srcpkgs/neomutt/template
+++ b/srcpkgs/neomutt/template
@@ -26,6 +26,9 @@ checksum="45496542897ba8de6bc7cce3f5951d9033ed1c49e5d6f1353adaeefe795d9043
bda7c7f9f7bac528398040a46da505f906913a86f5db65cdbab743d595ee2947"
python_version=3
+build_options="mixmaster"
+desc_option_mixmaster="Enable mixmaster remailer support"
+
# fix:
if [ "${XBPS_CROSS_BASE}" ]; then
configure_args="${configure_args} --host=$XBPS_CROSS_TRIPLET"
@@ -38,6 +41,10 @@ case "${XBPS_TARGET_MACHINE}" in
# Inquiry: Do we have largefile support on everywhere?
esac
+if [ "$build_option_mixmaster" ]; then
+ configure_args+=" --mixmaster"
+fi
+
post_install() {
# move dist to examples dir
vsconf contrib/samples/gpg.rc Muttrc.gpg.dist
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
` (2 preceding siblings ...)
2023-02-10 18:04 ` terminaldweller
@ 2023-02-10 18:05 ` terminaldweller
2023-02-10 22:41 ` paper42
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: terminaldweller @ 2023-02-10 18:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 154 bytes --]
New comment by terminaldweller on void-packages repository
https://github.com/void-linux/void-packages/pull/42193#issuecomment-1426158545
Comment:
done
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
` (3 preceding siblings ...)
2023-02-10 18:05 ` terminaldweller
@ 2023-02-10 22:41 ` paper42
2023-02-10 23:29 ` Vaelatern
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2023-02-10 22:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 223 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/42193#issuecomment-1426434730
Comment:
and squash the commits, it should be one per package
cc maintainer @Vaelatern
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
` (4 preceding siblings ...)
2023-02-10 22:41 ` paper42
@ 2023-02-10 23:29 ` Vaelatern
2023-02-10 23:29 ` Vaelatern
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: Vaelatern @ 2023-02-10 23:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
New comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/42193#issuecomment-1426489541
Comment:
I believe this will be enabled by default next release. Do you think that is the case too?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
` (5 preceding siblings ...)
2023-02-10 23:29 ` Vaelatern
@ 2023-02-10 23:29 ` Vaelatern
2023-02-11 5:01 ` terminaldweller
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: Vaelatern @ 2023-02-10 23:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
New comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/42193#issuecomment-1426489541
Comment:
I suspect this will be enabled by default next release. Do you think that is the case too?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
` (6 preceding siblings ...)
2023-02-10 23:29 ` Vaelatern
@ 2023-02-11 5:01 ` terminaldweller
2023-02-11 5:03 ` terminaldweller
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: terminaldweller @ 2023-02-11 5:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
New comment by terminaldweller on void-packages repository
https://github.com/void-linux/void-packages/pull/42193#issuecomment-1426617196
Comment:
you mean the neomutt devs will enable this by default from the next release?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
` (7 preceding siblings ...)
2023-02-11 5:01 ` terminaldweller
@ 2023-02-11 5:03 ` terminaldweller
2023-02-11 5:14 ` terminaldweller
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: terminaldweller @ 2023-02-11 5:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
New comment by terminaldweller on void-packages repository
https://github.com/void-linux/void-packages/pull/42193#issuecomment-1426617615
Comment:
> and squash the commits, it should be one per package
>
> cc maintainer @Vaelatern
It is one commit now. at least it says so at the top. is that acceptable?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
` (8 preceding siblings ...)
2023-02-11 5:03 ` terminaldweller
@ 2023-02-11 5:14 ` terminaldweller
2023-05-13 1:51 ` github-actions
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: terminaldweller @ 2023-02-11 5:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
New comment by terminaldweller on void-packages repository
https://github.com/void-linux/void-packages/pull/42193#issuecomment-1426617196
Comment:
you mean the neomutt devs will enable this by default from the next release?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
` (9 preceding siblings ...)
2023-02-11 5:14 ` terminaldweller
@ 2023-05-13 1:51 ` github-actions
2023-05-30 9:03 ` terminaldweller
2023-05-30 9:03 ` [PR PATCH] [Closed]: " terminaldweller
12 siblings, 0 replies; 14+ messages in thread
From: github-actions @ 2023-05-13 1:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/42193#issuecomment-1546491262
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
` (10 preceding siblings ...)
2023-05-13 1:51 ` github-actions
@ 2023-05-30 9:03 ` terminaldweller
2023-05-30 9:03 ` [PR PATCH] [Closed]: " terminaldweller
12 siblings, 0 replies; 14+ messages in thread
From: terminaldweller @ 2023-05-30 9:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
New comment by terminaldweller on void-packages repository
https://github.com/void-linux/void-packages/pull/42193#issuecomment-1568057874
Comment:
mixmaster is kinda dead so it doesn't add much to have this enabled by default so I'm closing this. feel free to re-open if anyone disagrees.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Closed]: added mixmaster as a build option to the neomutt template
2023-02-10 17:20 [PR PATCH] added mixmaster as a build option to the neomutt template terminaldweller
` (11 preceding siblings ...)
2023-05-30 9:03 ` terminaldweller
@ 2023-05-30 9:03 ` terminaldweller
12 siblings, 0 replies; 14+ messages in thread
From: terminaldweller @ 2023-05-30 9:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]
There's a closed pull request on the void-packages repository
added mixmaster as a build option to the neomutt template
https://github.com/void-linux/void-packages/pull/42193
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 14+ messages in thread