Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Increase open files limit for Nix
@ 2023-02-16 16:21 gabrielhdt
  2023-02-16 17:06 ` paper42
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: gabrielhdt @ 2023-02-16 16:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]

There is a new pull request by gabrielhdt against master on the void-packages repository

https://github.com/gabrielhdt/void-packages ulimit-nix
https://github.com/void-linux/void-packages/pull/42311

Increase open files limit for Nix
The new value is the same as the one of NixOS:
<https://github.com/NixOS/nix/blob/601849b95afc3d173ea34ff5dba6353f9b71b495/misc/systemd/nix-daemon.service.in#L12>

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** 

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/42311.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ulimit-nix-42311.patch --]
[-- Type: text/x-diff, Size: 775 bytes --]

From 53ff5cd0f37add4df9986578d735d22ba7585a57 Mon Sep 17 00:00:00 2001
From: Gabriel Hondet <7418676+gabrielhdt@users.noreply.github.com>
Date: Thu, 16 Feb 2023 16:57:48 +0100
Subject: [PATCH] Incread open files limit for Nix

The value is the same as the one of NixOS:
<https://github.com/NixOS/nix/blob/601849b95afc3d173ea34ff5dba6353f9b71b495/misc/systemd/nix-daemon.service.in#L12>
---
 srcpkgs/nix/files/nix-daemon/run | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/nix/files/nix-daemon/run b/srcpkgs/nix/files/nix-daemon/run
index 052cf9d45a8d..1a57c15efdc2 100644
--- a/srcpkgs/nix/files/nix-daemon/run
+++ b/srcpkgs/nix/files/nix-daemon/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 exec 2>&1
-exec nix-daemon
+exec prlimit --nofile=1048576 nix-daemon

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Increase open files limit for Nix
  2023-02-16 16:21 [PR PATCH] Increase open files limit for Nix gabrielhdt
@ 2023-02-16 17:06 ` paper42
  2023-02-17  8:49 ` [PR PATCH] [Updated] " gabrielhdt
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2023-02-16 17:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42311#issuecomment-1433420139

Comment:
increase revision in the template and please follow CONTRIBUTING.md to fix the commit message

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] Increase open files limit for Nix
  2023-02-16 16:21 [PR PATCH] Increase open files limit for Nix gabrielhdt
  2023-02-16 17:06 ` paper42
@ 2023-02-17  8:49 ` gabrielhdt
  2023-02-18  5:48 ` nix: update to 2.11.0 revision 3 classabbyamp
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: gabrielhdt @ 2023-02-17  8:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

There is an updated pull request by gabrielhdt against master on the void-packages repository

https://github.com/gabrielhdt/void-packages ulimit-nix
https://github.com/void-linux/void-packages/pull/42311

Increase open files limit for Nix
The new value is the same as the one of NixOS:
<https://github.com/NixOS/nix/blob/601849b95afc3d173ea34ff5dba6353f9b71b495/misc/systemd/nix-daemon.service.in#L12>

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** 

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/42311.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ulimit-nix-42311.patch --]
[-- Type: text/x-diff, Size: 987 bytes --]

From 8c70fddd34aa925888f79382fab832bd8bb84378 Mon Sep 17 00:00:00 2001
From: Gabriel Hondet <gabriel.hondet@tweag.io>
Date: Thu, 16 Feb 2023 16:57:48 +0100
Subject: [PATCH] nix: update to 2.11.0 revision 3.

---
 srcpkgs/nix/files/nix-daemon/run | 2 +-
 srcpkgs/nix/template             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nix/files/nix-daemon/run b/srcpkgs/nix/files/nix-daemon/run
index 052cf9d45a8d..1a57c15efdc2 100644
--- a/srcpkgs/nix/files/nix-daemon/run
+++ b/srcpkgs/nix/files/nix-daemon/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 exec 2>&1
-exec nix-daemon
+exec prlimit --nofile=1048576 nix-daemon
diff --git a/srcpkgs/nix/template b/srcpkgs/nix/template
index 1c9bd931df65..6c842fa336c3 100644
--- a/srcpkgs/nix/template
+++ b/srcpkgs/nix/template
@@ -1,7 +1,7 @@
 # Template file for 'nix'
 pkgname=nix
 version=2.11.0
-revision=2
+revision=3
 build_style=gnu-configure
 build_helper=qemu
 # Use /nix/var as suggested by the official Manual.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: nix: update to 2.11.0 revision 3.
  2023-02-16 16:21 [PR PATCH] Increase open files limit for Nix gabrielhdt
  2023-02-16 17:06 ` paper42
  2023-02-17  8:49 ` [PR PATCH] [Updated] " gabrielhdt
@ 2023-02-18  5:48 ` classabbyamp
  2023-02-22  7:29 ` [PR PATCH] [Updated] " gabrielhdt
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2023-02-18  5:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42311#issuecomment-1435492253

Comment:
this is not an update, commit message should be `<package>: <description of changes>`

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] nix: update to 2.11.0 revision 3.
  2023-02-16 16:21 [PR PATCH] Increase open files limit for Nix gabrielhdt
                   ` (2 preceding siblings ...)
  2023-02-18  5:48 ` nix: update to 2.11.0 revision 3 classabbyamp
@ 2023-02-22  7:29 ` gabrielhdt
  2023-05-26  1:53 ` nix: increase open files limit github-actions
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: gabrielhdt @ 2023-02-22  7:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

There is an updated pull request by gabrielhdt against master on the void-packages repository

https://github.com/gabrielhdt/void-packages ulimit-nix
https://github.com/void-linux/void-packages/pull/42311

nix: update to 2.11.0 revision 3.
The new value is the same as the one of NixOS:
<https://github.com/NixOS/nix/blob/601849b95afc3d173ea34ff5dba6353f9b71b495/misc/systemd/nix-daemon.service.in#L12>

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** 

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/42311.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ulimit-nix-42311.patch --]
[-- Type: text/x-diff, Size: 984 bytes --]

From f5f1e8cb08e48b46e091a2ddf510e3dd1418402d Mon Sep 17 00:00:00 2001
From: Gabriel Hondet <gabriel.hondet@tweag.io>
Date: Thu, 16 Feb 2023 16:57:48 +0100
Subject: [PATCH] nix: increase open files limit

---
 srcpkgs/nix/files/nix-daemon/run | 2 +-
 srcpkgs/nix/template             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nix/files/nix-daemon/run b/srcpkgs/nix/files/nix-daemon/run
index 052cf9d45a8d..1a57c15efdc2 100644
--- a/srcpkgs/nix/files/nix-daemon/run
+++ b/srcpkgs/nix/files/nix-daemon/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 exec 2>&1
-exec nix-daemon
+exec prlimit --nofile=1048576 nix-daemon
diff --git a/srcpkgs/nix/template b/srcpkgs/nix/template
index 1c9bd931df65..6c842fa336c3 100644
--- a/srcpkgs/nix/template
+++ b/srcpkgs/nix/template
@@ -1,7 +1,7 @@
 # Template file for 'nix'
 pkgname=nix
 version=2.11.0
-revision=2
+revision=3
 build_style=gnu-configure
 build_helper=qemu
 # Use /nix/var as suggested by the official Manual.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: nix: increase open files limit.
  2023-02-16 16:21 [PR PATCH] Increase open files limit for Nix gabrielhdt
                   ` (3 preceding siblings ...)
  2023-02-22  7:29 ` [PR PATCH] [Updated] " gabrielhdt
@ 2023-05-26  1:53 ` github-actions
  2023-05-26  2:05 ` classabbyamp
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2023-05-26  1:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42311#issuecomment-1563709665

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: nix: increase open files limit.
  2023-02-16 16:21 [PR PATCH] Increase open files limit for Nix gabrielhdt
                   ` (4 preceding siblings ...)
  2023-05-26  1:53 ` nix: increase open files limit github-actions
@ 2023-05-26  2:05 ` classabbyamp
  2023-06-27  8:38 ` [PR PATCH] [Updated] " classabbyamp
  2023-06-27  8:58 ` [PR PATCH] [Merged]: " classabbyamp
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2023-05-26  2:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42311#issuecomment-1563717146

Comment:
can you add the email you used to commit to your github account settings?

also rebase to resolve the conflicts

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] nix: increase open files limit.
  2023-02-16 16:21 [PR PATCH] Increase open files limit for Nix gabrielhdt
                   ` (5 preceding siblings ...)
  2023-05-26  2:05 ` classabbyamp
@ 2023-06-27  8:38 ` classabbyamp
  2023-06-27  8:58 ` [PR PATCH] [Merged]: " classabbyamp
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2023-06-27  8:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/gabrielhdt/void-packages ulimit-nix
https://github.com/void-linux/void-packages/pull/42311

nix: increase open files limit.
The new value is the same as the one of NixOS:
<https://github.com/NixOS/nix/blob/601849b95afc3d173ea34ff5dba6353f9b71b495/misc/systemd/nix-daemon.service.in#L12>

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** 

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/42311.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ulimit-nix-42311.patch --]
[-- Type: text/x-diff, Size: 984 bytes --]

From c18571727c71ecb63bb379c69c2d76aea0b23394 Mon Sep 17 00:00:00 2001
From: Gabriel Hondet <gabriel.hondet@tweag.io>
Date: Thu, 16 Feb 2023 16:57:48 +0100
Subject: [PATCH] nix: increase open files limit

---
 srcpkgs/nix/files/nix-daemon/run | 2 +-
 srcpkgs/nix/template             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nix/files/nix-daemon/run b/srcpkgs/nix/files/nix-daemon/run
index 052cf9d45a8d..1a57c15efdc2 100644
--- a/srcpkgs/nix/files/nix-daemon/run
+++ b/srcpkgs/nix/files/nix-daemon/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 exec 2>&1
-exec nix-daemon
+exec prlimit --nofile=1048576 nix-daemon
diff --git a/srcpkgs/nix/template b/srcpkgs/nix/template
index ee2f9f148354..20eb0d85fdaf 100644
--- a/srcpkgs/nix/template
+++ b/srcpkgs/nix/template
@@ -1,7 +1,7 @@
 # Template file for 'nix'
 pkgname=nix
 version=2.11.0
-revision=5
+revision=6
 build_style=gnu-configure
 build_helper=qemu
 # Use /nix/var as suggested by the official Manual.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Merged]: nix: increase open files limit.
  2023-02-16 16:21 [PR PATCH] Increase open files limit for Nix gabrielhdt
                   ` (6 preceding siblings ...)
  2023-06-27  8:38 ` [PR PATCH] [Updated] " classabbyamp
@ 2023-06-27  8:58 ` classabbyamp
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2023-06-27  8:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

There's a merged pull request on the void-packages repository

nix: increase open files limit.
https://github.com/void-linux/void-packages/pull/42311

Description:
The new value is the same as the one of NixOS:
<https://github.com/NixOS/nix/blob/601849b95afc3d173ea34ff5dba6353f9b71b495/misc/systemd/nix-daemon.service.in#L12>

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** 

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-06-27  8:58 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-16 16:21 [PR PATCH] Increase open files limit for Nix gabrielhdt
2023-02-16 17:06 ` paper42
2023-02-17  8:49 ` [PR PATCH] [Updated] " gabrielhdt
2023-02-18  5:48 ` nix: update to 2.11.0 revision 3 classabbyamp
2023-02-22  7:29 ` [PR PATCH] [Updated] " gabrielhdt
2023-05-26  1:53 ` nix: increase open files limit github-actions
2023-05-26  2:05 ` classabbyamp
2023-06-27  8:38 ` [PR PATCH] [Updated] " classabbyamp
2023-06-27  8:58 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).