[PR PATCH] Update lolcat-c to 1.4 version

[PR PATCH] Update lolcat-c to 1.4 version

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

There is a new pull request by SpidFightFR against master on the void-packages repository

https://github.com/SpidFightFR/void-packages patch-1
https://github.com/void-linux/void-packages/pull/42482

Update lolcat-c to 1.4 version
This version fix an issue with neofetch (see: https://github.com/jaseg/lolcat/issues/48 )

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64 Glibc)



A patch file from https://github.com/void-linux/void-packages/pull/42482.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-42482.patch --]
[-- Type: text/x-diff, Size: 1113 bytes --]

From aca53bc0b76844a25cdcf5fac6815892b5ef4261 Mon Sep 17 00:00:00 2001
From: SpidFightFR <60798703+SpidFightFR@users.noreply.github.com>
Date: Mon, 27 Feb 2023 11:48:20 +0000
Subject: [PATCH] Update lolcat-c to 1.4 version

This version fix an issue with neofetch (see: https://github.com/jaseg/lolcat/issues/48 )
---
 srcpkgs/lolcat-c/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/lolcat-c/template b/srcpkgs/lolcat-c/template
index 3db29baec216..8b01acf704d1 100644
--- a/srcpkgs/lolcat-c/template
+++ b/srcpkgs/lolcat-c/template
@@ -1,6 +1,6 @@
 # Template file for 'lolcat-c'
 pkgname=lolcat-c
-version=1.3
+version=1.4
 revision=1
 build_style=gnu-makefile
 make_build_target="lolcat"
@@ -9,7 +9,7 @@ maintainer="John <me@johnnynator.dev>"
 license="WTFPL"
 homepage="https://github.com/jaseg/lolcat"
 distfiles="https://github.com/jaseg/lolcat/archive/refs/tags/v${version}.tar.gz"
-checksum=5596c9ad40f78cc40483ada3fed25f9fa743b4d281b00c2b78de02f49a415d10
+checksum=6ea43ee2b2bb2f15fc91812b72ebcdaa883052853ed8f055b6f8b38637bda909
 
 do_install() {
 	vbin lolcat

Re: Update lolcat-c to 1.4 version

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1446882077

Comment:
Amend the commit subject to: 'lolcat-c: update to 1.3.' and force push to this branch. You should also [set the email](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address) on your GitHub account and in git so your commits are associated with your GitHub account properly.

Re: lolcat-c: update to 1.4 version.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1447588506

Comment:
How do i force the push?

Re: lolcat-c: update to 1.4 version.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1447591905

Comment:
`git commit --amend` to change to commit msg then `git push --force`

Re: lolcat-c: update to 1.4 version.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1447623575

Comment:
This seems to be on the git cli, i don’t have access to it rn… is there a way to do it with github directly? 

Re: lolcat-c: update to 1.4 version.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1448978995

Comment:
> This seems to be on the git cli, i don’t have access to it rn… is there a way to do it with github directly?

The github interface is incredibly limited and not usable for any serious work, it's probably not possible without regular git CLI.

Re: lolcat-c: update to 1.4 version.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1449801604

Comment:
I tried to connect with a token, using the git command, but it says that for this repo, the access is denied, thus, i can’t force push…

Re: lolcat-c: update to 1.4 version.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1449845427

Comment:
> I tried to connect with a token, using the git command, but it says that for this repo, the access is denied, thus, i can’t force push…

you are not allowed to push to the official repositories, only the Void team members are. A pull request is a request to include changes from one branch in another one, often across forks. You are supposed to push to your branch that you named [patch-1](https://github.com/SpidFightFR/void-packages/tree/patch-1) on your fork to update this PR.

Re: lolcat-c: update to 1.4 version.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450024531

Comment:
Ah okay, makes sense. Well the pr is just a change of version, as a consequence, i got no more pushes to do.

Re: lolcat-c: update to 1.4 version.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450092518

Comment:
> Ah okay, makes sense. Well the pr is just a change of version, as a consequence, i got no more pushes to do.

that's not true, you can see that the CI is failing and if you click on the details, you should be able to see why:

```
Error: aca53bc0b: authored by noreply email
Error: aca53bc0b: subject does not follow CONTRIBUTING.md guildelines
```

This needs to be fixed before this can be merged.

Re: lolcat-c: update to 1.4 version.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450092518

Comment:
> Ah okay, makes sense. Well the pr is just a change of version, as a consequence, i got no more pushes to do.

The CI is failing and if you click on the details link, you should be able to see why:

```
Error: aca53bc0b: authored by noreply email
Error: aca53bc0b: subject does not follow CONTRIBUTING.md guildelines
```

This needs to be fixed before this can be merged.

Re: lolcat-c: update to 1.4 version.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450092518

Comment:
> Ah okay, makes sense. Well the pr is just a change of version, as a consequence, i got no more pushes to do.

The CI is failing and if you click on the details link, you should be able to see why:

```
Error: aca53bc0b: authored by noreply email
Error: aca53bc0b: subject does not follow CONTRIBUTING.md guildelines
```

This needs to be fixed before this PR can be merged.

Re: lolcat-c: update to 1.4 version.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450114672

Comment:
Ah i think it’s because i done the pr with github web interface. The manual says it’s better to do it with git or gh.

Re: [PR PATCH] [Updated] lolcat-c: update to 1.4 version.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

There is an updated pull request by SpidFightFR against master on the void-packages repository

https://github.com/SpidFightFR/void-packages patch-1
https://github.com/void-linux/void-packages/pull/42482

lolcat-c: update to 1.4 version.
This version fix an issue with neofetch (see: https://github.com/jaseg/lolcat/issues/48 )

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64 Glibc)



A patch file from https://github.com/void-linux/void-packages/pull/42482.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-42482.patch --]
[-- Type: text/x-diff, Size: 1500 bytes --]

From 2c9cb5068997baf1f955907096e791022f9ffc00 Mon Sep 17 00:00:00 2001
From: SpidFightFR <vincent.bardot@outlook.fr>
Date: Wed, 1 Mar 2023 14:18:52 +0100
Subject: [PATCH 1/2] lolcat-c: update to 1.3.

---
 srcpkgs/lolcat-c/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/lolcat-c/template b/srcpkgs/lolcat-c/template
index 3db29baec216..dca6f5a74f55 100644
--- a/srcpkgs/lolcat-c/template
+++ b/srcpkgs/lolcat-c/template
@@ -9,7 +9,7 @@ maintainer="John <me@johnnynator.dev>"
 license="WTFPL"
 homepage="https://github.com/jaseg/lolcat"
 distfiles="https://github.com/jaseg/lolcat/archive/refs/tags/v${version}.tar.gz"
-checksum=5596c9ad40f78cc40483ada3fed25f9fa743b4d281b00c2b78de02f49a415d10
+checksum=6ea43ee2b2bb2f15fc91812b72ebcdaa883052853ed8f055b6f8b38637bda909
 
 do_install() {
 	vbin lolcat

From f105caf9441dacb1d07189b19a4d238cd798c11c Mon Sep 17 00:00:00 2001
From: SpidFightFR <vincent.bardot@outlook.fr>
Date: Wed, 1 Mar 2023 14:19:19 +0100
Subject: [PATCH 2/2] lolcat-c: update to 1.4.

Update to 1.4 verison

Update to 1.4 version
---
 srcpkgs/lolcat-c/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/lolcat-c/template b/srcpkgs/lolcat-c/template
index dca6f5a74f55..8b01acf704d1 100644
--- a/srcpkgs/lolcat-c/template
+++ b/srcpkgs/lolcat-c/template
@@ -1,6 +1,6 @@
 # Template file for 'lolcat-c'
 pkgname=lolcat-c
-version=1.3
+version=1.4
 revision=1
 build_style=gnu-makefile
 make_build_target="lolcat"

Re: lolcat-c: update to 1.4 version.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450151855

Comment:
Ok, this time, everything should be okay. Thanks for your help, guys !

Re: lolcat-c: update to 1.4 version.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450173689

Comment:
Now there are two commits, I suspect you didn't amend the old commit and just created a new one. Now you will have to squash them for example with an interactive rebase.

Re: lolcat-c: update to 1.4 version.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450254442

Comment:
Yes, i made one commit that changed the checksum, but then i forgot to bump the version number so i made another one… is it problematic for the pr? Or is it acceptable?

Re: lolcat-c: update to 1.4 version.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450255522

Comment:
How do i squash them? (Sorry it’s the first time i contribute to a linux distro, i’m lost)

Re: lolcat-c: update to 1.4 version.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450421434

Comment:
> Yes, i made one commit that changed the checksum, but then i forgot to bump the version number so i made another one… is it problematic for the pr? Or is it acceptable?

[CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md) describes this, one PR should contain one commit per package. Any git tutorial should be able to help you with squashing commits, for example this is the first result when I searched for "how to squash commits git": https://www.git-tower.com/learn/git/faq/git-squash/

Re: [PR PATCH] [Updated] lolcat-c: update to 1.4 version.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

There is an updated pull request by SpidFightFR against master on the void-packages repository

https://github.com/SpidFightFR/void-packages patch-1
https://github.com/void-linux/void-packages/pull/42482

lolcat-c: update to 1.4 version.
This version fix an issue with neofetch (see: https://github.com/jaseg/lolcat/issues/48 )

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64 Glibc)



A patch file from https://github.com/void-linux/void-packages/pull/42482.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-42482.patch --]
[-- Type: text/x-diff, Size: 1003 bytes --]

From 20d769cacd30fff3d36144ade7705b91a8fc755a Mon Sep 17 00:00:00 2001
From: SpidFightFR <vincent.bardot@outlook.fr>
Date: Wed, 1 Mar 2023 18:29:27 +0000
Subject: [PATCH] lolcat-c: update to 1.4 version

---
 srcpkgs/lolcat-c/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/lolcat-c/template b/srcpkgs/lolcat-c/template
index 3db29baec216..8b01acf704d1 100644
--- a/srcpkgs/lolcat-c/template
+++ b/srcpkgs/lolcat-c/template
@@ -1,6 +1,6 @@
 # Template file for 'lolcat-c'
 pkgname=lolcat-c
-version=1.3
+version=1.4
 revision=1
 build_style=gnu-makefile
 make_build_target="lolcat"
@@ -9,7 +9,7 @@ maintainer="John <me@johnnynator.dev>"
 license="WTFPL"
 homepage="https://github.com/jaseg/lolcat"
 distfiles="https://github.com/jaseg/lolcat/archive/refs/tags/v${version}.tar.gz"
-checksum=5596c9ad40f78cc40483ada3fed25f9fa743b4d281b00c2b78de02f49a415d10
+checksum=6ea43ee2b2bb2f15fc91812b72ebcdaa883052853ed8f055b6f8b38637bda909
 
 do_install() {
 	vbin lolcat

Re: lolcat-c: update to 1.4 version.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450661488

Comment:
i re-made the commits to make them a single commit. what else should i do ?

Re: lolcat-c: update to 1.4 version.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450691858

Comment:
as CONTRIBUTING.md says, the commit message should be `<pkgname>: update to <version>.`, not `<pkgname>: update to <version> version`

Re: lolcat-c: update to 1.4.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450697099

Comment:
like this ?

Re: lolcat-c: update to 1.4.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450708599

Comment:
no, you changed the PR title, not the commit message

Re: lolcat-c: update to 1.4.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450709584

Comment:
ah silly me... hold on

Re: [PR PATCH] [Updated] lolcat-c: update to 1.4.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

There is an updated pull request by SpidFightFR against master on the void-packages repository

https://github.com/SpidFightFR/void-packages patch-1
https://github.com/void-linux/void-packages/pull/42482

lolcat-c: update to 1.4.
This version fix an issue with neofetch (see: https://github.com/jaseg/lolcat/issues/48 )

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64 Glibc)



A patch file from https://github.com/void-linux/void-packages/pull/42482.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-42482.patch --]
[-- Type: text/x-diff, Size: 996 bytes --]

From f97e8dc6166382a848b090100c08bc2cc7f5c5d0 Mon Sep 17 00:00:00 2001
From: SpidFightFR <vincent.bardot@outlook.fr>
Date: Wed, 1 Mar 2023 18:29:27 +0000
Subject: [PATCH] lolcat-c: update to 1.4.

---
 srcpkgs/lolcat-c/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/lolcat-c/template b/srcpkgs/lolcat-c/template
index 3db29baec216..8b01acf704d1 100644
--- a/srcpkgs/lolcat-c/template
+++ b/srcpkgs/lolcat-c/template
@@ -1,6 +1,6 @@
 # Template file for 'lolcat-c'
 pkgname=lolcat-c
-version=1.3
+version=1.4
 revision=1
 build_style=gnu-makefile
 make_build_target="lolcat"
@@ -9,7 +9,7 @@ maintainer="John <me@johnnynator.dev>"
 license="WTFPL"
 homepage="https://github.com/jaseg/lolcat"
 distfiles="https://github.com/jaseg/lolcat/archive/refs/tags/v${version}.tar.gz"
-checksum=5596c9ad40f78cc40483ada3fed25f9fa743b4d281b00c2b78de02f49a415d10
+checksum=6ea43ee2b2bb2f15fc91812b72ebcdaa883052853ed8f055b6f8b38637bda909
 
 do_install() {
 	vbin lolcat

Re: lolcat-c: update to 1.4.

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1450715515

Comment:
Alright... Now it should be good. (sorry again, i'm new to git, i only used it to clone stuff and update xbps-src 😅 )

Re: lolcat-c: update to 1.4.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42482#issuecomment-1452555073

Comment:
lgtm, thanks for contributing!

Re: [PR PATCH] [Merged]: lolcat-c: update to 1.4.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

There's a merged pull request on the void-packages repository

lolcat-c: update to 1.4.
https://github.com/void-linux/void-packages/pull/42482

Description:
This version fix an issue with neofetch (see: https://github.com/jaseg/lolcat/issues/48 )

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64 Glibc)