[PR PATCH] added zssh

[PR PATCH] added zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

There is a new pull request by ufud-org against master on the void-packages repository

https://github.com/ufud-org/void-packages add-zssh
https://github.com/void-linux/void-packages/pull/42568

added zssh
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (cross-build)
  - armv6l (cross-build)
  - armv6l-musl (cross-build)
  - armv7l (cross-build)
  - armv7l-musl (cross-build)
  - aarch64 (cross-build)
  - aarch64-musl (cross-build)


A patch file from https://github.com/void-linux/void-packages/pull/42568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-zssh-42568.patch --]
[-- Type: text/x-diff, Size: 1110 bytes --]

From 517769a8013bcd5825379cffbfcd75e4aa699101 Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 17:39:19 +0100
Subject: [PATCH] added zssh

---
 srcpkgs/zssh/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/zssh/template

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
new file mode 100644
index 000000000000..84890facf75b
--- /dev/null
+++ b/srcpkgs/zssh/template
@@ -0,0 +1,23 @@
+# Template file for 'zssh'
+pkgname=zssh
+version=1.5c
+revision=1
+build_style=gnu-configure
+makedepends="readline-devel"
+depends="openssh inetutils-telnet lrzsz"
+short_desc="Zmodem aware telnet and ssh cli client"
+maintainer="Niels Haedecke <webmaster@ufud.org>"
+license="GPL-2.0-only"
+homepage="https://zssh.sourceforge.net/"
+distfiles="http://prdownloads.sf.net/zssh/zssh-${version}.tgz"
+checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
+
+pre_build() {
+	rm -f ${XBPS_WRAPPERDIR}/strip
+}
+
+do_install() {
+	vmkdir usr/bin
+	vcopy zssh usr/bin/zssh
+	vcopy ztelnet usr/bin/ztelnet
+}

Re: New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by ufud-org on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#issuecomment-1453806616

Comment:
second try, now with proper template revision number and without screwed up branch ... 

Re: [PR REVIEW] New package: zssh

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124724259

Comment:
why? 

Re: [PR REVIEW] New package: zssh

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124727322

Comment:
```suggestion
	vbin zssh
	vbin ztelnet
```

Re: [PR REVIEW] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

New review comment by ufud-org on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124741198

Comment:
Makefile uses strip with additional parameter which is not supported by wrapper script, thus not creating stripped binatied. Found this solution to work around this issue while reading the voidlinux subreddit threads and other templates so assumed this to be proper way to do it.

Re: [PR REVIEW] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

New review comment by ufud-org on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124741198

Comment:
Makefile uses strip with additional parameter which is not supported by wrapper script, thus not creating stripped binaries. Found this solution to work around this issue while reading the voidlinux subreddit threads and other templates so assumed this to be proper way to do it.

Re: [PR REVIEW] New package: zssh

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124744441

Comment:
the wrapper supports all arguments, the whole point of it is to ignore all strip invocations so xbps-src can strip things itself

Re: [PR REVIEW] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New review comment by ufud-org on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124745013

Comment:
will change and add missing vman commands as well to provide proper man files

Re: [PR REVIEW] New package: zssh

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124744441

Comment:
the wrapper supports all arguments, the whole point of it is to ignore all strip invocations so xbps-src can strip things itself

https://github.com/void-linux/void-packages/blob/master/common/wrappers/strip.sh

Re: [PR PATCH] [Updated] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

There is an updated pull request by ufud-org against master on the void-packages repository

https://github.com/ufud-org/void-packages add-zssh
https://github.com/void-linux/void-packages/pull/42568

New package: zssh
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (cross-build)
  - armv6l (cross-build)
  - armv6l-musl (cross-build)
  - armv7l (cross-build)
  - armv7l-musl (cross-build)
  - aarch64 (cross-build)
  - aarch64-musl (cross-build)


A patch file from https://github.com/void-linux/void-packages/pull/42568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-zssh-42568.patch --]
[-- Type: text/x-diff, Size: 1766 bytes --]

From 517769a8013bcd5825379cffbfcd75e4aa699101 Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 17:39:19 +0100
Subject: [PATCH 1/2] added zssh

---
 srcpkgs/zssh/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/zssh/template

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
new file mode 100644
index 000000000000..84890facf75b
--- /dev/null
+++ b/srcpkgs/zssh/template
@@ -0,0 +1,23 @@
+# Template file for 'zssh'
+pkgname=zssh
+version=1.5c
+revision=1
+build_style=gnu-configure
+makedepends="readline-devel"
+depends="openssh inetutils-telnet lrzsz"
+short_desc="Zmodem aware telnet and ssh cli client"
+maintainer="Niels Haedecke <webmaster@ufud.org>"
+license="GPL-2.0-only"
+homepage="https://zssh.sourceforge.net/"
+distfiles="http://prdownloads.sf.net/zssh/zssh-${version}.tgz"
+checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
+
+pre_build() {
+	rm -f ${XBPS_WRAPPERDIR}/strip
+}
+
+do_install() {
+	vmkdir usr/bin
+	vcopy zssh usr/bin/zssh
+	vcopy ztelnet usr/bin/ztelnet
+}

From afaae8c3b876728d805ad415055dbea99dd341ed Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 17:57:40 +0100
Subject: [PATCH 2/2] fixed copy command and added missing vman command

---
 srcpkgs/zssh/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
index 84890facf75b..e260eb216efb 100644
--- a/srcpkgs/zssh/template
+++ b/srcpkgs/zssh/template
@@ -18,6 +18,8 @@ pre_build() {
 
 do_install() {
 	vmkdir usr/bin
-	vcopy zssh usr/bin/zssh
-	vcopy ztelnet usr/bin/ztelnet
+	vbin zssh
+	vbin ztelnet
+	vman zssh.1
+	vman ztelnet.1
 }

Re: [PR REVIEW] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by ufud-org on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124758005

Comment:
I see. I think this is the part I've misunderstood. Will remove as recommended.

Re: [PR PATCH] [Updated] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

There is an updated pull request by ufud-org against master on the void-packages repository

https://github.com/ufud-org/void-packages add-zssh
https://github.com/void-linux/void-packages/pull/42568

New package: zssh
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (cross-build)
  - armv6l (cross-build)
  - armv6l-musl (cross-build)
  - armv7l (cross-build)
  - armv7l-musl (cross-build)
  - aarch64 (cross-build)
  - aarch64-musl (cross-build)


A patch file from https://github.com/void-linux/void-packages/pull/42568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-zssh-42568.patch --]
[-- Type: text/x-diff, Size: 2484 bytes --]

From 517769a8013bcd5825379cffbfcd75e4aa699101 Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 17:39:19 +0100
Subject: [PATCH 1/3] added zssh

---
 srcpkgs/zssh/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/zssh/template

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
new file mode 100644
index 000000000000..84890facf75b
--- /dev/null
+++ b/srcpkgs/zssh/template
@@ -0,0 +1,23 @@
+# Template file for 'zssh'
+pkgname=zssh
+version=1.5c
+revision=1
+build_style=gnu-configure
+makedepends="readline-devel"
+depends="openssh inetutils-telnet lrzsz"
+short_desc="Zmodem aware telnet and ssh cli client"
+maintainer="Niels Haedecke <webmaster@ufud.org>"
+license="GPL-2.0-only"
+homepage="https://zssh.sourceforge.net/"
+distfiles="http://prdownloads.sf.net/zssh/zssh-${version}.tgz"
+checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
+
+pre_build() {
+	rm -f ${XBPS_WRAPPERDIR}/strip
+}
+
+do_install() {
+	vmkdir usr/bin
+	vcopy zssh usr/bin/zssh
+	vcopy ztelnet usr/bin/ztelnet
+}

From afaae8c3b876728d805ad415055dbea99dd341ed Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 17:57:40 +0100
Subject: [PATCH 2/3] fixed copy command and added missing vman command

---
 srcpkgs/zssh/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
index 84890facf75b..e260eb216efb 100644
--- a/srcpkgs/zssh/template
+++ b/srcpkgs/zssh/template
@@ -18,6 +18,8 @@ pre_build() {
 
 do_install() {
 	vmkdir usr/bin
-	vcopy zssh usr/bin/zssh
-	vcopy ztelnet usr/bin/ztelnet
+	vbin zssh
+	vbin ztelnet
+	vman zssh.1
+	vman ztelnet.1
 }

From 2980edf11e7059a4d5576074b5086aaf94cfaf89 Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 18:03:29 +0100
Subject: [PATCH 3/3] removed pre_build()

---
 srcpkgs/zssh/template | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
index e260eb216efb..14baf24a4c64 100644
--- a/srcpkgs/zssh/template
+++ b/srcpkgs/zssh/template
@@ -12,10 +12,6 @@ homepage="https://zssh.sourceforge.net/"
 distfiles="http://prdownloads.sf.net/zssh/zssh-${version}.tgz"
 checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
 
-pre_build() {
-	rm -f ${XBPS_WRAPPERDIR}/strip
-}
-
 do_install() {
 	vmkdir usr/bin
 	vbin zssh

Re: [PR PATCH] [Updated] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

There is an updated pull request by ufud-org against master on the void-packages repository

https://github.com/ufud-org/void-packages add-zssh
https://github.com/void-linux/void-packages/pull/42568

New package: zssh
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (cross-build)
  - armv6l (cross-build)
  - armv6l-musl (cross-build)
  - armv7l (cross-build)
  - armv7l-musl (cross-build)
  - aarch64 (cross-build)
  - aarch64-musl (cross-build)


A patch file from https://github.com/void-linux/void-packages/pull/42568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-zssh-42568.patch --]
[-- Type: text/x-diff, Size: 3126 bytes --]

From 517769a8013bcd5825379cffbfcd75e4aa699101 Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 17:39:19 +0100
Subject: [PATCH 1/4] added zssh

---
 srcpkgs/zssh/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/zssh/template

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
new file mode 100644
index 000000000000..84890facf75b
--- /dev/null
+++ b/srcpkgs/zssh/template
@@ -0,0 +1,23 @@
+# Template file for 'zssh'
+pkgname=zssh
+version=1.5c
+revision=1
+build_style=gnu-configure
+makedepends="readline-devel"
+depends="openssh inetutils-telnet lrzsz"
+short_desc="Zmodem aware telnet and ssh cli client"
+maintainer="Niels Haedecke <webmaster@ufud.org>"
+license="GPL-2.0-only"
+homepage="https://zssh.sourceforge.net/"
+distfiles="http://prdownloads.sf.net/zssh/zssh-${version}.tgz"
+checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
+
+pre_build() {
+	rm -f ${XBPS_WRAPPERDIR}/strip
+}
+
+do_install() {
+	vmkdir usr/bin
+	vcopy zssh usr/bin/zssh
+	vcopy ztelnet usr/bin/ztelnet
+}

From afaae8c3b876728d805ad415055dbea99dd341ed Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 17:57:40 +0100
Subject: [PATCH 2/4] fixed copy command and added missing vman command

---
 srcpkgs/zssh/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
index 84890facf75b..e260eb216efb 100644
--- a/srcpkgs/zssh/template
+++ b/srcpkgs/zssh/template
@@ -18,6 +18,8 @@ pre_build() {
 
 do_install() {
 	vmkdir usr/bin
-	vcopy zssh usr/bin/zssh
-	vcopy ztelnet usr/bin/ztelnet
+	vbin zssh
+	vbin ztelnet
+	vman zssh.1
+	vman ztelnet.1
 }

From 2980edf11e7059a4d5576074b5086aaf94cfaf89 Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 18:03:29 +0100
Subject: [PATCH 3/4] removed pre_build()

---
 srcpkgs/zssh/template | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
index e260eb216efb..14baf24a4c64 100644
--- a/srcpkgs/zssh/template
+++ b/srcpkgs/zssh/template
@@ -12,10 +12,6 @@ homepage="https://zssh.sourceforge.net/"
 distfiles="http://prdownloads.sf.net/zssh/zssh-${version}.tgz"
 checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
 
-pre_build() {
-	rm -f ${XBPS_WRAPPERDIR}/strip
-}
-
 do_install() {
 	vmkdir usr/bin
 	vbin zssh

From 6c8023833abac41248eab704b2175950bbd9158a Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 18:07:45 +0100
Subject: [PATCH 4/4] removed vmkdir

---
 srcpkgs/zssh/template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
index 14baf24a4c64..cd3120e2f716 100644
--- a/srcpkgs/zssh/template
+++ b/srcpkgs/zssh/template
@@ -13,7 +13,6 @@ distfiles="http://prdownloads.sf.net/zssh/zssh-${version}.tgz"
 checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
 
 do_install() {
-	vmkdir usr/bin
 	vbin zssh
 	vbin ztelnet
 	vman zssh.1

Re: New package: zssh

[paper42]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#issuecomment-1453852093

Comment:
Make sure this PR contains one commit per package as mentioned in CONTRIBUTING.md

Re: New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

New comment by ufud-org on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#issuecomment-1453854216

Comment:
> Make sure this PR contains one commit per package as mentioned in CONTRIBUTING.md

just to clarify - what do you mean by 'per package' ?

Re: New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New comment by ufud-org on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#issuecomment-1453854216

Comment:
> Make sure this PR contains one commit per package as mentioned in CONTRIBUTING.md

just to clarify - what do you mean by 'per package' ? Do you mean due to more than 1 commit this PR can not be merged?

Re: New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

New comment by ufud-org on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#issuecomment-1453854216

Comment:
> Make sure this PR contains one commit per package as mentioned in CONTRIBUTING.md

just to clarify - what do you mean by 'per package' ? Do you mean due to more than 1 commit this PR can not be merged? Should I convert to draft until all open issues are fixed?

Re: New package: zssh

[paper42]

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#issuecomment-1453858874

Comment:
You are touching one package, so this PR should contain one commit with the appropriate commit message which you can find in CONTRIBUTING.md. Please fix this in this PR and don't open a new one. In this state it can not be merged because it doesn't meet our quality requirements, but that can be fixed with a force push.

Re: New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

New comment by ufud-org on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#issuecomment-1453866153

Comment:
> You are touching one package, so this PR should contain one commit with the appropriate commit message which you can find in CONTRIBUTING.md. Please fix this in this PR and don't open a new one. In this state it can not be merged because it doesn't meet our quality requirements, but that can be fixed with a force push.

Could you please you point me to some documentation on how to accomplish this without the risk of doing something wrong?

Re: [PR REVIEW] New package: zssh

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124805453

Comment:
```suggestion
distfiles="${SOURCEFORGE_SITE}/zssh/zssh-${version}.tgz"
```

Re: [PR PATCH] [Updated] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

There is an updated pull request by ufud-org against master on the void-packages repository

https://github.com/ufud-org/void-packages add-zssh
https://github.com/void-linux/void-packages/pull/42568

New package: zssh
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (cross-build)
  - armv6l (cross-build)
  - armv6l-musl (cross-build)
  - armv7l (cross-build)
  - armv7l-musl (cross-build)
  - aarch64 (cross-build)
  - aarch64-musl (cross-build)


A patch file from https://github.com/void-linux/void-packages/pull/42568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-zssh-42568.patch --]
[-- Type: text/x-diff, Size: 3957 bytes --]

From 517769a8013bcd5825379cffbfcd75e4aa699101 Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 17:39:19 +0100
Subject: [PATCH 1/5] added zssh

---
 srcpkgs/zssh/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/zssh/template

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
new file mode 100644
index 000000000000..84890facf75b
--- /dev/null
+++ b/srcpkgs/zssh/template
@@ -0,0 +1,23 @@
+# Template file for 'zssh'
+pkgname=zssh
+version=1.5c
+revision=1
+build_style=gnu-configure
+makedepends="readline-devel"
+depends="openssh inetutils-telnet lrzsz"
+short_desc="Zmodem aware telnet and ssh cli client"
+maintainer="Niels Haedecke <webmaster@ufud.org>"
+license="GPL-2.0-only"
+homepage="https://zssh.sourceforge.net/"
+distfiles="http://prdownloads.sf.net/zssh/zssh-${version}.tgz"
+checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
+
+pre_build() {
+	rm -f ${XBPS_WRAPPERDIR}/strip
+}
+
+do_install() {
+	vmkdir usr/bin
+	vcopy zssh usr/bin/zssh
+	vcopy ztelnet usr/bin/ztelnet
+}

From afaae8c3b876728d805ad415055dbea99dd341ed Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 17:57:40 +0100
Subject: [PATCH 2/5] fixed copy command and added missing vman command

---
 srcpkgs/zssh/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
index 84890facf75b..e260eb216efb 100644
--- a/srcpkgs/zssh/template
+++ b/srcpkgs/zssh/template
@@ -18,6 +18,8 @@ pre_build() {
 
 do_install() {
 	vmkdir usr/bin
-	vcopy zssh usr/bin/zssh
-	vcopy ztelnet usr/bin/ztelnet
+	vbin zssh
+	vbin ztelnet
+	vman zssh.1
+	vman ztelnet.1
 }

From 2980edf11e7059a4d5576074b5086aaf94cfaf89 Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 18:03:29 +0100
Subject: [PATCH 3/5] removed pre_build()

---
 srcpkgs/zssh/template | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
index e260eb216efb..14baf24a4c64 100644
--- a/srcpkgs/zssh/template
+++ b/srcpkgs/zssh/template
@@ -12,10 +12,6 @@ homepage="https://zssh.sourceforge.net/"
 distfiles="http://prdownloads.sf.net/zssh/zssh-${version}.tgz"
 checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
 
-pre_build() {
-	rm -f ${XBPS_WRAPPERDIR}/strip
-}
-
 do_install() {
 	vmkdir usr/bin
 	vbin zssh

From 6c8023833abac41248eab704b2175950bbd9158a Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 18:07:45 +0100
Subject: [PATCH 4/5] removed vmkdir

---
 srcpkgs/zssh/template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
index 14baf24a4c64..cd3120e2f716 100644
--- a/srcpkgs/zssh/template
+++ b/srcpkgs/zssh/template
@@ -13,7 +13,6 @@ distfiles="http://prdownloads.sf.net/zssh/zssh-${version}.tgz"
 checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
 
 do_install() {
-	vmkdir usr/bin
 	vbin zssh
 	vbin ztelnet
 	vman zssh.1

From 9433728ac9f961570c69bb7cbd397b78595e006b Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 18:39:50 +0100
Subject: [PATCH 5/5] fixef distfiles URL

---
 srcpkgs/zssh/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
index cd3120e2f716..6e69825a3717 100644
--- a/srcpkgs/zssh/template
+++ b/srcpkgs/zssh/template
@@ -9,7 +9,7 @@ short_desc="Zmodem aware telnet and ssh cli client"
 maintainer="Niels Haedecke <webmaster@ufud.org>"
 license="GPL-2.0-only"
 homepage="https://zssh.sourceforge.net/"
-distfiles="http://prdownloads.sf.net/zssh/zssh-${version}.tgz"
+distfiles="${SOURCEFORGE_SITE}/zssh/zssh-${version}.tgz"
 checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
 
 do_install() {

Re: [PR REVIEW] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New review comment by ufud-org on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124810260

Comment:
fixed. 

Q: how can I get this into a mergable state? @paper42 metioned a force push but I'm not sure how to accomplish this?

Re: [PR REVIEW] New package: zssh

[paper42]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124813791

Comment:
You will have to Google git basics

Re: [PR REVIEW] New package: zssh

[paper42]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124813791

Comment:
You will have to google some basic git tutorial, especially interactive rebase, amending and force pushing

Re: [PR PATCH] [Updated] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

There is an updated pull request by ufud-org against master on the void-packages repository

https://github.com/ufud-org/void-packages add-zssh
https://github.com/void-linux/void-packages/pull/42568

New package: zssh
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (cross-build)
  - armv6l (cross-build)
  - armv6l-musl (cross-build)
  - armv7l (cross-build)
  - armv7l-musl (cross-build)
  - aarch64 (cross-build)
  - aarch64-musl (cross-build)


A patch file from https://github.com/void-linux/void-packages/pull/42568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-zssh-42568.patch --]
[-- Type: text/x-diff, Size: 1031 bytes --]

From 9c79f38a2ceff5800479e8cd5936de2847f45a51 Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 17:39:19 +0100
Subject: [PATCH] added zssh

---
 srcpkgs/zssh/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/zssh/template

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
new file mode 100644
index 000000000000..6e69825a3717
--- /dev/null
+++ b/srcpkgs/zssh/template
@@ -0,0 +1,20 @@
+# Template file for 'zssh'
+pkgname=zssh
+version=1.5c
+revision=1
+build_style=gnu-configure
+makedepends="readline-devel"
+depends="openssh inetutils-telnet lrzsz"
+short_desc="Zmodem aware telnet and ssh cli client"
+maintainer="Niels Haedecke <webmaster@ufud.org>"
+license="GPL-2.0-only"
+homepage="https://zssh.sourceforge.net/"
+distfiles="${SOURCEFORGE_SITE}/zssh/zssh-${version}.tgz"
+checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
+
+do_install() {
+	vbin zssh
+	vbin ztelnet
+	vman zssh.1
+	vman ztelnet.1
+}

Re: [PR REVIEW] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New review comment by ufud-org on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124889251

Comment:
@paper42 done - consolidated commit history. Is this okay now?

Re: [PR PATCH] [Updated] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

There is an updated pull request by ufud-org against master on the void-packages repository

https://github.com/ufud-org/void-packages add-zssh
https://github.com/void-linux/void-packages/pull/42568

New package: zssh
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (cross-build)
  - armv6l (cross-build)
  - armv6l-musl (cross-build)
  - armv7l (cross-build)
  - armv7l-musl (cross-build)
  - aarch64 (cross-build)
  - aarch64-musl (cross-build)


A patch file from https://github.com/void-linux/void-packages/pull/42568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-zssh-42568.patch --]
[-- Type: text/x-diff, Size: 1043 bytes --]

From 4d187f036a263d267c3a0246bb7cfd390dec938b Mon Sep 17 00:00:00 2001
From: Niels Haedecke <webmaster@ufud.org>
Date: Fri, 3 Mar 2023 17:39:19 +0100
Subject: [PATCH] New package: zssh-1.5c

---
 srcpkgs/zssh/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/zssh/template

diff --git a/srcpkgs/zssh/template b/srcpkgs/zssh/template
new file mode 100644
index 000000000000..6e69825a3717
--- /dev/null
+++ b/srcpkgs/zssh/template
@@ -0,0 +1,20 @@
+# Template file for 'zssh'
+pkgname=zssh
+version=1.5c
+revision=1
+build_style=gnu-configure
+makedepends="readline-devel"
+depends="openssh inetutils-telnet lrzsz"
+short_desc="Zmodem aware telnet and ssh cli client"
+maintainer="Niels Haedecke <webmaster@ufud.org>"
+license="GPL-2.0-only"
+homepage="https://zssh.sourceforge.net/"
+distfiles="${SOURCEFORGE_SITE}/zssh/zssh-${version}.tgz"
+checksum="a2e840f82590690d27ea1ea1141af509ee34681fede897e58ae8d354701ce71b"
+
+do_install() {
+	vbin zssh
+	vbin ztelnet
+	vman zssh.1
+	vman ztelnet.1
+}

Re: [PR REVIEW] New package: zssh

[ufud-org]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by ufud-org on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#discussion_r1124923213

Comment:
fixed commit message to conform to CONTRIBUTING.md

Re: New package: zssh

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42568#issuecomment-1573029868

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: zssh

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

There's a closed pull request on the void-packages repository

New package: zssh
https://github.com/void-linux/void-packages/pull/42568

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (cross-build)
  - armv6l (cross-build)
  - armv6l-musl (cross-build)
  - armv7l (cross-build)
  - armv7l-musl (cross-build)
  - aarch64 (cross-build)
  - aarch64-musl (cross-build)