Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] inxi: update to 3.3.26
@ 2023-04-01 11:30 realcharmer
  2023-04-01 11:31 ` [PR REVIEW] " realcharmer
                   ` (14 more replies)
  0 siblings, 15 replies; 16+ messages in thread
From: realcharmer @ 2023-04-01 11:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

There is a new pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages inxi
https://github.com/void-linux/void-packages/pull/43160

inxi: update to 3.3.26
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/43160.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-inxi-43160.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]

From 524c23171e8ae360613d7fd70e994c35921b497b Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Sat, 1 Apr 2023 13:27:31 +0200
Subject: [PATCH] inxi: update to 3.3.26

---
 srcpkgs/inxi/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/inxi/template b/srcpkgs/inxi/template
index 349225861087..73d5d1b71ae5 100644
--- a/srcpkgs/inxi/template
+++ b/srcpkgs/inxi/template
@@ -1,6 +1,6 @@
 # Template file for 'inxi'
 pkgname=inxi
-version=3.3.25
+version=3.3.26
 revision=1
 depends="dmidecode file glxinfo pciutils perl procps-ng usbutils xdpyinfo
  xprop xrandr"
@@ -10,7 +10,7 @@ license="GPL-3.0-or-later"
 homepage="https://smxi.org/docs/inxi.htm"
 changelog="https://raw.githubusercontent.com/smxi/inxi/master/inxi.changelog"
 distfiles="https://github.com/smxi/inxi/archive/refs/tags/${version}-1.tar.gz"
-checksum=17176e70516adae4adced317905ab759316e5658a55c4a002c130bbcc21af3b7
+checksum=9c76b90044a5840d9e32fd83d1b3c1bb0d7c39c89904ac387cf6be339785451e
 
 do_install() {
 	vbin inxi

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] inxi: update to 3.3.26
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
@ 2023-04-01 11:31 ` realcharmer
  2023-04-01 11:32 ` realcharmer
                   ` (13 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: realcharmer @ 2023-04-01 11:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/43160#discussion_r1155098107

Comment:
Wouldn't it be better to include the `-1` in version, since that is what the upstream is using?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] inxi: update to 3.3.26
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
  2023-04-01 11:31 ` [PR REVIEW] " realcharmer
@ 2023-04-01 11:32 ` realcharmer
  2023-04-01 12:39 ` mhmdanas
                   ` (12 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: realcharmer @ 2023-04-01 11:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/43160#discussion_r1155098107

Comment:
Wouldn't it be better to include the `-1` in version, since that is what the upstream is using? For example `3.3.26-1`.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] inxi: update to 3.3.26
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
  2023-04-01 11:31 ` [PR REVIEW] " realcharmer
  2023-04-01 11:32 ` realcharmer
@ 2023-04-01 12:39 ` mhmdanas
  2023-04-01 12:39 ` mhmdanas
                   ` (11 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: mhmdanas @ 2023-04-01 12:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43160#discussion_r1155106104

Comment:
Hyphens are not allowed in `version`, but you can instead do something like this:
```suggestion
version=3.3.26.1
_distver="${version%.*}-${version##*.}"
```
and then use `${_distver}` instead of `${version}` in `distfiles`.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] inxi: update to 3.3.26
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
                   ` (2 preceding siblings ...)
  2023-04-01 12:39 ` mhmdanas
@ 2023-04-01 12:39 ` mhmdanas
  2023-04-01 12:41 ` mhmdanas
                   ` (10 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: mhmdanas @ 2023-04-01 12:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43160#discussion_r1155106104

Comment:
Hyphens are not allowed in `version`, but you can instead do something like this:
```suggestion
version=3.3.26.1
_distver="${version%.*}-${version##*.}"
```
and then use `${_distver}` instead of `${version}-1` in `distfiles`.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] inxi: update to 3.3.26
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
                   ` (3 preceding siblings ...)
  2023-04-01 12:39 ` mhmdanas
@ 2023-04-01 12:41 ` mhmdanas
  2023-04-01 13:10 ` [PR PATCH] [Updated] " realcharmer
                   ` (9 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: mhmdanas @ 2023-04-01 12:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43160#discussion_r1155106104

Comment:
Hyphens are not allowed in `version`, but you can instead do something like this:
```suggestion
version=3.3.26.1
_distver="${version%.*}-${version##*.}"
```
and then use `${_distver}` instead of `${version}-1` in `distfiles`.

For what it's worth, it's been years since the last release with a non-`-1` suffix was released, so this may not be really necessary (I think it wouldn't be a terrible idea though).

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] inxi: update to 3.3.26
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
                   ` (4 preceding siblings ...)
  2023-04-01 12:41 ` mhmdanas
@ 2023-04-01 13:10 ` realcharmer
  2023-04-01 13:12 ` realcharmer
                   ` (8 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: realcharmer @ 2023-04-01 13:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is an updated pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages inxi
https://github.com/void-linux/void-packages/pull/43160

inxi: update to 3.3.26
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/43160.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-inxi-43160.patch --]
[-- Type: text/x-diff, Size: 1202 bytes --]

From 6cb4549a80d556165970c53f486c5fbeffd0f385 Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Sat, 1 Apr 2023 13:27:31 +0200
Subject: [PATCH] inxi: update to 3.3.26

---
 srcpkgs/inxi/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/inxi/template b/srcpkgs/inxi/template
index 349225861087..4315cb367299 100644
--- a/srcpkgs/inxi/template
+++ b/srcpkgs/inxi/template
@@ -1,6 +1,7 @@
 # Template file for 'inxi'
 pkgname=inxi
-version=3.3.25
+version=3.3.26.1
+_distver="${version%.*}-${version##*.}"
 revision=1
 depends="dmidecode file glxinfo pciutils perl procps-ng usbutils xdpyinfo
  xprop xrandr"
@@ -9,8 +10,8 @@ maintainer="Emil Miler <em@0x45.cz>"
 license="GPL-3.0-or-later"
 homepage="https://smxi.org/docs/inxi.htm"
 changelog="https://raw.githubusercontent.com/smxi/inxi/master/inxi.changelog"
-distfiles="https://github.com/smxi/inxi/archive/refs/tags/${version}-1.tar.gz"
-checksum=17176e70516adae4adced317905ab759316e5658a55c4a002c130bbcc21af3b7
+distfiles="https://github.com/smxi/inxi/archive/refs/tags/${_distver}.tar.gz"
+checksum=9c76b90044a5840d9e32fd83d1b3c1bb0d7c39c89904ac387cf6be339785451e
 
 do_install() {
 	vbin inxi

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] inxi: update to 3.3.26
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
                   ` (5 preceding siblings ...)
  2023-04-01 13:10 ` [PR PATCH] [Updated] " realcharmer
@ 2023-04-01 13:12 ` realcharmer
  2023-04-01 13:14 ` [PR REVIEW] " realcharmer
                   ` (7 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: realcharmer @ 2023-04-01 13:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is an updated pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages inxi
https://github.com/void-linux/void-packages/pull/43160

inxi: update to 3.3.26
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/43160.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-inxi-43160.patch --]
[-- Type: text/x-diff, Size: 1256 bytes --]

From 5a38ce43892cde6fdeaad42492f2ce01a448bdd2 Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Sat, 1 Apr 2023 13:27:31 +0200
Subject: [PATCH] inxi: update to 3.3.26

---
 srcpkgs/inxi/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/inxi/template b/srcpkgs/inxi/template
index 349225861087..302777ceab02 100644
--- a/srcpkgs/inxi/template
+++ b/srcpkgs/inxi/template
@@ -1,7 +1,8 @@
 # Template file for 'inxi'
 pkgname=inxi
-version=3.3.25
+version=3.3.26.1
 revision=1
+_distver="${version%.*}-${version##*.}"
 depends="dmidecode file glxinfo pciutils perl procps-ng usbutils xdpyinfo
  xprop xrandr"
 short_desc="Full featured system information script"
@@ -9,8 +10,8 @@ maintainer="Emil Miler <em@0x45.cz>"
 license="GPL-3.0-or-later"
 homepage="https://smxi.org/docs/inxi.htm"
 changelog="https://raw.githubusercontent.com/smxi/inxi/master/inxi.changelog"
-distfiles="https://github.com/smxi/inxi/archive/refs/tags/${version}-1.tar.gz"
-checksum=17176e70516adae4adced317905ab759316e5658a55c4a002c130bbcc21af3b7
+distfiles="https://github.com/smxi/inxi/archive/refs/tags/${_distver}.tar.gz"
+checksum=9c76b90044a5840d9e32fd83d1b3c1bb0d7c39c89904ac387cf6be339785451e
 
 do_install() {
 	vbin inxi

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] inxi: update to 3.3.26
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
                   ` (6 preceding siblings ...)
  2023-04-01 13:12 ` realcharmer
@ 2023-04-01 13:14 ` realcharmer
  2023-04-01 13:16 ` mhmdanas
                   ` (6 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: realcharmer @ 2023-04-01 13:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/43160#discussion_r1155109681

Comment:
Thanks, that looks good.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] inxi: update to 3.3.26
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
                   ` (7 preceding siblings ...)
  2023-04-01 13:14 ` [PR REVIEW] " realcharmer
@ 2023-04-01 13:16 ` mhmdanas
  2023-04-01 13:18 ` [PR PATCH] [Updated] " realcharmer
                   ` (5 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: mhmdanas @ 2023-04-01 13:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43160#discussion_r1155110003

Comment:
You forgot to update the commit message and PR title. :)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] inxi: update to 3.3.26
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
                   ` (8 preceding siblings ...)
  2023-04-01 13:16 ` mhmdanas
@ 2023-04-01 13:18 ` realcharmer
  2023-04-01 13:20 ` [PR REVIEW] inxi: update to 3.3.26.1 realcharmer
                   ` (4 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: realcharmer @ 2023-04-01 13:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is an updated pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages inxi
https://github.com/void-linux/void-packages/pull/43160

inxi: update to 3.3.26
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/43160.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-inxi-43160.patch --]
[-- Type: text/x-diff, Size: 1258 bytes --]

From f4d1f0d9a5d32d7a3f6208a20062b3f8d04da80b Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Sat, 1 Apr 2023 13:27:31 +0200
Subject: [PATCH] inxi: update to 3.3.26.1

---
 srcpkgs/inxi/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/inxi/template b/srcpkgs/inxi/template
index 349225861087..302777ceab02 100644
--- a/srcpkgs/inxi/template
+++ b/srcpkgs/inxi/template
@@ -1,7 +1,8 @@
 # Template file for 'inxi'
 pkgname=inxi
-version=3.3.25
+version=3.3.26.1
 revision=1
+_distver="${version%.*}-${version##*.}"
 depends="dmidecode file glxinfo pciutils perl procps-ng usbutils xdpyinfo
  xprop xrandr"
 short_desc="Full featured system information script"
@@ -9,8 +10,8 @@ maintainer="Emil Miler <em@0x45.cz>"
 license="GPL-3.0-or-later"
 homepage="https://smxi.org/docs/inxi.htm"
 changelog="https://raw.githubusercontent.com/smxi/inxi/master/inxi.changelog"
-distfiles="https://github.com/smxi/inxi/archive/refs/tags/${version}-1.tar.gz"
-checksum=17176e70516adae4adced317905ab759316e5658a55c4a002c130bbcc21af3b7
+distfiles="https://github.com/smxi/inxi/archive/refs/tags/${_distver}.tar.gz"
+checksum=9c76b90044a5840d9e32fd83d1b3c1bb0d7c39c89904ac387cf6be339785451e
 
 do_install() {
 	vbin inxi

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] inxi: update to 3.3.26.1
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
                   ` (9 preceding siblings ...)
  2023-04-01 13:18 ` [PR PATCH] [Updated] " realcharmer
@ 2023-04-01 13:20 ` realcharmer
  2023-04-01 13:20 ` realcharmer
                   ` (3 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: realcharmer @ 2023-04-01 13:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New review comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/43160#discussion_r1155110576

Comment:
Oh yea, sorry :D

I hope this format is correct, meaning exactly what's in `version`, so `3.3.26.1`, not `3.3.26-1`.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] inxi: update to 3.3.26.1
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
                   ` (10 preceding siblings ...)
  2023-04-01 13:20 ` [PR REVIEW] inxi: update to 3.3.26.1 realcharmer
@ 2023-04-01 13:20 ` realcharmer
  2023-04-01 13:39 ` mhmdanas
                   ` (2 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: realcharmer @ 2023-04-01 13:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New review comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/43160#discussion_r1155110576

Comment:
Oh yea, sorry :D
I hope this format is correct, meaning exactly what's in `version`, so `3.3.26.1`, not `3.3.26-1`.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] inxi: update to 3.3.26.1
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
                   ` (11 preceding siblings ...)
  2023-04-01 13:20 ` realcharmer
@ 2023-04-01 13:39 ` mhmdanas
  2023-04-01 13:39 ` mhmdanas
  2023-04-01 21:13 ` [PR PATCH] [Merged]: " Chocimier
  14 siblings, 0 replies; 16+ messages in thread
From: mhmdanas @ 2023-04-01 13:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43160#discussion_r1155112717

Comment:
It is, yeah.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] inxi: update to 3.3.26.1
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
                   ` (12 preceding siblings ...)
  2023-04-01 13:39 ` mhmdanas
@ 2023-04-01 13:39 ` mhmdanas
  2023-04-01 21:13 ` [PR PATCH] [Merged]: " Chocimier
  14 siblings, 0 replies; 16+ messages in thread
From: mhmdanas @ 2023-04-01 13:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43160#discussion_r1155112717

Comment:
It is, no worries.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Merged]: inxi: update to 3.3.26.1
  2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
                   ` (13 preceding siblings ...)
  2023-04-01 13:39 ` mhmdanas
@ 2023-04-01 21:13 ` Chocimier
  14 siblings, 0 replies; 16+ messages in thread
From: Chocimier @ 2023-04-01 21:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

There's a merged pull request on the void-packages repository

inxi: update to 3.3.26.1
https://github.com/void-linux/void-packages/pull/43160

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2023-04-01 21:13 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-01 11:30 [PR PATCH] inxi: update to 3.3.26 realcharmer
2023-04-01 11:31 ` [PR REVIEW] " realcharmer
2023-04-01 11:32 ` realcharmer
2023-04-01 12:39 ` mhmdanas
2023-04-01 12:39 ` mhmdanas
2023-04-01 12:41 ` mhmdanas
2023-04-01 13:10 ` [PR PATCH] [Updated] " realcharmer
2023-04-01 13:12 ` realcharmer
2023-04-01 13:14 ` [PR REVIEW] " realcharmer
2023-04-01 13:16 ` mhmdanas
2023-04-01 13:18 ` [PR PATCH] [Updated] " realcharmer
2023-04-01 13:20 ` [PR REVIEW] inxi: update to 3.3.26.1 realcharmer
2023-04-01 13:20 ` realcharmer
2023-04-01 13:39 ` mhmdanas
2023-04-01 13:39 ` mhmdanas
2023-04-01 21:13 ` [PR PATCH] [Merged]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).