* [PR PATCH] Kooha: update to 2.2.3
@ 2023-04-02 15:59 cinerea0
2023-04-03 12:22 ` [PR REVIEW] " abenson
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: cinerea0 @ 2023-04-02 15:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
There is a new pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages Kooha
https://github.com/void-linux/void-packages/pull/43215
Kooha: update to 2.2.3
#### Testing the changes
- I tested the changes in this PR: **YES**
---
Please note that I had to disable tests on this package for a few reasons. There is a PR that changes a few files that would allow tests to be run; let me know if it would be preferable to include that PR as a patch here instead of disabling the tests.
A patch file from https://github.com/void-linux/void-packages/pull/43215.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Kooha-43215.patch --]
[-- Type: text/x-diff, Size: 2660 bytes --]
From 07d47afbd6d717bd06d0b51877ef45b7dd720a72 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Sun, 2 Apr 2023 11:57:24 -0400
Subject: [PATCH] Kooha: update to 2.2.3
---
srcpkgs/Kooha/patches/libadwaita-1.0.0.patch | 11 -----------
srcpkgs/Kooha/template | 18 ++++++++++--------
2 files changed, 10 insertions(+), 19 deletions(-)
delete mode 100644 srcpkgs/Kooha/patches/libadwaita-1.0.0.patch
diff --git a/srcpkgs/Kooha/patches/libadwaita-1.0.0.patch b/srcpkgs/Kooha/patches/libadwaita-1.0.0.patch
deleted file mode 100644
index 469af9fbe3bd..000000000000
--- a/srcpkgs/Kooha/patches/libadwaita-1.0.0.patch
+++ /dev/null
@@ -1,11 +0,0 @@
---- a/meson.build
-+++ b/meson.build
-@@ -14,7 +14,7 @@
- dependency('glib-2.0', version: '>= 2.66')
- dependency('gio-2.0', version: '>= 2.66')
- dependency('gtk4', version: '>= 4.0.0')
--dependency('libadwaita-1', version: '>= 1.0.0-alpha.1')
-+dependency('libadwaita-1', version: '>= 1.0.0')
-
- glib_compile_resources = find_program('glib-compile-resources', required: true)
- glib_compile_schemas = find_program('glib-compile-schemas', required: true)
diff --git a/srcpkgs/Kooha/template b/srcpkgs/Kooha/template
index 9e8d2b81835b..995caa600a42 100644
--- a/srcpkgs/Kooha/template
+++ b/srcpkgs/Kooha/template
@@ -1,22 +1,24 @@
# Template file for 'Kooha'
pkgname=Kooha
-version=2.0.1
+version=2.2.3
revision=1
build_style=meson
build_helper="rust"
-hostmakedepends="pkg-config gettext glib-devel cargo"
-makedepends="libglib-devel gtk4-devel libadwaita-devel rust-std"
+hostmakedepends="cargo desktop-file-utils gettext glib glib-devel pkg-config"
+makedepends="libadwaita-devel libglib-devel gtk4-devel pulseaudio-devel rust-std"
+depends="gstreamer1-pipewire pipewire xdg-desktop-portal"
+checkdepends="appstream-glib"
short_desc="Simple screen recorder with a minimal interface"
maintainer="Unai Hernández Minaberry <unihernandez22@gmail.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/SeaDve/Kooha"
-distfiles="https://github.com/SeaDve/Kooha/archive/v${version}.tar.gz"
-checksum=984ee062fabfe6bbdf8024dd5e4d1c5ce2fafc3b75539f2ba52449bdd4cc3f98
+distfiles="https://github.com/SeaDve/Kooha/archive/refs/tags/v${version}.tar.gz"
+checksum=3fb2fea4e8aaceb24d6bae12bdd13bdc2f7d2d5665536fe8e57f7ca20e7c2591
+make_check=no # Tests are broken, see https://github.com/SeaDve/Kooha/pull/206
post_patch() {
if [ "$CROSS_BUILD" ]; then
- vsed -i build-aux/cargo.sh \
- -e 's%"$CARGO_TARGET_DIR"/%&${RUST_TARGET}/%' \
- -e '/CARGO_HOME/d'
+ vsed -i src/meson.build \
+ -e "s%rust_target /%'${RUST_TARGET}' / rust_target /%"
fi
}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] Kooha: update to 2.2.3
2023-04-02 15:59 [PR PATCH] Kooha: update to 2.2.3 cinerea0
@ 2023-04-03 12:22 ` abenson
2023-04-04 3:04 ` [PR PATCH] [Updated] " cinerea0
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: abenson @ 2023-04-03 12:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/43215#discussion_r1155888705
Comment:
Might need `gtk-update-icon-cache` in `hostmakedepends` for cross
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] Kooha: update to 2.2.3
2023-04-02 15:59 [PR PATCH] Kooha: update to 2.2.3 cinerea0
2023-04-03 12:22 ` [PR REVIEW] " abenson
@ 2023-04-04 3:04 ` cinerea0
2023-04-04 3:09 ` cinerea0
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cinerea0 @ 2023-04-04 3:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
There is an updated pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages Kooha
https://github.com/void-linux/void-packages/pull/43215
Kooha: update to 2.2.3
#### Testing the changes
- I tested the changes in this PR: **YES**
---
Please note that I had to disable tests on this package for a few reasons. There is a PR that changes a few files that would allow tests to be run; let me know if it would be preferable to include that PR as a patch here instead of disabling the tests.
A patch file from https://github.com/void-linux/void-packages/pull/43215.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Kooha-43215.patch --]
[-- Type: text/x-diff, Size: 2733 bytes --]
From f2fdc1c81e5bdba1cae5f86dbf507470d000387c Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Mon, 3 Apr 2023 23:04:04 -0400
Subject: [PATCH] Kooha: update to 2.2.3
---
srcpkgs/Kooha/patches/libadwaita-1.0.0.patch | 11 -----------
srcpkgs/Kooha/template | 20 ++++++++++++--------
2 files changed, 12 insertions(+), 19 deletions(-)
delete mode 100644 srcpkgs/Kooha/patches/libadwaita-1.0.0.patch
diff --git a/srcpkgs/Kooha/patches/libadwaita-1.0.0.patch b/srcpkgs/Kooha/patches/libadwaita-1.0.0.patch
deleted file mode 100644
index 469af9fbe3bd..000000000000
--- a/srcpkgs/Kooha/patches/libadwaita-1.0.0.patch
+++ /dev/null
@@ -1,11 +0,0 @@
---- a/meson.build
-+++ b/meson.build
-@@ -14,7 +14,7 @@
- dependency('glib-2.0', version: '>= 2.66')
- dependency('gio-2.0', version: '>= 2.66')
- dependency('gtk4', version: '>= 4.0.0')
--dependency('libadwaita-1', version: '>= 1.0.0-alpha.1')
-+dependency('libadwaita-1', version: '>= 1.0.0')
-
- glib_compile_resources = find_program('glib-compile-resources', required: true)
- glib_compile_schemas = find_program('glib-compile-schemas', required: true)
diff --git a/srcpkgs/Kooha/template b/srcpkgs/Kooha/template
index 9e8d2b81835b..46b18f5a7d43 100644
--- a/srcpkgs/Kooha/template
+++ b/srcpkgs/Kooha/template
@@ -1,22 +1,26 @@
# Template file for 'Kooha'
pkgname=Kooha
-version=2.0.1
+version=2.2.3
revision=1
build_style=meson
build_helper="rust"
-hostmakedepends="pkg-config gettext glib-devel cargo"
-makedepends="libglib-devel gtk4-devel libadwaita-devel rust-std"
+hostmakedepends="cargo desktop-file-utils gettext glib glib-devel
+ gtk-update-icon-cache pkg-config"
+makedepends="libadwaita-devel libglib-devel gtk4-devel pulseaudio-devel rust-std"
+depends="gst-plugins-base1 gstreamer-vaapi gstreamer1 gstreamer1-pipewire
+ pipewire xdg-desktop-portal"
+checkdepends="appstream-glib"
short_desc="Simple screen recorder with a minimal interface"
maintainer="Unai Hernández Minaberry <unihernandez22@gmail.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/SeaDve/Kooha"
-distfiles="https://github.com/SeaDve/Kooha/archive/v${version}.tar.gz"
-checksum=984ee062fabfe6bbdf8024dd5e4d1c5ce2fafc3b75539f2ba52449bdd4cc3f98
+distfiles="https://github.com/SeaDve/Kooha/archive/refs/tags/v${version}.tar.gz"
+checksum=3fb2fea4e8aaceb24d6bae12bdd13bdc2f7d2d5665536fe8e57f7ca20e7c2591
+make_check=no # Tests are broken, see https://github.com/SeaDve/Kooha/pull/206
post_patch() {
if [ "$CROSS_BUILD" ]; then
- vsed -i build-aux/cargo.sh \
- -e 's%"$CARGO_TARGET_DIR"/%&${RUST_TARGET}/%' \
- -e '/CARGO_HOME/d'
+ vsed -i src/meson.build \
+ -e "s%rust_target /%'${RUST_TARGET}' / rust_target /%"
fi
}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Kooha: update to 2.2.3
2023-04-02 15:59 [PR PATCH] Kooha: update to 2.2.3 cinerea0
2023-04-03 12:22 ` [PR REVIEW] " abenson
2023-04-04 3:04 ` [PR PATCH] [Updated] " cinerea0
@ 2023-04-04 3:09 ` cinerea0
2023-04-04 3:22 ` [PR REVIEW] " cinerea0
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cinerea0 @ 2023-04-04 3:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/43215#issuecomment-1495282113
Comment:
I was doing some testing to see if I could enable encoding directly to mp4. That functionality would be provided by `gst-plugins-ugly1` and would require enabling [the gpl option](https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/gst-plugins-ugly/meson_options.txt#L21). Not sure if that would cause license problems.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] Kooha: update to 2.2.3
2023-04-02 15:59 [PR PATCH] Kooha: update to 2.2.3 cinerea0
` (2 preceding siblings ...)
2023-04-04 3:09 ` cinerea0
@ 2023-04-04 3:22 ` cinerea0
2023-04-06 16:38 ` paper42
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cinerea0 @ 2023-04-04 3:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/43215#discussion_r1156687997
Comment:
That fixed it, thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] Kooha: update to 2.2.3
2023-04-02 15:59 [PR PATCH] Kooha: update to 2.2.3 cinerea0
` (3 preceding siblings ...)
2023-04-04 3:22 ` [PR REVIEW] " cinerea0
@ 2023-04-06 16:38 ` paper42
2023-04-06 18:48 ` [PR PATCH] [Updated] " cinerea0
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2023-04-06 16:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/43215#discussion_r1160028973
Comment:
glib should be implied by glib-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] Kooha: update to 2.2.3
2023-04-02 15:59 [PR PATCH] Kooha: update to 2.2.3 cinerea0
` (4 preceding siblings ...)
2023-04-06 16:38 ` paper42
@ 2023-04-06 18:48 ` cinerea0
2023-04-06 18:49 ` [PR REVIEW] " cinerea0
2023-04-23 22:36 ` [PR PATCH] [Merged]: " Duncaen
7 siblings, 0 replies; 9+ messages in thread
From: cinerea0 @ 2023-04-06 18:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
There is an updated pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages Kooha
https://github.com/void-linux/void-packages/pull/43215
Kooha: update to 2.2.3
#### Testing the changes
- I tested the changes in this PR: **YES**
---
Please note that I had to disable tests on this package for a few reasons. There is a PR that changes a few files that would allow tests to be run; let me know if it would be preferable to include that PR as a patch here instead of disabling the tests.
A patch file from https://github.com/void-linux/void-packages/pull/43215.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Kooha-43215.patch --]
[-- Type: text/x-diff, Size: 2728 bytes --]
From 4e269eb944498440684e816c12ce7d15b2e041bf Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Thu, 6 Apr 2023 14:47:59 -0400
Subject: [PATCH] Kooha: update to 2.2.3
---
srcpkgs/Kooha/patches/libadwaita-1.0.0.patch | 11 -----------
srcpkgs/Kooha/template | 20 ++++++++++++--------
2 files changed, 12 insertions(+), 19 deletions(-)
delete mode 100644 srcpkgs/Kooha/patches/libadwaita-1.0.0.patch
diff --git a/srcpkgs/Kooha/patches/libadwaita-1.0.0.patch b/srcpkgs/Kooha/patches/libadwaita-1.0.0.patch
deleted file mode 100644
index 469af9fbe3bd..000000000000
--- a/srcpkgs/Kooha/patches/libadwaita-1.0.0.patch
+++ /dev/null
@@ -1,11 +0,0 @@
---- a/meson.build
-+++ b/meson.build
-@@ -14,7 +14,7 @@
- dependency('glib-2.0', version: '>= 2.66')
- dependency('gio-2.0', version: '>= 2.66')
- dependency('gtk4', version: '>= 4.0.0')
--dependency('libadwaita-1', version: '>= 1.0.0-alpha.1')
-+dependency('libadwaita-1', version: '>= 1.0.0')
-
- glib_compile_resources = find_program('glib-compile-resources', required: true)
- glib_compile_schemas = find_program('glib-compile-schemas', required: true)
diff --git a/srcpkgs/Kooha/template b/srcpkgs/Kooha/template
index 9e8d2b81835b..62d5332ef8ad 100644
--- a/srcpkgs/Kooha/template
+++ b/srcpkgs/Kooha/template
@@ -1,22 +1,26 @@
# Template file for 'Kooha'
pkgname=Kooha
-version=2.0.1
+version=2.2.3
revision=1
build_style=meson
build_helper="rust"
-hostmakedepends="pkg-config gettext glib-devel cargo"
-makedepends="libglib-devel gtk4-devel libadwaita-devel rust-std"
+hostmakedepends="cargo desktop-file-utils gettext glib-devel
+ gtk-update-icon-cache pkg-config"
+makedepends="libadwaita-devel libglib-devel gtk4-devel pulseaudio-devel rust-std"
+depends="gst-plugins-base1 gstreamer-vaapi gstreamer1 gstreamer1-pipewire
+ pipewire xdg-desktop-portal"
+checkdepends="appstream-glib"
short_desc="Simple screen recorder with a minimal interface"
maintainer="Unai Hernández Minaberry <unihernandez22@gmail.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/SeaDve/Kooha"
-distfiles="https://github.com/SeaDve/Kooha/archive/v${version}.tar.gz"
-checksum=984ee062fabfe6bbdf8024dd5e4d1c5ce2fafc3b75539f2ba52449bdd4cc3f98
+distfiles="https://github.com/SeaDve/Kooha/archive/refs/tags/v${version}.tar.gz"
+checksum=3fb2fea4e8aaceb24d6bae12bdd13bdc2f7d2d5665536fe8e57f7ca20e7c2591
+make_check=no # Tests are broken, see https://github.com/SeaDve/Kooha/pull/206
post_patch() {
if [ "$CROSS_BUILD" ]; then
- vsed -i build-aux/cargo.sh \
- -e 's%"$CARGO_TARGET_DIR"/%&${RUST_TARGET}/%' \
- -e '/CARGO_HOME/d'
+ vsed -i src/meson.build \
+ -e "s%rust_target /%'${RUST_TARGET}' / rust_target /%"
fi
}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] Kooha: update to 2.2.3
2023-04-02 15:59 [PR PATCH] Kooha: update to 2.2.3 cinerea0
` (5 preceding siblings ...)
2023-04-06 18:48 ` [PR PATCH] [Updated] " cinerea0
@ 2023-04-06 18:49 ` cinerea0
2023-04-23 22:36 ` [PR PATCH] [Merged]: " Duncaen
7 siblings, 0 replies; 9+ messages in thread
From: cinerea0 @ 2023-04-06 18:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/43215#discussion_r1160144723
Comment:
Fixed in the latest push.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: Kooha: update to 2.2.3
2023-04-02 15:59 [PR PATCH] Kooha: update to 2.2.3 cinerea0
` (6 preceding siblings ...)
2023-04-06 18:49 ` [PR REVIEW] " cinerea0
@ 2023-04-23 22:36 ` Duncaen
7 siblings, 0 replies; 9+ messages in thread
From: Duncaen @ 2023-04-23 22:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
There's a merged pull request on the void-packages repository
Kooha: update to 2.2.3
https://github.com/void-linux/void-packages/pull/43215
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
---
Please note that I had to disable tests on this package for a few reasons. There is a PR that changes a few files that would allow tests to be run; let me know if it would be preferable to include that PR as a patch here instead of disabling the tests.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-04-23 22:36 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-02 15:59 [PR PATCH] Kooha: update to 2.2.3 cinerea0
2023-04-03 12:22 ` [PR REVIEW] " abenson
2023-04-04 3:04 ` [PR PATCH] [Updated] " cinerea0
2023-04-04 3:09 ` cinerea0
2023-04-04 3:22 ` [PR REVIEW] " cinerea0
2023-04-06 16:38 ` paper42
2023-04-06 18:48 ` [PR PATCH] [Updated] " cinerea0
2023-04-06 18:49 ` [PR REVIEW] " cinerea0
2023-04-23 22:36 ` [PR PATCH] [Merged]: " Duncaen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).