* Re: [PR PATCH] [Updated] ncspot: update to 0.13.0.
2023-04-03 9:34 [PR PATCH] ncspot: update to 0.13.0 lukas-jo
@ 2023-04-03 13:27 ` lukas-jo
2023-04-03 13:31 ` lukas-jo
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: lukas-jo @ 2023-04-03 13:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
There is an updated pull request by lukas-jo against master on the void-packages repository
https://github.com/lukas-jo/void-packages ncspot
https://github.com/void-linux/void-packages/pull/43235
ncspot: update to 0.13.0.
#### Testing the changes
- I tested the changes in this PR: **YES**
CC Maintainer: @ram02z
A patch file from https://github.com/void-linux/void-packages/pull/43235.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-43235.patch --]
[-- Type: text/x-diff, Size: 1705 bytes --]
From a273b3ef55d774897a8ce814644ddc638911abbe Mon Sep 17 00:00:00 2001
From: Lukas Jordan <lukas.jordan@pm.me>
Date: Sun, 2 Apr 2023 11:33:40 +0200
Subject: [PATCH] ncspot: update to 0.13.0.
---
srcpkgs/ncspot/template | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 2144ec2f6d24..f8e466022d35 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,7 +1,7 @@
# Template file for 'ncspot'
pkgname=ncspot
-version=0.11.2
-revision=2
+version=0.13.0
+revision=1
build_style=cargo
configure_args="--features alsa_backend,cover"
hostmakedepends="pkg-config python3"
@@ -11,11 +11,24 @@ short_desc="Cross-platform ncurses Spotify client"
maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
license="BSD-2-Clause"
homepage="https://github.com/hrkfdn/ncspot"
-distfiles="https://github.com/hrkfdn/ncspot/archive/v${version}.tar.gz"
-checksum=0fd9696e13912b906605e9972bf3b2a8a68688cce17478353713550801c94fab
+changelog="https://github.com/hrkfdn/ncspot/releases"
+distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
+checksum=35210f8237a20eb894dc6b7cc517e60c82c2e93ff5940c267fe0bf673eccc411
+
post_install() {
vlicense LICENSE
vinstall misc/ncspot.desktop 644 usr/share/applications
vinstall images/logo.svg 644 usr/share/icons/hicolor/scalable/apps ncspot.svg
+ case "$XBPS_TARGET_MACHINE" in
+ arm*|aarch64*) ;;
+ *)
+ cargo xtask generate-manpage
+ cargo xtask generate-shell-completion
+ vman misc/ncspot.1
+ vcompletion misc/ncspot.bash bash
+ vcompletion misc/_ncspot zsh
+ vcompletion misc/ncspot.fish fish
+ ;;
+ esac
}
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: ncspot: update to 0.13.0.
2023-04-03 9:34 [PR PATCH] ncspot: update to 0.13.0 lukas-jo
2023-04-03 13:27 ` [PR PATCH] [Updated] " lukas-jo
@ 2023-04-03 13:31 ` lukas-jo
2023-04-03 14:52 ` [PR REVIEW] " icp1994
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: lukas-jo @ 2023-04-03 13:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 282 bytes --]
New comment by lukas-jo on void-packages repository
https://github.com/void-linux/void-packages/pull/43235#issuecomment-1494331176
Comment:
The cargo xtask for manpage and shell completion generation didn't crosscompile on arm. As a workaround xtask only executes on x86 and i686
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PR REVIEW] ncspot: update to 0.13.0.
2023-04-03 9:34 [PR PATCH] ncspot: update to 0.13.0 lukas-jo
2023-04-03 13:27 ` [PR PATCH] [Updated] " lukas-jo
2023-04-03 13:31 ` lukas-jo
@ 2023-04-03 14:52 ` icp1994
2023-04-03 14:52 ` icp1994
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: icp1994 @ 2023-04-03 14:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
New review comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/43235#discussion_r1156074854
Comment:
```suggestion
vtargetrun target/${RUST_TARGET}/release/xtask generate-manpage
vtargetrun target/${RUST_TARGET}/release/xtask generate-shell-completion
vman misc/ncspot.1
vcompletion misc/_ncspot zsh
vcompletion misc/ncspot.bash bash
vcompletion misc/ncspot.fish fish
```
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PR REVIEW] ncspot: update to 0.13.0.
2023-04-03 9:34 [PR PATCH] ncspot: update to 0.13.0 lukas-jo
` (2 preceding siblings ...)
2023-04-03 14:52 ` [PR REVIEW] " icp1994
@ 2023-04-03 14:52 ` icp1994
2023-04-03 15:35 ` icp1994
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: icp1994 @ 2023-04-03 14:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New review comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/43235#discussion_r1156071686
Comment:
```suggestion
build_style=cargo
build_helper="qemu"
```
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PR REVIEW] ncspot: update to 0.13.0.
2023-04-03 9:34 [PR PATCH] ncspot: update to 0.13.0 lukas-jo
` (3 preceding siblings ...)
2023-04-03 14:52 ` icp1994
@ 2023-04-03 15:35 ` icp1994
2023-04-03 15:37 ` icp1994
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: icp1994 @ 2023-04-03 15:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 292 bytes --]
New review comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/43235#discussion_r1156074854
Comment:
```suggestion
vman misc/ncspot.1
vcompletion misc/_ncspot zsh
vcompletion misc/ncspot.bash bash
vcompletion misc/ncspot.fish fish
```
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PR REVIEW] ncspot: update to 0.13.0.
2023-04-03 9:34 [PR PATCH] ncspot: update to 0.13.0 lukas-jo
` (4 preceding siblings ...)
2023-04-03 15:35 ` icp1994
@ 2023-04-03 15:37 ` icp1994
2023-04-04 10:19 ` [PR PATCH] [Updated] " lukas-jo
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: icp1994 @ 2023-04-03 15:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
New review comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/43235#discussion_r1156131757
Comment:
```suggestion
post_build() {
cargo auditable build --release --target ${RUST_TARGET} --package xtask
vtargetrun target/${RUST_TARGET}/release/xtask generate-shell-completion
vtargetrun target/${RUST_TARGET}/release/xtask generate-manpage
}
```
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PR PATCH] [Updated] ncspot: update to 0.13.0.
2023-04-03 9:34 [PR PATCH] ncspot: update to 0.13.0 lukas-jo
` (5 preceding siblings ...)
2023-04-03 15:37 ` icp1994
@ 2023-04-04 10:19 ` lukas-jo
2023-04-04 10:21 ` lukas-jo
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: lukas-jo @ 2023-04-04 10:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
There is an updated pull request by lukas-jo against master on the void-packages repository
https://github.com/lukas-jo/void-packages ncspot
https://github.com/void-linux/void-packages/pull/43235
ncspot: update to 0.13.0.
#### Testing the changes
- I tested the changes in this PR: **YES**
CC Maintainer: @ram02z
A patch file from https://github.com/void-linux/void-packages/pull/43235.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-43235.patch --]
[-- Type: text/x-diff, Size: 1874 bytes --]
From a0455873cc28f2a9ab3124b2c6432de699e80c8e Mon Sep 17 00:00:00 2001
From: Lukas Jordan <lukas.jordan@pm.me>
Date: Sun, 2 Apr 2023 11:33:40 +0200
Subject: [PATCH] ncspot: update to 0.13.0.
---
srcpkgs/ncspot/template | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 2144ec2f6d24..29d4ab27c6c1 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,8 +1,9 @@
# Template file for 'ncspot'
pkgname=ncspot
-version=0.11.2
-revision=2
+version=0.13.0
+revision=1
build_style=cargo
+build_helper="qemu"
configure_args="--features alsa_backend,cover"
hostmakedepends="pkg-config python3"
makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
@@ -11,11 +12,22 @@ short_desc="Cross-platform ncurses Spotify client"
maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
license="BSD-2-Clause"
homepage="https://github.com/hrkfdn/ncspot"
-distfiles="https://github.com/hrkfdn/ncspot/archive/v${version}.tar.gz"
-checksum=0fd9696e13912b906605e9972bf3b2a8a68688cce17478353713550801c94fab
+changelog="https://github.com/hrkfdn/ncspot/releases"
+distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
+checksum=35210f8237a20eb894dc6b7cc517e60c82c2e93ff5940c267fe0bf673eccc411
+
+post_build() {
+ cargo auditable build --release --target ${RUST_TARGET} --package xtask
+ vtargetrun target/${RUST_TARGET}/release/xtask generate-shell-completion
+ vtargetrun target/${RUST_TARGET}/release/xtask generate-manpage
+}
post_install() {
vlicense LICENSE
vinstall misc/ncspot.desktop 644 usr/share/applications
vinstall images/logo.svg 644 usr/share/icons/hicolor/scalable/apps ncspot.svg
+ vman misc/ncspot.1
+ vcompletion misc/ncspot.bash bash
+ vcompletion misc/_ncspot zsh
+ vcompletion misc/ncspot.fish fish
}
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: ncspot: update to 0.13.0.
2023-04-03 9:34 [PR PATCH] ncspot: update to 0.13.0 lukas-jo
` (6 preceding siblings ...)
2023-04-04 10:19 ` [PR PATCH] [Updated] " lukas-jo
@ 2023-04-04 10:21 ` lukas-jo
2023-04-06 16:29 ` [PR PATCH] [Updated] " lukas-jo
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: lukas-jo @ 2023-04-04 10:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New comment by lukas-jo on void-packages repository
https://github.com/void-linux/void-packages/pull/43235#issuecomment-1495715520
Comment:
looks and works better than what I did, thanks
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PR PATCH] [Updated] ncspot: update to 0.13.0.
2023-04-03 9:34 [PR PATCH] ncspot: update to 0.13.0 lukas-jo
` (7 preceding siblings ...)
2023-04-04 10:21 ` lukas-jo
@ 2023-04-06 16:29 ` lukas-jo
2023-04-06 16:30 ` ncspot: update to 0.13.1 lukas-jo
2023-05-04 18:09 ` [PR PATCH] [Merged]: " abenson
10 siblings, 0 replies; 12+ messages in thread
From: lukas-jo @ 2023-04-06 16:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
There is an updated pull request by lukas-jo against master on the void-packages repository
https://github.com/lukas-jo/void-packages ncspot
https://github.com/void-linux/void-packages/pull/43235
ncspot: update to 0.13.0.
#### Testing the changes
- I tested the changes in this PR: **YES**
CC Maintainer: @ram02z
A patch file from https://github.com/void-linux/void-packages/pull/43235.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-43235.patch --]
[-- Type: text/x-diff, Size: 1877 bytes --]
From 85b067c1b340d1c5af07ca5d4698544e73faefd3 Mon Sep 17 00:00:00 2001
From: Lukas Jordan <lukas.jordan@pm.me>
Date: Sun, 2 Apr 2023 11:33:40 +0200
Subject: [PATCH] ncspot: update to 0.13.1.
---
srcpkgs/ncspot/template | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 2144ec2f6d24..98b3d847ed12 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,8 +1,9 @@
# Template file for 'ncspot'
pkgname=ncspot
-version=0.11.2
-revision=2
+version=0.13.1
+revision=1
build_style=cargo
+build_helper="qemu"
configure_args="--features alsa_backend,cover"
hostmakedepends="pkg-config python3"
makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
@@ -11,11 +12,23 @@ short_desc="Cross-platform ncurses Spotify client"
maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
license="BSD-2-Clause"
homepage="https://github.com/hrkfdn/ncspot"
-distfiles="https://github.com/hrkfdn/ncspot/archive/v${version}.tar.gz"
-checksum=0fd9696e13912b906605e9972bf3b2a8a68688cce17478353713550801c94fab
+changelog="https://github.com/hrkfdn/ncspot/releases"
+distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
+checksum=51394f0a4f75c6d6273f1a98be350dca3f50a8ba21e5b563e85b08b9da04af89
+
+post_build() {
+ cargo auditable build --release --target ${RUST_TARGET} --package xtask
+ vtargetrun target/${RUST_TARGET}/release/xtask generate-shell-completion
+ vtargetrun target/${RUST_TARGET}/release/xtask generate-manpage
+}
post_install() {
vlicense LICENSE
vinstall misc/ncspot.desktop 644 usr/share/applications
vinstall images/logo.svg 644 usr/share/icons/hicolor/scalable/apps ncspot.svg
+
+ vman misc/ncspot.1
+ vcompletion misc/ncspot.bash bash
+ vcompletion misc/_ncspot zsh
+ vcompletion misc/ncspot.fish fish
}
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: ncspot: update to 0.13.1.
2023-04-03 9:34 [PR PATCH] ncspot: update to 0.13.0 lukas-jo
` (8 preceding siblings ...)
2023-04-06 16:29 ` [PR PATCH] [Updated] " lukas-jo
@ 2023-04-06 16:30 ` lukas-jo
2023-05-04 18:09 ` [PR PATCH] [Merged]: " abenson
10 siblings, 0 replies; 12+ messages in thread
From: lukas-jo @ 2023-04-06 16:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 159 bytes --]
New comment by lukas-jo on void-packages repository
https://github.com/void-linux/void-packages/pull/43235#issuecomment-1499329956
Comment:
bumped to 0.13.1
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PR PATCH] [Merged]: ncspot: update to 0.13.1.
2023-04-03 9:34 [PR PATCH] ncspot: update to 0.13.0 lukas-jo
` (9 preceding siblings ...)
2023-04-06 16:30 ` ncspot: update to 0.13.1 lukas-jo
@ 2023-05-04 18:09 ` abenson
10 siblings, 0 replies; 12+ messages in thread
From: abenson @ 2023-05-04 18:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
There's a merged pull request on the void-packages repository
ncspot: update to 0.13.1.
https://github.com/void-linux/void-packages/pull/43235
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
CC Maintainer: @ram02z
^ permalink raw reply [flat|nested] 12+ messages in thread