From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] common/build-style/go.sh: use -modcacherw
Date: Wed, 05 Apr 2023 20:39:47 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43288@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
There is a new pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages go-modcacherw
https://github.com/void-linux/void-packages/pull/43288
common/build-style/go.sh: use -modcacherw
makes sure the go mod cache is not read only and ./xbps-src zap can properly remove it
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
If someone wants to test this, try to build go-ipfs which fails and then zap the masterdir. Without this change, you will get a lot of error messages about not removing a read only file.
cc @the-maldridge
A patch file from https://github.com/void-linux/void-packages/pull/43288.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-modcacherw-43288.patch --]
[-- Type: text/x-diff, Size: 1023 bytes --]
From 14642cedc41f9f5552e2efd2469d40ae5383bc32 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Wed, 5 Apr 2023 20:33:25 +0200
Subject: [PATCH] common/build-style/go.sh: use -modcacherw
makes sure the go mod cache is not read only and ./xbps-src zap can
properly remove it
---
common/build-style/go.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index 9093527860f6..1315473f9600 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -40,7 +40,7 @@ do_build() {
# default behavior.
go_mod_mode=
fi
- go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
+ go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -modcacherw -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
else
# Otherwise, build using GOPATH
go get -p "$XBPS_MAKEJOBS" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
next reply other threads:[~2023-04-05 18:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 18:39 paper42 [this message]
2023-04-06 16:33 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43288@inbox.vuxu.org \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).