[PR PATCH] common/build-style/go.sh: use -modcacherw

[PR PATCH] common/build-style/go.sh: use -modcacherw

[paper42]

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages go-modcacherw
https://github.com/void-linux/void-packages/pull/43288

common/build-style/go.sh: use -modcacherw
makes sure the go mod cache is not read only and ./xbps-src zap can properly remove it

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

If someone wants to test this, try to build go-ipfs which fails and then zap the masterdir. Without this change, you will get a lot of error messages about not removing a read only file.

cc @the-maldridge 

A patch file from https://github.com/void-linux/void-packages/pull/43288.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-modcacherw-43288.patch --]
[-- Type: text/x-diff, Size: 1023 bytes --]

From 14642cedc41f9f5552e2efd2469d40ae5383bc32 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Wed, 5 Apr 2023 20:33:25 +0200
Subject: [PATCH] common/build-style/go.sh: use -modcacherw

makes sure the go mod cache is not read only and ./xbps-src zap can
properly remove it
---
 common/build-style/go.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index 9093527860f6..1315473f9600 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -40,7 +40,7 @@ do_build() {
 			# default behavior.
 			go_mod_mode=
 		fi
-		go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
+		go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -modcacherw -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
 	else
 		# Otherwise, build using GOPATH
 		go get -p "$XBPS_MAKEJOBS" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}

Re: [PR PATCH] [Merged]: common/build-style/go.sh: use -modcacherw

[paper42]

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

There's a merged pull request on the void-packages repository

common/build-style/go.sh: use -modcacherw
https://github.com/void-linux/void-packages/pull/43288

Description:
makes sure the go mod cache is not read only and ./xbps-src zap can properly remove it

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

If someone wants to test this, try to build go-ipfs which fails and then zap the masterdir. Without this change, you will get a lot of error messages about not removing a read only file.

cc @the-maldridge