Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] browsh: temporarily not depends on firefox
@ 2023-04-06  9:36 sgn
  2023-04-07 18:51 ` [PR REVIEW] " mhmdanas
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: sgn @ 2023-04-06  9:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages browsh-firefox-esr
https://github.com/void-linux/void-packages/pull/43299

browsh: temporarily not depends on firefox
Fix: #43298

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-browsh-firefox-esr-43299.patch --]
[-- Type: text/x-diff, Size: 1014 bytes --]

From 27027b18c9a1589a90217b99eec5406c6ce790da Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Thu, 6 Apr 2023 16:34:17 +0700
Subject: [PATCH] browsh: temporarily not depends on firefox

Fix: #43298
---
 srcpkgs/browsh/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/browsh/template b/srcpkgs/browsh/template
index 856fefd13d78..d6ad04dab817 100644
--- a/srcpkgs/browsh/template
+++ b/srcpkgs/browsh/template
@@ -1,13 +1,14 @@
 # Template file for 'browsh'
 pkgname=browsh
 version=1.6.4
-revision=2
+revision=3
 build_wrksrc=interfacer
 build_style=go
 go_import_path="github.com/browsh-org/browsh"
 go_package=./cmd/browsh
 hostmakedepends="go-bindata"
-depends="firefox"
+# Commented out until firefox-esr has been rebuilt.
+# depends="firefox"
 short_desc="Fully-modern text-based browser, rendering to TTY and browsers"
 maintainer="zhengqunkoo <root@zhengqunkoo.com>"
 license="LGPL-2.1-only"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] browsh: temporarily not depends on firefox
  2023-04-06  9:36 [PR PATCH] browsh: temporarily not depends on firefox sgn
@ 2023-04-07 18:51 ` mhmdanas
  2023-07-07  2:06 ` github-actions
  2023-07-22  1:53 ` [PR PATCH] [Closed]: " github-actions
  2 siblings, 0 replies; 4+ messages in thread
From: mhmdanas @ 2023-04-07 18:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43299#discussion_r1160893767

Comment:
Has firefox-esr not been rebuilt? (I think it has, but please confirm first)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: browsh: temporarily not depends on firefox
  2023-04-06  9:36 [PR PATCH] browsh: temporarily not depends on firefox sgn
  2023-04-07 18:51 ` [PR REVIEW] " mhmdanas
@ 2023-07-07  2:06 ` github-actions
  2023-07-22  1:53 ` [PR PATCH] [Closed]: " github-actions
  2 siblings, 0 replies; 4+ messages in thread
From: github-actions @ 2023-07-07  2:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/43299#issuecomment-1624538767

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: browsh: temporarily not depends on firefox
  2023-04-06  9:36 [PR PATCH] browsh: temporarily not depends on firefox sgn
  2023-04-07 18:51 ` [PR REVIEW] " mhmdanas
  2023-07-07  2:06 ` github-actions
@ 2023-07-22  1:53 ` github-actions
  2 siblings, 0 replies; 4+ messages in thread
From: github-actions @ 2023-07-22  1:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]

There's a closed pull request on the void-packages repository

browsh: temporarily not depends on firefox
https://github.com/void-linux/void-packages/pull/43299

Description:
Fix: #43298

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-22  1:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-06  9:36 [PR PATCH] browsh: temporarily not depends on firefox sgn
2023-04-07 18:51 ` [PR REVIEW] " mhmdanas
2023-07-07  2:06 ` github-actions
2023-07-22  1:53 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).